Add Threshold suffix to QLevelOfDetail enum values

Change-Id: I70a39b4a2664e2952d9f3cdd1ace1f021b0311dd
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>

7 files changed, 16 insertions, 16 deletions

diff --git a/src/render/backend/levelofdetail.cpp b/src/render/backend/levelofdetail.cpp
index d7806fc4d..157bfc004 100644
--- a/src/render/backend/levelofdetail.cpp
+++ b/src/render/backend/levelofdetail.cpp
@@ -54,7 +54,7 @@ namespace Render {
 LevelOfDetail::LevelOfDetail()
     : BackendNode(BackendNode::ReadWrite)
     , m_currentIndex(0)
-    , m_thresholdType(QLevelOfDetail::DistanceToCamera)
+    , m_thresholdType(QLevelOfDetail::DistanceToCameraThreshold)
     , m_volumeOverride()
 {
 }
diff --git a/src/render/frontend/qlevelofdetail.cpp b/src/render/frontend/qlevelofdetail.cpp
index 92bbc2471..e806b8401 100644
--- a/src/render/frontend/qlevelofdetail.cpp
+++ b/src/render/frontend/qlevelofdetail.cpp
@@ -50,7 +50,7 @@ QLevelOfDetailPrivate::QLevelOfDetailPrivate()
     : QComponentPrivate()
     , m_camera(nullptr)
     , m_currentIndex(0)
-    , m_thresholdType(QLevelOfDetail::DistanceToCamera)
+    , m_thresholdType(QLevelOfDetail::DistanceToCameraThreshold)
     , m_volumeOverride()
 {
 }
diff --git a/src/render/frontend/qlevelofdetail.h b/src/render/frontend/qlevelofdetail.h
index e88967851..2e752d962 100644
--- a/src/render/frontend/qlevelofdetail.h
+++ b/src/render/frontend/qlevelofdetail.h
@@ -64,8 +64,8 @@ class QT3DRENDERSHARED_EXPORT QLevelOfDetail : public Qt3DCore::QComponent
 
 public:
     enum ThresholdType {
-        DistanceToCamera,
-        ProjectedScreenPixelSize,
+        DistanceToCameraThreshold,
+        ProjectedScreenPixelSizeThreshold,
     };
     Q_ENUM(ThresholdType) // LCOV_EXCL_LINE
 
diff --git a/src/render/jobs/updatelevelofdetailjob.cpp b/src/render/jobs/updatelevelofdetailjob.cpp
index 36b83263a..24891f9b8 100644
--- a/src/render/jobs/updatelevelofdetailjob.cpp
+++ b/src/render/jobs/updatelevelofdetailjob.cpp
@@ -135,10 +135,10 @@ void UpdateLevelOfDetailJob::updateEntityLod(Entity *entity)
 
         if (lod->isEnabled() && !lod->thresholds().isEmpty()) {
             switch (lod->thresholdType()) {
-            case QLevelOfDetail::DistanceToCamera:
+            case QLevelOfDetail::DistanceToCameraThreshold:
                 updateEntityLodByDistance(entity, lod);
                 break;
-            case QLevelOfDetail::ProjectedScreenPixelSize:
+            case QLevelOfDetail::ProjectedScreenPixelSizeThreshold:
                 updateEntityLodByScreenArea(entity, lod);
                 break;
             default:
diff --git a/tests/auto/render/levelofdetail/tst_levelofdetail.cpp b/tests/auto/render/levelofdetail/tst_levelofdetail.cpp
index 1446811a8..148c54e58 100644
--- a/tests/auto/render/levelofdetail/tst_levelofdetail.cpp
+++ b/tests/auto/render/levelofdetail/tst_levelofdetail.cpp
@@ -70,7 +70,7 @@ private Q_SLOTS:
         // THEN
         QCOMPARE(renderLod.camera(), Qt3DCore::QNodeId{});
         QCOMPARE(renderLod.currentIndex(), 0);
-        QCOMPARE(renderLod.thresholdType(), Qt3DRender::QLevelOfDetail::DistanceToCamera);
+        QCOMPARE(renderLod.thresholdType(), Qt3DRender::QLevelOfDetail::DistanceToCameraThreshold);
         QVERIFY(renderLod.thresholds().empty());
         QCOMPARE(renderLod.radius(), 1.f);
         QCOMPARE(renderLod.center(), QVector3D{});
@@ -78,7 +78,7 @@ private Q_SLOTS:
 
         // GIVEN
         Qt3DRender::QLevelOfDetail lod;
-        lod.setThresholdType(Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSize);
+        lod.setThresholdType(Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSizeThreshold);
 
         // WHEN
         renderLod.setRenderer(&renderer);
@@ -96,18 +96,18 @@ private Q_SLOTS:
         renderLod.setRenderer(&renderer);
 
         // THEN
-        QVERIFY(renderLod.thresholdType() != Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSize);
+        QVERIFY(renderLod.thresholdType() != Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSizeThreshold);
         QVERIFY(renderLod.camera().isNull());
 
         {
             // WHEN
             Qt3DCore::QPropertyUpdatedChangePtr updateChange(new Qt3DCore::QPropertyUpdatedChange(Qt3DCore::QNodeId()));
-            updateChange->setValue(static_cast<int>(Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSize));
+            updateChange->setValue(static_cast<int>(Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSizeThreshold));
             updateChange->setPropertyName("thresholdType");
             renderLod.sceneChangeEvent(updateChange);
 
             // THEN
-            QCOMPARE(renderLod.thresholdType(), Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSize);
+            QCOMPARE(renderLod.thresholdType(), Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSizeThreshold);
             QVERIFY(renderer.dirtyBits() != 0);
         }
 
diff --git a/tests/auto/render/qlevelofdetail/tst_qlevelofdetail.cpp b/tests/auto/render/qlevelofdetail/tst_qlevelofdetail.cpp
index e2ffdd9da..ba357c8c9 100644
--- a/tests/auto/render/qlevelofdetail/tst_qlevelofdetail.cpp
+++ b/tests/auto/render/qlevelofdetail/tst_qlevelofdetail.cpp
@@ -89,14 +89,14 @@ private Q_SLOTS:
 
         {
             // WHEN
-            lod->setThresholdType(Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSize);
+            lod->setThresholdType(Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSizeThreshold);
             QCoreApplication::processEvents();
 
             // THEN
             QCOMPARE(arbiter.events.size(), 1);
             Qt3DCore::QPropertyUpdatedChangePtr change = arbiter.events.first().staticCast<Qt3DCore::QPropertyUpdatedChange>();
             QCOMPARE(change->propertyName(), "thresholdType");
-            QCOMPARE(change->value().value<int>(), static_cast<int>(Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSize));
+            QCOMPARE(change->value().value<int>(), static_cast<int>(Qt3DRender::QLevelOfDetail::ProjectedScreenPixelSizeThreshold));
 
             arbiter.events.clear();
         }
diff --git a/tests/manual/lod/main.qml b/tests/manual/lod/main.qml
index 0c03ff257..80547dcff 100644
--- a/tests/manual/lod/main.qml
+++ b/tests/manual/lod/main.qml
@@ -126,7 +126,7 @@ Entity {
                     id: lod
                     camera: camera
                     thresholds: [1000, 600, 300, 180]
-                    thresholdType: LevelOfDetail.ProjectedScreenPixelSize
+                    thresholdType: LevelOfDetail.ProjectedScreenPixelSizeThreshold
                     volumeOverride: lod.createBoundingSphere(Qt.vector3d(0, 0, 0), 2.0)
                 }
             ]
@@ -149,7 +149,7 @@ Entity {
 
             camera: camera
             thresholds: [20, 35, 50, 65]
-            thresholdType: LevelOfDetail.DistanceToCamera
+            thresholdType: LevelOfDetail.DistanceToCameraThreshold
             volumeOverride: lodLoader.createBoundingSphere(Qt.vector3d(0, 0, 0), -1)
             sources: ["qrc:/SphereEntity.qml", "qrc:/CylinderEntity.qml", "qrc:/ConeEntity.qml", "qrc:/CuboidEntity.qml"]
         }
@@ -171,7 +171,7 @@ Entity {
                 LevelOfDetailSwitch {
                     camera: camera
                     thresholds: [20, 35, 50, 65]
-                    thresholdType: LevelOfDetail.DistanceToCamera
+                    thresholdType: LevelOfDetail.DistanceToCameraThreshold
                 }
             ]