diff options
| author | Anton Kreuzkamp <anton.kreuzkamp@kdab.com> | 2019-03-21 11:19:58 +0100 |
|---|---|---|
| committer | Sean Harmer <sean.harmer@kdab.com> | 2019-03-21 10:37:41 +0000 |
| commit | fa12f14b2b97249b68652ed9f5fd0df0c0c27be4 (patch) | |
| tree | ba13fffbbfacc664f71992dda4e45ca2e3a1488a | |
| parent | 7a0d24164afc1c7d2075c68260af21bfefd07021 (diff) | |
Scene3D: Call update on the item not the window
On scene change QQuickWindow::update was called to ask the QQ2Renderer
to rerender the scene. The problem here is, that calling
QQuickWindow::update is percieved as a call to rerender under all
circumstances, while QQuickItem::update only means update if the scene
graph actually changed in the end. Using QQuickWindow::update the scene
will be rerendered even if the Scene3D item is invisible, using
QQuickItem::update it won't.
Change-Id: I1ff455628d3e536349683b064acaeadd354ec864
Fixes: QTBUG-72923
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
| -rw-r--r-- | src/quick3d/imports/scene3d/scene3drenderer.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/quick3d/imports/scene3d/scene3drenderer.cpp b/src/quick3d/imports/scene3d/scene3drenderer.cpp index b96fc516d..4582e7b40 100644 --- a/src/quick3d/imports/scene3d/scene3drenderer.cpp +++ b/src/quick3d/imports/scene3d/scene3drenderer.cpp @@ -347,7 +347,7 @@ void Scene3DRenderer::render() m_node->markDirty(QSGNode::DirtyMaterial); // Request next frame - m_window->update(); + m_item->update(); } } // namespace Qt3DRender |