diff options
| author | Konstantin Ritt <ritt.ks@gmail.com> | 2015-05-18 06:48:29 +0400 |
|---|---|---|
| committer | Konstantin Ritt <ritt.ks@gmail.com> | 2015-05-20 05:55:12 +0000 |
| commit | ee2b4e7cba8f7451ca974a1f461c90932f232624 (patch) | |
| tree | a88fc99d73b8084cd2bd63e15b32ec745965696f /src/core/jobs/qaspectjob_p.h | |
| parent | bfae282e8fb6d6d83e92df712f93b583616169d9 (diff) | |
Properly initialize q_ptr (or avoid where it is not needed)
Referencing a partially-constructed object is typically a bad design.
Change-Id: I48ef92452202f6c8c0014e17efd20e2ee2ae7e40
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Diffstat (limited to 'src/core/jobs/qaspectjob_p.h')
| -rw-r--r-- | src/core/jobs/qaspectjob_p.h | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/core/jobs/qaspectjob_p.h b/src/core/jobs/qaspectjob_p.h index 1517f5100..d1fdac44c 100644 --- a/src/core/jobs/qaspectjob_p.h +++ b/src/core/jobs/qaspectjob_p.h @@ -49,11 +49,9 @@ class QAspectJob; class QAspectJobPrivate { public: - QAspectJobPrivate(QAspectJob *qq); + QAspectJobPrivate(); - Q_DECLARE_PUBLIC(QAspectJob) QVector<QWeakPointer<QAspectJob> > m_dependencies; - QAspectJob *q_ptr; }; } // Qt3D |