QThreadPooler: minimize critical section

The localStorageMutex only needs to be held when
appending to localStorages here, because the
heap allocation is a purely local act and setting
the object on QThreadStorage is thead-safe.

Change-Id: I01f6f12a22e19ec0d53d5e039779c6917dbbda05
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/src/core/jobs/qthreadpooler.cpp b/src/core/jobs/qthreadpooler.cpp
index 8d64b3f20..7efac01a8 100644
--- a/src/core/jobs/qthreadpooler.cpp
+++ b/src/core/jobs/qthreadpooler.cpp
@@ -185,9 +185,9 @@ QMutex localStoragesMutex;
 void QThreadPooler::addJobLogStatsEntry(JobRunStats &stats)
 {
     if (!jobStatsCached.hasLocalData()) {
-        QMutexLocker lock(&localStoragesMutex);
         auto jobVector = new JobRunStatsList;
         jobStatsCached.setLocalData(jobVector);
+        QMutexLocker lock(&localStoragesMutex);
         localStorages.push_back(jobVector);
     }
     jobStatsCached.localData()->push_back(stats);