Iterate by const reference on handles

When iterating on handles, use const references to avoid copy of non
trivial type. Found by Clazy clazy-range-loop

Change-Id: I33ec54b3958160da2517e196411bcf92cd7b3bff
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>

4 files changed, 6 insertions, 6 deletions

diff --git a/src/input/backend/assignkeyboardfocusjob.cpp b/src/input/backend/assignkeyboardfocusjob.cpp
index 216c914d4..385074812 100644
--- a/src/input/backend/assignkeyboardfocusjob.cpp
+++ b/src/input/backend/assignkeyboardfocusjob.cpp
@@ -67,7 +67,7 @@ void AssignKeyboardFocusJob::run()
 {
     KeyboardDevice *keyboardDevice = m_inputHandler->keyboardDeviceManager()->lookupResource(m_keyboardDevice);
     const auto handles = m_inputHandler->keyboardInputManager()->activeHandles();
-    for (const HKeyboardHandler handle : handles) {
+    for (const HKeyboardHandler &handle : handles) {
         KeyboardHandler *input = m_inputHandler->keyboardInputManager()->data(handle);
         Q_ASSERT(input);
         if (input->keyboardDevice() == m_keyboardDevice) {
diff --git a/src/input/backend/axisaccumulatorjob.cpp b/src/input/backend/axisaccumulatorjob.cpp
index 03e680ddb..cda8a5e26 100644
--- a/src/input/backend/axisaccumulatorjob.cpp
+++ b/src/input/backend/axisaccumulatorjob.cpp
@@ -62,7 +62,7 @@ void AxisAccumulatorJob::run()
 {
     // Iterate over the accumulators and ask each to step the integrations
     const auto activeHandles = m_axisAccumulatorManager->activeHandles();
-    for (auto accumulatorHandle : activeHandles) {
+    for (const auto &accumulatorHandle : activeHandles) {
         AxisAccumulator *accumulator = m_axisAccumulatorManager->data(accumulatorHandle);
         if (accumulator->isEnabled())
             accumulator->stepIntegration(m_axisManager, m_dt);
diff --git a/src/input/backend/inputhandler.cpp b/src/input/backend/inputhandler.cpp
index 525a45b6c..18559e9d4 100644
--- a/src/input/backend/inputhandler.cpp
+++ b/src/input/backend/inputhandler.cpp
@@ -221,7 +221,7 @@ QVector<Qt3DCore::QAspectJobPtr> InputHandler::keyboardJobs()
     QVector<QAspectJobPtr> jobs;
     const QList<QT_PREPEND_NAMESPACE(QKeyEvent)> events = pendingKeyEvents();
 
-    for (const HKeyboardDevice cHandle : qAsConst(m_activeKeyboardDevices)) {
+    for (const HKeyboardDevice &cHandle : qAsConst(m_activeKeyboardDevices)) {
         KeyboardDevice *keyboardDevice = m_keyboardDeviceManager->data(cHandle);
         if (keyboardDevice) {
             keyboardDevice->updateKeyEvents(events);
@@ -254,7 +254,7 @@ QVector<Qt3DCore::QAspectJobPtr> InputHandler::mouseJobs()
     const QList<QT_PREPEND_NAMESPACE(QWheelEvent)> wheelEvents = pendingWheelEvents();
 #endif
 
-    for (const HMouseDevice cHandle : qAsConst(m_activeMouseDevices)) {
+    for (const HMouseDevice &cHandle : qAsConst(m_activeMouseDevices)) {
         MouseDevice *controller = m_mouseDeviceManager->data(cHandle);
 
         controller->updateMouseEvents(mouseEvents);
@@ -269,7 +269,7 @@ QVector<Qt3DCore::QAspectJobPtr> InputHandler::mouseJobs()
                                     ) {
             // Send the events to the mouse handlers that have for sourceDevice controller
             const QVector<HMouseHandler> activeMouseHandlers = m_mouseInputManager->activeHandles();
-            for (HMouseHandler mouseHandlerHandle : activeMouseHandlers) {
+            for (const HMouseHandler &mouseHandlerHandle : activeMouseHandlers) {
 
                 MouseHandler *mouseHandler = m_mouseInputManager->data(mouseHandlerHandle);
                 Q_ASSERT(mouseHandler);
diff --git a/src/input/frontend/qinputaspect.cpp b/src/input/frontend/qinputaspect.cpp
index a3bf58f08..fe0e29ee7 100644
--- a/src/input/frontend/qinputaspect.cpp
+++ b/src/input/frontend/qinputaspect.cpp
@@ -258,7 +258,7 @@ QVector<QAspectJobPtr> QInputAspect::jobsToExecute(qint64 time)
     const auto devHandles = d->m_inputHandler->logicalDeviceManager()->activeDevices();
     QVector<QAspectJobPtr> axisActionJobs;
     axisActionJobs.reserve(devHandles.size());
-    for (Input::HLogicalDevice devHandle : devHandles) {
+    for (const Input::HLogicalDevice &devHandle : devHandles) {
         const auto device = d->m_inputHandler->logicalDeviceManager()->data(devHandle);
         if (!device->isEnabled())
             continue;