diff options
author | Paul Lemire <paul.lemire@kdab.com> | 2020-05-06 15:26:21 +0200 |
---|---|---|
committer | Paul Lemire <paul.lemire@kdab.com> | 2020-06-04 14:02:38 +0200 |
commit | 44fd52b3c7f6630a2b5e7dfe0963abd4a8c075ca (patch) | |
tree | fc5c63d002885fb9c8817e7227f4631fe44cf5bb /src/plugins/renderers/opengl/graphicshelpers | |
parent | 80e73b0a8537c794be187e8847f84d376c30bd66 (diff) |
ShaderParameterPack: use std::vector
Leads to a massive gain on bigscene-cpp (increase of 10 fps,
frame preparation time reduced by 2ms)
Change-Id: Ie2d1f0816fef8c28f316bb9cc8c7daf417c7f8fd
Reviewed-by: Mike Krus <mike.krus@kdab.com>
(cherry picked from commit 735fe47dab436727dc5ab6d66ba7feb7a868f4c3)
Diffstat (limited to 'src/plugins/renderers/opengl/graphicshelpers')
-rw-r--r-- | src/plugins/renderers/opengl/graphicshelpers/submissioncontext.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/renderers/opengl/graphicshelpers/submissioncontext.cpp b/src/plugins/renderers/opengl/graphicshelpers/submissioncontext.cpp index 86f0af505..abfb7922a 100644 --- a/src/plugins/renderers/opengl/graphicshelpers/submissioncontext.cpp +++ b/src/plugins/renderers/opengl/graphicshelpers/submissioncontext.cpp @@ -1238,7 +1238,7 @@ bool SubmissionContext::setParameters(ShaderParameterPack ¶meterPack, GLShad // for SSBO and UBO // Bind Shader Storage block to SSBO and update SSBO - const QVector<BlockToSSBO> blockToSSBOs = parameterPack.shaderStorageBuffers(); + const std::vector<BlockToSSBO> &blockToSSBOs = parameterPack.shaderStorageBuffers(); for (const BlockToSSBO b : blockToSSBOs) { Buffer *cpuBuffer = m_renderer->nodeManagers()->bufferManager()->lookupResource(b.m_bufferID); GLBuffer *ssbo = glBufferForRenderBuffer(cpuBuffer); @@ -1256,7 +1256,7 @@ bool SubmissionContext::setParameters(ShaderParameterPack ¶meterPack, GLShad // Bind UniformBlocks to UBO and update UBO from Buffer // TO DO: Convert ShaderData to Buffer so that we can use that generic process - const QVector<BlockToUBO> blockToUBOs = parameterPack.uniformBuffers(); + const std::vector<BlockToUBO> &blockToUBOs = parameterPack.uniformBuffers(); int uboIndex = 0; for (const BlockToUBO &b : blockToUBOs) { Buffer *cpuBuffer = m_renderer->nodeManagers()->bufferManager()->lookupResource(b.m_bufferID); |