summaryrefslogtreecommitdiffstats
path: root/src/plugins/sceneparsers/gltf
diff options
context:
space:
mode:
authorMike Krus <mike.krus@kdab.com>2017-05-01 14:00:48 +0100
committerMike Krus <mike.krus@kdab.com>2017-05-02 08:46:49 +0000
commitcb7dbc2e40f8258e92a79e8ac46d99a3b65c2a8c (patch)
tree53eeee700df4324e2a33b2f82ba64eabef3bb829 /src/plugins/sceneparsers/gltf
parent1cf81a67af6540d496439deeb43dab4028ff4bfb (diff)
Add missing reference in range-for with non trivial type (clazy reports)
Change-Id: Ib014b4ad7adc6604e600afc489e3dafaf0e299c1 Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Diffstat (limited to 'src/plugins/sceneparsers/gltf')
-rw-r--r--src/plugins/sceneparsers/gltf/gltfimporter.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/plugins/sceneparsers/gltf/gltfimporter.cpp b/src/plugins/sceneparsers/gltf/gltfimporter.cpp
index 916589ffa..5c209aa8a 100644
--- a/src/plugins/sceneparsers/gltf/gltfimporter.cpp
+++ b/src/plugins/sceneparsers/gltf/gltfimporter.cpp
@@ -1072,7 +1072,7 @@ void GLTFImporter::cleanup()
m_shaderPaths.clear();
delete_if_without_parent(m_programs);
m_programs.clear();
- for (auto params : m_techniqueParameters.values())
+ for (const auto &params : m_techniqueParameters.values())
delete_if_without_parent(params);
m_techniqueParameters.clear();
delete_if_without_parent(m_techniques);
@@ -1546,7 +1546,7 @@ void GLTFImporter::processJSONExtensions(const QString &id, const QJsonObject &j
// level GLTF item.
if (id == KEY_COMMON_MAT) {
const auto lights = jsonObject.value(KEY_LIGHTS).toObject();
- for (auto lightKey : lights.keys()) {
+ for (const auto &lightKey : lights.keys()) {
const auto light = lights.value(lightKey).toObject();
auto lightType = light.value(KEY_TYPE).toString();
const auto lightValues = light.value(lightType).toObject();