GLTFIO: remove {QMap,QMultiHash}::remove() calls

They are preceded by operator[] calls with the same argument,
causing the node to be looked up twice each time (once in
op[] and then again in remove()).

Just call find() and use erase(it) to remove the node later.

Costs ~32B in text size. Reason unknown.

Change-Id: I1bef16a6871ff7922c6b3fc5e1449defbaa582b4
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>

1 files changed, 6 insertions, 4 deletions

diff --git a/src/plugins/sceneparsers/gltf/gltfio.cpp b/src/plugins/sceneparsers/gltf/gltfio.cpp
index 01c4596b4..939404fcd 100644
--- a/src/plugins/sceneparsers/gltf/gltfio.cpp
+++ b/src/plugins/sceneparsers/gltf/gltfio.cpp
@@ -993,11 +993,12 @@ void GLTFIO::processJSONTechnique(const QString &id, const QJsonObject &jsonObje
             continue;
         }
         //Check if the parameter has a standard attribute semantic
-        QString standardAttributeName = standardAttributeNameFromSemantic(m_parameterDataDict[parameter].semantic);
+        const auto paramDataIt = m_parameterDataDict.find(parameter);
+        QString standardAttributeName = standardAttributeNameFromSemantic(paramDataIt->semantic);
         if (!standardAttributeName.isNull()) {
             attributeName = standardAttributeName;
             t->removeParameter(parameter);
-            m_parameterDataDict.remove(parameter);
+            m_parameterDataDict.erase(paramDataIt);
             delete parameter;
         }
 
@@ -1014,9 +1015,10 @@ void GLTFIO::processJSONTechnique(const QString &id, const QJsonObject &jsonObje
             continue;
         }
         //Check if the parameter has a standard uniform semantic
-        if (hasStandardUniformNameFromSemantic(m_parameterDataDict[parameter].semantic)) {
+        const auto paramDataIt = m_parameterDataDict.find(parameter);
+        if (hasStandardUniformNameFromSemantic(paramDataIt->semantic)) {
             t->removeParameter(parameter);
-            m_parameterDataDict.remove(parameter);
+            m_parameterDataDict.erase(paramDataIt);
             delete parameter;
         }
     } // of program-instance uniforms