diff options
author | Sean Harmer <sean.harmer@kdab.com> | 2017-08-21 20:28:00 +0100 |
---|---|---|
committer | Simon Hausmann <simon.hausmann@qt.io> | 2017-08-25 13:38:45 +0000 |
commit | dc4a29aa578c1c00fc750d1f6882e45f09134b47 (patch) | |
tree | efe05e6fce6cbdda209084115675013599b590b2 /src/quick3d/quick3dextras | |
parent | 5c99313eedada4e502b57798122ab20d71eca0fe (diff) |
Re-enable the QQmlType code paths in the node factories
Change-Id: Ieacfbfb25de4840d7c428f89cd1f7d178852036e
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Diffstat (limited to 'src/quick3d/quick3dextras')
-rw-r--r-- | src/quick3d/quick3dextras/qt3dquickextrasnodefactory.cpp | 5 | ||||
-rw-r--r-- | src/quick3d/quick3dextras/qt3dquickextrasnodefactory_p.h | 3 |
2 files changed, 3 insertions, 5 deletions
diff --git a/src/quick3d/quick3dextras/qt3dquickextrasnodefactory.cpp b/src/quick3d/quick3dextras/qt3dquickextrasnodefactory.cpp index be7dec52a..2e1f993f9 100644 --- a/src/quick3d/quick3dextras/qt3dquickextrasnodefactory.cpp +++ b/src/quick3d/quick3dextras/qt3dquickextrasnodefactory.cpp @@ -38,7 +38,6 @@ ****************************************************************************/ #include "qt3dquickextrasnodefactory_p.h" -#include <private/qqmlmetatype_p.h> QT_BEGIN_NAMESPACE @@ -65,12 +64,10 @@ Qt3DCore::QNode *QuickExtrasNodeFactory::createNode(const char *type) if (!typeInfo.resolved) { typeInfo.resolved = true; -#if 0 typeInfo.t = QQmlMetaType::qmlType(QString::fromLatin1(typeInfo.quickName), typeInfo.version.first, typeInfo.version.second); -#endif } - return typeInfo.t ? qobject_cast<Qt3DCore::QNode *>(typeInfo.t->create()) : nullptr; + return typeInfo.t.isValid() ? qobject_cast<Qt3DCore::QNode *>(typeInfo.t.create()) : nullptr; } } // namespace Qt3DExtras diff --git a/src/quick3d/quick3dextras/qt3dquickextrasnodefactory_p.h b/src/quick3d/quick3dextras/qt3dquickextrasnodefactory_p.h index 03769c397..43172952c 100644 --- a/src/quick3d/quick3dextras/qt3dquickextrasnodefactory_p.h +++ b/src/quick3d/quick3dextras/qt3dquickextrasnodefactory_p.h @@ -53,6 +53,7 @@ #include <private/qabstractnodefactory_p.h> #include <QtCore/qhash.h> +#include <QtQml/private/qqmlmetatype_p.h> QT_BEGIN_NAMESPACE @@ -76,7 +77,7 @@ private: : quickName(quickName), version(major, minor), t(nullptr), resolved(false) { } QByteArray quickName; QPair<int, int> version; - QQmlType *t; + QQmlType t; bool resolved; }; QHash<QByteArray, Type> m_types; |