diff options
author | Marc Mutz <marc.mutz@kdab.com> | 2016-02-29 01:01:50 +0100 |
---|---|---|
committer | Sean Harmer <sean.harmer@kdab.com> | 2016-05-14 16:02:31 +0000 |
commit | 6cbe56dfec652d24678aeec069a22f95eb83aa2b (patch) | |
tree | c6d1d828ef858d050aa71d07366d450ebda85f9b /src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp | |
parent | afc5426d4a1b22df72e4cf5582c390d774768673 (diff) |
quick3d: eradicate Q_FOREACH loops [low-risk]
... by replacing them with C++11 range-for loops.
This is the batch with low-risk changes. They operate
on local containers or the loop body clearly does not
cause the container to change.
Sprinkled in a reserve() or two.
Change-Id: I5a3da485213791ae58c82f4a81829cfba558a3d6
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Diffstat (limited to 'src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp')
-rw-r--r-- | src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp b/src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp index 8eb505470..b27d46c31 100644 --- a/src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp +++ b/src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp @@ -97,7 +97,8 @@ void Quick3DTechniqueFilter::clearRequires(QQmlListProperty<QFilterKey> *list) { Quick3DTechniqueFilter *filter = qobject_cast<Quick3DTechniqueFilter *>(list->object); if (filter) { - Q_FOREACH (QFilterKey *criterion, filter->parentTechniqueFilter()->matchAll()) + const auto criteria = filter->parentTechniqueFilter()->matchAll(); + for (QFilterKey *criterion : criteria) filter->parentTechniqueFilter()->removeMatch(criterion); } } @@ -123,7 +124,8 @@ int Quick3DTechniqueFilter::parametersCount(QQmlListProperty<QParameter> *list) void Quick3DTechniqueFilter::clearParameterList(QQmlListProperty<QParameter> *list) { Quick3DTechniqueFilter *techniqueFilter = qobject_cast<Quick3DTechniqueFilter *>(list->object); - Q_FOREACH (QParameter *p, techniqueFilter->parentTechniqueFilter()->parameters()) + const auto parameters = techniqueFilter->parentTechniqueFilter()->parameters(); + for (QParameter *p : parameters) techniqueFilter->parentTechniqueFilter()->removeParameter(p); } |