QGeometryRenderer: fix notification of geometry changing

Change-Id: Ic0fc25a9aacf47863d0ac058d3be687415b2cbdd
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>

1 files changed, 0 insertions, 17 deletions

diff --git a/src/render/geometry/qgeometryrenderer.cpp b/src/render/geometry/qgeometryrenderer.cpp
index 9a8b318d0..ddc1b1b23 100644
--- a/src/render/geometry/qgeometryrenderer.cpp
+++ b/src/render/geometry/qgeometryrenderer.cpp
@@ -390,14 +390,6 @@ void QGeometryRenderer::setGeometry(QGeometry *geometry)
     if (d->m_geometry == geometry)
         return;
 
-    // TODO: Investigate if we can rely upon the automatic property change notifications
-    // rather than having to manually send a PropertyValueRemoved followed by a PropertyValueAdded change.
-    if (d->m_geometry && d->m_changeArbiter) {
-        const auto change = QPropertyNodeRemovedChangePtr::create(id(), d->m_geometry);
-        change->setPropertyName("geometry");
-        d->notifyObservers(change);
-    }
-
     if (d->m_geometry)
         d->unregisterDestructionHelper(d->m_geometry);
 
@@ -406,20 +398,11 @@ void QGeometryRenderer::setGeometry(QGeometry *geometry)
 
     d->m_geometry = geometry;
 
-
     // Ensures proper bookkeeping
     if (d->m_geometry)
         d->registerDestructionHelper(d->m_geometry, &QGeometryRenderer::setGeometry, d->m_geometry);
 
-    const bool blocked = blockNotifications(true);
     emit geometryChanged(geometry);
-    blockNotifications(blocked);
-
-    if (d->m_geometry && d->m_changeArbiter) {
-        const auto change = QPropertyNodeAddedChangePtr::create(id(), d->m_geometry);
-        change->setPropertyName("geometry");
-        d->notifyObservers(change);
-    }
 }
 
 void QGeometryRenderer::setPrimitiveType(QGeometryRenderer::PrimitiveType primitiveType)