diff options
author | Marc Mutz <marc.mutz@kdab.com> | 2016-05-14 00:15:32 +0200 |
---|---|---|
committer | Sean Harmer <sean.harmer@kdab.com> | 2016-05-14 16:02:47 +0000 |
commit | 6da09812519d1656d03c1a8c97b6ba53f38be705 (patch) | |
tree | 630f6899faab04a32ce736d947d50b70dfb5fb3e /src/render/geometry/qgeometryrenderer.h | |
parent | 881fbf9a89b12669178987e5b4c58fedfb8eb9ff (diff) |
QTextureImageData: fix exception specifications
- The ctor is not nothrow because it allocates memory
- The dtor is implicitly noexcept, no need to mark it
as such
- The copy assignment operator copies a QByteArray
which is not nothrow because the source may be
unsharable.
- setImage() is not nothrow because it allocates
memory
- likewise for setData()
- setCompressedFile() is not nothrow because it opens
a file (which involves allocating memory)
- data() allocates memory and this cannot be nothrow,
either
- The protected ctor may later want to add more code,
and construction is anyway not nothrow, so there's
no need to micro-optimize here.
The rest is ok, but should use Q_DECL_NOTHROW so MSVC
2013 benefits, too.
This is a source- and binary incompatible change. But
neither SC nor BC are in effect in Qt3D, yet.
Change-Id: I8126a2ff7cdd7b81e8a3f37ada4341f558470eca
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Diffstat (limited to 'src/render/geometry/qgeometryrenderer.h')
0 files changed, 0 insertions, 0 deletions