diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2016-05-14 08:52:45 +0200 |
|---|---|---|
| committer | Sean Harmer <sean.harmer@kdab.com> | 2016-05-19 07:03:19 +0000 |
| commit | 6f6207fadc1a334d1aed98f840a0d074acf18d06 (patch) | |
| tree | 083bf49b4d6bc999f099b3c1e2897cb23cb89887 /src/render/geometry/qgeometryrenderer.h | |
| parent | 72f2c87d15c76cc861699aea536e01bc8d56c8f2 (diff) | |
De-inline dtors of public polymorphic classes
By making the destructor (usually the first non-inline, non-pure,
virtual function, and therefore the trigger for most compilers to
emit the vtable and type_info structures for the class in that TU)
out-of-line, vtables and, more importantly, type_info structures for
the class are pinned to a single TU. This prevents false negative
dynamic_cast and catch evaluation.
It also allows to add code to them later, if necessary.
Change-Id: I0da301cd788162abba6cdbbb21910090a22adb9a
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Diffstat (limited to 'src/render/geometry/qgeometryrenderer.h')
| -rw-r--r-- | src/render/geometry/qgeometryrenderer.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/render/geometry/qgeometryrenderer.h b/src/render/geometry/qgeometryrenderer.h index 60b769a0b..be3bb6146 100644 --- a/src/render/geometry/qgeometryrenderer.h +++ b/src/render/geometry/qgeometryrenderer.h @@ -69,6 +69,7 @@ class QT3DRENDERSHARED_EXPORT QGeometryRenderer : public Qt3DCore::QComponent public: explicit QGeometryRenderer(Qt3DCore::QNode *parent = nullptr); + ~QGeometryRenderer(); enum PrimitiveType { Points = 0x0000, |