Eradicate Java-style iterators and mark the module clean

Change-Id: I81ef72c1cdd589ccedfd7141116df50a49bb1622
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
 

1 files changed, 4 insertions, 4 deletions

diff --git a/src/render/geometry/buffermanager.cpp b/src/render/geometry/buffermanager.cpp
index 14b552879..92f87ab13 100644
--- a/src/render/geometry/buffermanager.cpp
+++ b/src/render/geometry/buffermanager.cpp
@@ -83,12 +83,12 @@ QVector<Qt3DCore::QNodeId> BufferManager::takeBuffersToRelease()
 {
     QMutexLocker lock(&m_mutex);
     QVector<Qt3DCore::QNodeId> buffersToRelease;
-    QMutableHashIterator<Qt3DCore::QNodeId, int> it(m_bufferReferences);
-    while (it.hasNext()) {
-        it.next();
+    for (auto it = m_bufferReferences.begin(), end = m_bufferReferences.end(); it != end; /*erasing*/) {
         if (it.value() == 0) {
             buffersToRelease.append(it.key());
-            it.remove();
+            it = m_bufferReferences.erase(it);
+        } else {
+            ++it;
         }
     }
     return buffersToRelease;