Cleanup of Parameter

A Parameter is now used only for user specified uniforms. For StandardUniforms
and Attributes we could rely on the ParameterBinder. In case a mesh attribute
or standard uniform doesn't have the default name used by Qt3D shaders (that
will have to be specified somewhere), a ParameterBinder could be added to
solve that issue. Will see how that goes in a follow up patch.

Change-Id: I41bd0d4ef2ac731c109f87fca5b28571074bfba5
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>

1 files changed, 8 insertions, 8 deletions

diff --git a/src/render/io/gltfparser.cpp b/src/render/io/gltfparser.cpp
index 8a0796f1e..0728ff05e 100644
--- a/src/render/io/gltfparser.cpp
+++ b/src/render/io/gltfparser.cpp
@@ -799,14 +799,14 @@ void GLTFParser::processJSONTechnique( QString id, QJsonObject jsonObj )
         // But a string
         Parameter* p = new Parameter(t, pname, parseType(po.value(KEY_TYPE).toString().toUtf8()));
         Parameter::StandardUniform su = parseSemanticName(semantic.toUtf8());
-        if (su != Parameter::None) {
-            p->setStandardUniform(su);
-        } else {
-            // should really verify it's an attribute parameter?
-            // but what would be the way to do that?
-            // check the accessor dict?
-            p->setMeshAttributeName(semantic);
-        }
+//        if (su != Parameter::None) {
+//            p->setStandardUniform(su);
+//        } else {
+//            // should really verify it's an attribute parameter?
+//            // but what would be the way to do that?
+//            // check the accessor dict?
+//            p->setMeshAttributeName(semantic);
+//        }
 
         t->addParameter(p);