summaryrefslogtreecommitdiffstats
path: root/src/render/jobs/pickboundingvolumeutils.cpp
diff options
context:
space:
mode:
authorMike Krus <mike.krus@kdab.com>2017-12-27 15:28:55 +0000
committerSean Harmer <sean.harmer@kdab.com>2018-01-14 11:47:57 +0000
commit1ea7122cad14c14d56474528a429bcb5b94101d0 (patch)
treefed50664f191ab828e621381b6ef48e056e2301a /src/render/jobs/pickboundingvolumeutils.cpp
parente5c16bb630345e819e8eeaf1733eeca694afe6ae (diff)
Prevent potential containers detaching
Found by Clazy clazy-range-loop Change-Id: I4956f9be2b7b3f986b2fc83c1d883829314a8b6c Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Diffstat (limited to 'src/render/jobs/pickboundingvolumeutils.cpp')
-rw-r--r--src/render/jobs/pickboundingvolumeutils.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/render/jobs/pickboundingvolumeutils.cpp b/src/render/jobs/pickboundingvolumeutils.cpp
index 73095f497..564c1e86c 100644
--- a/src/render/jobs/pickboundingvolumeutils.cpp
+++ b/src/render/jobs/pickboundingvolumeutils.cpp
@@ -588,7 +588,8 @@ bool HierarchicalEntityPicker::collectHits(Entity *root)
}
// and pick children
- for (auto child: current.first->children())
+ const auto children = current.first->children();
+ for (auto child: children)
worklist.push_back({child, current.second || !child->componentHandle<ObjectPicker>().isNull()});
}