Fix OnDemand render policy

The OnDemand render policy has no effect because the ShadersDirty and
ComputeDirty flags are always set. This commit resets ShadersDirty so
that ShaderGathererJob is only run when needed. It also introduces the
TechniquesDirty flag so we know when to run
FilterCompatibleTechniqueJob and makes sure the job is only run if
the context has been initialized and the renderer is running.

Task-number: QTBUG-65965
Change-Id: Icbcc03ed2dc6b14c6580cc794267b5a88e5f4ca2
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>

1 files changed, 6 insertions, 7 deletions

diff --git a/src/render/jobs/filtercompatibletechniquejob.cpp b/src/render/jobs/filtercompatibletechniquejob.cpp
index 362e4088f..080ccd306 100644
--- a/src/render/jobs/filtercompatibletechniquejob.cpp
+++ b/src/render/jobs/filtercompatibletechniquejob.cpp
@@ -79,14 +79,13 @@ Renderer *FilterCompatibleTechniqueJob::renderer() const
 void FilterCompatibleTechniqueJob::run()
 {
     Q_ASSERT(m_manager != nullptr && m_renderer != nullptr);
+    Q_ASSERT(m_renderer->isRunning() && m_renderer->graphicsContext()->isInitialized());
 
-    if (m_renderer->isRunning() && m_renderer->graphicsContext()->isInitialized()) {
-        const QVector<Qt3DCore::QNodeId> dirtyTechniqueIds = m_manager->takeDirtyTechniques();
-        for (const Qt3DCore::QNodeId techniqueId : dirtyTechniqueIds) {
-            Technique *technique = m_manager->lookupResource(techniqueId);
-            if (Q_LIKELY(technique != nullptr))
-                technique->setCompatibleWithRenderer((*m_renderer->contextInfo() == *technique->graphicsApiFilter()));
-        }
+    const QVector<Qt3DCore::QNodeId> dirtyTechniqueIds = m_manager->takeDirtyTechniques();
+    for (const Qt3DCore::QNodeId techniqueId : dirtyTechniqueIds) {
+        Technique *technique = m_manager->lookupResource(techniqueId);
+        if (Q_LIKELY(technique != nullptr))
+            technique->setCompatibleWithRenderer((*m_renderer->contextInfo() == *technique->graphicsApiFilter()));
     }
 }