summaryrefslogtreecommitdiffstats
path: root/src/render/renderstates/renderstates.cpp
diff options
context:
space:
mode:
authorMauro Persano <mauro.persano@kdab.com>2017-06-07 11:04:22 -0300
committerMauro Persano <mauro.persano@kdab.com>2017-06-08 08:34:45 +0000
commit842b8fa5ef41135cc58a98e15d56497482dc5619 (patch)
treeba3abceb1cc57ed23f4961cfe19db4f5981e95ea /src/render/renderstates/renderstates.cpp
parent93ea4251c7771f11cf93b47651af3d4ede46d1f2 (diff)
Remove redundant code in AlphaCoverage/SeamlessCubemap render states
The render states AlphaCoverage and SeamlessCubemap will only be added to the render set when their nodes are enabled, so there's no need for an additional boolean field in their backend nodes. Task-number: QTBUG-60419 Change-Id: I3184c665b1d1bd10c067428b2acac6cfb68bd638 Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
Diffstat (limited to 'src/render/renderstates/renderstates.cpp')
-rw-r--r--src/render/renderstates/renderstates.cpp15
1 files changed, 2 insertions, 13 deletions
diff --git a/src/render/renderstates/renderstates.cpp b/src/render/renderstates/renderstates.cpp
index 9b99162d0..49ccf9ae7 100644
--- a/src/render/renderstates/renderstates.cpp
+++ b/src/render/renderstates/renderstates.cpp
@@ -194,13 +194,7 @@ void StencilTest::apply(GraphicsContext *gc) const
void AlphaCoverage::apply(GraphicsContext *gc) const
{
- gc->setAlphaCoverageEnabled(std::get<0>(m_values));
-}
-
-void AlphaCoverage::updateProperty(const char *name, const QVariant &value)
-{
- if (name == QByteArrayLiteral("enabled"))
- std::get<0>(m_values) = value.toBool();
+ gc->setAlphaCoverageEnabled(true);
}
void PointSize::apply(GraphicsContext *gc) const
@@ -254,12 +248,7 @@ void ClipPlane::updateProperty(const char *name, const QVariant &value)
void SeamlessCubemap::apply(GraphicsContext *gc) const
{
- gc->setSeamlessCubemap(std::get<0>(m_values));
-}
-
-void SeamlessCubemap::updateProperty(const char *name, const QVariant &value)
-{
- if (name == QByteArrayLiteral("enabled")) std::get<0>(m_values) = value.toBool();
+ gc->setSeamlessCubemap(true);
}
void StencilOp::apply(GraphicsContext *gc) const