render: eradicate Q_FOREACH loops [remaining low-risk]

... by replacing them with C++11 range-for loops. To
avoid detaches of these mutable Qt containers, wrap
the container in qAsConst(), where needed.

This is the batch with low-risk changes. They operate
on local containers or the loop body clearly does not
cause the container to change.

Saves ~3.8KiB in text size on optimized GCC 6.0 Linux
AMD64 builds.

Change-Id: I9c9669dd89f44d371d7a9cd4fc83a7930a06ce17
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/src/render/renderstates/renderstateset.cpp b/src/render/renderstates/renderstateset.cpp
index 8e850c688..f2715a3cd 100644
--- a/src/render/renderstates/renderstateset.cpp
+++ b/src/render/renderstates/renderstateset.cpp
@@ -124,7 +124,7 @@ int RenderStateSet::changeCost(RenderStateSet *previousState)
     cost += int(bs.count());
 
     // now, find out how many states we're changing
-    Q_FOREACH (RenderStateImpl *ds, m_states) {
+    for (RenderStateImpl *ds : qAsConst(m_states)) {
         // if the other state contains matching, then doesn't
         // contribute to cost at all
         if (previousState->contains(ds)) {
@@ -266,7 +266,7 @@ bool RenderStateSet::contains(RenderStateImpl *ds) const
     if (!(ds->mask() & stateMask()))
         return false;
 
-    Q_FOREACH (RenderStateImpl* rs, m_states) {
+    for (RenderStateImpl* rs : m_states) {
         if (ds->equalTo(*rs))
             return true;
     }