diff options
| author | Thiago Macieira <thiago.macieira@intel.com> | 2020-05-02 17:06:50 -0700 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-05-20 14:32:36 +0200 |
| commit | c2fcb68fcf13527e353fe0338c6f00ea8bac41be (patch) | |
| tree | 081a63599fb268f3b51a74d385ea4307c3f11cc2 /src/render | |
| parent | 66bfb7411579db3feb93e5967009c83f675813a2 (diff) | |
Fix Clang 10 warning about creating copies in range-for
uniform_p.h:171:25: warning: loop variable 'm' of type 'const QMatrix4x4' creates a copy from type 'const QMatrix4x4' [-Wrange-loop- construct]
Task-number: QTBUG-83666
Change-Id: I99ab0f318b1c43b89888fffd160b494c6749bd41
Reviewed-by: Mike Krus <mike.krus@kdab.com>
(cherry picked from commit 0653789506f7043d0154bc97b24944766bd44098)
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/render')
| -rw-r--r-- | src/render/backend/uniform.cpp | 2 | ||||
| -rw-r--r-- | src/render/backend/uniform_p.h | 2 | ||||
| -rw-r--r-- | src/render/jobs/filterentitybycomponentjob_p.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/render/backend/uniform.cpp b/src/render/backend/uniform.cpp index 17c26e6c7..34f87b3b3 100644 --- a/src/render/backend/uniform.cpp +++ b/src/render/backend/uniform.cpp @@ -281,7 +281,7 @@ void UniformValue::setData<QMatrix4x4>(const QVector<QMatrix4x4> &v) int offset = 0; const int byteSize = 16 * sizeof(float); float *data = m_data.data(); - for (const auto m : v) { + for (const auto &m : v) { memcpy(data + offset, m.constData(), byteSize); offset += 16; } diff --git a/src/render/backend/uniform_p.h b/src/render/backend/uniform_p.h index eb959923a..cd9dc97f1 100644 --- a/src/render/backend/uniform_p.h +++ b/src/render/backend/uniform_p.h @@ -168,7 +168,7 @@ public: int offset = 0; const int byteSize = 16 * sizeof(float); float *data = m_data.data(); - for (const auto m : v) { + for (const auto &m : v) { memcpy(data + offset, m.constData(), byteSize); offset += 16; } diff --git a/src/render/jobs/filterentitybycomponentjob_p.h b/src/render/jobs/filterentitybycomponentjob_p.h index 61b2e7ce4..94f3d0fd5 100644 --- a/src/render/jobs/filterentitybycomponentjob_p.h +++ b/src/render/jobs/filterentitybycomponentjob_p.h @@ -85,7 +85,7 @@ public: m_filteredEntities.clear(); const QVector<HEntity> handles = m_manager->activeHandles(); m_filteredEntities.reserve(handles.size()); - for (const HEntity handle : handles) { + for (const HEntity &handle : handles) { Entity *e = m_manager->data(handle); if (e->containsComponentsOfType<T, Ts...>()) m_filteredEntities.push_back(e); |