diff options
| author | Paul Lemire <paul.lemire@kdab.com> | 2022-10-13 07:33:07 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-10-17 14:20:40 +0000 |
| commit | 611de02eccc5e742513545eb0a0925dd3b8d0561 (patch) | |
| tree | 23a1379208b6d4060bcf70f2c863422adaf8bd30 /src | |
| parent | 33655f329f8cd9b82ec567f592c15aad146338c1 (diff) | |
GLTFGeometryLoader: prevent early return on option bufferview target property
The glTF specs mention that the target property on a buffer view is not
required:
https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#reference-bufferview
Therefore, since the parser would return early if no target was specified,
preventing any mesh from being loaded. This patch removes the target checking
which serves no purpose.
Change-Id: I7b1781060b79d1d102c1366dc1884a9f283a7f9f
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
(cherry picked from commit cffc59ff37fbce8fe987e2b4ee64b3d03b3928e9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src')
| -rw-r--r-- | src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp b/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp index a2c539787..caf38452a 100644 --- a/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp +++ b/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp @@ -340,15 +340,6 @@ void GLTFGeometryLoader::processJSONBufferViewV2(const QJsonObject &json) } const auto bufferData = m_gltf2.m_bufferDatas[bufferIndex]; - int target = json.value(KEY_TARGET).toInt(); - switch (target) { - case GL_ARRAY_BUFFER: - case GL_ELEMENT_ARRAY_BUFFER: - break; - default: - return; - } - quint64 offset = 0; const auto byteOffset = json.value(KEY_BYTE_OFFSET); if (!byteOffset.isUndefined()) { |