OpenGLVertexArrayObject: fix bugprone erase() call

openglvertexarrayobject.cpp:117:5: this call will remove at most one
item even when multiple items should be removed [bugprone-inaccurate-
erase]

Change-Id: Ife88facc1cad159658c08180548fe365eaeb1714
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>

1 files changed, 4 insertions, 3 deletions

diff --git a/src/plugins/renderers/opengl/renderer/openglvertexarrayobject.cpp b/src/plugins/renderers/opengl/renderer/openglvertexarrayobject.cpp
index 44badbad5..6f3f7b259 100644
--- a/src/plugins/renderers/opengl/renderer/openglvertexarrayobject.cpp
+++ b/src/plugins/renderers/opengl/renderer/openglvertexarrayobject.cpp
@@ -116,9 +116,10 @@ void OpenGLVertexArrayObject::saveVertexAttribute(const SubmissionContext::VAOVe
     // Remove any vertexAttribute already at location
     m_vertexAttributes.erase(std::remove_if(m_vertexAttributes.begin(),
                                             m_vertexAttributes.end(),
-                                            [attr] (const SubmissionContext::VAOVertexAttribute &a) {
-        return a.location == attr.location;
-    }));
+                                            [attr](const SubmissionContext::VAOVertexAttribute &a) {
+                                                return a.location == attr.location;
+                                            }),
+                             m_vertexAttributes.end());
     m_vertexAttributes.push_back(attr);
 }