diff options
author | Laszlo Agocs <laszlo.agocs@theqtcompany.com> | 2015-12-10 13:16:21 +0100 |
---|---|---|
committer | Laszlo Agocs <laszlo.agocs@theqtcompany.com> | 2015-12-10 13:46:31 +0000 |
commit | 3b699444951a5467249c36f47bd3489591971569 (patch) | |
tree | 88b42d8a4c179188e58292501f1e02db3043002e /src | |
parent | 5e94c15ddc89779c6da7ae919985688173a4d20d (diff) |
Reduce specular reflectivity defaults
0.95 -> 0.01 to prevent eye-poppingly white specular highlights.
Change-Id: I3e765bad13afe991053932e73cea13b95c950c1c
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Andy Nichols <andy.nichols@theqtcompany.com>
Diffstat (limited to 'src')
11 files changed, 12 insertions, 12 deletions
diff --git a/src/quick3d/imports/render/defaults/qml/DiffuseMapMaterial.qml b/src/quick3d/imports/render/defaults/qml/DiffuseMapMaterial.qml index f9b06afdf..49b7729fc 100644 --- a/src/quick3d/imports/render/defaults/qml/DiffuseMapMaterial.qml +++ b/src/quick3d/imports/render/defaults/qml/DiffuseMapMaterial.qml @@ -42,7 +42,7 @@ Material { property color ambient: Qt.rgba( 0.05, 0.05, 0.05, 1.0 ) property alias diffuse: diffuseTextureImage.source - property color specular: Qt.rgba( 0.95, 0.95, 0.95, 1.0 ) + property color specular: Qt.rgba( 0.01, 0.01, 0.01, 1.0 ) property real shininess: 150.0 property real textureScale: 1.0 diff --git a/src/quick3d/imports/render/defaults/qml/NormalDiffuseMapAlphaMaterial.qml b/src/quick3d/imports/render/defaults/qml/NormalDiffuseMapAlphaMaterial.qml index 8757f3ee7..ca658c2c5 100644 --- a/src/quick3d/imports/render/defaults/qml/NormalDiffuseMapAlphaMaterial.qml +++ b/src/quick3d/imports/render/defaults/qml/NormalDiffuseMapAlphaMaterial.qml @@ -42,7 +42,7 @@ Material { property color ambient: Qt.rgba( 0.05, 0.05, 0.05, 1.0 ) property alias diffuse: diffuseTextureImage.source - property color specular: Qt.rgba( 0.95, 0.95, 0.95, 1.0 ) + property color specular: Qt.rgba( 0.01, 0.01, 0.01, 1.0 ) property alias normal: normalTextureImage.source property real shininess: 150.0 property real textureScale: 1.0 diff --git a/src/quick3d/imports/render/defaults/qml/NormalDiffuseMapMaterial.qml b/src/quick3d/imports/render/defaults/qml/NormalDiffuseMapMaterial.qml index ede2f44ec..91fb1d859 100644 --- a/src/quick3d/imports/render/defaults/qml/NormalDiffuseMapMaterial.qml +++ b/src/quick3d/imports/render/defaults/qml/NormalDiffuseMapMaterial.qml @@ -42,7 +42,7 @@ Material { property color ambient: Qt.rgba( 0.05, 0.05, 0.05, 1.0 ) property alias diffuse: diffuseTextureImage.source - property color specular: Qt.rgba( 0.95, 0.95, 0.95, 1.0 ) + property color specular: Qt.rgba( 0.01, 0.01, 0.01, 1.0 ) property alias normal: normalTextureImage.source property real shininess: 150.0 property real textureScale: 1.0 diff --git a/src/quick3d/imports/render/defaults/qml/PhongAlphaMaterial.qml b/src/quick3d/imports/render/defaults/qml/PhongAlphaMaterial.qml index 82ba1008c..1edcbe03c 100644 --- a/src/quick3d/imports/render/defaults/qml/PhongAlphaMaterial.qml +++ b/src/quick3d/imports/render/defaults/qml/PhongAlphaMaterial.qml @@ -41,7 +41,7 @@ Material { id:root property color ambient: Qt.rgba( 0.05, 0.05, 0.05, 1.0 ) property color diffuse: Qt.rgba( 0.7, 0.7, 0.7, 1.0 ) - property color specular: Qt.rgba( 0.95, 0.95, 0.95, 1.0 ) + property color specular: Qt.rgba( 0.01, 0.01, 0.01, 1.0 ) property real shininess: 150.0 property real alpha: 0.5 diff --git a/src/quick3d/imports/render/defaults/qml/PhongMaterial.qml b/src/quick3d/imports/render/defaults/qml/PhongMaterial.qml index af6acaff8..6cab55dd9 100644 --- a/src/quick3d/imports/render/defaults/qml/PhongMaterial.qml +++ b/src/quick3d/imports/render/defaults/qml/PhongMaterial.qml @@ -41,7 +41,7 @@ Material { id:root property color ambient: Qt.rgba( 0.05, 0.05, 0.05, 1.0 ) property color diffuse: Qt.rgba( 0.7, 0.7, 0.7, 1.0 ) - property color specular: Qt.rgba( 0.95, 0.95, 0.95, 1.0 ) + property color specular: Qt.rgba( 0.01, 0.01, 0.01, 1.0 ) property real shininess: 150.0 diff --git a/src/render/backend/renderer.cpp b/src/render/backend/renderer.cpp index 989c4ec00..e924222a8 100644 --- a/src/render/backend/renderer.cpp +++ b/src/render/backend/renderer.cpp @@ -215,7 +215,7 @@ void Renderer::buildDefaultTechnique() m_defaultTechnique->addParameter(kd); basicPass->addBinding(new QParameterMapping(QStringLiteral("diffuse"), QStringLiteral("kd"), QParameterMapping::Uniform)); - QParameter* ks = new QParameter(QStringLiteral("specular"), QVector3D(0.95f, 0.95f, 0.95f)); + QParameter* ks = new QParameter(QStringLiteral("specular"), QVector3D(0.01f, 0.01f, 0.01f)); m_defaultTechnique->addParameter(ks); basicPass->addBinding(new QParameterMapping(QStringLiteral("specular"), QStringLiteral("ks"), QParameterMapping::Uniform)); @@ -228,7 +228,7 @@ void Renderer::buildDefaultMaterial() m_defaultMaterial->setObjectName(QStringLiteral("DefaultMaterial")); m_defaultMaterial->addParameter(new QParameter(QStringLiteral("ambient"), QVector3D(0.2f, 0.2f, 0.2f))); m_defaultMaterial->addParameter(new QParameter(QStringLiteral("diffuse"), QVector3D(1.0f, 0.5f, 0.0f))); - m_defaultMaterial->addParameter(new QParameter(QStringLiteral("specular"), QVector3D(0.95f, 0.95f, 0.95f))); + m_defaultMaterial->addParameter(new QParameter(QStringLiteral("specular"), QVector3D(0.01f, 0.01f, 0.01f))); m_defaultMaterial->addParameter(new QParameter(QStringLiteral("shininess"), 150.0f)); QEffect* defEff = new QEffect; diff --git a/src/render/backend/renderview.cpp b/src/render/backend/renderview.cpp index 23599a223..12e18633a 100644 --- a/src/render/backend/renderview.cpp +++ b/src/render/backend/renderview.cpp @@ -791,7 +791,7 @@ void RenderView::setShaderAndUniforms(RenderCommand *command, RenderPass *rPass, setUniformValue(command->m_uniforms, QStringLiteral("lights[0].type"), int(QLight::DirectionalLight)); setUniformValue(command->m_uniforms, QStringLiteral("lights[0].direction"), QVector3D(0.0f, -1.0f, -1.0f)); setUniformValue(command->m_uniforms, QStringLiteral("lights[0].color"), QVector3D(1.0f, 1.0f, 1.0f)); - setUniformValue(command->m_uniforms, QStringLiteral("lights[0].intensity"), QVector3D(0.5f, 0.5f, 0.5f)); + setUniformValue(command->m_uniforms, QStringLiteral("lights[0].intensity"), 1.0f); } } // Set frag outputs in the shaders if hash not empty diff --git a/src/render/defaults/qdiffusemapmaterial.cpp b/src/render/defaults/qdiffusemapmaterial.cpp index 36bf2ea59..8ef50b250 100644 --- a/src/render/defaults/qdiffusemapmaterial.cpp +++ b/src/render/defaults/qdiffusemapmaterial.cpp @@ -62,7 +62,7 @@ QDiffuseMapMaterialPrivate::QDiffuseMapMaterialPrivate() , m_diffuseTexture(new QTexture2D()) , m_ambientParameter(new QParameter(QStringLiteral("ka"), QColor::fromRgbF(0.05f, 0.05f, 0.05f, 1.0f))) , m_diffuseParameter(new QParameter(QStringLiteral("diffuseTexture"), m_diffuseTexture)) - , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.95f, 0.95f, 0.95f, 1.0f))) + , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.01f, 0.01f, 0.01f, 1.0f))) , m_shininessParameter(new QParameter(QStringLiteral("shininess"), 150.0f)) , m_textureScaleParameter(new QParameter(QStringLiteral("texCoordScale"), 1.0f)) , m_diffuseMapGL3Technique(new QTechnique()) diff --git a/src/render/defaults/qnormaldiffusemapmaterial.cpp b/src/render/defaults/qnormaldiffusemapmaterial.cpp index 5a72278f7..a6b358564 100644 --- a/src/render/defaults/qnormaldiffusemapmaterial.cpp +++ b/src/render/defaults/qnormaldiffusemapmaterial.cpp @@ -65,7 +65,7 @@ QNormalDiffuseMapMaterialPrivate::QNormalDiffuseMapMaterialPrivate() , m_ambientParameter(new QParameter(QStringLiteral("ka"), QColor::fromRgbF(0.1f, 0.1f, 0.1f, 1.0f))) , m_diffuseParameter(new QParameter(QStringLiteral("diffuseTexture"), m_diffuseTexture)) , m_normalParameter(new QParameter(QStringLiteral("normalTexture"), m_normalTexture)) - , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.95f, 0.95f, 0.95f, 1.0f))) + , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.01f, 0.01f, 0.01f, 1.0f))) , m_shininessParameter(new QParameter(QStringLiteral("shininess"), 150.0f)) , m_textureScaleParameter(new QParameter(QStringLiteral("texCoordScale"), 1.0f)) , m_normalDiffuseGL3Technique(new QTechnique()) diff --git a/src/render/defaults/qphongalphamaterial.cpp b/src/render/defaults/qphongalphamaterial.cpp index e54e9c694..494c77e1b 100644 --- a/src/render/defaults/qphongalphamaterial.cpp +++ b/src/render/defaults/qphongalphamaterial.cpp @@ -63,7 +63,7 @@ QPhongAlphaMaterialPrivate::QPhongAlphaMaterialPrivate() , m_phongEffect(new QEffect()) , m_ambientParameter(new QParameter(QStringLiteral("ka"), QColor::fromRgbF(0.05f, 0.05f, 0.05f, 1.0f))) , m_diffuseParameter(new QParameter(QStringLiteral("kd"), QColor::fromRgbF(0.7f, 0.7f, 0.7f, 1.0f))) - , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.95f, 0.95f, 0.95f, 1.0f))) + , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.01f, 0.01f, 0.01f, 1.0f))) , m_shininessParameter(new QParameter(QStringLiteral("shininess"), 150.0f)) , m_alphaParameter(new QParameter(QStringLiteral("alpha"), 0.5f)) , m_phongAlphaGL3Technique(new QTechnique()) diff --git a/src/render/defaults/qphongmaterial.cpp b/src/render/defaults/qphongmaterial.cpp index 233eebd6e..97612078a 100644 --- a/src/render/defaults/qphongmaterial.cpp +++ b/src/render/defaults/qphongmaterial.cpp @@ -60,7 +60,7 @@ QPhongMaterialPrivate::QPhongMaterialPrivate() , m_phongEffect(new QEffect()) , m_ambientParameter(new QParameter(QStringLiteral("ka"), QColor::fromRgbF(0.05f, 0.05f, 0.05f, 1.0f))) , m_diffuseParameter(new QParameter(QStringLiteral("kd"), QColor::fromRgbF(0.7f, 0.7f, 0.7f, 1.0f))) - , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.95f, 0.95f, 0.95f, 1.0f))) + , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.01f, 0.01f, 0.01f, 1.0f))) , m_shininessParameter(new QParameter(QStringLiteral("shininess"), 150.0f)) , m_phongGL3Technique(new QTechnique()) , m_phongGL2Technique(new QTechnique()) |