diff options
author | Marc Mutz <marc.mutz@kdab.com> | 2016-10-05 10:35:30 +0200 |
---|---|---|
committer | Marc Mutz <marc.mutz@kdab.com> | 2016-10-24 10:08:16 +0000 |
commit | 8206e216c1e9fbe3fd5c7c221d2e471523fd76f7 (patch) | |
tree | 6f1c843444e79f454b5fc9e8984772d951d302df /sync.profile | |
parent | b949f984e286c7a34132fbd97301186826dcc7fa (diff) |
QFixedFrameAllocator: Extract Method scan()
The old code used indices to detect when it fell off the
end of m_chunks and needed to allocate a new chunk, but
this was opaque to Coverity, which saw the potential for
m_lastAllocatedChunk == nullptr at the end of the function,
and thus reported a nullptr deref there.
Fix by moving the scanning of m_chunks into a new method,
scan(), which more clearly communicates that it never
returns nullptr, not least because it returns by reference
instead of pointer.
Coverity-Id: 154279
Change-Id: I0cfe8fd819bbfc5b03a98b5e9354c0e98a521d34
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
Diffstat (limited to 'sync.profile')
0 files changed, 0 insertions, 0 deletions