diff options
author | Paul Lemire <paul.lemire@kdab.com> | 2016-08-19 08:42:54 +0200 |
---|---|---|
committer | Paul Lemire <paul.lemire@kdab.com> | 2016-08-26 05:59:44 +0000 |
commit | 918970f5f0283ebff7c0a33f4d87f88283fdbb3e (patch) | |
tree | 806e37f31d10bb4eb25cf538f558f94388630c1f /tests/manual/skybox | |
parent | ca85c459cdff08a04d3d6420ea7d00c3d1eaeea7 (diff) |
QSkyboxEntity: remove camera translation property
If we convert a mat4 matrix to a mat3 matrix, then back to a mat4, this
removes the translation component from it. Making the skybox shaders use that
property allows to remove references to the camera translation in
QSkyboxEntity.
This makes using a skybox neater as we don't need to care about the Camera
position anymore. This also allows to render the same skybox with different
cameras which required to have duplicate QSkyboxEntity previously.
Change-Id: I1adddd17d151e4d26d0f19b048df88dbf738042b
Reviewed-by: Kevin Ottens <kevin.ottens@kdab.com>
Diffstat (limited to 'tests/manual/skybox')
-rw-r--r-- | tests/manual/skybox/main.qml | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/tests/manual/skybox/main.qml b/tests/manual/skybox/main.qml index 13468906c..d89df316e 100644 --- a/tests/manual/skybox/main.qml +++ b/tests/manual/skybox/main.qml @@ -81,7 +81,6 @@ Entity { // So that the camera is rendered always at the same position as the camera SkyboxEntity { - cameraPosition: basicCamera.position baseName: "qrc:/assets/cubemaps/miramar/miramar" extension: ".webp" } |