Fix crash on surface selector unit test

Change order of local variables affecting the destructions order
and making sure window outlives the surface selector

Change-Id: Ia04f110656f4cc563643fb056ae491ffadf3a8b4
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>

1 files changed, 2 insertions, 2 deletions

diff --git a/tests/auto/render/qrendersurfaceselector/tst_qrendersurfaceselector.cpp b/tests/auto/render/qrendersurfaceselector/tst_qrendersurfaceselector.cpp
index 1e003e6b8..982a58b2b 100644
--- a/tests/auto/render/qrendersurfaceselector/tst_qrendersurfaceselector.cpp
+++ b/tests/auto/render/qrendersurfaceselector/tst_qrendersurfaceselector.cpp
@@ -188,8 +188,8 @@ private Q_SLOTS:
     void checkCreationData()
     {
         // GIVEN
-        Qt3DRender::QRenderSurfaceSelector renderSurfaceSelector;
         QWindow newValue;
+        Qt3DRender::QRenderSurfaceSelector renderSurfaceSelector;
 
         renderSurfaceSelector.setSurface(&newValue);
         renderSurfaceSelector.setExternalRenderTargetSize(QSize(128, 128));
@@ -250,10 +250,10 @@ private Q_SLOTS:
     void checkSurfaceUpdate()
     {
         // GIVEN
+        QWindow newWindow;
         TestArbiter arbiter;
         Qt3DRender::QRenderSurfaceSelector renderSurfaceSelector;
         arbiter.setArbiterOnNode(&renderSurfaceSelector);
-        QWindow newWindow;
 
         {
             // WHEN