diff options
398 files changed, 1039 insertions, 323 deletions
diff --git a/.cmake.conf b/.cmake.conf index 54b068eff..e5cf5fa49 100644 --- a/.cmake.conf +++ b/.cmake.conf @@ -1,2 +1,2 @@ -set(QT_REPO_MODULE_VERSION "6.3.1") -set(QT_REPO_MODULE_PRERELEASE_VERSION_SEGMENT "alpha1") +set(QT_REPO_MODULE_VERSION "6.3.3") +set(QT_REPO_MODULE_PRERELEASE_VERSION_SEGMENT "") diff --git a/.qmake.conf b/.qmake.conf index 24c125fce..554a607fc 100644 --- a/.qmake.conf +++ b/.qmake.conf @@ -6,4 +6,4 @@ load(qt_build_config) DEFINES += QT_NO_FOREACH DEFINES += QT_NO_JAVA_STYLE_ITERATORS -MODULE_VERSION = 6.3.1 +MODULE_VERSION = 6.3.3 diff --git a/CMakeLists.txt b/CMakeLists.txt index 36ed2165b..fb7804a26 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -30,7 +30,7 @@ if(WASM OR NOT QT_FEATURE_opengl) endif() # special case begin -# TODO: Fix warnings and remove this +# TODO: Fix warnings and remove this (can't remove now because of QTBUG-99248) set(QT_REPO_NOT_WARNINGS_CLEAN TRUE) # special case end diff --git a/conanfile.py b/conanfile.py index 891dbbfcb..0a27af85d 100644 --- a/conanfile.py +++ b/conanfile.py @@ -1,6 +1,6 @@ ############################################################################# ## -## Copyright (C) 2021 The Qt Company Ltd. +## Copyright (C) 2022 The Qt Company Ltd. ## Contact: https://www.qt.io/licensing/ ## ## This file is part of the release tools of the Qt Toolkit. @@ -73,8 +73,8 @@ class Qt3D(ConanFile): def get_qt_leaf_module_options(self) -> Dict[str, Any]: """Implements abstractmethod from qt-conan-common.QtLeafModule""" - return {item.replace("-", "_"): ["yes", "no", None] for item in _qt3d_features} + return self._shared.convert_qt_features_to_conan_options(_qt3d_features) def get_qt_leaf_module_default_options(self) -> Dict[str, Any]: """Implements abstractmethod from qt-conan-common.QtLeafModule""" - return {item.replace("-", "_"): None for item in _qt3d_features} + return self._shared.convert_qt_features_to_default_conan_options(_qt3d_features) diff --git a/dependencies.yaml b/dependencies.yaml index 3f87f6512..7577a4dc6 100644 --- a/dependencies.yaml +++ b/dependencies.yaml @@ -1,13 +1,13 @@ dependencies: ../qtbase: - ref: 9a75c286b45afa061459ce8256a5a2ad6b278409 + ref: fe0dd828ab031eb1fb6bcf081b463833086c5383 required: true ../qtdeclarative: - ref: 5233b0630496130b89a1bbaeba7c6cd46ed879e4 + ref: 17af1433bfab54091051fa2b336a4c0866d4cc14 required: false ../qtmultimedia: - ref: ca5398503770a342c4502a407e867f41a2bb9c36 + ref: 792e5d45cf7c73d6b0c2c22af406ff3be3585731 required: false ../qtshadertools: - ref: 0657cc393cbf36fc9c47654381681b9541a385dd + ref: 011d3b86679c42dbb46727de398447c86553f10b required: false diff --git a/examples/qt3d/scene3d/CMakeLists.txt b/examples/qt3d/scene3d/CMakeLists.txt index 4efeb864d..07729af38 100644 --- a/examples/qt3d/scene3d/CMakeLists.txt +++ b/examples/qt3d/scene3d/CMakeLists.txt @@ -35,7 +35,7 @@ set(scene3d_resource_files "main.qml" ) -qt6_add_resources(scene3d "scene3d" +qt6_add_resources(scene3d "scene3dres" PREFIX "/" FILES diff --git a/src/3rdparty/assimp/assimp.cmake b/src/3rdparty/assimp/assimp.cmake index 592246a6f..36678cac0 100644 --- a/src/3rdparty/assimp/assimp.cmake +++ b/src/3rdparty/assimp/assimp.cmake @@ -342,4 +342,14 @@ function(qt3d_extend_target_for_assimp target) COMPILE_OPTIONS /bigobj ) + + # Silence warnings in 3rdparty code + if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "GNU") + set_source_files_properties(${assimpDir}/src/code/AssetLib/Collada/ColladaParser.cpp PROPERTIES COMPILE_FLAGS "-Wno-strict-aliasing") + set_source_files_properties(${assimpDir}/src/code/Common/ZipArchiveIOSystem.cpp PROPERTIES COMPILE_FLAGS "-Wno-cast-function-type") + endif() + if (CMAKE_CXX_COMPILER_ID MATCHES "Clang") + set_source_files_properties(${assimpDir}/src/code/Common/Assimp.cpp PROPERTIES COMPILE_FLAGS "-Wno-ordered-compare-function-pointers") + endif() + endfunction() diff --git a/src/animation/frontend/qabstractanimation.cpp b/src/animation/frontend/qabstractanimation.cpp index 4eee6ebac..0c04780c1 100644 --- a/src/animation/frontend/qabstractanimation.cpp +++ b/src/animation/frontend/qabstractanimation.cpp @@ -190,3 +190,5 @@ void QAbstractAnimation::setDuration(float duration) } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qabstractanimation.cpp" diff --git a/src/animation/frontend/qabstractanimationclip.cpp b/src/animation/frontend/qabstractanimationclip.cpp index 27618cd7e..98bd45324 100644 --- a/src/animation/frontend/qabstractanimationclip.cpp +++ b/src/animation/frontend/qabstractanimationclip.cpp @@ -158,3 +158,5 @@ float QAbstractAnimationClip::duration() const } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qabstractanimationclip.cpp" diff --git a/src/animation/frontend/qabstractchannelmapping.cpp b/src/animation/frontend/qabstractchannelmapping.cpp index e1ea7f047..3e5e6a9fa 100644 --- a/src/animation/frontend/qabstractchannelmapping.cpp +++ b/src/animation/frontend/qabstractchannelmapping.cpp @@ -68,3 +68,5 @@ QAbstractChannelMapping::~QAbstractChannelMapping() } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qabstractchannelmapping.cpp" diff --git a/src/animation/frontend/qabstractclipanimator.cpp b/src/animation/frontend/qabstractclipanimator.cpp index cb4621182..6f3baa634 100644 --- a/src/animation/frontend/qabstractclipanimator.cpp +++ b/src/animation/frontend/qabstractclipanimator.cpp @@ -337,3 +337,5 @@ void QAbstractClipAnimator::stop() } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qabstractclipanimator.cpp" diff --git a/src/animation/frontend/qabstractclipblendnode.cpp b/src/animation/frontend/qabstractclipblendnode.cpp index de5084b35..ae03c3197 100644 --- a/src/animation/frontend/qabstractclipblendnode.cpp +++ b/src/animation/frontend/qabstractclipblendnode.cpp @@ -137,3 +137,5 @@ QAbstractClipBlendNode::~QAbstractClipBlendNode() } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qabstractclipblendnode.cpp" diff --git a/src/animation/frontend/qadditiveclipblend.cpp b/src/animation/frontend/qadditiveclipblend.cpp index ca49beb32..ceb2073e7 100644 --- a/src/animation/frontend/qadditiveclipblend.cpp +++ b/src/animation/frontend/qadditiveclipblend.cpp @@ -243,3 +243,5 @@ void QAdditiveClipBlend::setAdditiveClip(QAbstractClipBlendNode *additiveClip) } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qadditiveclipblend.cpp" diff --git a/src/animation/frontend/qanimationaspect.cpp b/src/animation/frontend/qanimationaspect.cpp index 351569190..d5d079bb1 100644 --- a/src/animation/frontend/qanimationaspect.cpp +++ b/src/animation/frontend/qanimationaspect.cpp @@ -150,3 +150,5 @@ std::vector<QAspectJobPtr> QAnimationAspect::jobsToExecute(qint64 time) QT_END_NAMESPACE QT3D_REGISTER_NAMESPACED_ASPECT("animation", QT_PREPEND_NAMESPACE(Qt3DAnimation), QAnimationAspect) + +#include "moc_qanimationaspect.cpp" diff --git a/src/animation/frontend/qanimationclip.cpp b/src/animation/frontend/qanimationclip.cpp index 8dfbf2a1f..9f15e3474 100644 --- a/src/animation/frontend/qanimationclip.cpp +++ b/src/animation/frontend/qanimationclip.cpp @@ -95,3 +95,5 @@ void QAnimationClip::setClipData(const Qt3DAnimation::QAnimationClipData &clipDa } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qanimationclip.cpp" diff --git a/src/animation/frontend/qanimationcliploader.cpp b/src/animation/frontend/qanimationcliploader.cpp index 25cb7253d..b2f4dcd8e 100644 --- a/src/animation/frontend/qanimationcliploader.cpp +++ b/src/animation/frontend/qanimationcliploader.cpp @@ -147,3 +147,5 @@ void QAnimationClipLoader::setSource(const QUrl &source) } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qanimationcliploader.cpp" diff --git a/src/animation/frontend/qanimationcontroller.cpp b/src/animation/frontend/qanimationcontroller.cpp index fef8ad084..98a6a751d 100644 --- a/src/animation/frontend/qanimationcontroller.cpp +++ b/src/animation/frontend/qanimationcontroller.cpp @@ -391,3 +391,5 @@ QAnimationGroup *QAnimationController::getGroup(int index) const } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qanimationcontroller.cpp" diff --git a/src/animation/frontend/qanimationgroup.cpp b/src/animation/frontend/qanimationgroup.cpp index 6c669106e..24ac1b396 100644 --- a/src/animation/frontend/qanimationgroup.cpp +++ b/src/animation/frontend/qanimationgroup.cpp @@ -213,3 +213,5 @@ void QAnimationGroup::setPosition(float position) } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qanimationgroup.cpp" diff --git a/src/animation/frontend/qblendedclipanimator.cpp b/src/animation/frontend/qblendedclipanimator.cpp index e6c5caead..02d9981fc 100644 --- a/src/animation/frontend/qblendedclipanimator.cpp +++ b/src/animation/frontend/qblendedclipanimator.cpp @@ -309,3 +309,5 @@ void QBlendedClipAnimator::setBlendTree(QAbstractClipBlendNode *blendTree) } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qblendedclipanimator.cpp" diff --git a/src/animation/frontend/qcallbackmapping.cpp b/src/animation/frontend/qcallbackmapping.cpp index 972ae73aa..af765378e 100644 --- a/src/animation/frontend/qcallbackmapping.cpp +++ b/src/animation/frontend/qcallbackmapping.cpp @@ -144,3 +144,5 @@ void QCallbackMapping::setCallback(int type, QAnimationCallback *callback, QAnim } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qcallbackmapping.cpp" diff --git a/src/animation/frontend/qchannelmapper.cpp b/src/animation/frontend/qchannelmapper.cpp index 334208238..1ad88941c 100644 --- a/src/animation/frontend/qchannelmapper.cpp +++ b/src/animation/frontend/qchannelmapper.cpp @@ -112,3 +112,5 @@ QList<QAbstractChannelMapping *> QChannelMapper::mappings() const } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qchannelmapper.cpp" diff --git a/src/animation/frontend/qchannelmapping.cpp b/src/animation/frontend/qchannelmapping.cpp index c2c6ade38..340cf309f 100644 --- a/src/animation/frontend/qchannelmapping.cpp +++ b/src/animation/frontend/qchannelmapping.cpp @@ -252,3 +252,5 @@ void QChannelMapping::setProperty(const QString &property) } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qchannelmapping.cpp" diff --git a/src/animation/frontend/qclipanimator.cpp b/src/animation/frontend/qclipanimator.cpp index 1f1d05a1b..f511b526e 100644 --- a/src/animation/frontend/qclipanimator.cpp +++ b/src/animation/frontend/qclipanimator.cpp @@ -166,3 +166,5 @@ void QClipAnimator::setClip(QAbstractAnimationClip *clip) } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qclipanimator.cpp" diff --git a/src/animation/frontend/qclipblendvalue.cpp b/src/animation/frontend/qclipblendvalue.cpp index e7e8a8898..0f6e0207c 100644 --- a/src/animation/frontend/qclipblendvalue.cpp +++ b/src/animation/frontend/qclipblendvalue.cpp @@ -122,3 +122,5 @@ void QClipBlendValue::setClip(Qt3DAnimation::QAbstractAnimationClip *clip) } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qclipblendvalue.cpp" diff --git a/src/animation/frontend/qclock.cpp b/src/animation/frontend/qclock.cpp index 5f9214419..0fa792158 100644 --- a/src/animation/frontend/qclock.cpp +++ b/src/animation/frontend/qclock.cpp @@ -90,3 +90,5 @@ void QClock::setPlaybackRate(double playbackRate) } QT_END_NAMESPACE + +#include "moc_qclock.cpp" diff --git a/src/animation/frontend/qkeyframeanimation.cpp b/src/animation/frontend/qkeyframeanimation.cpp index 08bd584f2..4f208de4d 100644 --- a/src/animation/frontend/qkeyframeanimation.cpp +++ b/src/animation/frontend/qkeyframeanimation.cpp @@ -416,3 +416,5 @@ Qt3DCore::QTransform *QKeyframeAnimation::target() const } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qkeyframeanimation.cpp" diff --git a/src/animation/frontend/qlerpclipblend.cpp b/src/animation/frontend/qlerpclipblend.cpp index 9ee95ccdb..891c6433e 100644 --- a/src/animation/frontend/qlerpclipblend.cpp +++ b/src/animation/frontend/qlerpclipblend.cpp @@ -218,3 +218,5 @@ void QLerpClipBlend::setEndClip(Qt3DAnimation::QAbstractClipBlendNode *endClip) } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qlerpclipblend.cpp" diff --git a/src/animation/frontend/qmorphinganimation.cpp b/src/animation/frontend/qmorphinganimation.cpp index df7b7b209..622f86eb1 100644 --- a/src/animation/frontend/qmorphinganimation.cpp +++ b/src/animation/frontend/qmorphinganimation.cpp @@ -454,3 +454,5 @@ void QMorphingAnimation::updateAnimation(float position) } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qmorphinganimation.cpp" diff --git a/src/animation/frontend/qmorphtarget.cpp b/src/animation/frontend/qmorphtarget.cpp index 1108bf45b..61386b77a 100644 --- a/src/animation/frontend/qmorphtarget.cpp +++ b/src/animation/frontend/qmorphtarget.cpp @@ -190,3 +190,5 @@ QMorphTarget *QMorphTarget::fromGeometry(Qt3DCore::QGeometry *geometry, const QS } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qmorphtarget.cpp" diff --git a/src/animation/frontend/qskeletonmapping.cpp b/src/animation/frontend/qskeletonmapping.cpp index e13cd87ec..90c5ddea9 100644 --- a/src/animation/frontend/qskeletonmapping.cpp +++ b/src/animation/frontend/qskeletonmapping.cpp @@ -95,3 +95,5 @@ void QSkeletonMapping::setSkeleton(Qt3DCore::QAbstractSkeleton *skeleton) } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qskeletonmapping.cpp" diff --git a/src/animation/frontend/qvertexblendanimation.cpp b/src/animation/frontend/qvertexblendanimation.cpp index 58e85581b..1b3b8e2eb 100644 --- a/src/animation/frontend/qvertexblendanimation.cpp +++ b/src/animation/frontend/qvertexblendanimation.cpp @@ -340,3 +340,5 @@ void QVertexBlendAnimation::updateAnimation(float position) } // Qt3DAnimation QT_END_NAMESPACE + +#include "moc_qvertexblendanimation.cpp" diff --git a/src/core/aspect/qcoreaspect.cpp b/src/core/aspect/qcoreaspect.cpp index b9aae3324..0a5999e51 100644 --- a/src/core/aspect/qcoreaspect.cpp +++ b/src/core/aspect/qcoreaspect.cpp @@ -153,3 +153,5 @@ void QCoreAspect::frameDone() QT_END_NAMESPACE QT3D_REGISTER_NAMESPACED_ASPECT("core", QT_PREPEND_NAMESPACE(Qt3DCore), QCoreAspect) + +#include "moc_qcoreaspect.cpp" diff --git a/src/core/aspect/qcoresettings.cpp b/src/core/aspect/qcoresettings.cpp index 81415de7e..39469e24b 100644 --- a/src/core/aspect/qcoresettings.cpp +++ b/src/core/aspect/qcoresettings.cpp @@ -135,3 +135,5 @@ void QCoreSettings::setBoundingVolumesEnabled(bool boundingVolumesEnabled) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qcoresettings.cpp" diff --git a/src/core/aspects/aspectcommanddebugger.cpp b/src/core/aspects/aspectcommanddebugger.cpp index 7635f44c0..1e4d7bd54 100644 --- a/src/core/aspects/aspectcommanddebugger.cpp +++ b/src/core/aspects/aspectcommanddebugger.cpp @@ -204,3 +204,5 @@ void AspectCommandDebugger::executeCommand(const QString &command, } // Qt3DCore QT_END_NAMESPACE + +#include "moc_aspectcommanddebugger_p.cpp" diff --git a/src/core/aspects/qabstractaspect.cpp b/src/core/aspects/qabstractaspect.cpp index 4c42b5093..f50c88df8 100644 --- a/src/core/aspects/qabstractaspect.cpp +++ b/src/core/aspects/qabstractaspect.cpp @@ -456,3 +456,7 @@ void AsynchronousCommandReply::setData(const QByteArray &data) } // of namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qabstractaspect_p.cpp" + +#include "moc_qabstractaspect.cpp" diff --git a/src/core/aspects/qabstractaspect_p.h b/src/core/aspects/qabstractaspect_p.h index f3878ed55..fea5dc311 100644 --- a/src/core/aspects/qabstractaspect_p.h +++ b/src/core/aspects/qabstractaspect_p.h @@ -51,6 +51,7 @@ // We mean it. // +#include <QtCore/QHash> #include <Qt3DCore/qabstractaspect.h> #include <Qt3DCore/private/qaspectjobproviderinterface_p.h> diff --git a/src/core/aspects/qaspectengine.cpp b/src/core/aspects/qaspectengine.cpp index c75bb150e..4a1ec0aeb 100644 --- a/src/core/aspects/qaspectengine.cpp +++ b/src/core/aspects/qaspectengine.cpp @@ -541,3 +541,5 @@ QAspectEngine::RunMode QAspectEngine::runMode() const } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qaspectengine.cpp" diff --git a/src/core/aspects/qaspectmanager.cpp b/src/core/aspects/qaspectmanager.cpp index 28f689c3c..72661aaa4 100644 --- a/src/core/aspects/qaspectmanager.cpp +++ b/src/core/aspects/qaspectmanager.cpp @@ -573,3 +573,5 @@ void QAspectManager::processFrame() } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qaspectmanager_p.cpp" diff --git a/src/core/doc/src/qmlextracontrollers.qdoc b/src/core/doc/src/qmlextracontrollers.qdoc index f02f4b29f..a1c3cb0a6 100644 --- a/src/core/doc/src/qmlextracontrollers.qdoc +++ b/src/core/doc/src/qmlextracontrollers.qdoc @@ -151,7 +151,7 @@ of the camera pan and tilt. */ /*! - \qmlproperty real OrbitCameraController::zoomLimit + \qmlproperty real OrbitCameraController::zoomInLimit Holds the current zoom-in limit. The zoom-in limit determines how close to the view center the camera can be zoomed. diff --git a/src/core/doc/src/qt3drender-porting-to-rhi.qdoc b/src/core/doc/src/qt3drender-porting-to-rhi.qdoc index 4f1709872..c0a23861b 100644 --- a/src/core/doc/src/qt3drender-porting-to-rhi.qdoc +++ b/src/core/doc/src/qt3drender-porting-to-rhi.qdoc @@ -69,7 +69,7 @@ \badcode Material { Effect { - technique: [ + techniques: [ Technique { id: gl3Technique graphicsApiFilter { diff --git a/src/core/geometry/qattribute.cpp b/src/core/geometry/qattribute.cpp index d3a564b66..7a5f529e5 100644 --- a/src/core/geometry/qattribute.cpp +++ b/src/core/geometry/qattribute.cpp @@ -503,3 +503,5 @@ The signal is emitted with \a vertexBaseType when the dataType changed. } // Qt3DCore QT_END_NAMESPACE + +#include "moc_qattribute.cpp" diff --git a/src/core/geometry/qboundingvolume.cpp b/src/core/geometry/qboundingvolume.cpp index 54bf9ffa8..8ecdbd3e9 100644 --- a/src/core/geometry/qboundingvolume.cpp +++ b/src/core/geometry/qboundingvolume.cpp @@ -390,3 +390,5 @@ bool QBoundingVolume::updateImplicitBounds() } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qboundingvolume.cpp" diff --git a/src/core/geometry/qbuffer.cpp b/src/core/geometry/qbuffer.cpp index 9169442f1..ad4eca85b 100644 --- a/src/core/geometry/qbuffer.cpp +++ b/src/core/geometry/qbuffer.cpp @@ -266,3 +266,5 @@ QBuffer::AccessType QBuffer::accessType() const } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qbuffer.cpp" diff --git a/src/core/geometry/qgeometryview.cpp b/src/core/geometry/qgeometryview.cpp index 6effa1d28..72c2f3c06 100644 --- a/src/core/geometry/qgeometryview.cpp +++ b/src/core/geometry/qgeometryview.cpp @@ -615,3 +615,5 @@ void QGeometryView::setPrimitiveType(QGeometryView::PrimitiveType primitiveType) } QT_END_NAMESPACE + +#include "moc_qgeometryview.cpp" diff --git a/src/core/jobs/qabstractaspectjobmanager.cpp b/src/core/jobs/qabstractaspectjobmanager.cpp index 5d921c778..c790cf47b 100644 --- a/src/core/jobs/qabstractaspectjobmanager.cpp +++ b/src/core/jobs/qabstractaspectjobmanager.cpp @@ -57,3 +57,5 @@ QAbstractAspectJobManager::QAbstractAspectJobManager(QObject *parent) } QT_END_NAMESPACE + +#include "moc_qabstractaspectjobmanager_p.cpp" diff --git a/src/core/jobs/qaspectjobmanager.cpp b/src/core/jobs/qaspectjobmanager.cpp index e352536cd..2d1106260 100644 --- a/src/core/jobs/qaspectjobmanager.cpp +++ b/src/core/jobs/qaspectjobmanager.cpp @@ -152,3 +152,5 @@ int QAspectJobManager::idealThreadCount() } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qaspectjobmanager_p.cpp" diff --git a/src/core/jobs/qthreadpooler.cpp b/src/core/jobs/qthreadpooler.cpp index b2f53b7e7..6dfd9f320 100644 --- a/src/core/jobs/qthreadpooler.cpp +++ b/src/core/jobs/qthreadpooler.cpp @@ -50,7 +50,7 @@ QThreadPooler::QThreadPooler(QObject *parent) , m_futureInterface(nullptr) , m_mutex() , m_taskCount(0) - , m_threadPool(QThreadPool::globalInstance()) + , m_threadPool(new QThreadPool(this)) , m_totalRunJobs(0) { m_threadPool->setMaxThreadCount(QAspectJobManager::idealThreadCount()); @@ -203,3 +203,5 @@ int QThreadPooler::currentCount() const } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qthreadpooler_p.cpp" diff --git a/src/core/jobs/qthreadpooler_p.h b/src/core/jobs/qthreadpooler_p.h index 058da2fc9..8d8be8d23 100644 --- a/src/core/jobs/qthreadpooler_p.h +++ b/src/core/jobs/qthreadpooler_p.h @@ -77,8 +77,6 @@ public: void taskFinished(RunnableInterface *task); QFuture<void> future(); - static int maxThreadCount(); - private: void enqueueTasks(const QList<RunnableInterface *> &tasks); void skipTask(RunnableInterface *task); diff --git a/src/core/nodes/propertychangehandler.cpp b/src/core/nodes/propertychangehandler.cpp index 0a1d59932..3d58b5f0f 100644 --- a/src/core/nodes/propertychangehandler.cpp +++ b/src/core/nodes/propertychangehandler.cpp @@ -84,3 +84,5 @@ void PropertyChangeHandlerBase::disconnectFromPropertyChange(const QObject *obje } QT_END_NAMESPACE + +#include "moc_propertychangehandler_p.cpp" diff --git a/src/core/nodes/qcomponent.cpp b/src/core/nodes/qcomponent.cpp index 5e41e2f67..21fb20a50 100644 --- a/src/core/nodes/qcomponent.cpp +++ b/src/core/nodes/qcomponent.cpp @@ -190,3 +190,5 @@ QComponent::QComponent(QComponentPrivate &dd, QNode *parent) */ QT_END_NAMESPACE + +#include "moc_qcomponent.cpp" diff --git a/src/core/nodes/qentity.cpp b/src/core/nodes/qentity.cpp index 25ec4434c..7685f0984 100644 --- a/src/core/nodes/qentity.cpp +++ b/src/core/nodes/qentity.cpp @@ -329,3 +329,5 @@ void QEntity::onParentChanged(QObject *) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qentity.cpp" diff --git a/src/core/nodes/qnode.cpp b/src/core/nodes/qnode.cpp index d9ab8f0dc..dd623995a 100644 --- a/src/core/nodes/qnode.cpp +++ b/src/core/nodes/qnode.cpp @@ -924,4 +924,6 @@ void NodePostConstructorInit::processNodes() QT_END_NAMESPACE +#include "moc_qnode_p.cpp" + #include "moc_qnode.cpp" diff --git a/src/core/qchangearbiter.cpp b/src/core/qchangearbiter.cpp index add672d1f..78b22eebc 100644 --- a/src/core/qchangearbiter.cpp +++ b/src/core/qchangearbiter.cpp @@ -113,3 +113,5 @@ QList<ComponentRelationshipChange> QChangeArbiter::takeDirtyEntityComponentNodes } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qchangearbiter_p.cpp" diff --git a/src/core/qscheduler.cpp b/src/core/qscheduler.cpp index c982e39ca..c72a3c48e 100644 --- a/src/core/qscheduler.cpp +++ b/src/core/qscheduler.cpp @@ -157,3 +157,5 @@ int QScheduler::scheduleAndWaitForFrameAspectJobs(qint64 time, bool dumpJobs) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qscheduler_p.cpp" diff --git a/src/core/services/qabstractframeadvanceservice.cpp b/src/core/services/qabstractframeadvanceservice.cpp index 15bf46afa..fc4752c62 100644 --- a/src/core/services/qabstractframeadvanceservice.cpp +++ b/src/core/services/qabstractframeadvanceservice.cpp @@ -91,3 +91,5 @@ QAbstractFrameAdvanceService::QAbstractFrameAdvanceService(QAbstractFrameAdvance } // Qt3D QT_END_NAMESPACE + +#include "moc_qabstractframeadvanceservice_p.cpp" diff --git a/src/core/services/qdownloadnetworkworker.cpp b/src/core/services/qdownloadnetworkworker.cpp index e1f806e92..ffc44b2a6 100644 --- a/src/core/services/qdownloadnetworkworker.cpp +++ b/src/core/services/qdownloadnetworkworker.cpp @@ -146,3 +146,5 @@ void QDownloadNetworkWorker::onDownloadProgressed(qint64 bytesReceived, qint64 b QT_END_NAMESPACE +#include "moc_qdownloadnetworkworker_p.cpp" + diff --git a/src/core/services/qeventfilterservice.cpp b/src/core/services/qeventfilterservice.cpp index 59b4eedb3..254a2d31e 100644 --- a/src/core/services/qeventfilterservice.cpp +++ b/src/core/services/qeventfilterservice.cpp @@ -189,4 +189,6 @@ bool InternalEventListener::eventFilter(QObject *obj, QEvent *e) QT_END_NAMESPACE +#include "moc_qeventfilterservice_p.cpp" + #include "qeventfilterservice.moc" diff --git a/src/core/services/qopenglinformationservice.cpp b/src/core/services/qopenglinformationservice.cpp index c1c05018e..76b4fa690 100644 --- a/src/core/services/qopenglinformationservice.cpp +++ b/src/core/services/qopenglinformationservice.cpp @@ -84,3 +84,5 @@ QOpenGLInformationService::QOpenGLInformationService(QOpenGLInformationServicePr } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qopenglinformationservice_p.cpp" diff --git a/src/core/services/qservicelocator.cpp b/src/core/services/qservicelocator.cpp index 73a40c2e4..2f8117bb4 100644 --- a/src/core/services/qservicelocator.cpp +++ b/src/core/services/qservicelocator.cpp @@ -267,3 +267,5 @@ QAbstractServiceProvider *QServiceLocator::_q_getServiceHelper(int type) } QT_END_NAMESPACE + +#include "moc_qservicelocator_p.cpp" diff --git a/src/core/services/qsysteminformationservice.cpp b/src/core/services/qsysteminformationservice.cpp index 02571482f..882aef15d 100644 --- a/src/core/services/qsysteminformationservice.cpp +++ b/src/core/services/qsysteminformationservice.cpp @@ -436,3 +436,5 @@ void QSystemInformationService::dumpCommand(const QString &command) } QT_END_NAMESPACE + +#include "moc_qsysteminformationservice_p.cpp" diff --git a/src/core/services/qtickclockservice.cpp b/src/core/services/qtickclockservice.cpp index 225e70ec2..f3f67ab4c 100644 --- a/src/core/services/qtickclockservice.cpp +++ b/src/core/services/qtickclockservice.cpp @@ -98,3 +98,5 @@ void QTickClockService::stop() } // Qt3D QT_END_NAMESPACE + +#include "moc_qtickclockservice_p.cpp" diff --git a/src/core/transforms/qabstractskeleton.cpp b/src/core/transforms/qabstractskeleton.cpp index cdda89418..8d30b27da 100644 --- a/src/core/transforms/qabstractskeleton.cpp +++ b/src/core/transforms/qabstractskeleton.cpp @@ -130,3 +130,5 @@ void QAbstractSkeletonPrivate::setJointCount(int jointCount) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qabstractskeleton.cpp" diff --git a/src/core/transforms/qarmature.cpp b/src/core/transforms/qarmature.cpp index 56d310152..528827e7f 100644 --- a/src/core/transforms/qarmature.cpp +++ b/src/core/transforms/qarmature.cpp @@ -160,3 +160,5 @@ void QArmature::setSkeleton(Qt3DCore::QAbstractSkeleton *skeleton) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qarmature.cpp" diff --git a/src/core/transforms/qjoint.cpp b/src/core/transforms/qjoint.cpp index 1c0233f49..2df5b9b96 100644 --- a/src/core/transforms/qjoint.cpp +++ b/src/core/transforms/qjoint.cpp @@ -391,3 +391,5 @@ QString QJoint::name() const } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qjoint.cpp" diff --git a/src/core/transforms/qskeleton.cpp b/src/core/transforms/qskeleton.cpp index 751daaabe..a268378a8 100644 --- a/src/core/transforms/qskeleton.cpp +++ b/src/core/transforms/qskeleton.cpp @@ -139,3 +139,5 @@ void QSkeleton::setRootJoint(Qt3DCore::QJoint *rootJoint) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qskeleton.cpp" diff --git a/src/core/transforms/qskeletonloader.cpp b/src/core/transforms/qskeletonloader.cpp index e86c72fbf..6197f1ad1 100644 --- a/src/core/transforms/qskeletonloader.cpp +++ b/src/core/transforms/qskeletonloader.cpp @@ -242,3 +242,5 @@ void QSkeletonLoader::setRootJoint(QJoint *rootJoint) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qskeletonloader.cpp" diff --git a/src/extras/3dtext/qextrudedtextgeometry.cpp b/src/extras/3dtext/qextrudedtextgeometry.cpp index 1c9208ea9..c353bf62c 100644 --- a/src/extras/3dtext/qextrudedtextgeometry.cpp +++ b/src/extras/3dtext/qextrudedtextgeometry.cpp @@ -130,7 +130,7 @@ TriangulationData triangulate(const QString &text, const QFont &font) result.indices.resize(result.indices.size() + size_t(triangles.indices.size())); memcpy(&result.indices[prevNumIndices], triangles.indices.data(), size_t(triangles.indices.size()) * sizeof(IndexType)); for (size_t i = prevNumIndices, m = result.indices.size(); i < m; ++i) - result.indices[i] += result.vertices.size(); + result.indices[i] += IndexType(result.vertices.size()); // Append new triangles to result.vertices result.vertices.reserve(size_t(triangles.vertices.size()) / 2); @@ -307,7 +307,7 @@ void QExtrudedTextGeometryPrivate::update() TriangulationData data = triangulate(m_text, m_font); - const size_t numVertices = data.vertices.size(); + const IndexType numVertices = IndexType(data.vertices.size()); const size_t numIndices = data.indices.size(); struct Vertex { @@ -327,7 +327,8 @@ void QExtrudedTextGeometryPrivate::update() vertices.push_back({ QVector3D(v.x(), v.y(), m_depth), // vertex QVector3D(0.0f, 0.0f, 1.0f) }); // normal - for (size_t i = 0, verticesIndex = vertices.size(); i < data.outlines.size(); ++i) { + int verticesIndex = int(vertices.size()); + for (size_t i = 0; i < data.outlines.size(); ++i) { const int begin = data.outlines[i].begin; const int end = data.outlines[i].end; const int verticesIndexBegin = verticesIndex; @@ -380,12 +381,12 @@ void QExtrudedTextGeometryPrivate::update() memcpy(data.data(), vertices.data(), vertices.size() * sizeof(Vertex)); m_vertexBuffer->setData(data); - m_positionAttribute->setCount(vertices.size()); - m_normalAttribute->setCount(vertices.size()); + m_positionAttribute->setCount(int(vertices.size())); + m_normalAttribute->setCount(int(vertices.size())); } // resize for following insertions - const int indicesOffset = indices.size(); + const int indicesOffset = int(indices.size()); indices.resize(indices.size() + numIndices * 2); // copy values for back faces @@ -405,7 +406,7 @@ void QExtrudedTextGeometryPrivate::update() memcpy(data.data(), indices.data(), indices.size() * sizeof(IndexType)); m_indexBuffer->setData(data); - m_indexAttribute->setCount(indices.size()); + m_indexAttribute->setCount(uint(indices.size())); } } @@ -512,3 +513,5 @@ Qt3DCore::QAttribute *QExtrudedTextGeometry::indexAttribute() const } // Qt3DExtras QT_END_NAMESPACE + +#include "moc_qextrudedtextgeometry.cpp" diff --git a/src/extras/3dtext/qextrudedtextmesh.cpp b/src/extras/3dtext/qextrudedtextmesh.cpp index fc93726d2..d6555b52b 100644 --- a/src/extras/3dtext/qextrudedtextmesh.cpp +++ b/src/extras/3dtext/qextrudedtextmesh.cpp @@ -167,3 +167,5 @@ float QExtrudedTextMesh::depth() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qextrudedtextmesh.cpp" diff --git a/src/extras/defaults/qabstractcameracontroller.cpp b/src/extras/defaults/qabstractcameracontroller.cpp index dafe1fde8..f50b8c987 100644 --- a/src/extras/defaults/qabstractcameracontroller.cpp +++ b/src/extras/defaults/qabstractcameracontroller.cpp @@ -288,7 +288,8 @@ QAbstractCameraController::QAbstractCameraController(QAbstractCameraControllerPr d->init(); QObject::connect(d->m_frameAction, &Qt3DLogic::QFrameAction::triggered, - this, [=] (float dt) { + this, [this] (float dt) { + Q_D(const QAbstractCameraController); InputState state; state.rxAxisValue = d->m_rxAxis->value(); diff --git a/src/extras/defaults/qabstractspritesheet.cpp b/src/extras/defaults/qabstractspritesheet.cpp index 2cf134f7c..d70e924c4 100644 --- a/src/extras/defaults/qabstractspritesheet.cpp +++ b/src/extras/defaults/qabstractspritesheet.cpp @@ -141,3 +141,5 @@ void QAbstractSpriteSheet::setCurrentIndex(int currentIndex) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qabstractspritesheet.cpp" diff --git a/src/extras/defaults/qdiffusemapmaterial.cpp b/src/extras/defaults/qdiffusemapmaterial.cpp index bd9785e2e..ce3726454 100644 --- a/src/extras/defaults/qdiffusemapmaterial.cpp +++ b/src/extras/defaults/qdiffusemapmaterial.cpp @@ -359,3 +359,5 @@ void QDiffuseMapMaterial::setTextureScale(float textureScale) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qdiffusemapmaterial.cpp" diff --git a/src/extras/defaults/qdiffusespecularmapmaterial.cpp b/src/extras/defaults/qdiffusespecularmapmaterial.cpp index 8f1dd66e1..1d9f6e54c 100644 --- a/src/extras/defaults/qdiffusespecularmapmaterial.cpp +++ b/src/extras/defaults/qdiffusespecularmapmaterial.cpp @@ -378,3 +378,5 @@ void QDiffuseSpecularMapMaterial::setTextureScale(float textureScale) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qdiffusespecularmapmaterial.cpp" diff --git a/src/extras/defaults/qdiffusespecularmaterial.cpp b/src/extras/defaults/qdiffusespecularmaterial.cpp index 2a1139aef..db44fcb8d 100644 --- a/src/extras/defaults/qdiffusespecularmaterial.cpp +++ b/src/extras/defaults/qdiffusespecularmaterial.cpp @@ -539,3 +539,5 @@ void QDiffuseSpecularMaterial::setAlphaBlendingEnabled(bool enabled) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qdiffusespecularmaterial.cpp" diff --git a/src/extras/defaults/qforwardrenderer.cpp b/src/extras/defaults/qforwardrenderer.cpp index a31c9a188..ede7811b9 100644 --- a/src/extras/defaults/qforwardrenderer.cpp +++ b/src/extras/defaults/qforwardrenderer.cpp @@ -394,3 +394,5 @@ bool QForwardRenderer::showDebugOverlay() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qforwardrenderer.cpp" diff --git a/src/extras/defaults/qgoochmaterial.cpp b/src/extras/defaults/qgoochmaterial.cpp index b5665d776..a0088c80a 100644 --- a/src/extras/defaults/qgoochmaterial.cpp +++ b/src/extras/defaults/qgoochmaterial.cpp @@ -377,3 +377,5 @@ void QGoochMaterial::setShininess(float shininess) } QT_END_NAMESPACE + +#include "moc_qgoochmaterial.cpp" diff --git a/src/extras/defaults/qmetalroughmaterial.cpp b/src/extras/defaults/qmetalroughmaterial.cpp index 79ff94337..0e3cab916 100644 --- a/src/extras/defaults/qmetalroughmaterial.cpp +++ b/src/extras/defaults/qmetalroughmaterial.cpp @@ -505,3 +505,5 @@ void QMetalRoughMaterial::setTextureScale(float textureScale) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qmetalroughmaterial.cpp" diff --git a/src/extras/defaults/qmorphphongmaterial.cpp b/src/extras/defaults/qmorphphongmaterial.cpp index e5b94837c..6c0c05e2f 100644 --- a/src/extras/defaults/qmorphphongmaterial.cpp +++ b/src/extras/defaults/qmorphphongmaterial.cpp @@ -61,9 +61,9 @@ namespace Qt3DExtras { QMorphPhongMaterialPrivate::QMorphPhongMaterialPrivate() : QMaterialPrivate() , m_phongEffect(new QEffect()) - , m_ambientParameter(new QParameter(QStringLiteral("ka"), QColor::fromRgbF(0.05, 0.05, 0.05, 1.0))) - , m_diffuseParameter(new QParameter(QStringLiteral("kd"), QColor::fromRgbF(0.7, 0.7, 0.7, 1.0))) - , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.01, 0.01, 0.01, 1.0))) + , m_ambientParameter(new QParameter(QStringLiteral("ka"), QColor::fromRgbF(0.05f, 0.05f, 0.05f, 1.0f))) + , m_diffuseParameter(new QParameter(QStringLiteral("kd"), QColor::fromRgbF(0.7f, 0.7f, 0.7f, 1.0f))) + , m_specularParameter(new QParameter(QStringLiteral("ks"), QColor::fromRgbF(0.01f, 0.01f, 0.01f, 1.0f))) , m_shininessParameter(new QParameter(QStringLiteral("shininess"), 150.0f)) , m_interpolatorParameter(new QParameter(QStringLiteral("interpolator"), 0.0f)) , m_phongGL3Technique(new QTechnique()) @@ -333,3 +333,5 @@ void QMorphPhongMaterial::setInterpolator(float interpolator) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qmorphphongmaterial.cpp" diff --git a/src/extras/defaults/qnormaldiffusemapalphamaterial.cpp b/src/extras/defaults/qnormaldiffusemapalphamaterial.cpp index b618742a0..031e0552e 100644 --- a/src/extras/defaults/qnormaldiffusemapalphamaterial.cpp +++ b/src/extras/defaults/qnormaldiffusemapalphamaterial.cpp @@ -219,3 +219,5 @@ QNormalDiffuseMapAlphaMaterial::~QNormalDiffuseMapAlphaMaterial() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qnormaldiffusemapalphamaterial.cpp" diff --git a/src/extras/defaults/qnormaldiffusemapmaterial.cpp b/src/extras/defaults/qnormaldiffusemapmaterial.cpp index 95e031233..5044c58c6 100644 --- a/src/extras/defaults/qnormaldiffusemapmaterial.cpp +++ b/src/extras/defaults/qnormaldiffusemapmaterial.cpp @@ -408,3 +408,5 @@ void QNormalDiffuseMapMaterial::setTextureScale(float textureScale) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qnormaldiffusemapmaterial.cpp" diff --git a/src/extras/defaults/qnormaldiffusespecularmapmaterial.cpp b/src/extras/defaults/qnormaldiffusespecularmapmaterial.cpp index 69fd34e19..84f206a06 100644 --- a/src/extras/defaults/qnormaldiffusespecularmapmaterial.cpp +++ b/src/extras/defaults/qnormaldiffusespecularmapmaterial.cpp @@ -425,3 +425,5 @@ void QNormalDiffuseSpecularMapMaterial::setTextureScale(float textureScale) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qnormaldiffusespecularmapmaterial.cpp" diff --git a/src/extras/defaults/qpervertexcolormaterial.cpp b/src/extras/defaults/qpervertexcolormaterial.cpp index ef41cbce7..53ea83a7d 100644 --- a/src/extras/defaults/qpervertexcolormaterial.cpp +++ b/src/extras/defaults/qpervertexcolormaterial.cpp @@ -175,3 +175,5 @@ void QPerVertexColorMaterialPrivate::init() } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qpervertexcolormaterial.cpp" diff --git a/src/extras/defaults/qphongalphamaterial.cpp b/src/extras/defaults/qphongalphamaterial.cpp index 57c81b721..573b3f8e5 100644 --- a/src/extras/defaults/qphongalphamaterial.cpp +++ b/src/extras/defaults/qphongalphamaterial.cpp @@ -470,3 +470,5 @@ void QPhongAlphaMaterial::setBlendFunctionArg(QBlendEquation::BlendFunction blen } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qphongalphamaterial.cpp" diff --git a/src/extras/defaults/qphongmaterial.cpp b/src/extras/defaults/qphongmaterial.cpp index 465db7a5c..6240f60ba 100644 --- a/src/extras/defaults/qphongmaterial.cpp +++ b/src/extras/defaults/qphongmaterial.cpp @@ -310,3 +310,5 @@ void QPhongMaterial::setShininess(float shininess) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qphongmaterial.cpp" diff --git a/src/extras/defaults/qskyboxentity.cpp b/src/extras/defaults/qskyboxentity.cpp index 163cf63a4..89d6d7973 100644 --- a/src/extras/defaults/qskyboxentity.cpp +++ b/src/extras/defaults/qskyboxentity.cpp @@ -384,3 +384,5 @@ bool QSkyboxEntity::isGammaCorrectEnabled() const \since 5.9 */ QT_END_NAMESPACE + +#include "moc_qskyboxentity.cpp" diff --git a/src/extras/defaults/qspritegrid.cpp b/src/extras/defaults/qspritegrid.cpp index 15016a891..0e4ab20ab 100644 --- a/src/extras/defaults/qspritegrid.cpp +++ b/src/extras/defaults/qspritegrid.cpp @@ -154,3 +154,5 @@ void QSpriteGrid::setColumns(int columns) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qspritegrid.cpp" diff --git a/src/extras/defaults/qspritesheet.cpp b/src/extras/defaults/qspritesheet.cpp index 94f608f4a..020362a0e 100644 --- a/src/extras/defaults/qspritesheet.cpp +++ b/src/extras/defaults/qspritesheet.cpp @@ -171,3 +171,5 @@ void QSpriteSheet::setSprites(QList<QSpriteSheetItem *> sprites) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qspritesheet.cpp" diff --git a/src/extras/defaults/qspritesheetitem.cpp b/src/extras/defaults/qspritesheetitem.cpp index b4e096ae9..e05e41bef 100644 --- a/src/extras/defaults/qspritesheetitem.cpp +++ b/src/extras/defaults/qspritesheetitem.cpp @@ -125,3 +125,5 @@ void QSpriteSheetItem::setHeight(int height) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qspritesheetitem.cpp" diff --git a/src/extras/defaults/qt3dwindow.cpp b/src/extras/defaults/qt3dwindow.cpp index 04a0c5b5a..85ca73cca 100644 --- a/src/extras/defaults/qt3dwindow.cpp +++ b/src/extras/defaults/qt3dwindow.cpp @@ -363,3 +363,5 @@ void setupWindowSurface(QWindow *window, Qt3DRender::API api) noexcept } // Qt3DExtras QT_END_NAMESPACE + +#include "moc_qt3dwindow.cpp" diff --git a/src/extras/defaults/qtexturematerial.cpp b/src/extras/defaults/qtexturematerial.cpp index b38d6551d..f3a63ce6f 100644 --- a/src/extras/defaults/qtexturematerial.cpp +++ b/src/extras/defaults/qtexturematerial.cpp @@ -302,3 +302,5 @@ void QTextureMaterial::setAlphaBlendingEnabled(bool enabled) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qtexturematerial.cpp" diff --git a/src/extras/geometries/qconegeometry.cpp b/src/extras/geometries/qconegeometry.cpp index e2165e6f8..258d85bb7 100644 --- a/src/extras/geometries/qconegeometry.cpp +++ b/src/extras/geometries/qconegeometry.cpp @@ -673,3 +673,5 @@ QAttribute *QConeGeometry::indexAttribute() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qconegeometry.cpp" diff --git a/src/extras/geometries/qconegeometryview.cpp b/src/extras/geometries/qconegeometryview.cpp index 28707d043..519c488f0 100644 --- a/src/extras/geometries/qconegeometryview.cpp +++ b/src/extras/geometries/qconegeometryview.cpp @@ -238,3 +238,5 @@ float QConeGeometryView::length() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qconegeometryview.cpp" diff --git a/src/extras/geometries/qconemesh.cpp b/src/extras/geometries/qconemesh.cpp index 5f4ebd369..6b391b1d3 100644 --- a/src/extras/geometries/qconemesh.cpp +++ b/src/extras/geometries/qconemesh.cpp @@ -238,3 +238,5 @@ float QConeMesh::length() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qconemesh.cpp" diff --git a/src/extras/geometries/qcuboidgeometry.cpp b/src/extras/geometries/qcuboidgeometry.cpp index 87707eefd..978670cd7 100644 --- a/src/extras/geometries/qcuboidgeometry.cpp +++ b/src/extras/geometries/qcuboidgeometry.cpp @@ -838,3 +838,5 @@ QAttribute *QCuboidGeometry::indexAttribute() const } // Qt3DExtras QT_END_NAMESPACE + +#include "moc_qcuboidgeometry.cpp" diff --git a/src/extras/geometries/qcuboidgeometryview.cpp b/src/extras/geometries/qcuboidgeometryview.cpp index ee0977b71..ee21f3526 100644 --- a/src/extras/geometries/qcuboidgeometryview.cpp +++ b/src/extras/geometries/qcuboidgeometryview.cpp @@ -225,3 +225,5 @@ QSize QCuboidGeometryView::xyMeshResolution() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qcuboidgeometryview.cpp" diff --git a/src/extras/geometries/qcuboidmesh.cpp b/src/extras/geometries/qcuboidmesh.cpp index 5440ef0ba..78f742424 100644 --- a/src/extras/geometries/qcuboidmesh.cpp +++ b/src/extras/geometries/qcuboidmesh.cpp @@ -225,3 +225,5 @@ QSize QCuboidMesh::xyMeshResolution() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qcuboidmesh.cpp" diff --git a/src/extras/geometries/qcylindergeometry.cpp b/src/extras/geometries/qcylindergeometry.cpp index 5d37b5ac8..f16705c77 100644 --- a/src/extras/geometries/qcylindergeometry.cpp +++ b/src/extras/geometries/qcylindergeometry.cpp @@ -546,3 +546,5 @@ QAttribute *QCylinderGeometry::indexAttribute() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qcylindergeometry.cpp" diff --git a/src/extras/geometries/qcylindergeometryview.cpp b/src/extras/geometries/qcylindergeometryview.cpp index 9347f1134..6bedb4756 100644 --- a/src/extras/geometries/qcylindergeometryview.cpp +++ b/src/extras/geometries/qcylindergeometryview.cpp @@ -182,3 +182,5 @@ float QCylinderGeometryView::length() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qcylindergeometryview.cpp" diff --git a/src/extras/geometries/qcylindermesh.cpp b/src/extras/geometries/qcylindermesh.cpp index 2c2bb4d81..31a633e55 100644 --- a/src/extras/geometries/qcylindermesh.cpp +++ b/src/extras/geometries/qcylindermesh.cpp @@ -182,3 +182,5 @@ float QCylinderMesh::length() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qcylindermesh.cpp" diff --git a/src/extras/geometries/qplanegeometry.cpp b/src/extras/geometries/qplanegeometry.cpp index e83548ad5..41d7ed4b9 100644 --- a/src/extras/geometries/qplanegeometry.cpp +++ b/src/extras/geometries/qplanegeometry.cpp @@ -517,3 +517,5 @@ QByteArray QPlaneGeometryPrivate::generateIndexData() const } // Qt3DExtras QT_END_NAMESPACE + +#include "moc_qplanegeometry.cpp" diff --git a/src/extras/geometries/qplanegeometryview.cpp b/src/extras/geometries/qplanegeometryview.cpp index dd1544b3b..e4e1f6295 100644 --- a/src/extras/geometries/qplanegeometryview.cpp +++ b/src/extras/geometries/qplanegeometryview.cpp @@ -173,3 +173,5 @@ bool QPlaneGeometryView::mirrored() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qplanegeometryview.cpp" diff --git a/src/extras/geometries/qplanemesh.cpp b/src/extras/geometries/qplanemesh.cpp index ebcaa1d9c..78714ddaf 100644 --- a/src/extras/geometries/qplanemesh.cpp +++ b/src/extras/geometries/qplanemesh.cpp @@ -175,3 +175,5 @@ bool QPlaneMesh::mirrored() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qplanemesh.cpp" diff --git a/src/extras/geometries/qspheregeometry.cpp b/src/extras/geometries/qspheregeometry.cpp index c780ba83c..61ab08f4c 100644 --- a/src/extras/geometries/qspheregeometry.cpp +++ b/src/extras/geometries/qspheregeometry.cpp @@ -541,3 +541,5 @@ QAttribute *QSphereGeometry::indexAttribute() const QT_END_NAMESPACE +#include "moc_qspheregeometry.cpp" + diff --git a/src/extras/geometries/qspheregeometryview.cpp b/src/extras/geometries/qspheregeometryview.cpp index 6ac72ad82..f3cb83b94 100644 --- a/src/extras/geometries/qspheregeometryview.cpp +++ b/src/extras/geometries/qspheregeometryview.cpp @@ -172,3 +172,5 @@ float QSphereGeometryView::radius() const } // Qt3DExtras QT_END_NAMESPACE + +#include "moc_qspheregeometryview.cpp" diff --git a/src/extras/geometries/qspheremesh.cpp b/src/extras/geometries/qspheremesh.cpp index fa2b795c8..11aa38aec 100644 --- a/src/extras/geometries/qspheremesh.cpp +++ b/src/extras/geometries/qspheremesh.cpp @@ -172,3 +172,5 @@ float QSphereMesh::radius() const } // Qt3DExtras QT_END_NAMESPACE + +#include "moc_qspheremesh.cpp" diff --git a/src/extras/geometries/qtorusgeometry.cpp b/src/extras/geometries/qtorusgeometry.cpp index c9b430043..5a0bdd820 100644 --- a/src/extras/geometries/qtorusgeometry.cpp +++ b/src/extras/geometries/qtorusgeometry.cpp @@ -501,3 +501,5 @@ QAttribute *QTorusGeometry::indexAttribute() const } // Qt3DExtras QT_END_NAMESPACE + +#include "moc_qtorusgeometry.cpp" diff --git a/src/extras/geometries/qtorusgeometryview.cpp b/src/extras/geometries/qtorusgeometryview.cpp index 958d17974..907e5596c 100644 --- a/src/extras/geometries/qtorusgeometryview.cpp +++ b/src/extras/geometries/qtorusgeometryview.cpp @@ -175,3 +175,5 @@ float QTorusGeometryView::minorRadius() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qtorusgeometryview.cpp" diff --git a/src/extras/geometries/qtorusmesh.cpp b/src/extras/geometries/qtorusmesh.cpp index ddcec3ece..16add5779 100644 --- a/src/extras/geometries/qtorusmesh.cpp +++ b/src/extras/geometries/qtorusmesh.cpp @@ -176,3 +176,5 @@ float QTorusMesh::minorRadius() const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qtorusmesh.cpp" diff --git a/src/extras/text/distancefieldtextrenderer.cpp b/src/extras/text/distancefieldtextrenderer.cpp index 3cafd93df..8a4c192d2 100644 --- a/src/extras/text/distancefieldtextrenderer.cpp +++ b/src/extras/text/distancefieldtextrenderer.cpp @@ -154,3 +154,5 @@ void DistanceFieldTextRenderer::setColor(const QColor &color) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_distancefieldtextrenderer_p.cpp" diff --git a/src/extras/text/qdistancefieldglyphcache.cpp b/src/extras/text/qdistancefieldglyphcache.cpp index d367410c8..6859f74ac 100644 --- a/src/extras/text/qdistancefieldglyphcache.cpp +++ b/src/extras/text/qdistancefieldglyphcache.cpp @@ -63,12 +63,11 @@ namespace Qt3DExtras { class StoredGlyph { public: StoredGlyph() = default; - StoredGlyph(const StoredGlyph &) = default; StoredGlyph(const QRawFont &font, quint32 glyph, bool doubleResolution); - int refCount() const { return m_ref; } + int refCount() const { return int(m_ref); } void ref() { ++m_ref; } - int deref() { return m_ref = std::max(m_ref - 1, (quint32) 0); } + int deref() { m_ref = std::max(m_ref - 1, quint32(0)); return int(m_ref); } bool addToTextureAtlas(QTextureAtlas *atlas); void removeFromTextureAtlas(); diff --git a/src/extras/text/qtext2dentity.cpp b/src/extras/text/qtext2dentity.cpp index f9edbe090..e4dc93f10 100644 --- a/src/extras/text/qtext2dentity.cpp +++ b/src/extras/text/qtext2dentity.cpp @@ -490,3 +490,5 @@ void QText2DEntity::setHeight(float height) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qtext2dentity.cpp" diff --git a/src/extras/text/qtext2dmaterial.cpp b/src/extras/text/qtext2dmaterial.cpp index 2070bf15f..8df65d069 100644 --- a/src/extras/text/qtext2dmaterial.cpp +++ b/src/extras/text/qtext2dmaterial.cpp @@ -195,3 +195,5 @@ void QText2DMaterial::setDistanceFieldTexture(Qt3DRender::QAbstractTexture *tex) } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qtext2dmaterial_p.cpp" diff --git a/src/extras/text/qtextureatlas.cpp b/src/extras/text/qtextureatlas.cpp index 97f9845e0..ef2035a68 100644 --- a/src/extras/text/qtextureatlas.cpp +++ b/src/extras/text/qtextureatlas.cpp @@ -297,3 +297,5 @@ int QTextureAtlas::imagePadding(TextureId id) const } // namespace Qt3DExtras QT_END_NAMESPACE + +#include "moc_qtextureatlas_p.cpp" diff --git a/src/input/backend/inputhandler.cpp b/src/input/backend/inputhandler.cpp index 20ad24001..8548f24d6 100644 --- a/src/input/backend/inputhandler.cpp +++ b/src/input/backend/inputhandler.cpp @@ -80,6 +80,7 @@ protected: auto mouseEvent = QT_PREPEND_NAMESPACE(QMouseEvent)(QEvent::MouseMove, #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) he->position(), + he->globalPosition(), #else he->pos(), #endif diff --git a/src/input/backend/keyboardmousegenericdeviceintegration.cpp b/src/input/backend/keyboardmousegenericdeviceintegration.cpp index fdbd10e30..e1b5c6eae 100644 --- a/src/input/backend/keyboardmousegenericdeviceintegration.cpp +++ b/src/input/backend/keyboardmousegenericdeviceintegration.cpp @@ -100,3 +100,5 @@ QStringList KeyboardMouseGenericDeviceIntegration::deviceNames() const } // Qt3DInput QT_END_NAMESPACE + +#include "moc_keyboardmousegenericdeviceintegration_p.cpp" diff --git a/src/input/frontend/qabstractactioninput.cpp b/src/input/frontend/qabstractactioninput.cpp index 5d7af72f8..6da0ab59d 100644 --- a/src/input/frontend/qabstractactioninput.cpp +++ b/src/input/frontend/qabstractactioninput.cpp @@ -81,3 +81,5 @@ QAbstractActionInput::~QAbstractActionInput() } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qabstractactioninput.cpp" diff --git a/src/input/frontend/qabstractaxisinput.cpp b/src/input/frontend/qabstractaxisinput.cpp index d7022835d..b4b0ba3ef 100644 --- a/src/input/frontend/qabstractaxisinput.cpp +++ b/src/input/frontend/qabstractaxisinput.cpp @@ -120,3 +120,5 @@ QAbstractPhysicalDevice *QAbstractAxisInput::sourceDevice() const } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qabstractaxisinput.cpp" diff --git a/src/input/frontend/qabstractphysicaldevice.cpp b/src/input/frontend/qabstractphysicaldevice.cpp index 3a7eaf0dd..a5dc8e29b 100644 --- a/src/input/frontend/qabstractphysicaldevice.cpp +++ b/src/input/frontend/qabstractphysicaldevice.cpp @@ -211,3 +211,5 @@ void QAbstractPhysicalDevicePrivate::postButtonEvent(int button, qreal value) } QT_END_NAMESPACE + +#include "moc_qabstractphysicaldevice.cpp" diff --git a/src/input/frontend/qabstractphysicaldeviceproxy.cpp b/src/input/frontend/qabstractphysicaldeviceproxy.cpp index ae1401921..8622187a4 100644 --- a/src/input/frontend/qabstractphysicaldeviceproxy.cpp +++ b/src/input/frontend/qabstractphysicaldeviceproxy.cpp @@ -210,3 +210,5 @@ void QAbstractPhysicalDeviceProxyPrivate::resetDevice(QAbstractPhysicalDevice *d } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qabstractphysicaldeviceproxy_p.cpp" diff --git a/src/input/frontend/qaction.cpp b/src/input/frontend/qaction.cpp index 51f375fb5..527f5306d 100644 --- a/src/input/frontend/qaction.cpp +++ b/src/input/frontend/qaction.cpp @@ -150,3 +150,5 @@ QList<QAbstractActionInput *> QAction::inputs() const } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qaction.cpp" diff --git a/src/input/frontend/qactioninput.cpp b/src/input/frontend/qactioninput.cpp index 1b4834d7f..0aea536fa 100644 --- a/src/input/frontend/qactioninput.cpp +++ b/src/input/frontend/qactioninput.cpp @@ -200,3 +200,5 @@ void QActionInput::setButtons(const QList<int> &buttons) } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qactioninput.cpp" diff --git a/src/input/frontend/qanalogaxisinput.cpp b/src/input/frontend/qanalogaxisinput.cpp index 8503fe4db..846f2f9be 100644 --- a/src/input/frontend/qanalogaxisinput.cpp +++ b/src/input/frontend/qanalogaxisinput.cpp @@ -112,3 +112,5 @@ int QAnalogAxisInput::axis() const } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qanalogaxisinput.cpp" diff --git a/src/input/frontend/qaxis.cpp b/src/input/frontend/qaxis.cpp index d19b0f08e..e8287fb86 100644 --- a/src/input/frontend/qaxis.cpp +++ b/src/input/frontend/qaxis.cpp @@ -169,3 +169,5 @@ float QAxis::value() const } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qaxis.cpp" diff --git a/src/input/frontend/qaxisaccumulator.cpp b/src/input/frontend/qaxisaccumulator.cpp index 94942126e..9de06e9bd 100644 --- a/src/input/frontend/qaxisaccumulator.cpp +++ b/src/input/frontend/qaxisaccumulator.cpp @@ -291,3 +291,5 @@ void QAxisAccumulator::setScale(float scale) } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_qaxisaccumulator.cpp" diff --git a/src/input/frontend/qaxissetting.cpp b/src/input/frontend/qaxissetting.cpp index 70f8120b7..d217921ae 100644 --- a/src/input/frontend/qaxissetting.cpp +++ b/src/input/frontend/qaxissetting.cpp @@ -227,3 +227,5 @@ void QAxisSetting::setSmoothEnabled(bool enabled) } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_qaxissetting.cpp" diff --git a/src/input/frontend/qbuttonaxisinput.cpp b/src/input/frontend/qbuttonaxisinput.cpp index 0149766f6..15bfea5e3 100644 --- a/src/input/frontend/qbuttonaxisinput.cpp +++ b/src/input/frontend/qbuttonaxisinput.cpp @@ -179,3 +179,5 @@ void QButtonAxisInput::setDeceleration(float deceleration) } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qbuttonaxisinput.cpp" diff --git a/src/input/frontend/qgenericinputdevice.cpp b/src/input/frontend/qgenericinputdevice.cpp index 84a1699fc..c9796a9cb 100644 --- a/src/input/frontend/qgenericinputdevice.cpp +++ b/src/input/frontend/qgenericinputdevice.cpp @@ -98,3 +98,5 @@ void QGenericInputDevice::setButtonsMap(const QVariantMap &buttonsMap) } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qgenericinputdevice_p.cpp" diff --git a/src/input/frontend/qinputaspect.cpp b/src/input/frontend/qinputaspect.cpp index 0f95f93a3..9ad3245ab 100644 --- a/src/input/frontend/qinputaspect.cpp +++ b/src/input/frontend/qinputaspect.cpp @@ -325,3 +325,5 @@ void QInputAspect::jobsDone() QT_END_NAMESPACE QT3D_REGISTER_NAMESPACED_ASPECT("input", QT_PREPEND_NAMESPACE(Qt3DInput), QInputAspect) + +#include "moc_qinputaspect.cpp" diff --git a/src/input/frontend/qinputchord.cpp b/src/input/frontend/qinputchord.cpp index 3e470f8bb..811b66e3a 100644 --- a/src/input/frontend/qinputchord.cpp +++ b/src/input/frontend/qinputchord.cpp @@ -193,3 +193,5 @@ QInputChordPrivate::QInputChordPrivate() } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qinputchord.cpp" diff --git a/src/input/frontend/qinputdeviceintegration.cpp b/src/input/frontend/qinputdeviceintegration.cpp index 29691531f..a08a4b9f4 100644 --- a/src/input/frontend/qinputdeviceintegration.cpp +++ b/src/input/frontend/qinputdeviceintegration.cpp @@ -127,3 +127,5 @@ QInputAspect *QInputDeviceIntegration::inputAspect() const */ QT_END_NAMESPACE + +#include "moc_qinputdeviceintegration_p.cpp" diff --git a/src/input/frontend/qinputdeviceplugin.cpp b/src/input/frontend/qinputdeviceplugin.cpp index 6ac8b3a0c..96acab467 100644 --- a/src/input/frontend/qinputdeviceplugin.cpp +++ b/src/input/frontend/qinputdeviceplugin.cpp @@ -62,3 +62,5 @@ QInputDeviceIntegration *QInputDevicePlugin::create(const QString &key, const QS } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qinputdeviceplugin_p.cpp" diff --git a/src/input/frontend/qinputsequence.cpp b/src/input/frontend/qinputsequence.cpp index 7fa701749..df694202d 100644 --- a/src/input/frontend/qinputsequence.cpp +++ b/src/input/frontend/qinputsequence.cpp @@ -240,3 +240,5 @@ QList<QAbstractActionInput *> QInputSequence::sequences() const } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qinputsequence.cpp" diff --git a/src/input/frontend/qinputsettings.cpp b/src/input/frontend/qinputsettings.cpp index d3d973c97..ac2ed48d9 100644 --- a/src/input/frontend/qinputsettings.cpp +++ b/src/input/frontend/qinputsettings.cpp @@ -134,3 +134,5 @@ void QInputSettings::eventSourceDestroyed() QT_END_NAMESPACE + +#include "moc_qinputsettings.cpp" diff --git a/src/input/frontend/qkeyboarddevice.cpp b/src/input/frontend/qkeyboarddevice.cpp index 0fe3a1338..0708d9275 100644 --- a/src/input/frontend/qkeyboarddevice.cpp +++ b/src/input/frontend/qkeyboarddevice.cpp @@ -324,3 +324,5 @@ void QKeyboardDevice::setActiveInput(QKeyboardHandler *activeInput) } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_qkeyboarddevice.cpp" diff --git a/src/input/frontend/qkeyboardhandler.cpp b/src/input/frontend/qkeyboardhandler.cpp index 5126c4692..a30a4b1ad 100644 --- a/src/input/frontend/qkeyboardhandler.cpp +++ b/src/input/frontend/qkeyboardhandler.cpp @@ -721,3 +721,5 @@ void QKeyboardHandler::setFocus(bool focus) } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_qkeyboardhandler.cpp" diff --git a/src/input/frontend/qkeyevent.cpp b/src/input/frontend/qkeyevent.cpp index 6df197321..5065882b2 100644 --- a/src/input/frontend/qkeyevent.cpp +++ b/src/input/frontend/qkeyevent.cpp @@ -253,3 +253,5 @@ QKeyEvent::~QKeyEvent() } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_qkeyevent.cpp" diff --git a/src/input/frontend/qlogicaldevice.cpp b/src/input/frontend/qlogicaldevice.cpp index eb1eaf350..35656625b 100644 --- a/src/input/frontend/qlogicaldevice.cpp +++ b/src/input/frontend/qlogicaldevice.cpp @@ -255,3 +255,5 @@ QList<QAxis *> QLogicalDevice::axes() const } // Qt3DInput QT_END_NAMESPACE + +#include "moc_qlogicaldevice.cpp" diff --git a/src/input/frontend/qmousedevice.cpp b/src/input/frontend/qmousedevice.cpp index 49427c5a8..1e1cb7756 100644 --- a/src/input/frontend/qmousedevice.cpp +++ b/src/input/frontend/qmousedevice.cpp @@ -261,3 +261,5 @@ void QMouseDevice::setUpdateAxesContinuously(bool updateAxesContinuously) } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_qmousedevice.cpp" diff --git a/src/input/frontend/qmouseevent.cpp b/src/input/frontend/qmouseevent.cpp index b0c7427b1..3bdce834d 100644 --- a/src/input/frontend/qmouseevent.cpp +++ b/src/input/frontend/qmouseevent.cpp @@ -515,3 +515,5 @@ QWheelEvent::Modifiers QWheelEvent::modifiers() const } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_qmouseevent.cpp" diff --git a/src/input/frontend/qmousehandler.cpp b/src/input/frontend/qmousehandler.cpp index 6c354d55d..313ef67ff 100644 --- a/src/input/frontend/qmousehandler.cpp +++ b/src/input/frontend/qmousehandler.cpp @@ -339,3 +339,5 @@ void QMouseHandler::setContainsMouse(bool contains) } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_qmousehandler.cpp" diff --git a/src/logic/executor.cpp b/src/logic/executor.cpp index b12c54ebe..66b9fd9f9 100644 --- a/src/logic/executor.cpp +++ b/src/logic/executor.cpp @@ -78,3 +78,5 @@ void Executor::processLogicFrameUpdates(const QList<QNodeId> &nodeIds, float dt) } // namespace Qt3DLogic QT_END_NAMESPACE + +#include "moc_executor_p.cpp" diff --git a/src/logic/qframeaction.cpp b/src/logic/qframeaction.cpp index a3ae748be..b23cd9797 100644 --- a/src/logic/qframeaction.cpp +++ b/src/logic/qframeaction.cpp @@ -137,3 +137,5 @@ void QFrameAction::onTriggered(float dt) } // namespace Qt3DLogic QT_END_NAMESPACE + +#include "moc_qframeaction.cpp" diff --git a/src/logic/qlogicaspect.cpp b/src/logic/qlogicaspect.cpp index cd9b3e47a..dc665201c 100644 --- a/src/logic/qlogicaspect.cpp +++ b/src/logic/qlogicaspect.cpp @@ -70,7 +70,6 @@ namespace Qt3DLogic { QLogicAspectPrivate::QLogicAspectPrivate() : QAbstractAspectPrivate() , m_time(0) - , m_initialized(false) , m_manager(new Logic::Manager) , m_executor(new Logic::Executor) , m_callbackJob(new Logic::CallbackJob) @@ -145,3 +144,4 @@ QT_END_NAMESPACE QT3D_REGISTER_NAMESPACED_ASPECT("logic", QT_PREPEND_NAMESPACE(Qt3DLogic), QLogicAspect) +#include "moc_qlogicaspect.cpp" diff --git a/src/logic/qlogicaspect_p.h b/src/logic/qlogicaspect_p.h index 2a6a7259a..d3388c72c 100644 --- a/src/logic/qlogicaspect_p.h +++ b/src/logic/qlogicaspect_p.h @@ -75,7 +75,6 @@ class QLogicAspectPrivate : public Qt3DCore::QAbstractAspectPrivate void registerBackendTypes(); qint64 m_time; - bool m_initialized; QScopedPointer<Logic::Manager> m_manager; QScopedPointer<Logic::Executor> m_executor; QSharedPointer<Logic::CallbackJob> m_callbackJob; diff --git a/src/plugins/geometryloaders/default/basegeometryloader.cpp b/src/plugins/geometryloaders/default/basegeometryloader.cpp index 33e68db82..a754b2eb5 100644 --- a/src/plugins/geometryloaders/default/basegeometryloader.cpp +++ b/src/plugins/geometryloaders/default/basegeometryloader.cpp @@ -121,7 +121,7 @@ void BaseGeometryLoader::generateAveragedNormals(const std::vector<QVector3D> &p void BaseGeometryLoader::generateGeometry() { QByteArray bufferBytes; - const size_t count = m_points.size(); + const uint count = uint(m_points.size()); const quint32 elementSize = 3 + (hasTextureCoordinates() ? 2 : 0) + (hasNormals() ? 3 : 0) + (hasTangents() ? 4 : 0); @@ -201,7 +201,7 @@ void BaseGeometryLoader::generateGeometry() auto *indexBuffer = new Qt3DCore::QBuffer(); indexBuffer->setData(indexBytes); - QAttribute *indexAttribute = new QAttribute(indexBuffer, ty, 1, m_indices.size()); + QAttribute *indexAttribute = new QAttribute(indexBuffer, ty, 1, uint(m_indices.size())); indexAttribute->setAttributeType(QAttribute::IndexAttribute); m_geometry->addAttribute(indexAttribute); } @@ -280,3 +280,5 @@ void BaseGeometryLoader::center(std::vector<QVector3D> &points) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_basegeometryloader_p.cpp" diff --git a/src/plugins/geometryloaders/default/objgeometryloader.cpp b/src/plugins/geometryloaders/default/objgeometryloader.cpp index 14a2b588e..8515b2ffa 100644 --- a/src/plugins/geometryloaders/default/objgeometryloader.cpp +++ b/src/plugins/geometryloaders/default/objgeometryloader.cpp @@ -39,6 +39,7 @@ #include "objgeometryloader.h" +#include <QtCore/QHash> #include <QtCore/QLoggingCategory> #include <QtCore/QRegularExpression> #include <QtCore/QIODevice> diff --git a/src/plugins/geometryloaders/default/stlgeometryloader.cpp b/src/plugins/geometryloaders/default/stlgeometryloader.cpp index a8083eb32..92204b8db 100644 --- a/src/plugins/geometryloaders/default/stlgeometryloader.cpp +++ b/src/plugins/geometryloaders/default/stlgeometryloader.cpp @@ -90,7 +90,7 @@ bool StlGeometryLoader::loadAscii(QIODevice *ioDev) const float y = tokens.floatAt(2); const float z = tokens.floatAt(3); m_points.push_back(QVector3D(x, y, z)); - m_indices.push_back(m_indices.size()); + m_indices.push_back(uint(m_indices.size())); } } } diff --git a/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp b/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp index 9f13ca2c6..0962e47ce 100644 --- a/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp +++ b/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp @@ -626,3 +626,5 @@ uint GLTFGeometryLoader::accessorDataSizeFromJson(const QString &type) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_gltfgeometryloader.cpp" diff --git a/src/plugins/geometryloaders/gltf/gltfgeometryloader.h b/src/plugins/geometryloaders/gltf/gltfgeometryloader.h index 36ac0f174..f3a0961ab 100644 --- a/src/plugins/geometryloaders/gltf/gltfgeometryloader.h +++ b/src/plugins/geometryloaders/gltf/gltfgeometryloader.h @@ -51,6 +51,7 @@ // We mean it. // +#include <QtCore/QHash> #include <QtCore/QJsonDocument> #include <Qt3DRender/private/qgeometryloaderinterface_p.h> diff --git a/src/plugins/renderers/opengl/debug/imguirenderer.cpp b/src/plugins/renderers/opengl/debug/imguirenderer.cpp index 744060fcf..5b0e277d8 100644 --- a/src/plugins/renderers/opengl/debug/imguirenderer.cpp +++ b/src/plugins/renderers/opengl/debug/imguirenderer.cpp @@ -65,6 +65,10 @@ #define GL_VERTEX_ARRAY_BINDING 0x85B5 #endif +#ifdef _MSC_VER +#pragma warning (disable: 4996) // 'This function or variable may be unsafe': strcpy, strdup, sprintf, vsnprintf, sscanf, fopen +#endif + QT_BEGIN_NAMESPACE using namespace Qt3DRender; diff --git a/src/plugins/renderers/opengl/renderer/glshader.cpp b/src/plugins/renderers/opengl/renderer/glshader.cpp index ce0a9deb0..4437ad018 100644 --- a/src/plugins/renderers/opengl/renderer/glshader.cpp +++ b/src/plugins/renderers/opengl/renderer/glshader.cpp @@ -236,7 +236,7 @@ void GLShader::prepareUniforms(ShaderParameterPack &pack) auto it = values.keys.cbegin(); const auto end = values.keys.cend(); - const int shaderUniformsCount = m_uniforms.size(); + const int shaderUniformsCount = int(m_uniforms.size()); const auto uIt = m_uniforms.cbegin(); while (it != end) { @@ -325,7 +325,7 @@ void GLShader::initializeUniforms(const std::vector<ShaderUniform> &uniformsDesc } m_uniformBlockIndexToShaderUniforms.insert(-1, activeUniformsInDefaultBlock); - m_parameterPackSize += m_standardUniformNamesIds.size() + m_lightUniformsNamesIds.size() + m_uniformsNamesIds.size(); + m_parameterPackSize += int(m_standardUniformNamesIds.size()) + int(m_lightUniformsNamesIds.size()) + int(m_uniformsNamesIds.size()); m_hasActiveVariables |= (m_parameterPackSize > 0); // Sort by ascending order to make contains check faster @@ -343,7 +343,7 @@ void GLShader::initializeAttributes(const std::vector<ShaderAttribute> &attribut m_attributes = attributesDescription; m_attributesNames.resize(attributesDescription.size()); m_attributeNamesIds.resize(attributesDescription.size()); - for (int i = 0, m = attributesDescription.size(); i < m; i++) { + for (int i = 0, m = int(attributesDescription.size()); i < m; i++) { m_attributesNames[i] = attributesDescription[i].m_name; m_attributes[i].m_nameId = StringToInt::lookupId(m_attributesNames[i]); m_attributeNamesIds[i] = m_attributes[i].m_nameId; @@ -357,7 +357,7 @@ void GLShader::initializeUniformBlocks(const std::vector<ShaderUniformBlock> &un m_uniformBlocks = uniformBlockDescription; m_uniformBlockNames.resize(uniformBlockDescription.size()); m_uniformBlockNamesIds.resize(uniformBlockDescription.size()); - for (int i = 0, m = uniformBlockDescription.size(); i < m; ++i) { + for (int i = 0, m = int(uniformBlockDescription.size()); i < m; ++i) { m_uniformBlockNames[i] = m_uniformBlocks[i].m_name; m_uniformBlockNamesIds[i] = StringToInt::lookupId(m_uniformBlockNames[i]); m_uniformBlocks[i].m_nameId = m_uniformBlockNamesIds[i]; @@ -386,7 +386,7 @@ void GLShader::initializeUniformBlocks(const std::vector<ShaderUniformBlock> &un m_uniformBlockIndexToShaderUniforms.insert(uniformBlockDescription[i].m_index, activeUniformsInBlock); } - m_parameterPackSize += m_uniformsNamesIds.size(); + m_parameterPackSize += int(m_uniformsNamesIds.size()); m_hasActiveVariables |= (m_parameterPackSize > 0); // Sort by ascending order to make contains check faster @@ -399,14 +399,14 @@ void GLShader::initializeShaderStorageBlocks(const std::vector<ShaderStorageBloc m_shaderStorageBlockNames.resize(shaderStorageBlockDescription.size()); m_shaderStorageBlockNamesIds.resize(shaderStorageBlockDescription.size()); - for (int i = 0, m = shaderStorageBlockDescription.size(); i < m; ++i) { + for (int i = 0, m = int(shaderStorageBlockDescription.size()); i < m; ++i) { m_shaderStorageBlockNames[i] = m_shaderStorageBlocks[i].m_name; m_shaderStorageBlockNamesIds[i] = StringToInt::lookupId(m_shaderStorageBlockNames[i]); m_shaderStorageBlocks[i].m_nameId =m_shaderStorageBlockNamesIds[i]; qCDebug(Shaders) << "Initializing Shader Storage Block {" << m_shaderStorageBlockNames[i] << "}"; } - m_parameterPackSize += m_shaderStorageBlockNamesIds.size(); + m_parameterPackSize += int(m_shaderStorageBlockNamesIds.size()); m_hasActiveVariables |= (m_parameterPackSize > 0); // Sort by ascending order to make contains check faster diff --git a/src/plugins/renderers/opengl/renderer/renderer.cpp b/src/plugins/renderers/opengl/renderer/renderer.cpp index aaec6ad7b..9c3cd934f 100644 --- a/src/plugins/renderers/opengl/renderer/renderer.cpp +++ b/src/plugins/renderers/opengl/renderer/renderer.cpp @@ -1643,6 +1643,7 @@ Renderer::ViewSubmissionResultData Renderer::submitRenderViews(const std::vector static_cast<Render::RenderCapture*>(m_nodesManager->frameGraphManager()->lookupNode(renderView->renderCaptureNodeId())); renderCapture->addRenderCapture(request.captureId, image); const QNodeId renderCaptureId = renderView->renderCaptureNodeId(); + QMutexLocker lock(&m_pendingRenderCaptureSendRequestsMutex); if (!Qt3DCore::contains(m_pendingRenderCaptureSendRequests, renderCaptureId)) m_pendingRenderCaptureSendRequests.push_back(renderView->renderCaptureNodeId()); } @@ -1753,7 +1754,9 @@ void Renderer::jobsDone(Qt3DCore::QAspectManager *manager) // called in main thread once all jobs are done running // sync captured renders to frontend + QMutexLocker lock(&m_pendingRenderCaptureSendRequestsMutex); const std::vector<Qt3DCore::QNodeId> pendingCaptureIds = Qt3DCore::moveAndClear(m_pendingRenderCaptureSendRequests); + lock.unlock(); for (const Qt3DCore::QNodeId &id : pendingCaptureIds) { auto *backend = static_cast<Qt3DRender::Render::RenderCapture *> (m_nodesManager->frameGraphManager()->lookupNode(id)); diff --git a/src/plugins/renderers/opengl/renderer/renderer_p.h b/src/plugins/renderers/opengl/renderer/renderer_p.h index 78dfbe2a5..151d2a5cf 100644 --- a/src/plugins/renderers/opengl/renderer/renderer_p.h +++ b/src/plugins/renderers/opengl/renderer/renderer_p.h @@ -359,6 +359,7 @@ private: RenderableEntityFilterPtr m_renderableEntityFilterJob; ComputableEntityFilterPtr m_computableEntityFilterJob; + QMutex m_pendingRenderCaptureSendRequestsMutex; std::vector<Qt3DCore::QNodeId> m_pendingRenderCaptureSendRequests; void performDraw(const RenderCommand *command); diff --git a/src/plugins/renderers/opengl/renderer/renderview.cpp b/src/plugins/renderers/opengl/renderer/renderview.cpp index 055e19b7a..a97889d34 100644 --- a/src/plugins/renderers/opengl/renderer/renderview.cpp +++ b/src/plugins/renderers/opengl/renderer/renderview.cpp @@ -1210,11 +1210,11 @@ void RenderView::setShaderStorageValue(ShaderParameterPack &uniformPack, } void RenderView::setDefaultUniformBlockShaderDataValue(ShaderParameterPack &uniformPack, - const GLShader *shader, + const std::vector<int> &uniformsNamesIds, ShaderData *shaderData, const QString &structName) const { - UniformBlockValueBuilder builder(shader->uniformsNamesIds(), + UniformBlockValueBuilder builder(uniformsNamesIds, m_manager->shaderDataManager(), m_manager->textureManager(), m_viewMatrix); @@ -1258,7 +1258,7 @@ void RenderView::applyParameter(const Parameter *param, if (uniformValue.valueType() == UniformValue::NodeId && (shaderData = m_manager->shaderDataManager()->lookupResource(*uniformValue.constData<Qt3DCore::QNodeId>())) != nullptr) { // Try to check if we have a struct or array matching a QShaderData parameter - setDefaultUniformBlockShaderDataValue(command->m_parameterPack, shader, shaderData, StringToInt::lookupString(nameId)); + setDefaultUniformBlockShaderDataValue(command->m_parameterPack, shader->uniformsNamesIds(), shaderData, StringToInt::lookupString(nameId)); } break; } @@ -1382,7 +1382,7 @@ void RenderView::updateLightUniforms(RenderCommand *command, const Entity *entit break; const Entity *lightEntity = lightSource.entity; const Matrix4x4 lightWorldTransform = *(lightEntity->worldTransform()); - const Vector3D worldPos = lightWorldTransform * Vector3D(0.0f, 0.0f, 0.0f); + const Vector3D worldPos = lightWorldTransform.map(Vector3D(0.0f, 0.0f, 0.0f)); for (Light *light : lightSource.lights) { if (!light->isEnabled()) continue; @@ -1414,8 +1414,8 @@ void RenderView::updateLightUniforms(RenderCommand *command, const Entity *entit if (worldTransform) shaderData->updateWorldTransform(*worldTransform); - setDefaultUniformBlockShaderDataValue(command->m_parameterPack, shader, shaderData, GLLights::LIGHT_STRUCT_NAMES[lightIdx]); - setDefaultUniformBlockShaderDataValue(command->m_parameterPack, shader, shaderData, GLLights::LIGHT_STRUCT_UNROLL_NAMES[lightIdx]); + setDefaultUniformBlockShaderDataValue(command->m_parameterPack, shader->lightUniformsNamesIds(), shaderData, GLLights::LIGHT_STRUCT_NAMES[lightIdx]); + setDefaultUniformBlockShaderDataValue(command->m_parameterPack, shader->lightUniformsNamesIds(), shaderData, GLLights::LIGHT_STRUCT_UNROLL_NAMES[lightIdx]); ++lightIdx; } } @@ -1448,7 +1448,8 @@ void RenderView::updateLightUniforms(RenderCommand *command, const Entity *entit if (m_environmentLight && m_environmentLight->isEnabled()) { ShaderData *shaderData = m_manager->shaderDataManager()->lookupResource(m_environmentLight->shaderData()); if (shaderData) { - setDefaultUniformBlockShaderDataValue(command->m_parameterPack, shader, shaderData, QStringLiteral("envLight")); + // EnvLight isn't part of the light uniform name ids + setDefaultUniformBlockShaderDataValue(command->m_parameterPack, shader->uniformsNamesIds(), shaderData, QStringLiteral("envLight")); auto irr = shaderData->properties()["irradiance"].value.value<Qt3DCore::QNodeId>(); auto spec = diff --git a/src/plugins/renderers/opengl/renderer/renderview_p.h b/src/plugins/renderers/opengl/renderer/renderview_p.h index d67a04b8c..b2fb7c69f 100644 --- a/src/plugins/renderers/opengl/renderer/renderview_p.h +++ b/src/plugins/renderers/opengl/renderer/renderview_p.h @@ -392,7 +392,7 @@ private: const ShaderStorageBlock &block, const UniformValue &value) const; void setDefaultUniformBlockShaderDataValue(ShaderParameterPack &uniformPack, - const GLShader *shader, + const std::vector<int> &uniformsNamesIds, ShaderData *shaderData, const QString &structName) const; void applyParameter(const Parameter *param, diff --git a/src/plugins/renderers/opengl/renderer/renderviewbuilder.cpp b/src/plugins/renderers/opengl/renderer/renderviewbuilder.cpp index d21c205c3..7715e26bf 100644 --- a/src/plugins/renderers/opengl/renderer/renderviewbuilder.cpp +++ b/src/plugins/renderers/opengl/renderer/renderviewbuilder.cpp @@ -40,8 +40,7 @@ #include "renderviewbuilder_p.h" #include <Qt3DRender/private/qrenderaspect_p.h> #include <Qt3DRender/private/rendersyncjobs_p.h> - -#include <QThread> +#include <Qt3DCore/private/qaspectjobmanager_p.h> QT_BEGIN_NAMESPACE @@ -90,7 +89,7 @@ RenderViewBuilder::RenderViewBuilder(Render::FrameGraphNode *leafNode, int rende // In some cases having less jobs is better (especially on fast cpus where // splitting just adds more overhead). Ideally, we should try to set the value // depending on the platform/CPU/nbr of cores - m_optimalParallelJobCount = QThread::idealThreadCount(); + m_optimalParallelJobCount = Qt3DCore::QAspectJobManager::idealThreadCount(); } RenderViewInitializerJobPtr RenderViewBuilder::renderViewJob() const diff --git a/src/plugins/renderers/rhi/renderer/commandexecuter.cpp b/src/plugins/renderers/rhi/renderer/commandexecuter.cpp index 9cac6f16b..0a34a35d9 100644 --- a/src/plugins/renderers/rhi/renderer/commandexecuter.cpp +++ b/src/plugins/renderers/rhi/renderer/commandexecuter.cpp @@ -58,10 +58,12 @@ QT_BEGIN_NAMESPACE namespace Qt3DRender { -namespace Debug { +namespace DebugRhi { namespace { +#if 0 // unused for now + template<typename Type> QJsonObject typeToJsonObj(const Type &) noexcept { @@ -298,9 +300,13 @@ QJsonObject parameterPackToJson(const Render::Rhi::ShaderParameterPack &pack) no return obj; } +#endif // 0 + } // anonymous -CommandExecuter::CommandExecuter(Render::Rhi::Renderer *renderer) : m_renderer(renderer) { } +CommandExecuter::CommandExecuter(Render::Rhi::Renderer *renderer) : m_renderer(renderer) { + Q_UNUSED(m_renderer) +} // Render thread void CommandExecuter::performAsynchronousCommandExecution( @@ -398,7 +404,7 @@ QVariant CommandExecuter::executeCommand(const QStringList &args) return QVariant(); } -} // Debug +} // DebugRhi } // Qt3DRenderer diff --git a/src/plugins/renderers/rhi/renderer/commandexecuter_p.h b/src/plugins/renderers/rhi/renderer/commandexecuter_p.h index 1cd44874b..e683253a7 100644 --- a/src/plugins/renderers/rhi/renderer/commandexecuter_p.h +++ b/src/plugins/renderers/rhi/renderer/commandexecuter_p.h @@ -75,7 +75,7 @@ class RenderView; } // Rhi } // Render -namespace Debug { +namespace DebugRhi { class CommandExecuter { @@ -92,7 +92,7 @@ private: QMutex m_pendingCommandsMutex; }; -} // Debug +} // DebugRhi } // Qt3DRender diff --git a/src/plugins/renderers/rhi/renderer/pipelineuboset.cpp b/src/plugins/renderers/rhi/renderer/pipelineuboset.cpp index ce53de1ab..54c02a8b1 100644 --- a/src/plugins/renderers/rhi/renderer/pipelineuboset.cpp +++ b/src/plugins/renderers/rhi/renderer/pipelineuboset.cpp @@ -220,14 +220,14 @@ std::vector<QRhiCommandBuffer::DynamicOffset> PipelineUBOSet::offsets(const Rend const size_t dToCmd = distanceToCommand(cmd); { // Compute offset relative to the select UBO in the subset - const size_t localOffset = m_commandsUBO.localOffsetInBufferForCommand(dToCmd); - offsets.push_back({1, localOffset}); + const auto localOffset = m_commandsUBO.localOffsetInBufferForCommand(dToCmd); + offsets.push_back({1, quint32(localOffset)}); } for (const MultiUBOBufferWithBindingAndBlockSize &materialUBO : m_materialsUBOs) { // Compute offset relative to the select UBO in the subset const size_t localOffset = materialUBO.localOffsetInBufferForCommand(dToCmd); - offsets.push_back({materialUBO.binding, localOffset}); + offsets.push_back({materialUBO.binding, quint32(localOffset)}); } return offsets; @@ -620,29 +620,34 @@ void PipelineUBOSet::uploadUBOsForCommand(const RenderCommand &command, for (const RHIShader::UBO_Member &member : qAsConst(uboBlock.members)) { const QShaderDescription::BlockVariable &blockVariable = member.blockVariable; + + // Array if (!blockVariable.arrayDims.empty()) { - if (!blockVariable.structMembers.empty()) { - const int arr0 = blockVariable.arrayDims[0]; - for (int i = 0; i < arr0; i++) { - for (const RHIShader::UBO_Member &structMember : member.structMembers) { + if (!blockVariable.structMembers.empty()) { // Array of structs + // we treat structMembers as arrayMembers when we are dealing with an array of structs´ + const size_t arr0 = size_t(blockVariable.arrayDims[0]); + const size_t m = std::max(arr0, member.structMembers.size()); + for (size_t i = 0; i < m; ++i) { + const RHIShader::UBO_Member &arrayMember = member.structMembers[i]; + for (const RHIShader::UBO_Member &arrayStructMember : arrayMember.structMembers) { uploadUniform(uniforms, ubo, - structMember, + arrayStructMember, distanceToCommand, i * blockVariable.size / arr0); } } - } else { + } else { // Array of scalars uploadUniform(uniforms, ubo, member, distanceToCommand); } } else { - if (!blockVariable.structMembers.empty()) { + if (!blockVariable.structMembers.empty()) { // Struct for (const RHIShader::UBO_Member &structMember : member.structMembers) { uploadUniform(uniforms, ubo, structMember, distanceToCommand); } - } else { + } else { // Scalar uploadUniform(uniforms, ubo, member, distanceToCommand); } diff --git a/src/plugins/renderers/rhi/renderer/renderer.cpp b/src/plugins/renderers/rhi/renderer/renderer.cpp index 47839b5b2..8f4df706d 100644 --- a/src/plugins/renderers/rhi/renderer/renderer.cpp +++ b/src/plugins/renderers/rhi/renderer/renderer.cpp @@ -266,7 +266,7 @@ Renderer::Renderer() JobTypes::DirtyShaderGathering)), m_ownedContext(false), m_RHIResourceManagers(nullptr), - m_commandExecuter(new Qt3DRender::Debug::CommandExecuter(this)), + m_commandExecuter(new Qt3DRender::DebugRhi::CommandExecuter(this)), m_shouldSwapBuffers(true) { std::fill_n(m_textureTransform, 4, 0.f); @@ -2199,8 +2199,10 @@ void Renderer::jobsDone(Qt3DCore::QAspectManager *manager) // called in main thread once all jobs are done running // sync captured renders to frontend + QMutexLocker lock(&m_pendingRenderCaptureSendRequestsMutex); const std::vector<Qt3DCore::QNodeId> pendingCaptureIds = Qt3DCore::moveAndClear(m_pendingRenderCaptureSendRequests); + lock.unlock(); for (const Qt3DCore::QNodeId &id : qAsConst(pendingCaptureIds)) { auto *backend = static_cast<Qt3DRender::Render::RenderCapture *>( m_nodesManager->frameGraphManager()->lookupNode(id)); @@ -2774,20 +2776,21 @@ bool Renderer::executeCommandsSubmission(const RHIPassInfo &passInfo) QRect rect(QPoint(0, 0), size); if (!request.rect.isEmpty()) rect = rect.intersected(request.rect); - QImage image; if (!rect.isEmpty()) { // Bind fbo as read framebuffer QRhiReadbackResult *readBackResult = new QRhiReadbackResult; readBackResult->completed = [this, readBackResult, renderCaptureId, request] () { const QImage::Format fmt = QImage::Format_RGBA8888_Premultiplied; // fits QRhiTexture::RGBA8 const uchar *p = reinterpret_cast<const uchar *>(readBackResult->data.constData()); - const QImage image(p, readBackResult->pixelSize.width(), readBackResult->pixelSize.height(), fmt); + const QImage image(p, readBackResult->pixelSize.width(), readBackResult->pixelSize.height(), fmt, [] (void *ptr) { + delete static_cast<QRhiReadbackResult *>(ptr); + }, readBackResult); Render::RenderCapture *renderCapture = static_cast<Render::RenderCapture*>(m_nodesManager->frameGraphManager()->lookupNode(renderCaptureId)); renderCapture->addRenderCapture(request.captureId, image); + QMutexLocker lock(&m_pendingRenderCaptureSendRequestsMutex); if (!Qt3DCore::contains(m_pendingRenderCaptureSendRequests, renderCaptureId)) m_pendingRenderCaptureSendRequests.push_back(renderCaptureId); - delete readBackResult; }; QRhiReadbackDescription readbackDesc; diff --git a/src/plugins/renderers/rhi/renderer/renderer.pri b/src/plugins/renderers/rhi/renderer/renderer.pri index 761a6ce9b..5ff7d9d44 100644 --- a/src/plugins/renderers/rhi/renderer/renderer.pri +++ b/src/plugins/renderers/rhi/renderer/renderer.pri @@ -6,6 +6,7 @@ SOURCES += \ $$PWD/renderview.cpp \ $$PWD/renderviewbuilder.cpp \ $$PWD/rhigraphicspipeline.cpp \ + $$PWD/rhirendertarget.cpp \ $$PWD/rhishader.cpp \ $$PWD/shaderparameterpack.cpp \ $$PWD/logging.cpp \ @@ -18,6 +19,7 @@ HEADERS += \ $$PWD/renderview_p.h \ $$PWD/renderviewbuilder_p.h \ $$PWD/rhigraphicspipeline_p.h \ + $$PWD/rhirendertarget_p.h \ $$PWD/rhishader_p.h \ $$PWD/shaderparameterpack_p.h \ $$PWD/shadervariables_p.h \ diff --git a/src/plugins/renderers/rhi/renderer/renderer_p.h b/src/plugins/renderers/rhi/renderer/renderer_p.h index cb2137d95..f60ee0ba0 100644 --- a/src/plugins/renderers/rhi/renderer/renderer_p.h +++ b/src/plugins/renderers/rhi/renderer/renderer_p.h @@ -118,7 +118,7 @@ class QAbstractShapeMesh; struct GraphicsApiFilterData; class QSceneImporter; -namespace Debug { +namespace DebugRhi { class CommandExecuter; } @@ -360,6 +360,7 @@ private: RenderableEntityFilterPtr m_renderableEntityFilterJob; ComputableEntityFilterPtr m_computableEntityFilterJob; + QMutex m_pendingRenderCaptureSendRequestsMutex; std::vector<Qt3DCore::QNodeId> m_pendingRenderCaptureSendRequests; SynchronizerJobPtr m_bufferGathererJob; @@ -389,7 +390,7 @@ private: RHIResourceManagers *m_RHIResourceManagers; QMutex m_offscreenSurfaceMutex; - QScopedPointer<Qt3DRender::Debug::CommandExecuter> m_commandExecuter; + QScopedPointer<Qt3DRender::DebugRhi::CommandExecuter> m_commandExecuter; #ifdef QT_BUILD_INTERNAL friend class ::tst_Renderer; diff --git a/src/plugins/renderers/rhi/renderer/renderview.cpp b/src/plugins/renderers/rhi/renderer/renderview.cpp index cf8d27871..89416e093 100644 --- a/src/plugins/renderers/rhi/renderer/renderview.cpp +++ b/src/plugins/renderers/rhi/renderer/renderview.cpp @@ -641,7 +641,7 @@ void sortByMaterial(EntityRenderCommandDataView *view, int begin, const int end) while (begin != end) { if (begin + 1 < rangeEnd) { std::stable_sort(commandIndices.begin() + begin + 1, commandIndices.begin() + rangeEnd, - [&commands] (const int &iA, const int &iB) { + [&commands] (const size_t &iA, const size_t &iB) { const RenderCommand &a = commands[iA]; const RenderCommand &b = commands[iB]; return a.m_material.handle() < b.m_material.handle(); @@ -1465,7 +1465,7 @@ void RenderView::setShaderAndUniforms(RenderCommand *command, ParameterInfoList break; const Entity *lightEntity = lightSource.entity; const Matrix4x4 lightWorldTransform = *(lightEntity->worldTransform()); - const Vector3D worldPos = lightWorldTransform * Vector3D(0.0f, 0.0f, 0.0f); + const Vector3D worldPos = lightWorldTransform.map(Vector3D(0.0f, 0.0f, 0.0f)); for (Light *light : lightSource.lights) { if (!light->isEnabled()) continue; diff --git a/src/plugins/renderers/rhi/renderer/renderviewbuilder.cpp b/src/plugins/renderers/rhi/renderer/renderviewbuilder.cpp index 832f550eb..c69fd762b 100644 --- a/src/plugins/renderers/rhi/renderer/renderviewbuilder.cpp +++ b/src/plugins/renderers/rhi/renderer/renderviewbuilder.cpp @@ -39,8 +39,7 @@ #include "renderviewbuilder_p.h" #include <Qt3DRender/private/qrenderaspect_p.h> - -#include <QThread> +#include <Qt3DCore/private/qaspectjobmanager_p.h> QT_BEGIN_NAMESPACE @@ -63,7 +62,7 @@ RenderViewBuilder::RenderViewBuilder(Render::FrameGraphNode *leafNode, int rende // In some cases having less jobs is better (especially on fast cpus where // splitting just adds more overhead). Ideally, we should try to set the value // depending on the platform/CPU/nbr of cores - m_optimalParallelJobCount = QThread::idealThreadCount(); + m_optimalParallelJobCount = Qt3DCore::QAspectJobManager::idealThreadCount(); } RenderViewInitializerJobPtr RenderViewBuilder::renderViewJob() const diff --git a/src/plugins/renderers/rhi/renderer/rhishader.cpp b/src/plugins/renderers/rhi/renderer/rhishader.cpp index 5684e27ce..6509746ab 100644 --- a/src/plugins/renderers/rhi/renderer/rhishader.cpp +++ b/src/plugins/renderers/rhi/renderer/rhishader.cpp @@ -332,7 +332,14 @@ void RHIShader::recordAllUniforms(UBO_Member &uboMember, // We iterate through all the [l][n][m] by building [0][0][0] and incrementing forEachArrayAccessor(member.arrayDims, [&](const QString &str) { // "foo.bar[1][2]" - m_unqualifiedUniformNames << (fullMemberName + str); + const QString unqualifiedMemberName = (fullMemberName + str); + m_unqualifiedUniformNames << unqualifiedMemberName; + + // Record as an individual uniform + m_uniformsNames.push_back(unqualifiedMemberName); + const int nameId = StringToInt::lookupId(unqualifiedMemberName); + m_uniformsNamesIds.push_back(nameId); + // Question : does it make sense to also record foo[0], foo[0][0], etc... // if there are e.g. 3 dimensions ? }); @@ -344,20 +351,29 @@ void RHIShader::recordAllUniforms(UBO_Member &uboMember, m_structNamesIds.push_back(StringToInt::lookupId(m_structNames.back())); }); - // Record the struct members - for (const QShaderDescription::BlockVariable& bv : member.structMembers) { - forEachArrayAccessor(member.arrayDims, [&] (const QString& str) { + // Record the array times the struct members => entry[i].struct_member + forEachArrayAccessor(member.arrayDims, [&] (const QString& str) { + UBO_Member arrayMember {StringToInt::lookupId(fullMemberName + str), {}, {}}; + // Record all struct member into the array member[i] + for (const QShaderDescription::BlockVariable& bv : member.structMembers) { //recordAllUniforms("baz", "foo.bar[1][2].") const QString structMemberNamePrefix = fullMemberName + str + QLatin1Char('.'); UBO_Member innerMember {StringToInt::lookupId(structMemberNamePrefix), bv, {}}; recordAllUniforms(innerMember, structMemberNamePrefix); - uboMember.structMembers.push_back(innerMember); - }); - } + arrayMember.structMembers.push_back(innerMember); + } + // When dealing with an array of structs, we treat structMembers as arrayMembers + uboMember.structMembers.push_back(arrayMember); + }); } else { // Final member (not array or struct) // Replace nameId with final nameId name uboMember.nameId = StringToInt::lookupId(fullMemberName); + + // Record as an individual uniform + m_uniformsNames.push_back(fullMemberName); + const int nameId = StringToInt::lookupId(fullMemberName); + m_uniformsNamesIds.push_back(nameId); } } @@ -492,7 +508,7 @@ QHash<QString, ShaderUniform> RHIShader::activeUniformsForUniformBlock(int block ShaderUniformBlock RHIShader::uniformBlockForBlockIndex(int blockIndex) const noexcept { - for (int i = 0, m = m_uniformBlocks.size(); i < m; ++i) { + for (size_t i = 0, m = m_uniformBlocks.size(); i < m; ++i) { if (m_uniformBlocks[i].m_index == blockIndex) { return m_uniformBlocks[i]; } @@ -502,7 +518,7 @@ ShaderUniformBlock RHIShader::uniformBlockForBlockIndex(int blockIndex) const no ShaderUniformBlock RHIShader::uniformBlockForBlockNameId(int blockNameId) const noexcept { - for (int i = 0, m = m_uniformBlocks.size(); i < m; ++i) { + for (size_t i = 0, m = m_uniformBlocks.size(); i < m; ++i) { if (m_uniformBlocks[i].m_nameId == blockNameId) { return m_uniformBlocks[i]; } @@ -512,7 +528,7 @@ ShaderUniformBlock RHIShader::uniformBlockForBlockNameId(int blockNameId) const ShaderUniformBlock RHIShader::uniformBlockForBlockName(const QString &blockName) const noexcept { - for (int i = 0, m = m_uniformBlocks.size(); i < m; ++i) { + for (size_t i = 0, m = m_uniformBlocks.size(); i < m; ++i) { if (m_uniformBlocks[i].m_name == blockName) { return m_uniformBlocks[i]; } @@ -539,7 +555,7 @@ ShaderUniformBlock RHIShader::uniformBlockForInstanceNameId(int instanceNameId) ShaderStorageBlock RHIShader::storageBlockForBlockIndex(int blockIndex) const noexcept { - for (int i = 0, m = m_shaderStorageBlockNames.size(); i < m; ++i) { + for (size_t i = 0, m = m_shaderStorageBlockNames.size(); i < m; ++i) { if (m_shaderStorageBlocks[i].m_index == blockIndex) return m_shaderStorageBlocks[i]; } @@ -548,7 +564,7 @@ ShaderStorageBlock RHIShader::storageBlockForBlockIndex(int blockIndex) const no ShaderStorageBlock RHIShader::storageBlockForBlockNameId(int blockNameId) const noexcept { - for (int i = 0, m = m_shaderStorageBlockNames.size(); i < m; ++i) { + for (size_t i = 0, m = m_shaderStorageBlockNames.size(); i < m; ++i) { if (m_shaderStorageBlocks[i].m_nameId == blockNameId) return m_shaderStorageBlocks[i]; } @@ -557,7 +573,7 @@ ShaderStorageBlock RHIShader::storageBlockForBlockNameId(int blockNameId) const ShaderStorageBlock RHIShader::storageBlockForBlockName(const QString &blockName) const noexcept { - for (int i = 0, m = m_shaderStorageBlockNames.size(); i < m; ++i) { + for (size_t i = 0, m = m_shaderStorageBlockNames.size(); i < m; ++i) { if (m_shaderStorageBlocks[i].m_name == blockName) return m_shaderStorageBlocks[i]; } @@ -612,7 +628,7 @@ void RHIShader::initializeAttributes(const std::vector<ShaderAttribute> &attribu m_attributes = attributesDescription; m_attributesNames.resize(attributesDescription.size()); m_attributeNamesIds.resize(attributesDescription.size()); - for (int i = 0, m = attributesDescription.size(); i < m; i++) { + for (size_t i = 0, m = attributesDescription.size(); i < m; i++) { m_attributesNames[i] = attributesDescription[i].m_name; m_attributes[i].m_nameId = StringToInt::lookupId(m_attributesNames[i]); m_attributeNamesIds[i] = m_attributes[i].m_nameId; @@ -625,7 +641,7 @@ void RHIShader::initializeSamplers(const std::vector<ShaderAttribute> &samplersD m_samplers = samplersDescription; m_samplerNames.resize(samplersDescription.size()); m_samplerIds.resize(samplersDescription.size()); - for (int i = 0, m = samplersDescription.size(); i < m; i++) { + for (size_t i = 0, m = samplersDescription.size(); i < m; i++) { m_samplerNames[i] = samplersDescription[i].m_name; m_samplers[i].m_nameId = StringToInt::lookupId(m_samplerNames[i]); m_samplerIds[i] = m_samplers[i].m_nameId; @@ -638,7 +654,7 @@ void RHIShader::initializeImages(const std::vector<ShaderAttribute> &imagesDescr m_images = imagesDescription; m_imageNames.resize(imagesDescription.size()); m_imageIds.resize(imagesDescription.size()); - for (int i = 0, m = imagesDescription.size(); i < m; i++) { + for (size_t i = 0, m = imagesDescription.size(); i < m; i++) { m_imageNames[i] = imagesDescription[i].m_name; m_images[i].m_nameId = StringToInt::lookupId(m_imageNames[i]); m_imageIds[i] = m_images[i].m_nameId; @@ -651,7 +667,7 @@ void RHIShader::initializeUniformBlocks(const std::vector<ShaderUniformBlock> &u m_uniformBlocks = uniformBlockDescription; m_uniformBlockNames.resize(uniformBlockDescription.size()); m_uniformBlockNamesIds.resize(uniformBlockDescription.size()); - for (int i = 0, m = uniformBlockDescription.size(); i < m; ++i) { + for (size_t i = 0, m = uniformBlockDescription.size(); i < m; ++i) { m_uniformBlockNames[i] = m_uniformBlocks[i].m_name; m_uniformBlockNamesIds[i] = StringToInt::lookupId(m_uniformBlockNames[i]); m_uniformBlocks[i].m_nameId = m_uniformBlockNamesIds[i]; @@ -692,7 +708,7 @@ void RHIShader::initializeShaderStorageBlocks( m_shaderStorageBlockNames.resize(shaderStorageBlockDescription.size()); m_shaderStorageBlockNamesIds.resize(shaderStorageBlockDescription.size()); - for (int i = 0, m = shaderStorageBlockDescription.size(); i < m; ++i) { + for (size_t i = 0, m = shaderStorageBlockDescription.size(); i < m; ++i) { m_shaderStorageBlockNames[i] = m_shaderStorageBlocks[i].m_name; m_shaderStorageBlockNamesIds[i] = StringToInt::lookupId(m_shaderStorageBlockNames[i]); m_shaderStorageBlocks[i].m_nameId = m_shaderStorageBlockNamesIds[i]; diff --git a/src/plugins/renderers/rhi/renderer/shaderparameterpack.cpp b/src/plugins/renderers/rhi/renderer/shaderparameterpack.cpp index 46f6480e4..d7f986981 100644 --- a/src/plugins/renderers/rhi/renderer/shaderparameterpack.cpp +++ b/src/plugins/renderers/rhi/renderer/shaderparameterpack.cpp @@ -86,7 +86,7 @@ void ShaderParameterPack::setTexture(const int glslNameId, int uniformArrayIndex void ShaderParameterPack::setImage(const int glslNameId, int uniformArrayIndex, Qt3DCore::QNodeId id) { - for (int i=0, m = m_images.size(); i < m; ++i) { + for (size_t i=0, m = m_images.size(); i < m; ++i) { if (m_images[i].glslNameId != glslNameId || m_images[i].uniformArrayIndex != uniformArrayIndex) continue; diff --git a/src/plugins/sceneparsers/assimp/assimphelpers.cpp b/src/plugins/sceneparsers/assimp/assimphelpers.cpp index 77209a7a9..2f81e460c 100644 --- a/src/plugins/sceneparsers/assimp/assimphelpers.cpp +++ b/src/plugins/sceneparsers/assimp/assimphelpers.cpp @@ -45,6 +45,8 @@ #include <QtCore/QDir> #include <QtCore/QDebug> +#include <memory> + QT_BEGIN_NAMESPACE namespace Qt3DRender { @@ -208,9 +210,9 @@ Assimp::IOStream *AssimpIOSystem::Open(const char *pFile, const char *pMode) const QLatin1String cleanedMode = QLatin1String{pMode}.trimmed(); if (const QIODevice::OpenMode openMode = openModeFromText(cleanedMode.data())) { - QScopedPointer<QFile> file(new QFile(fileName)); + auto file = std::make_unique<QFile>(fileName); if (file->open(openMode)) - return new AssimpIOStream(file.take()); + return new AssimpIOStream(file.release()); } return nullptr; } diff --git a/src/plugins/sceneparsers/assimp/assimpimporter.cpp b/src/plugins/sceneparsers/assimp/assimpimporter.cpp index 1a775d888..8e21a7dbd 100644 --- a/src/plugins/sceneparsers/assimp/assimpimporter.cpp +++ b/src/plugins/sceneparsers/assimp/assimpimporter.cpp @@ -1402,4 +1402,6 @@ AssimpImporter::SceneImporter::~SceneImporter() QT_END_NAMESPACE +#include "moc_assimpimporter.cpp" + #include "assimpimporter.moc" diff --git a/src/plugins/sceneparsers/assimp/assimpimporter.h b/src/plugins/sceneparsers/assimp/assimpimporter.h index c1c8537cc..0488ec652 100644 --- a/src/plugins/sceneparsers/assimp/assimpimporter.h +++ b/src/plugins/sceneparsers/assimp/assimpimporter.h @@ -58,6 +58,7 @@ #include <assimp/DefaultLogger.hpp> #include <QtCore/QDir> +#include <QtCore/QHash> #include <QtCore/QList> #include <QtCore/QLoggingCategory> diff --git a/src/plugins/sceneparsers/gltf/gltfimporter.cpp b/src/plugins/sceneparsers/gltf/gltfimporter.cpp index 67510486a..eff2a5ecf 100644 --- a/src/plugins/sceneparsers/gltf/gltfimporter.cpp +++ b/src/plugins/sceneparsers/gltf/gltfimporter.cpp @@ -2630,4 +2630,5 @@ bool GLTFRawTextureImage::GLTFRawTextureImageFunctor::operator ==(const QTexture QT_END_NAMESPACE +#include "moc_gltfimporter.cpp" #include "gltfimporter.moc" diff --git a/src/plugins/sceneparsers/gltfexport/gltfexporter.h b/src/plugins/sceneparsers/gltfexport/gltfexporter.h index 0d30a2064..254bc2e2a 100644 --- a/src/plugins/sceneparsers/gltfexport/gltfexporter.h +++ b/src/plugins/sceneparsers/gltfexport/gltfexporter.h @@ -54,6 +54,7 @@ #include <QtCore/qjsondocument.h> #include <QtCore/qjsonobject.h> #include <QtCore/qhash.h> +#include <QtCore/qset.h> #include <QtGui/qvector3d.h> #include <Qt3DRender/qabstractlight.h> diff --git a/src/quick3d/imports/animation/qt3dquick3danimationplugin.cpp b/src/quick3d/imports/animation/qt3dquick3danimationplugin.cpp index 0ece3c88a..a6ebf39ea 100644 --- a/src/quick3d/imports/animation/qt3dquick3danimationplugin.cpp +++ b/src/quick3d/imports/animation/qt3dquick3danimationplugin.cpp @@ -106,3 +106,5 @@ void Qt3DQuick3DAnimationPlugin::registerTypes(const char *uri) } QT_END_NAMESPACE + +#include "moc_qt3dquick3danimationplugin.cpp" diff --git a/src/quick3d/imports/core/qt3dquick3dcoreplugin.cpp b/src/quick3d/imports/core/qt3dquick3dcoreplugin.cpp index 14987e764..95b1c4153 100644 --- a/src/quick3d/imports/core/qt3dquick3dcoreplugin.cpp +++ b/src/quick3d/imports/core/qt3dquick3dcoreplugin.cpp @@ -62,8 +62,18 @@ #include <QtQml/qqml.h> +extern void qml_register_types_Qt3D_Core(); +Q_GHS_KEEP_REFERENCE(qml_register_types_Qt3D_Core); + QT_BEGIN_NAMESPACE +Qt3DQuick3DCorePlugin::Qt3DQuick3DCorePlugin(QObject *parent) + : QQmlExtensionPlugin(parent) +{ + volatile auto registration = &qml_register_types_Qt3D_Core; + Q_UNUSED(registration); +} + void Qt3DQuick3DCorePlugin::registerTypes(const char *uri) { Q_UNUSED(uri); @@ -79,3 +89,5 @@ Qt3DQuick3DCorePlugin::~Qt3DQuick3DCorePlugin() } QT_END_NAMESPACE + +#include "moc_qt3dquick3dcoreplugin.cpp" diff --git a/src/quick3d/imports/core/qt3dquick3dcoreplugin.h b/src/quick3d/imports/core/qt3dquick3dcoreplugin.h index afc092bbb..ebedb22a4 100644 --- a/src/quick3d/imports/core/qt3dquick3dcoreplugin.h +++ b/src/quick3d/imports/core/qt3dquick3dcoreplugin.h @@ -49,7 +49,7 @@ class Qt3DQuick3DCorePlugin : public QQmlExtensionPlugin Q_OBJECT Q_PLUGIN_METADATA(IID QQmlExtensionInterface_iid) public: - Qt3DQuick3DCorePlugin(QObject *parent = nullptr) : QQmlExtensionPlugin(parent) { } + Qt3DQuick3DCorePlugin(QObject *parent = nullptr); ~Qt3DQuick3DCorePlugin(); void registerTypes(const char *uri) override; }; diff --git a/src/quick3d/imports/extras/CMakeLists.txt b/src/quick3d/imports/extras/CMakeLists.txt index 9263f632b..98be63038 100644 --- a/src/quick3d/imports/extras/CMakeLists.txt +++ b/src/quick3d/imports/extras/CMakeLists.txt @@ -14,7 +14,8 @@ qt_internal_add_qml_module(quick3dextrasplugin NO_GENERATE_QMLTYPES INSTALL_SOURCE_QMLTYPES "plugins.qmltypes" DEPENDENCIES - Qt3D.Logic/2.0 + QtQuick/auto + Qt3D.Logic/auto SOURCES qt3dquick3dextrasplugin.cpp qt3dquick3dextrasplugin.h LIBRARIES diff --git a/src/quick3d/imports/extras/qt3dquick3dextrasplugin.cpp b/src/quick3d/imports/extras/qt3dquick3dextrasplugin.cpp index a7bdd62db..5492b4788 100644 --- a/src/quick3d/imports/extras/qt3dquick3dextrasplugin.cpp +++ b/src/quick3d/imports/extras/qt3dquick3dextrasplugin.cpp @@ -159,3 +159,5 @@ void Qt3DQuick3DExtrasPlugin::registerTypes(const char *uri) QT_END_NAMESPACE + +#include "moc_qt3dquick3dextrasplugin.cpp" diff --git a/src/quick3d/imports/input/CMakeLists.txt b/src/quick3d/imports/input/CMakeLists.txt index 3742a6ed7..6df18be17 100644 --- a/src/quick3d/imports/input/CMakeLists.txt +++ b/src/quick3d/imports/input/CMakeLists.txt @@ -8,6 +8,8 @@ qt_internal_add_qml_module(quick3dinputplugin URI "Qt3D.Input" VERSION "2.${PROJECT_VERSION_MINOR}" CLASS_NAME Qt3DQuick3DInputPlugin + DEPENDENCIES + QtQml/auto PLUGIN_TARGET quick3dinputplugin NO_PLUGIN_OPTIONAL NO_GENERATE_PLUGIN_SOURCE diff --git a/src/quick3d/imports/input/qt3dquick3dinputplugin.cpp b/src/quick3d/imports/input/qt3dquick3dinputplugin.cpp index 3ea731885..d8c6c4ec1 100644 --- a/src/quick3d/imports/input/qt3dquick3dinputplugin.cpp +++ b/src/quick3d/imports/input/qt3dquick3dinputplugin.cpp @@ -112,3 +112,5 @@ void Qt3DQuick3DInputPlugin::registerTypes(const char *uri) } QT_END_NAMESPACE + +#include "moc_qt3dquick3dinputplugin.cpp" diff --git a/src/quick3d/imports/logic/qt3dquick3dlogicplugin.cpp b/src/quick3d/imports/logic/qt3dquick3dlogicplugin.cpp index 969b28a0d..ad6e1881e 100644 --- a/src/quick3d/imports/logic/qt3dquick3dlogicplugin.cpp +++ b/src/quick3d/imports/logic/qt3dquick3dlogicplugin.cpp @@ -54,3 +54,5 @@ void Qt3DQuick3DLogicPlugin::registerTypes(const char *uri) } QT_END_NAMESPACE + +#include "moc_qt3dquick3dlogicplugin.cpp" diff --git a/src/quick3d/imports/render/CMakeLists.txt b/src/quick3d/imports/render/CMakeLists.txt index e37a04912..7cd7df848 100644 --- a/src/quick3d/imports/render/CMakeLists.txt +++ b/src/quick3d/imports/render/CMakeLists.txt @@ -8,6 +8,8 @@ qt_internal_add_qml_module(quick3drenderplugin URI "Qt3D.Render" VERSION "2.${PROJECT_VERSION_MINOR}" CLASS_NAME Qt3DQuick3DRenderPlugin + DEPENDENCIES + QtQml/auto PLUGIN_TARGET quick3drenderplugin NO_PLUGIN_OPTIONAL NO_GENERATE_PLUGIN_SOURCE diff --git a/src/quick3d/imports/render/qt3dquick3drenderplugin.cpp b/src/quick3d/imports/render/qt3dquick3drenderplugin.cpp index 59fcfa6d6..d329a0762 100644 --- a/src/quick3d/imports/render/qt3dquick3drenderplugin.cpp +++ b/src/quick3d/imports/render/qt3dquick3drenderplugin.cpp @@ -321,4 +321,6 @@ void Qt3DQuick3DRenderPlugin::registerTypes(const char *uri) QT_END_NAMESPACE +#include "moc_qt3dquick3drenderplugin.cpp" + diff --git a/src/quick3d/imports/scene2d/qtquickscene2dplugin.cpp b/src/quick3d/imports/scene2d/qtquickscene2dplugin.cpp index 0ddb9eb0c..4693f21b8 100644 --- a/src/quick3d/imports/scene2d/qtquickscene2dplugin.cpp +++ b/src/quick3d/imports/scene2d/qtquickscene2dplugin.cpp @@ -63,3 +63,5 @@ void QtQuickScene2DPlugin::registerTypes(const char *uri) } QT_END_NAMESPACE + +#include "moc_qtquickscene2dplugin.cpp" diff --git a/src/quick3d/imports/scene3d/qtquickscene3dplugin.cpp b/src/quick3d/imports/scene3d/qtquickscene3dplugin.cpp index fa79af1cd..338a7ef7f 100644 --- a/src/quick3d/imports/scene3d/qtquickscene3dplugin.cpp +++ b/src/quick3d/imports/scene3d/qtquickscene3dplugin.cpp @@ -56,3 +56,5 @@ void QtQuickScene3DPlugin::registerTypes(const char *uri) } QT_END_NAMESPACE + +#include "moc_qtquickscene3dplugin.cpp" diff --git a/src/quick3d/imports/scene3d/scene3ditem.cpp b/src/quick3d/imports/scene3d/scene3ditem.cpp index 6f84fff7e..f6bcb63a7 100644 --- a/src/quick3d/imports/scene3d/scene3ditem.cpp +++ b/src/quick3d/imports/scene3d/scene3ditem.cpp @@ -908,4 +908,5 @@ void Scene3DItem::mousePressEvent(QMouseEvent *event) QT_END_NAMESPACE +#include "moc_scene3ditem_p.cpp" #include "scene3ditem.moc" diff --git a/src/quick3d/imports/scene3d/scene3drenderer.cpp b/src/quick3d/imports/scene3d/scene3drenderer.cpp index e99705006..7c6a925fe 100644 --- a/src/quick3d/imports/scene3d/scene3drenderer.cpp +++ b/src/quick3d/imports/scene3d/scene3drenderer.cpp @@ -663,3 +663,5 @@ Scene3DRenderer::QuickRenderer::~QuickRenderer() {} } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_scene3drenderer_p.cpp" diff --git a/src/quick3d/quick3d/items/quick3dbuffer.cpp b/src/quick3d/quick3d/items/quick3dbuffer.cpp index 159eb1017..e9ace7349 100644 --- a/src/quick3d/quick3d/items/quick3dbuffer.cpp +++ b/src/quick3d/quick3d/items/quick3dbuffer.cpp @@ -141,3 +141,5 @@ void Quick3DBuffer::initEngines() } // Qt3DCore QT_END_NAMESPACE + +#include "moc_quick3dbuffer_p.cpp" diff --git a/src/quick3d/quick3d/items/quick3dentity.cpp b/src/quick3d/quick3d/items/quick3dentity.cpp index 0ef1f8863..0ee35e07e 100644 --- a/src/quick3d/quick3d/items/quick3dentity.cpp +++ b/src/quick3d/quick3d/items/quick3dentity.cpp @@ -118,3 +118,5 @@ QQmlListProperty<QComponent> Quick3DEntity::componentList() } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_quick3dentity_p.cpp" diff --git a/src/quick3d/quick3d/items/quick3dgeometry.cpp b/src/quick3d/quick3d/items/quick3dgeometry.cpp index bcd25731d..03a30615c 100644 --- a/src/quick3d/quick3d/items/quick3dgeometry.cpp +++ b/src/quick3d/quick3d/items/quick3dgeometry.cpp @@ -85,3 +85,5 @@ QQmlListProperty<Qt3DCore::QAttribute> Quick3DGeometry::attributeList() } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_quick3dgeometry_p.cpp" diff --git a/src/quick3d/quick3d/items/quick3djoint.cpp b/src/quick3d/quick3d/items/quick3djoint.cpp index 91f84c5e1..00026460f 100644 --- a/src/quick3d/quick3d/items/quick3djoint.cpp +++ b/src/quick3d/quick3d/items/quick3djoint.cpp @@ -89,3 +89,5 @@ QQmlListProperty<QJoint> Quick3DJoint::childJoints() } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_quick3djoint_p.cpp" diff --git a/src/quick3d/quick3d/items/quick3dnode.cpp b/src/quick3d/quick3d/items/quick3dnode.cpp index 7642fe4c7..9b48ac713 100644 --- a/src/quick3d/quick3d/items/quick3dnode.cpp +++ b/src/quick3d/quick3d/items/quick3dnode.cpp @@ -162,3 +162,6 @@ void Quick3DNode::childRemoved(int, QObject *obj) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_quick3dnode_p.cpp" +#include "moc_qt3dquickforeign_p.cpp" diff --git a/src/quick3d/quick3d/qquaternionanimation.cpp b/src/quick3d/quick3d/qquaternionanimation.cpp index 933a08ee4..78e07ea6a 100644 --- a/src/quick3d/quick3d/qquaternionanimation.cpp +++ b/src/quick3d/quick3d/qquaternionanimation.cpp @@ -257,3 +257,5 @@ void QQuaternionAnimation::setToZRotation(float f) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qquaternionanimation_p.cpp" diff --git a/src/quick3d/quick3d/qt3dquickvaluetypes.cpp b/src/quick3d/quick3d/qt3dquickvaluetypes.cpp index a4084fec3..d126acccb 100644 --- a/src/quick3d/quick3d/qt3dquickvaluetypes.cpp +++ b/src/quick3d/quick3d/qt3dquickvaluetypes.cpp @@ -302,7 +302,7 @@ QVector4D QQuick3DMatrix4x4ValueType::times(const QVector4D &vec) const QVector3D QQuick3DMatrix4x4ValueType::times(const QVector3D &vec) const { - return v * vec; + return v.map(vec); } QMatrix4x4 QQuick3DMatrix4x4ValueType::times(qreal factor) const @@ -422,7 +422,7 @@ qreal QQuick3DVector3DValueType::dotProduct(const QVector3D &vec) const QVector3D QQuick3DVector3DValueType::times(const QMatrix4x4 &m) const { - return v * m; + return (QVector4D(v, 1.f) * m).toVector3DAffine(); } QVector3D QQuick3DVector3DValueType::times(const QVector3D &vec) const @@ -765,3 +765,5 @@ void QQuick3DQuaternionValueType::setZ(qreal z) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qt3dquickvaluetypes_p.cpp" diff --git a/src/quick3d/quick3danimation/items/quick3danimationcontroller.cpp b/src/quick3d/quick3danimation/items/quick3danimationcontroller.cpp index 1f655dd36..012408d2d 100644 --- a/src/quick3d/quick3danimation/items/quick3danimationcontroller.cpp +++ b/src/quick3d/quick3danimation/items/quick3danimationcontroller.cpp @@ -89,3 +89,5 @@ QQmlListProperty<QAnimationGroup> QQuick3DAnimationController::animationGroups() } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_quick3danimationcontroller_p.cpp" diff --git a/src/quick3d/quick3danimation/items/quick3danimationgroup.cpp b/src/quick3d/quick3danimation/items/quick3danimationgroup.cpp index e07a195f1..df9187ba3 100644 --- a/src/quick3d/quick3danimation/items/quick3danimationgroup.cpp +++ b/src/quick3d/quick3danimation/items/quick3danimationgroup.cpp @@ -95,3 +95,5 @@ QQmlListProperty<Qt3DAnimation::QAbstractAnimation> QQuick3DAnimationGroup::anim } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_quick3danimationgroup_p.cpp" diff --git a/src/quick3d/quick3danimation/items/quick3dchannelmapper.cpp b/src/quick3d/quick3danimation/items/quick3dchannelmapper.cpp index 3c62ae03b..534e7ff9b 100644 --- a/src/quick3d/quick3danimation/items/quick3dchannelmapper.cpp +++ b/src/quick3d/quick3danimation/items/quick3dchannelmapper.cpp @@ -86,3 +86,5 @@ QQmlListProperty<QAbstractChannelMapping> Quick3DChannelMapper::qmlMappings() } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_quick3dchannelmapper_p.cpp" diff --git a/src/quick3d/quick3danimation/items/quick3dkeyframeanimation.cpp b/src/quick3d/quick3danimation/items/quick3dkeyframeanimation.cpp index 0a57f61c6..dea6117a6 100644 --- a/src/quick3d/quick3danimation/items/quick3dkeyframeanimation.cpp +++ b/src/quick3d/quick3danimation/items/quick3dkeyframeanimation.cpp @@ -94,3 +94,5 @@ QQmlListProperty<Qt3DCore::QTransform> QQuick3DKeyframeAnimation::keyframes() } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_quick3dkeyframeanimation_p.cpp" diff --git a/src/quick3d/quick3danimation/items/quick3dmorphinganimation.cpp b/src/quick3d/quick3danimation/items/quick3dmorphinganimation.cpp index f1e88f5ef..532890b73 100644 --- a/src/quick3d/quick3danimation/items/quick3dmorphinganimation.cpp +++ b/src/quick3d/quick3danimation/items/quick3dmorphinganimation.cpp @@ -90,3 +90,5 @@ QQmlListProperty<Qt3DAnimation::QMorphTarget> QQuick3DMorphingAnimation::morphTa } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_quick3dmorphinganimation_p.cpp" diff --git a/src/quick3d/quick3danimation/items/quick3dmorphtarget.cpp b/src/quick3d/quick3danimation/items/quick3dmorphtarget.cpp index c960a9904..a216e7d14 100644 --- a/src/quick3d/quick3danimation/items/quick3dmorphtarget.cpp +++ b/src/quick3d/quick3danimation/items/quick3dmorphtarget.cpp @@ -90,3 +90,5 @@ QQmlListProperty<Qt3DCore::QAttribute> QQuick3DMorphTarget::attributes() } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_quick3dmorphtarget_p.cpp" diff --git a/src/quick3d/quick3danimation/items/quick3dvertexblendanimation.cpp b/src/quick3d/quick3danimation/items/quick3dvertexblendanimation.cpp index bf172580c..446f6d377 100644 --- a/src/quick3d/quick3danimation/items/quick3dvertexblendanimation.cpp +++ b/src/quick3d/quick3danimation/items/quick3dvertexblendanimation.cpp @@ -94,3 +94,5 @@ QQmlListProperty<Qt3DAnimation::QMorphTarget> QQuick3DVertexBlendAnimation::morp } // namespace Qt3DAnimation QT_END_NAMESPACE + +#include "moc_quick3dvertexblendanimation_p.cpp" diff --git a/src/quick3d/quick3dextras/items/quick3dlevelofdetailloader.cpp b/src/quick3d/quick3dextras/items/quick3dlevelofdetailloader.cpp index ee505b1cf..d2766d8c9 100644 --- a/src/quick3d/quick3dextras/items/quick3dlevelofdetailloader.cpp +++ b/src/quick3d/quick3dextras/items/quick3dlevelofdetailloader.cpp @@ -191,4 +191,6 @@ QUrl Quick3DLevelOfDetailLoader::source() const QT_END_NAMESPACE +#include "moc_quick3dlevelofdetailloader_p.cpp" + diff --git a/src/quick3d/quick3dextras/items/quick3dspritesheet.cpp b/src/quick3d/quick3dextras/items/quick3dspritesheet.cpp index 361295382..182e80906 100644 --- a/src/quick3d/quick3dextras/items/quick3dspritesheet.cpp +++ b/src/quick3d/quick3dextras/items/quick3dspritesheet.cpp @@ -92,3 +92,5 @@ QQmlListProperty<Qt3DExtras::QSpriteSheetItem> Quick3DSpriteSheet::sprites() QT_END_NAMESPACE +#include "moc_quick3dspritesheet_p.cpp" + diff --git a/src/quick3d/quick3dextras/qt3dquickwindow.cpp b/src/quick3d/quick3dextras/qt3dquickwindow.cpp index 336e7b966..f03c52e16 100644 --- a/src/quick3d/quick3dextras/qt3dquickwindow.cpp +++ b/src/quick3d/quick3dextras/qt3dquickwindow.cpp @@ -276,4 +276,5 @@ void Qt3DQuickWindow::updateCameraAspectRatio() QT_END_NAMESPACE +#include "moc_qt3dquickwindow.cpp" #include "qt3dquickwindow.moc" diff --git a/src/quick3d/quick3dinput/items/quick3daction.cpp b/src/quick3d/quick3dinput/items/quick3daction.cpp index 10c1b5a56..2422cc20e 100644 --- a/src/quick3d/quick3dinput/items/quick3daction.cpp +++ b/src/quick3d/quick3dinput/items/quick3daction.cpp @@ -86,3 +86,5 @@ QQmlListProperty<QAbstractActionInput> Quick3DAction::qmlActionInputs() } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_quick3daction_p.cpp" diff --git a/src/quick3d/quick3dinput/items/quick3daxis.cpp b/src/quick3d/quick3dinput/items/quick3daxis.cpp index 115fa4b78..592fb1e7b 100644 --- a/src/quick3d/quick3dinput/items/quick3daxis.cpp +++ b/src/quick3d/quick3dinput/items/quick3daxis.cpp @@ -87,3 +87,5 @@ QQmlListProperty<QAbstractAxisInput> Quick3DAxis::qmlAxisInputs() } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_quick3daxis_p.cpp" diff --git a/src/quick3d/quick3dinput/items/quick3dinputchord.cpp b/src/quick3d/quick3dinput/items/quick3dinputchord.cpp index 669c251d2..ba83affb3 100644 --- a/src/quick3d/quick3dinput/items/quick3dinputchord.cpp +++ b/src/quick3d/quick3dinput/items/quick3dinputchord.cpp @@ -86,3 +86,5 @@ QQmlListProperty<QAbstractActionInput> Quick3DInputChord::qmlActionInputs() } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_quick3dinputchord_p.cpp" diff --git a/src/quick3d/quick3dinput/items/quick3dinputsequence.cpp b/src/quick3d/quick3dinput/items/quick3dinputsequence.cpp index 4d637c18b..f5eadbc19 100644 --- a/src/quick3d/quick3dinput/items/quick3dinputsequence.cpp +++ b/src/quick3d/quick3dinput/items/quick3dinputsequence.cpp @@ -87,3 +87,5 @@ QQmlListProperty<QAbstractActionInput> Quick3DInputSequence::qmlActionInputs() } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_quick3dinputsequence_p.cpp" diff --git a/src/quick3d/quick3dinput/items/quick3dlogicaldevice.cpp b/src/quick3d/quick3dinput/items/quick3dlogicaldevice.cpp index 061fe1433..b50dc5786 100644 --- a/src/quick3d/quick3dinput/items/quick3dlogicaldevice.cpp +++ b/src/quick3d/quick3dinput/items/quick3dlogicaldevice.cpp @@ -118,3 +118,5 @@ QQmlListProperty<QAction> Quick3DLogicalDevice::qmlActions() } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_quick3dlogicaldevice_p.cpp" diff --git a/src/quick3d/quick3dinput/items/quick3dphysicaldevice.cpp b/src/quick3d/quick3dinput/items/quick3dphysicaldevice.cpp index 07b017735..1680e7465 100644 --- a/src/quick3d/quick3dinput/items/quick3dphysicaldevice.cpp +++ b/src/quick3d/quick3dinput/items/quick3dphysicaldevice.cpp @@ -86,3 +86,5 @@ QQmlListProperty<QAxisSetting> Quick3DPhysicalDevice::axisSettings() } // namespace Qt3DInput QT_END_NAMESPACE + +#include "moc_quick3dphysicaldevice_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3deffect.cpp b/src/quick3d/quick3drender/items/quick3deffect.cpp index 09045011b..d4fa51dfc 100644 --- a/src/quick3d/quick3drender/items/quick3deffect.cpp +++ b/src/quick3d/quick3drender/items/quick3deffect.cpp @@ -129,3 +129,5 @@ QQmlListProperty<QParameter> Quick3DEffect::parameterList() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3deffect_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dlayerfilter.cpp b/src/quick3d/quick3drender/items/quick3dlayerfilter.cpp index 431391af6..8f279d02a 100644 --- a/src/quick3d/quick3drender/items/quick3dlayerfilter.cpp +++ b/src/quick3d/quick3drender/items/quick3dlayerfilter.cpp @@ -100,3 +100,5 @@ QQmlListProperty<QLayer> Quick3DLayerFilter::qmlLayers() } // Qt3D QT_END_NAMESPACE + +#include "moc_quick3dlayerfilter_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dmaterial.cpp b/src/quick3d/quick3drender/items/quick3dmaterial.cpp index 0e1528fe2..50e7afe45 100644 --- a/src/quick3d/quick3drender/items/quick3dmaterial.cpp +++ b/src/quick3d/quick3drender/items/quick3dmaterial.cpp @@ -101,3 +101,5 @@ QQmlListProperty<QParameter> Quick3DMaterial::qmlParameters() } // Qt3D QT_END_NAMESPACE + +#include "moc_quick3dmaterial_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dmemorybarrier.cpp b/src/quick3d/quick3drender/items/quick3dmemorybarrier.cpp index 0754a0cf5..504ff3af9 100644 --- a/src/quick3d/quick3drender/items/quick3dmemorybarrier.cpp +++ b/src/quick3d/quick3drender/items/quick3dmemorybarrier.cpp @@ -72,3 +72,5 @@ int Quick3DMemoryBarrier::waitFor() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3dmemorybarrier_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dparameter.cpp b/src/quick3d/quick3drender/items/quick3dparameter.cpp index 2ef95a4d4..a4e6178e1 100644 --- a/src/quick3d/quick3drender/items/quick3dparameter.cpp +++ b/src/quick3d/quick3drender/items/quick3dparameter.cpp @@ -85,4 +85,6 @@ Quick3DParameter::Quick3DParameter(Quick3DParameterPrivate &dd, QNode *parent) QT_END_NAMESPACE +#include "moc_quick3dparameter_p.cpp" + diff --git a/src/quick3d/quick3drender/items/quick3draycaster.cpp b/src/quick3d/quick3drender/items/quick3draycaster.cpp index 4e901c82b..d227ff0ce 100644 --- a/src/quick3d/quick3drender/items/quick3draycaster.cpp +++ b/src/quick3d/quick3drender/items/quick3draycaster.cpp @@ -97,3 +97,5 @@ QQmlListProperty<Qt3DRender::QLayer> Qt3DRender::Render::Quick::Quick3DRayCaster } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3draycaster_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3drenderpass.cpp b/src/quick3d/quick3drender/items/quick3drenderpass.cpp index 0006191a5..49887f4d7 100644 --- a/src/quick3d/quick3drender/items/quick3drenderpass.cpp +++ b/src/quick3d/quick3drender/items/quick3drenderpass.cpp @@ -149,3 +149,5 @@ QQmlListProperty<QParameter> Quick3DRenderPass::parameterList() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3drenderpass_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3drenderpassfilter.cpp b/src/quick3d/quick3drender/items/quick3drenderpassfilter.cpp index 6323911b4..7974ba81e 100644 --- a/src/quick3d/quick3drender/items/quick3drenderpassfilter.cpp +++ b/src/quick3d/quick3drender/items/quick3drenderpassfilter.cpp @@ -132,3 +132,5 @@ QQmlListProperty<QParameter> Quick3DRenderPassFilter::parameterList() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3drenderpassfilter_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3drendertargetoutput.cpp b/src/quick3d/quick3drender/items/quick3drendertargetoutput.cpp index 810ded8b0..87cd2be29 100644 --- a/src/quick3d/quick3drender/items/quick3drendertargetoutput.cpp +++ b/src/quick3d/quick3drender/items/quick3drendertargetoutput.cpp @@ -93,3 +93,5 @@ QQmlListProperty<QRenderTargetOutput> Quick3DRenderTargetOutput::qmlAttachments( } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3drendertargetoutput_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dscene.cpp b/src/quick3d/quick3drender/items/quick3dscene.cpp index af4f44f0e..d118fa51d 100644 --- a/src/quick3d/quick3drender/items/quick3dscene.cpp +++ b/src/quick3d/quick3drender/items/quick3dscene.cpp @@ -55,3 +55,5 @@ Quick3DScene::Quick3DScene(QObject *parent) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3dscene_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dscreenraycaster.cpp b/src/quick3d/quick3drender/items/quick3dscreenraycaster.cpp index 206073426..5023bd197 100644 --- a/src/quick3d/quick3drender/items/quick3dscreenraycaster.cpp +++ b/src/quick3d/quick3drender/items/quick3dscreenraycaster.cpp @@ -101,3 +101,5 @@ QQmlListProperty<Qt3DRender::QLayer> Qt3DRender::Render::Quick::Quick3DScreenRay } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3dscreenraycaster_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dshaderdata.cpp b/src/quick3d/quick3drender/items/quick3dshaderdata.cpp index 539391da9..0cc669e44 100644 --- a/src/quick3d/quick3drender/items/quick3dshaderdata.cpp +++ b/src/quick3d/quick3drender/items/quick3dshaderdata.cpp @@ -104,3 +104,5 @@ Quick3DShaderData::Quick3DShaderData(QNode *parent) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3dshaderdata_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dshaderdataarray.cpp b/src/quick3d/quick3drender/items/quick3dshaderdataarray.cpp index 146a17477..868546c2e 100644 --- a/src/quick3d/quick3drender/items/quick3dshaderdataarray.cpp +++ b/src/quick3d/quick3drender/items/quick3dshaderdataarray.cpp @@ -110,3 +110,5 @@ QList<QShaderData *> Quick3DShaderDataArray::values() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3dshaderdataarray_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dstateset.cpp b/src/quick3d/quick3drender/items/quick3dstateset.cpp index 396fab309..252c793ca 100644 --- a/src/quick3d/quick3drender/items/quick3dstateset.cpp +++ b/src/quick3d/quick3drender/items/quick3dstateset.cpp @@ -91,3 +91,5 @@ QQmlListProperty<QRenderState> Quick3DStateSet::renderStateList() QT_END_NAMESPACE +#include "moc_quick3dstateset_p.cpp" + diff --git a/src/quick3d/quick3drender/items/quick3dtechnique.cpp b/src/quick3d/quick3drender/items/quick3dtechnique.cpp index edc6f3da2..380f9f3a0 100644 --- a/src/quick3d/quick3drender/items/quick3dtechnique.cpp +++ b/src/quick3d/quick3drender/items/quick3dtechnique.cpp @@ -165,3 +165,5 @@ QQmlListProperty<QFilterKey> Quick3DTechnique::filterKeyList() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3dtechnique_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp b/src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp index 0de7fe5ba..645206d20 100644 --- a/src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp +++ b/src/quick3d/quick3drender/items/quick3dtechniquefilter.cpp @@ -126,3 +126,5 @@ QQmlListProperty<QParameter> Quick3DTechniqueFilter::parameterList() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3dtechniquefilter_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dtexture.cpp b/src/quick3d/quick3drender/items/quick3dtexture.cpp index 8e1deed1c..d2d75edb9 100644 --- a/src/quick3d/quick3drender/items/quick3dtexture.cpp +++ b/src/quick3d/quick3drender/items/quick3dtexture.cpp @@ -94,3 +94,5 @@ QQmlListProperty<QAbstractTextureImage> Quick3DTextureExtension::textureImages() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3dtexture_p.cpp" diff --git a/src/quick3d/quick3drender/items/quick3dviewport.cpp b/src/quick3d/quick3drender/items/quick3dviewport.cpp index 3b4bf33f5..855b631eb 100644 --- a/src/quick3d/quick3drender/items/quick3dviewport.cpp +++ b/src/quick3d/quick3drender/items/quick3dviewport.cpp @@ -55,3 +55,5 @@ Quick3DViewport::Quick3DViewport(QObject *parent) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_quick3dviewport_p.cpp" diff --git a/src/quick3d/quick3dscene2d/items/qscene2d.cpp b/src/quick3d/quick3dscene2d/items/qscene2d.cpp index 55aba62ad..993a5ecfd 100644 --- a/src/quick3d/quick3dscene2d/items/qscene2d.cpp +++ b/src/quick3d/quick3dscene2d/items/qscene2d.cpp @@ -349,3 +349,5 @@ void QScene2D::setMouseEnabled(bool enabled) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qscene2d.cpp" diff --git a/src/quick3d/quick3dscene2d/items/qt3dquick3dscene2d.cpp b/src/quick3d/quick3dscene2d/items/qt3dquick3dscene2d.cpp index 5b8ee1896..4c5ab90d2 100644 --- a/src/quick3d/quick3dscene2d/items/qt3dquick3dscene2d.cpp +++ b/src/quick3d/quick3dscene2d/items/qt3dquick3dscene2d.cpp @@ -96,3 +96,5 @@ QQmlListProperty<Qt3DCore::QEntity> QQuick3DScene2D::entities() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qt3dquick3dscene2d_p.cpp" diff --git a/src/quick3d/quick3dscene2d/items/scene2d.cpp b/src/quick3d/quick3dscene2d/items/scene2d.cpp index 2ad32e755..c2ca79df3 100644 --- a/src/quick3d/quick3dscene2d/items/scene2d.cpp +++ b/src/quick3d/quick3dscene2d/items/scene2d.cpp @@ -503,3 +503,5 @@ void Scene2D::handlePickEvent(int type, const Qt3DRender::QPickEvent *ev) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_scene2d_p.cpp" diff --git a/src/quick3d/quick3dscene2d/items/scene2dmanager.cpp b/src/quick3d/quick3dscene2d/items/scene2dmanager.cpp index f4ec3aec8..65dbf2a98 100644 --- a/src/quick3d/quick3dscene2d/items/scene2dmanager.cpp +++ b/src/quick3d/quick3dscene2d/items/scene2dmanager.cpp @@ -258,3 +258,5 @@ void Scene2DManager::cleanup() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_scene2dmanager_p.cpp" diff --git a/src/render/backend/offscreensurfacehelper.cpp b/src/render/backend/offscreensurfacehelper.cpp index 38558d484..60c80d7b5 100644 --- a/src/render/backend/offscreensurfacehelper.cpp +++ b/src/render/backend/offscreensurfacehelper.cpp @@ -80,3 +80,5 @@ void OffscreenSurfaceHelper::createOffscreenSurface() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_offscreensurfacehelper_p.cpp" diff --git a/src/render/backend/platformsurfacefilter.cpp b/src/render/backend/platformsurfacefilter.cpp index 115fb637f..8004bf2e4 100644 --- a/src/render/backend/platformsurfacefilter.cpp +++ b/src/render/backend/platformsurfacefilter.cpp @@ -168,3 +168,5 @@ bool SurfaceLocker::isSurfaceValid() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_platformsurfacefilter_p.cpp" diff --git a/src/render/backend/triangleboundingvolume.cpp b/src/render/backend/triangleboundingvolume.cpp index c30b41920..77fbe7fd9 100644 --- a/src/render/backend/triangleboundingvolume.cpp +++ b/src/render/backend/triangleboundingvolume.cpp @@ -116,7 +116,7 @@ bool TriangleBoundingVolume::intersects(const RayCasting::QRay3D &ray, Vector3D { float t = 0.0f; Vector3D uvwr; - const float intersected = intersectsSegmentTriangle(ray, m_c, m_b, m_a, uvwr, t); + const bool intersected = intersectsSegmentTriangle(ray, m_c, m_b, m_a, uvwr, t); if (intersected) { if (q != nullptr) @@ -164,9 +164,9 @@ void TriangleBoundingVolume::setC(const Vector3D &c) TriangleBoundingVolume TriangleBoundingVolume::transformed(const Matrix4x4 &mat) const { - const Vector3D tA = mat * m_a; - const Vector3D tB = mat * m_b; - const Vector3D tC = mat * m_c; + const Vector3D tA = mat.map(m_a); + const Vector3D tB = mat.map(m_b); + const Vector3D tC = mat.map(m_c); return TriangleBoundingVolume(id(), tA, tB, tC); } diff --git a/src/render/backend/uniform_p.h b/src/render/backend/uniform_p.h index 24bbcd76c..8dedf6d63 100644 --- a/src/render/backend/uniform_p.h +++ b/src/render/backend/uniform_p.h @@ -58,6 +58,7 @@ #include <Qt3DCore/private/vector4d_p.h> #include <Qt3DRender/private/qt3drender_global_p.h> #include <QMatrix4x4> +#include <QVarLengthArray> #include <QVector2D> #include <QVector3D> #include <QColor> diff --git a/src/render/framegraph/qblitframebuffer.cpp b/src/render/framegraph/qblitframebuffer.cpp index 356b2db06..2e9f9a2c3 100644 --- a/src/render/framegraph/qblitframebuffer.cpp +++ b/src/render/framegraph/qblitframebuffer.cpp @@ -435,3 +435,5 @@ void QBlitFramebuffer::setInterpolationMethod(QBlitFramebuffer::InterpolationMet } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qblitframebuffer.cpp" diff --git a/src/render/framegraph/qbuffercapture.cpp b/src/render/framegraph/qbuffercapture.cpp index 49b923534..3c18e31ba 100644 --- a/src/render/framegraph/qbuffercapture.cpp +++ b/src/render/framegraph/qbuffercapture.cpp @@ -81,3 +81,5 @@ QBufferCapture::~QBufferCapture() } //Qt3DRender QT_END_NAMESPACE + +#include "moc_qbuffercapture.cpp" diff --git a/src/render/framegraph/qcameraselector.cpp b/src/render/framegraph/qcameraselector.cpp index f9deba592..dec88c392 100644 --- a/src/render/framegraph/qcameraselector.cpp +++ b/src/render/framegraph/qcameraselector.cpp @@ -141,3 +141,5 @@ Qt3DCore::QEntity *QCameraSelector::camera() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qcameraselector.cpp" diff --git a/src/render/framegraph/qclearbuffers.cpp b/src/render/framegraph/qclearbuffers.cpp index 177f6f097..f24a46874 100644 --- a/src/render/framegraph/qclearbuffers.cpp +++ b/src/render/framegraph/qclearbuffers.cpp @@ -234,3 +234,5 @@ void QClearBuffers::setColorBuffer(QRenderTargetOutput *buffer) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qclearbuffers.cpp" diff --git a/src/render/framegraph/qdebugoverlay.cpp b/src/render/framegraph/qdebugoverlay.cpp index da0401b1b..ad7ddc1f4 100644 --- a/src/render/framegraph/qdebugoverlay.cpp +++ b/src/render/framegraph/qdebugoverlay.cpp @@ -97,3 +97,5 @@ QDebugOverlay::QDebugOverlay(Qt3DCore::QNode *parent) } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qdebugoverlay.cpp" diff --git a/src/render/framegraph/qdispatchcompute.cpp b/src/render/framegraph/qdispatchcompute.cpp index f9d1df621..13498e50e 100644 --- a/src/render/framegraph/qdispatchcompute.cpp +++ b/src/render/framegraph/qdispatchcompute.cpp @@ -165,3 +165,5 @@ void QDispatchCompute::setWorkGroupZ(int workGroupZ) QT_END_NAMESPACE +#include "moc_qdispatchcompute.cpp" + diff --git a/src/render/framegraph/qframegraphnode.cpp b/src/render/framegraph/qframegraphnode.cpp index 2a2bda3f2..3b1a7c902 100644 --- a/src/render/framegraph/qframegraphnode.cpp +++ b/src/render/framegraph/qframegraphnode.cpp @@ -435,3 +435,5 @@ void QFrameGraphNode::onParentChanged(QObject *) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qframegraphnode.cpp" diff --git a/src/render/framegraph/qfrustumculling.cpp b/src/render/framegraph/qfrustumculling.cpp index c34d666b5..d86044725 100644 --- a/src/render/framegraph/qfrustumculling.cpp +++ b/src/render/framegraph/qfrustumculling.cpp @@ -96,3 +96,5 @@ QFrustumCulling::~QFrustumCulling() QT_END_NAMESPACE +#include "moc_qfrustumculling.cpp" + diff --git a/src/render/framegraph/qlayerfilter.cpp b/src/render/framegraph/qlayerfilter.cpp index d7285fad0..e4eab2261 100644 --- a/src/render/framegraph/qlayerfilter.cpp +++ b/src/render/framegraph/qlayerfilter.cpp @@ -247,3 +247,5 @@ void QLayerFilter::setFilterMode(QLayerFilter::FilterMode filterMode) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qlayerfilter.cpp" diff --git a/src/render/framegraph/qmemorybarrier.cpp b/src/render/framegraph/qmemorybarrier.cpp index 1b44fac79..77b5602ea 100644 --- a/src/render/framegraph/qmemorybarrier.cpp +++ b/src/render/framegraph/qmemorybarrier.cpp @@ -157,3 +157,5 @@ QMemoryBarrier::QMemoryBarrier(QMemoryBarrierPrivate &dd, Qt3DCore::QNode *paren } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qmemorybarrier.cpp" diff --git a/src/render/framegraph/qnodraw.cpp b/src/render/framegraph/qnodraw.cpp index 46756557e..bd77727ed 100644 --- a/src/render/framegraph/qnodraw.cpp +++ b/src/render/framegraph/qnodraw.cpp @@ -140,3 +140,5 @@ QNoDraw::~QNoDraw() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qnodraw.cpp" diff --git a/src/render/framegraph/qnopicking.cpp b/src/render/framegraph/qnopicking.cpp index 069560175..f7bfe6d47 100644 --- a/src/render/framegraph/qnopicking.cpp +++ b/src/render/framegraph/qnopicking.cpp @@ -137,3 +137,5 @@ QNoPicking::~QNoPicking() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qnopicking.cpp" diff --git a/src/render/framegraph/qproximityfilter.cpp b/src/render/framegraph/qproximityfilter.cpp index 6836956a4..f17eee20c 100644 --- a/src/render/framegraph/qproximityfilter.cpp +++ b/src/render/framegraph/qproximityfilter.cpp @@ -183,3 +183,5 @@ void QProximityFilter::setDistanceThreshold(float distanceThreshold) } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qproximityfilter.cpp" diff --git a/src/render/framegraph/qrendercapture.cpp b/src/render/framegraph/qrendercapture.cpp index 97a71cbed..cac563549 100644 --- a/src/render/framegraph/qrendercapture.cpp +++ b/src/render/framegraph/qrendercapture.cpp @@ -351,3 +351,5 @@ Qt3DRender::QRenderCaptureReply *QRenderCapture::requestCapture() } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qrendercapture.cpp" diff --git a/src/render/framegraph/qrenderpassfilter.cpp b/src/render/framegraph/qrenderpassfilter.cpp index 378ff63a6..44fa91a02 100644 --- a/src/render/framegraph/qrenderpassfilter.cpp +++ b/src/render/framegraph/qrenderpassfilter.cpp @@ -211,3 +211,5 @@ QList<QParameter *> QRenderPassFilter::parameters() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrenderpassfilter.cpp" diff --git a/src/render/framegraph/qrenderstateset.cpp b/src/render/framegraph/qrenderstateset.cpp index 6e8700695..ba499f919 100644 --- a/src/render/framegraph/qrenderstateset.cpp +++ b/src/render/framegraph/qrenderstateset.cpp @@ -221,3 +221,5 @@ QList<QRenderState *> QRenderStateSet::renderStates() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrenderstateset.cpp" diff --git a/src/render/framegraph/qrendersurfaceselector.cpp b/src/render/framegraph/qrendersurfaceselector.cpp index 3b8eb0ae8..c0d0fb8aa 100644 --- a/src/render/framegraph/qrendersurfaceselector.cpp +++ b/src/render/framegraph/qrendersurfaceselector.cpp @@ -256,7 +256,7 @@ void QRenderSurfaceSelector::setSurface(QObject *surfaceObject) d->m_heightConn = QObject::connect(window, &QWindow::heightChanged, [=] (int) { d->update(); }); - d->m_screenConn = QObject::connect(window, &QWindow::screenChanged, [=] (QScreen *screen) { + d->m_screenConn = QObject::connect(window, &QWindow::screenChanged, [this] (QScreen *screen) { if (screen && !qFuzzyCompare(surfacePixelRatio(), float(screen->devicePixelRatio()))) setSurfacePixelRatio(float(screen->devicePixelRatio())); }); @@ -317,3 +317,5 @@ void QRenderSurfaceSelector::setExternalRenderTargetSize(const QSize &size) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrendersurfaceselector.cpp" diff --git a/src/render/framegraph/qrendertargetselector.cpp b/src/render/framegraph/qrendertargetselector.cpp index 5004df234..9f38602d7 100644 --- a/src/render/framegraph/qrendertargetselector.cpp +++ b/src/render/framegraph/qrendertargetselector.cpp @@ -137,3 +137,5 @@ QRenderTargetSelector::QRenderTargetSelector(QRenderTargetSelectorPrivate &dd, Q } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrendertargetselector.cpp" diff --git a/src/render/framegraph/qsetfence.cpp b/src/render/framegraph/qsetfence.cpp index ae25ba80f..1583c30e9 100644 --- a/src/render/framegraph/qsetfence.cpp +++ b/src/render/framegraph/qsetfence.cpp @@ -151,3 +151,5 @@ void QSetFencePrivate::setHandle(QVariant handle) } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qsetfence.cpp" diff --git a/src/render/framegraph/qsortpolicy.cpp b/src/render/framegraph/qsortpolicy.cpp index d3d7fe58f..0d4e65474 100644 --- a/src/render/framegraph/qsortpolicy.cpp +++ b/src/render/framegraph/qsortpolicy.cpp @@ -189,3 +189,5 @@ void QSortPolicy::setSortTypes(const QList<int> &sortTypesInt) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qsortpolicy.cpp" diff --git a/src/render/framegraph/qsubtreeenabler.cpp b/src/render/framegraph/qsubtreeenabler.cpp index d37cc37e8..422aa8eb2 100644 --- a/src/render/framegraph/qsubtreeenabler.cpp +++ b/src/render/framegraph/qsubtreeenabler.cpp @@ -173,3 +173,5 @@ void QSubtreeEnabler::requestUpdate() } //Qt3DRender QT_END_NAMESPACE + +#include "moc_qsubtreeenabler.cpp" diff --git a/src/render/framegraph/qtechniquefilter.cpp b/src/render/framegraph/qtechniquefilter.cpp index 8bcc8af0f..02a6b8e11 100644 --- a/src/render/framegraph/qtechniquefilter.cpp +++ b/src/render/framegraph/qtechniquefilter.cpp @@ -213,3 +213,5 @@ QList<QParameter *> QTechniqueFilter::parameters() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qtechniquefilter.cpp" diff --git a/src/render/framegraph/qviewport.cpp b/src/render/framegraph/qviewport.cpp index fa04c647a..41077af2d 100644 --- a/src/render/framegraph/qviewport.cpp +++ b/src/render/framegraph/qviewport.cpp @@ -86,7 +86,7 @@ QViewportPrivate::QViewportPrivate() */ /*! - \qmlproperty rect Viewport::gamma + \qmlproperty real Viewport::gamma Specifies the gamma factor for the viewport. The default is 2.2 which should give proper result on most screens. */ @@ -156,3 +156,5 @@ void QViewport::setGamma(float gamma) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qviewport.cpp" diff --git a/src/render/framegraph/qwaitfence.cpp b/src/render/framegraph/qwaitfence.cpp index 4cd1bea61..e626b17d3 100644 --- a/src/render/framegraph/qwaitfence.cpp +++ b/src/render/framegraph/qwaitfence.cpp @@ -204,3 +204,5 @@ void QWaitFence::setHandle(QVariant handle) } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qwaitfence.cpp" diff --git a/src/render/frontend/qcamera.cpp b/src/render/frontend/qcamera.cpp index 4d4e5bf4d..c721ee728 100644 --- a/src/render/frontend/qcamera.cpp +++ b/src/render/frontend/qcamera.cpp @@ -1127,3 +1127,5 @@ QMatrix4x4 QCamera::viewMatrix() const } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qcamera.cpp" diff --git a/src/render/frontend/qcameralens.cpp b/src/render/frontend/qcameralens.cpp index a7b1d8be6..4669c17aa 100644 --- a/src/render/frontend/qcameralens.cpp +++ b/src/render/frontend/qcameralens.cpp @@ -620,3 +620,5 @@ float QCameraLens::exposure() const } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qcameralens.cpp" diff --git a/src/render/frontend/qcomputecommand.cpp b/src/render/frontend/qcomputecommand.cpp index 9dda7f596..e2db004eb 100644 --- a/src/render/frontend/qcomputecommand.cpp +++ b/src/render/frontend/qcomputecommand.cpp @@ -279,3 +279,5 @@ void QComputeCommand::trigger(int workGroupX, int workGroupY, int workGroupZ, in } // Render QT_END_NAMESPACE + +#include "moc_qcomputecommand.cpp" diff --git a/src/render/frontend/qlayer.cpp b/src/render/frontend/qlayer.cpp index 61fdbf4b3..c8b1d3007 100644 --- a/src/render/frontend/qlayer.cpp +++ b/src/render/frontend/qlayer.cpp @@ -190,3 +190,5 @@ QLayer::QLayer(QLayerPrivate &dd, QNode *parent) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qlayer.cpp" diff --git a/src/render/frontend/qlevelofdetailboundingsphere.cpp b/src/render/frontend/qlevelofdetailboundingsphere.cpp index 8354365d8..ce9688e38 100644 --- a/src/render/frontend/qlevelofdetailboundingsphere.cpp +++ b/src/render/frontend/qlevelofdetailboundingsphere.cpp @@ -155,3 +155,5 @@ bool QLevelOfDetailBoundingSphere::operator !=(const QLevelOfDetailBoundingSpher } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qlevelofdetailboundingsphere.cpp" diff --git a/src/render/frontend/qlevelofdetailswitch.cpp b/src/render/frontend/qlevelofdetailswitch.cpp index c0bbdc0f8..5220eb006 100644 --- a/src/render/frontend/qlevelofdetailswitch.cpp +++ b/src/render/frontend/qlevelofdetailswitch.cpp @@ -136,3 +136,5 @@ QLevelOfDetailSwitch::QLevelOfDetailSwitch(QLevelOfDetailPrivate &dd, QNode *par } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qlevelofdetailswitch.cpp" diff --git a/src/render/frontend/qpickingsettings.cpp b/src/render/frontend/qpickingsettings.cpp index 0c858aef2..e176f0329 100644 --- a/src/render/frontend/qpickingsettings.cpp +++ b/src/render/frontend/qpickingsettings.cpp @@ -308,3 +308,5 @@ void QPickingSettings::setWorldSpaceTolerance(float worldSpaceTolerance) } // namespace Qt3Drender QT_END_NAMESPACE + +#include "moc_qpickingsettings.cpp" diff --git a/src/render/frontend/qrenderaspect.cpp b/src/render/frontend/qrenderaspect.cpp index 2bc31506f..0c0851a97 100644 --- a/src/render/frontend/qrenderaspect.cpp +++ b/src/render/frontend/qrenderaspect.cpp @@ -1010,3 +1010,5 @@ void QRenderAspectPrivate::configurePlugin(const QString &plugin) QT_END_NAMESPACE QT3D_REGISTER_NAMESPACED_ASPECT("render", QT_PREPEND_NAMESPACE(Qt3DRender), QRenderAspect) + +#include "moc_qrenderaspect.cpp" diff --git a/src/render/frontend/qrendercapabilities.cpp b/src/render/frontend/qrendercapabilities.cpp index afe5d04a8..f1b8dfefb 100644 --- a/src/render/frontend/qrendercapabilities.cpp +++ b/src/render/frontend/qrendercapabilities.cpp @@ -876,3 +876,5 @@ int QRenderCapabilities::maxComputeSharedMemorySize() const } // namespace Qt3Drender QT_END_NAMESPACE + +#include "moc_qrendercapabilities.cpp" diff --git a/src/render/frontend/qrenderpluginfactoryif.cpp b/src/render/frontend/qrenderpluginfactoryif.cpp index 2bdd39090..00620fcf5 100644 --- a/src/render/frontend/qrenderpluginfactoryif.cpp +++ b/src/render/frontend/qrenderpluginfactoryif.cpp @@ -66,3 +66,5 @@ QRenderPlugin *QRenderPluginFactoryIf::create(const QString &key, const QStringL } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrenderpluginfactoryif_p.cpp" diff --git a/src/render/frontend/qrendertarget.cpp b/src/render/frontend/qrendertarget.cpp index 1abc0fca6..65f0fc005 100644 --- a/src/render/frontend/qrendertarget.cpp +++ b/src/render/frontend/qrendertarget.cpp @@ -153,3 +153,5 @@ QList<QRenderTargetOutput *> QRenderTarget::outputs() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrendertarget.cpp" diff --git a/src/render/frontend/qrendertargetoutput.cpp b/src/render/frontend/qrendertargetoutput.cpp index 9d6600233..f5f811503 100644 --- a/src/render/frontend/qrendertargetoutput.cpp +++ b/src/render/frontend/qrendertargetoutput.cpp @@ -303,3 +303,5 @@ QAbstractTexture::CubeMapFace QRenderTargetOutput::face() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrendertargetoutput.cpp" diff --git a/src/render/geometry/gltfskeletonloader.cpp b/src/render/geometry/gltfskeletonloader.cpp index b006d76b2..b60977dc2 100644 --- a/src/render/geometry/gltfskeletonloader.cpp +++ b/src/render/geometry/gltfskeletonloader.cpp @@ -560,7 +560,7 @@ void GLTFSkeletonLoader::setupNodeParentLinks() const Node &node = m_nodes[i]; const std::vector<int> &childNodeIndices = node.childNodeIndices; for (const auto childNodeIndex : childNodeIndices) { - Q_ASSERT(childNodeIndex < m_nodes.size()); + Q_ASSERT(childNodeIndex < int(m_nodes.size())); Node &childNode = m_nodes[size_t(childNodeIndex)]; Q_ASSERT(childNode.parentNodeIndex == -1); childNode.parentNodeIndex = int(i); diff --git a/src/render/geometry/qgeometryrenderer.cpp b/src/render/geometry/qgeometryrenderer.cpp index 036235624..ea7e47abd 100644 --- a/src/render/geometry/qgeometryrenderer.cpp +++ b/src/render/geometry/qgeometryrenderer.cpp @@ -254,6 +254,7 @@ void QGeometryRendererPrivate::setView(QGeometryView *view) QGeometryRenderer::QGeometryRenderer(QNode *parent) : Qt3DCore::QBoundingVolume(*new QGeometryRendererPrivate(), parent) { + Q_UNUSED(m_sortIndex) } /*! @@ -555,3 +556,5 @@ void QGeometryRenderer::setSortIndex(float sortIndex) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qgeometryrenderer.cpp" diff --git a/src/render/geometry/qgeometryrenderer.h b/src/render/geometry/qgeometryrenderer.h index c0e14eaaf..65eba247e 100644 --- a/src/render/geometry/qgeometryrenderer.h +++ b/src/render/geometry/qgeometryrenderer.h @@ -136,7 +136,7 @@ protected: private: Q_DECLARE_PRIVATE(QGeometryRenderer) - float m_sortIndex; + float m_sortIndex; // TODO Remove in Qt 7 }; } // namespace Qt3DRender diff --git a/src/render/geometry/qmesh.cpp b/src/render/geometry/qmesh.cpp index 9bcad868d..ae017b51d 100644 --- a/src/render/geometry/qmesh.cpp +++ b/src/render/geometry/qmesh.cpp @@ -442,3 +442,5 @@ void MeshDownloadRequest::onCompleted() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qmesh.cpp" diff --git a/src/render/geometry/qpickingproxy.cpp b/src/render/geometry/qpickingproxy.cpp index d9c2d264e..0427170af 100644 --- a/src/render/geometry/qpickingproxy.cpp +++ b/src/render/geometry/qpickingproxy.cpp @@ -154,3 +154,5 @@ QPickingProxy::QPickingProxy(QPickingProxyPrivate &dd, QNode *parent) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qpickingproxy.cpp" diff --git a/src/render/io/qgeometryloaderfactory.cpp b/src/render/io/qgeometryloaderfactory.cpp index c34469dc1..d33fa8ae3 100644 --- a/src/render/io/qgeometryloaderfactory.cpp +++ b/src/render/io/qgeometryloaderfactory.cpp @@ -56,3 +56,5 @@ QGeometryLoaderFactory::~QGeometryLoaderFactory() QT_END_NAMESPACE +#include "moc_qgeometryloaderfactory_p.cpp" + diff --git a/src/render/io/qsceneexporter.cpp b/src/render/io/qsceneexporter.cpp index 71a0120c0..fcc9f93c0 100644 --- a/src/render/io/qsceneexporter.cpp +++ b/src/render/io/qsceneexporter.cpp @@ -72,3 +72,5 @@ void QSceneExporter::logInfo(const QString &info) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qsceneexporter_p.cpp" diff --git a/src/render/io/qsceneexportplugin.cpp b/src/render/io/qsceneexportplugin.cpp index 9ba2a6298..fa0232aef 100644 --- a/src/render/io/qsceneexportplugin.cpp +++ b/src/render/io/qsceneexportplugin.cpp @@ -64,3 +64,5 @@ QSceneExporter *QSceneExportPlugin::create(const QString &key, const QStringList QT_END_NAMESPACE +#include "moc_qsceneexportplugin_p.cpp" + diff --git a/src/render/io/qsceneimporter.cpp b/src/render/io/qsceneimporter.cpp index f58a435eb..8c8633eea 100644 --- a/src/render/io/qsceneimporter.cpp +++ b/src/render/io/qsceneimporter.cpp @@ -86,3 +86,5 @@ void QSceneImporter::logInfo(const QString &info) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qsceneimporter_p.cpp" diff --git a/src/render/io/qsceneimportplugin.cpp b/src/render/io/qsceneimportplugin.cpp index 8cafdd25a..37b2a7f07 100644 --- a/src/render/io/qsceneimportplugin.cpp +++ b/src/render/io/qsceneimportplugin.cpp @@ -64,3 +64,5 @@ QSceneImporter *QSceneImportPlugin::create(const QString &key, const QStringList QT_END_NAMESPACE +#include "moc_qsceneimportplugin_p.cpp" + diff --git a/src/render/io/qsceneloader.cpp b/src/render/io/qsceneloader.cpp index 5dd690b49..cbbda235d 100644 --- a/src/render/io/qsceneloader.cpp +++ b/src/render/io/qsceneloader.cpp @@ -373,3 +373,5 @@ QComponent *QSceneLoader::component(const QString &entityName, } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qsceneloader.cpp" diff --git a/src/render/jobs/pickboundingvolumejob.cpp b/src/render/jobs/pickboundingvolumejob.cpp index c3e3cb9bf..5ec6dbb39 100644 --- a/src/render/jobs/pickboundingvolumejob.cpp +++ b/src/render/jobs/pickboundingvolumejob.cpp @@ -416,7 +416,7 @@ void PickBoundingVolumeJob::dispatchPickEvents(const QMouseEvent *event, // Send the corresponding event Vector3D localIntersection = hit.m_intersection; if (entity && entity->worldTransform()) - localIntersection = entity->worldTransform()->inverted() * hit.m_intersection; + localIntersection = entity->worldTransform()->inverted().map(hit.m_intersection); QPickEventPtr pickEvent; #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) diff --git a/src/render/jobs/pickboundingvolumeutils.cpp b/src/render/jobs/pickboundingvolumeutils.cpp index 10536c3c2..855cb9ccb 100644 --- a/src/render/jobs/pickboundingvolumeutils.cpp +++ b/src/render/jobs/pickboundingvolumeutils.cpp @@ -209,9 +209,9 @@ private: void TriangleCollisionVisitor::visit(uint andx, const Vector3D &a, uint bndx, const Vector3D &b, uint cndx, const Vector3D &c) { const Matrix4x4 &mat = *m_root->worldTransform(); - const Vector3D tA = mat * a; - const Vector3D tB = mat * b; - const Vector3D tC = mat * c; + const Vector3D tA = mat.map(a); + const Vector3D tB = mat.map(b); + const Vector3D tC = mat.map(c); bool intersected = m_frontFaceRequested && intersectsSegmentTriangle(cndx, tC, bndx, tB, andx, tA); // front facing @@ -273,8 +273,8 @@ private: void LineCollisionVisitor::visit(uint andx, const Vector3D &a, uint bndx, const Vector3D &b) { const Matrix4x4 &mat = *m_root->worldTransform(); - const Vector3D tA = mat * a; - const Vector3D tB = mat * b; + const Vector3D tA = mat.map(a); + const Vector3D tB = mat.map(b); intersectsSegmentSegment(andx, tA, bndx, tB); @@ -398,7 +398,7 @@ private: void PointCollisionVisitor::visit(uint ndx, const Vector3D &p) { const Matrix4x4 &mat = *m_root->worldTransform(); - const Vector3D tP = mat * p; + const Vector3D tP = mat.map(p); Vector3D intersection; float d = pointToRayDistance(tP, intersection); diff --git a/src/render/jobs/raycastingjob.cpp b/src/render/jobs/raycastingjob.cpp index b6ebdad99..8757b68f3 100644 --- a/src/render/jobs/raycastingjob.cpp +++ b/src/render/jobs/raycastingjob.cpp @@ -293,7 +293,7 @@ void RayCastingJob::dispatchHits(RayCaster *rayCaster, const PickingUtils::HitLi Entity *entity = m_manager->renderNodesManager()->lookupResource(sphereHit.m_entityId); Vector3D localIntersection = sphereHit.m_intersection; if (entity && entity->worldTransform()) - localIntersection = entity->worldTransform()->inverted() * localIntersection; + localIntersection = entity->worldTransform()->inverted().map(localIntersection); QRayCasterHit::HitType hitType = QRayCasterHit::EntityHit; switch (sphereHit.m_type) { diff --git a/src/render/jobs/updatelevelofdetailjob.cpp b/src/render/jobs/updatelevelofdetailjob.cpp index b5033a6b7..d4f09cb01 100644 --- a/src/render/jobs/updatelevelofdetailjob.cpp +++ b/src/render/jobs/updatelevelofdetailjob.cpp @@ -120,13 +120,13 @@ private: const QList<qreal> thresholds = lod->thresholds(); Vector3D center(lod->center()); if (lod->hasBoundingVolumeOverride() || entity->worldBoundingVolume() == nullptr) { - center = *entity->worldTransform() * center; + center = entity->worldTransform()->map(center); } else { center = entity->worldBoundingVolume()->center(); } - const Vector3D tcenter = viewMatrix * center; - const float dist = tcenter.length(); + const Vector3D tcenter = viewMatrix.map(center); + const double dist = double(tcenter.length()); const int n = thresholds.size(); for (int i=0; i<n; ++i) { if (dist <= thresholds[i] || i == n -1) { @@ -171,7 +171,7 @@ private: float area = vca.viewport.width() * sideLength * vca.viewport.height() * sideLength; const QRect r = windowViewport(vca.area, vca.viewport); - area = std::sqrt(area * r.width() * r.height()); + area = std::sqrt(area * float(r.width()) * float(r.height())); const int n = thresholds.size(); for (int i = 0; i < n; ++i) { diff --git a/src/render/lights/qabstractlight.cpp b/src/render/lights/qabstractlight.cpp index 83ac9e28b..3a8df3df0 100644 --- a/src/render/lights/qabstractlight.cpp +++ b/src/render/lights/qabstractlight.cpp @@ -175,3 +175,5 @@ void QAbstractLight::setIntensity(float value) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qabstractlight.cpp" diff --git a/src/render/lights/qdirectionallight.cpp b/src/render/lights/qdirectionallight.cpp index 51827b644..1ab43704c 100644 --- a/src/render/lights/qdirectionallight.cpp +++ b/src/render/lights/qdirectionallight.cpp @@ -146,3 +146,5 @@ QVector3D QDirectionalLight::worldDirection() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qdirectionallight.cpp" diff --git a/src/render/lights/qpointlight.cpp b/src/render/lights/qpointlight.cpp index c16291709..2a14a2d40 100644 --- a/src/render/lights/qpointlight.cpp +++ b/src/render/lights/qpointlight.cpp @@ -226,3 +226,5 @@ void QPointLight::setQuadraticAttenuation(float value) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qpointlight.cpp" diff --git a/src/render/lights/qspotlight.cpp b/src/render/lights/qspotlight.cpp index c725a6baf..5b650dfe0 100644 --- a/src/render/lights/qspotlight.cpp +++ b/src/render/lights/qspotlight.cpp @@ -292,3 +292,5 @@ void QSpotLight::setCutOffAngle(float value) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qspotlight.cpp" diff --git a/src/render/materialsystem/filterkey.cpp b/src/render/materialsystem/filterkey.cpp index 778a9ee75..572d11e57 100644 --- a/src/render/materialsystem/filterkey.cpp +++ b/src/render/materialsystem/filterkey.cpp @@ -83,7 +83,7 @@ void FilterKey::syncFromFrontEnd(const QNode *frontEnd, bool firstTime) } } -bool FilterKey::operator ==(const FilterKey &other) +bool FilterKey::equals(const FilterKey &other) const { if (&other == this) return true; @@ -101,11 +101,6 @@ bool FilterKey::operator ==(const FilterKey &other) other.value() == value()); } -bool FilterKey::operator !=(const FilterKey &other) -{ - return !operator ==(other); -} - } // namespace Render } // namespace Qt3DRender diff --git a/src/render/materialsystem/filterkey_p.h b/src/render/materialsystem/filterkey_p.h index 91d0ba1f0..1fe6bba7b 100644 --- a/src/render/materialsystem/filterkey_p.h +++ b/src/render/materialsystem/filterkey_p.h @@ -72,10 +72,15 @@ public: const QVariant &value() const { return m_value; } const QString &name() const { return m_name; } void syncFromFrontEnd(const Qt3DCore::QNode *frontEnd, bool firstTime) override; - bool operator ==(const FilterKey &other); - bool operator !=(const FilterKey &other); + + friend bool operator==(const FilterKey &lhs, const FilterKey &rhs) + { return lhs.equals(rhs); } + friend bool operator !=(const FilterKey &lhs, const FilterKey &rhs) + { return !lhs.equals(rhs); } private: + bool equals(const FilterKey &other) const; + QVariant m_value; QString m_name; }; diff --git a/src/render/materialsystem/qeffect.cpp b/src/render/materialsystem/qeffect.cpp index 2baeb4512..ebed36dd5 100644 --- a/src/render/materialsystem/qeffect.cpp +++ b/src/render/materialsystem/qeffect.cpp @@ -121,7 +121,7 @@ QEffectPrivate::QEffectPrivate() Effect { id: effect - technique: [ + techniques: [ Technique { id: gl3Technique graphicsApiFilter { @@ -270,3 +270,5 @@ QList<QTechnique *> QEffect::techniques() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qeffect.cpp" diff --git a/src/render/materialsystem/qfilterkey.cpp b/src/render/materialsystem/qfilterkey.cpp index a98dc2b4f..981e66521 100644 --- a/src/render/materialsystem/qfilterkey.cpp +++ b/src/render/materialsystem/qfilterkey.cpp @@ -145,3 +145,5 @@ QString QFilterKey::name() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qfilterkey.cpp" diff --git a/src/render/materialsystem/qgraphicsapifilter.cpp b/src/render/materialsystem/qgraphicsapifilter.cpp index ae85af6b2..9d998efcc 100644 --- a/src/render/materialsystem/qgraphicsapifilter.cpp +++ b/src/render/materialsystem/qgraphicsapifilter.cpp @@ -373,3 +373,5 @@ bool operator !=(const QGraphicsApiFilter &reference, const QGraphicsApiFilter & } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qgraphicsapifilter.cpp" diff --git a/src/render/materialsystem/qmaterial.cpp b/src/render/materialsystem/qmaterial.cpp index 7111dba23..8c85d7293 100644 --- a/src/render/materialsystem/qmaterial.cpp +++ b/src/render/materialsystem/qmaterial.cpp @@ -73,7 +73,7 @@ Effect { id: effect - technique: [ + techniques: [ Technique { id: gl3Technique graphicsApiFilter { @@ -302,3 +302,5 @@ QList<QParameter *> QMaterial::parameters() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qmaterial.cpp" diff --git a/src/render/materialsystem/qparameter.cpp b/src/render/materialsystem/qparameter.cpp index fc74155dc..14d67be8f 100644 --- a/src/render/materialsystem/qparameter.cpp +++ b/src/render/materialsystem/qparameter.cpp @@ -326,3 +326,5 @@ QVariant QParameter::value() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qparameter.cpp" diff --git a/src/render/materialsystem/qrenderpass.cpp b/src/render/materialsystem/qrenderpass.cpp index 282324915..242c070ae 100644 --- a/src/render/materialsystem/qrenderpass.cpp +++ b/src/render/materialsystem/qrenderpass.cpp @@ -401,3 +401,5 @@ ParameterList QRenderPass::parameters() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrenderpass.cpp" diff --git a/src/render/materialsystem/qshaderdata.cpp b/src/render/materialsystem/qshaderdata.cpp index 34aee02fb..1620b3578 100644 --- a/src/render/materialsystem/qshaderdata.cpp +++ b/src/render/materialsystem/qshaderdata.cpp @@ -134,3 +134,5 @@ bool QShaderData::event(QEvent *event) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qshaderdata.cpp" diff --git a/src/render/materialsystem/qshaderimage.cpp b/src/render/materialsystem/qshaderimage.cpp index d8bcb41ac..f34732a0d 100644 --- a/src/render/materialsystem/qshaderimage.cpp +++ b/src/render/materialsystem/qshaderimage.cpp @@ -974,3 +974,5 @@ void QShaderImage::setFormat(QShaderImage::ImageFormat format) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qshaderimage.cpp" diff --git a/src/render/materialsystem/qshaderprogram.cpp b/src/render/materialsystem/qshaderprogram.cpp index a43ddba9e..21c7303b6 100644 --- a/src/render/materialsystem/qshaderprogram.cpp +++ b/src/render/materialsystem/qshaderprogram.cpp @@ -974,3 +974,5 @@ QByteArray QShaderProgram::loadSource(const QUrl &sourceUrl) } // of namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qshaderprogram.cpp" diff --git a/src/render/materialsystem/qshaderprogrambuilder.cpp b/src/render/materialsystem/qshaderprogrambuilder.cpp index ed08af56f..75827df36 100644 --- a/src/render/materialsystem/qshaderprogrambuilder.cpp +++ b/src/render/materialsystem/qshaderprogrambuilder.cpp @@ -493,3 +493,5 @@ QByteArray QShaderProgramBuilder::computeShaderCode() const } // of namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qshaderprogrambuilder.cpp" diff --git a/src/render/materialsystem/shaderdata.cpp b/src/render/materialsystem/shaderdata.cpp index f5e194697..30ea64752 100644 --- a/src/render/materialsystem/shaderdata.cpp +++ b/src/render/materialsystem/shaderdata.cpp @@ -224,9 +224,9 @@ QVariant ShaderData::getTransformedProperty(const PropertyValue *v, const Matrix const TransformType transformType = static_cast<TransformType>(transformedValue.value.toInt()); switch (transformType) { case ModelToEye: - return QVariant::fromValue(viewMatrix * m_worldMatrix * Vector3D(v->value.value<QVector3D>())); + return QVariant::fromValue(viewMatrix.map(m_worldMatrix.map(Vector3D(v->value.value<QVector3D>())))); case ModelToWorld: - return QVariant::fromValue(m_worldMatrix * Vector3D(v->value.value<QVector3D>())); + return QVariant::fromValue(m_worldMatrix.map(Vector3D(v->value.value<QVector3D>()))); case ModelToWorldDirection: return QVariant::fromValue(Vector3D(m_worldMatrix * Vector4D(v->value.value<QVector3D>(), 0.0f))); case NoTransform: diff --git a/src/render/picking/pickeventfilter.cpp b/src/render/picking/pickeventfilter.cpp index a41ed6c1e..73afafa01 100644 --- a/src/render/picking/pickeventfilter.cpp +++ b/src/render/picking/pickeventfilter.cpp @@ -74,6 +74,7 @@ bool PickEventFilter::eventFilter(QObject *obj, QEvent *e) auto mouseEvent = QMouseEvent(QEvent::MouseMove, #if QT_VERSION >= QT_VERSION_CHECK(6, 0, 0) he->position(), + he->globalPosition(), #else he->pos(), #endif @@ -96,3 +97,5 @@ bool PickEventFilter::eventFilter(QObject *obj, QEvent *e) } // Qt3DRender QT_END_NAMESPACE + +#include "moc_pickeventfilter_p.cpp" diff --git a/src/render/picking/qabstractraycaster.cpp b/src/render/picking/qabstractraycaster.cpp index 473a0d3e3..568ba59ff 100644 --- a/src/render/picking/qabstractraycaster.cpp +++ b/src/render/picking/qabstractraycaster.cpp @@ -386,3 +386,5 @@ QList<QLayer *> QAbstractRayCaster::layers() const } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qabstractraycaster.cpp" diff --git a/src/render/picking/qobjectpicker.cpp b/src/render/picking/qobjectpicker.cpp index 498b0d97a..8f00d2c4d 100644 --- a/src/render/picking/qobjectpicker.cpp +++ b/src/render/picking/qobjectpicker.cpp @@ -124,14 +124,6 @@ namespace Qt3DRender { */ /*! - \qmlsignal Qt3D.Render::ObjectPicker::clicked(PickEvent pick) - - This signal is emitted when the bounding volume defined by the pickAttribute - property intersects with a ray on a mouse click the PickEvent \a pick contains - details of the event. -*/ - -/*! \qmlsignal Qt3D.Render::ObjectPicker::pressed(PickEvent pick) This signal is emitted when the bounding volume defined by the @@ -476,3 +468,5 @@ void QObjectPickerPrivate::releasedEvent(QPickEvent *event) } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qobjectpicker.cpp" diff --git a/src/render/picking/qpickevent.cpp b/src/render/picking/qpickevent.cpp index ae5748082..180925faf 100644 --- a/src/render/picking/qpickevent.cpp +++ b/src/render/picking/qpickevent.cpp @@ -353,3 +353,5 @@ Qt3DCore::QEntity *QPickEvent::entity() const QT_END_NAMESPACE +#include "moc_qpickevent.cpp" + diff --git a/src/render/picking/qpicklineevent.cpp b/src/render/picking/qpicklineevent.cpp index a079fb557..50b8e7803 100644 --- a/src/render/picking/qpicklineevent.cpp +++ b/src/render/picking/qpicklineevent.cpp @@ -171,3 +171,5 @@ uint QPickLineEvent::vertex2Index() const QT_END_NAMESPACE +#include "moc_qpicklineevent.cpp" + diff --git a/src/render/picking/qpickpointevent.cpp b/src/render/picking/qpickpointevent.cpp index 2e035d3f2..76680ff92 100644 --- a/src/render/picking/qpickpointevent.cpp +++ b/src/render/picking/qpickpointevent.cpp @@ -129,3 +129,5 @@ uint QPickPointEvent::pointIndex() const QT_END_NAMESPACE +#include "moc_qpickpointevent.cpp" + diff --git a/src/render/picking/qpicktriangleevent.cpp b/src/render/picking/qpicktriangleevent.cpp index b33c7c0dd..e5ae699b6 100644 --- a/src/render/picking/qpicktriangleevent.cpp +++ b/src/render/picking/qpicktriangleevent.cpp @@ -273,3 +273,5 @@ QVector3D QPickTriangleEvent::uvw() const QT_END_NAMESPACE +#include "moc_qpicktriangleevent.cpp" + diff --git a/src/render/picking/qraycaster.cpp b/src/render/picking/qraycaster.cpp index 1f418b4c8..c31a8f1b6 100644 --- a/src/render/picking/qraycaster.cpp +++ b/src/render/picking/qraycaster.cpp @@ -216,3 +216,5 @@ QAbstractRayCaster::Hits QRayCaster::pick(const QVector3D &origin, const QVector } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qraycaster.cpp" diff --git a/src/render/picking/qraycasterhit.cpp b/src/render/picking/qraycasterhit.cpp index 86a6a1052..8c9089508 100644 --- a/src/render/picking/qraycasterhit.cpp +++ b/src/render/picking/qraycasterhit.cpp @@ -267,3 +267,5 @@ void QRayCasterHit::setEntity(Qt3DCore::QEntity *entity) const } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qraycasterhit.cpp" diff --git a/src/render/picking/qscreenraycaster.cpp b/src/render/picking/qscreenraycaster.cpp index a8535187f..cfd4ed400 100644 --- a/src/render/picking/qscreenraycaster.cpp +++ b/src/render/picking/qscreenraycaster.cpp @@ -151,3 +151,5 @@ QAbstractRayCaster::Hits QScreenRayCaster::pick(const QPoint &position) } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qscreenraycaster.cpp" diff --git a/src/render/qrendererplugin.cpp b/src/render/qrendererplugin.cpp index edd4b1bf0..a267ff8f3 100644 --- a/src/render/qrendererplugin.cpp +++ b/src/render/qrendererplugin.cpp @@ -65,3 +65,5 @@ AbstractRenderer *QRendererPlugin::create(const QString &key) } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qrendererplugin_p.cpp" diff --git a/src/render/raycasting/qabstractcollisionqueryservice.cpp b/src/render/raycasting/qabstractcollisionqueryservice.cpp index 5148df911..852c11794 100644 --- a/src/render/raycasting/qabstractcollisionqueryservice.cpp +++ b/src/render/raycasting/qabstractcollisionqueryservice.cpp @@ -72,3 +72,5 @@ void QAbstractCollisionQueryService::addEntityHit(QCollisionQueryResult &result, } // Qt3DRender QT_END_NAMESPACE + +#include "moc_qabstractcollisionqueryservice_p.cpp" diff --git a/src/render/raycasting/qray3d.cpp b/src/render/raycasting/qray3d.cpp index 18dd9a40a..0d3f839f6 100644 --- a/src/render/raycasting/qray3d.cpp +++ b/src/render/raycasting/qray3d.cpp @@ -177,7 +177,7 @@ Vector3D QRay3D::point(float t) const QRay3D &QRay3D::transform(const Matrix4x4 &matrix) { - m_origin = matrix * m_origin; + m_origin = matrix.map(m_origin); m_direction = matrix.mapVector(m_direction).normalized(); return *this; @@ -185,7 +185,7 @@ QRay3D &QRay3D::transform(const Matrix4x4 &matrix) QRay3D QRay3D::transformed(const Matrix4x4 &matrix) const { - return QRay3D(matrix * m_origin, matrix.mapVector(m_direction).normalized()); + return QRay3D(matrix.map(m_origin), matrix.mapVector(m_direction).normalized()); } bool QRay3D::operator==(const QRay3D &other) const diff --git a/src/render/renderstates/qalphacoverage.cpp b/src/render/renderstates/qalphacoverage.cpp index 785e79057..6b372860f 100644 --- a/src/render/renderstates/qalphacoverage.cpp +++ b/src/render/renderstates/qalphacoverage.cpp @@ -161,3 +161,5 @@ QAlphaCoverage::~QAlphaCoverage() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qalphacoverage.cpp" diff --git a/src/render/renderstates/qalphatest.cpp b/src/render/renderstates/qalphatest.cpp index ebc455111..111e8addf 100644 --- a/src/render/renderstates/qalphatest.cpp +++ b/src/render/renderstates/qalphatest.cpp @@ -162,3 +162,5 @@ void QAlphaTest::setReferenceValue(float referenceValue) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qalphatest.cpp" diff --git a/src/render/renderstates/qblendequation.cpp b/src/render/renderstates/qblendequation.cpp index de7cb4a25..af0d7d37f 100644 --- a/src/render/renderstates/qblendequation.cpp +++ b/src/render/renderstates/qblendequation.cpp @@ -124,3 +124,5 @@ void QBlendEquation::setBlendFunction(QBlendEquation::BlendFunction blendFunctio } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qblendequation.cpp" diff --git a/src/render/renderstates/qblendequationarguments.cpp b/src/render/renderstates/qblendequationarguments.cpp index 0e8b5d9aa..8a4ce8262 100644 --- a/src/render/renderstates/qblendequationarguments.cpp +++ b/src/render/renderstates/qblendequationarguments.cpp @@ -206,7 +206,7 @@ void QBlendEquationArguments::setSourceAlpha(QBlendEquationArguments::Blending s } /*! - \qmlproperty enumeration BlendEquationArguments::DestinationAlpha + \qmlproperty enumeration BlendEquationArguments::destinationAlpha */ @@ -293,3 +293,5 @@ void QBlendEquationArguments::setBufferIndex(int bufferIndex) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qblendequationarguments.cpp" diff --git a/src/render/renderstates/qclipplane.cpp b/src/render/renderstates/qclipplane.cpp index 0771e01d5..b1bd7d765 100644 --- a/src/render/renderstates/qclipplane.cpp +++ b/src/render/renderstates/qclipplane.cpp @@ -166,3 +166,5 @@ void QClipPlane::setDistance(float distance) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qclipplane.cpp" diff --git a/src/render/renderstates/qcolormask.cpp b/src/render/renderstates/qcolormask.cpp index 0e1711671..f1f724b90 100644 --- a/src/render/renderstates/qcolormask.cpp +++ b/src/render/renderstates/qcolormask.cpp @@ -186,3 +186,5 @@ void QColorMask::setAlphaMasked(bool alphaMasked) QT_END_NAMESPACE +#include "moc_qcolormask.cpp" + diff --git a/src/render/renderstates/qcullface.cpp b/src/render/renderstates/qcullface.cpp index b5138e53a..e903af8a3 100644 --- a/src/render/renderstates/qcullface.cpp +++ b/src/render/renderstates/qcullface.cpp @@ -192,3 +192,5 @@ void QCullFace::setMode(QCullFace::CullingMode mode) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qcullface.cpp" diff --git a/src/render/renderstates/qdepthrange.cpp b/src/render/renderstates/qdepthrange.cpp index e2f1c5473..be4647e8b 100644 --- a/src/render/renderstates/qdepthrange.cpp +++ b/src/render/renderstates/qdepthrange.cpp @@ -143,3 +143,5 @@ void QDepthRange::setFarValue(double value) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qdepthrange.cpp" diff --git a/src/render/renderstates/qdepthtest.cpp b/src/render/renderstates/qdepthtest.cpp index 16b7ad588..4e1cac358 100644 --- a/src/render/renderstates/qdepthtest.cpp +++ b/src/render/renderstates/qdepthtest.cpp @@ -148,3 +148,5 @@ void QDepthTest::setDepthFunction(QDepthTest::DepthFunction depthFunction) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qdepthtest.cpp" diff --git a/src/render/renderstates/qdithering.cpp b/src/render/renderstates/qdithering.cpp index a449be508..409e3c9c3 100644 --- a/src/render/renderstates/qdithering.cpp +++ b/src/render/renderstates/qdithering.cpp @@ -99,3 +99,5 @@ QDithering::~QDithering() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qdithering.cpp" diff --git a/src/render/renderstates/qfrontface.cpp b/src/render/renderstates/qfrontface.cpp index b13f901d9..b913e7b1f 100644 --- a/src/render/renderstates/qfrontface.cpp +++ b/src/render/renderstates/qfrontface.cpp @@ -121,3 +121,5 @@ void QFrontFace::setDirection(QFrontFace::WindingDirection direction) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qfrontface.cpp" diff --git a/src/render/renderstates/qlinewidth.cpp b/src/render/renderstates/qlinewidth.cpp index abda5ef62..95ad63914 100644 --- a/src/render/renderstates/qlinewidth.cpp +++ b/src/render/renderstates/qlinewidth.cpp @@ -111,3 +111,5 @@ void QLineWidth::setSmooth(bool enabled) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qlinewidth.cpp" diff --git a/src/render/renderstates/qmultisampleantialiasing.cpp b/src/render/renderstates/qmultisampleantialiasing.cpp index 249dcd4bd..303474fbb 100644 --- a/src/render/renderstates/qmultisampleantialiasing.cpp +++ b/src/render/renderstates/qmultisampleantialiasing.cpp @@ -203,3 +203,5 @@ QMultiSampleAntiAliasing::~QMultiSampleAntiAliasing() QT_END_NAMESPACE +#include "moc_qmultisampleantialiasing.cpp" + diff --git a/src/render/renderstates/qnodepthmask.cpp b/src/render/renderstates/qnodepthmask.cpp index 241751a26..bd1af22f0 100644 --- a/src/render/renderstates/qnodepthmask.cpp +++ b/src/render/renderstates/qnodepthmask.cpp @@ -100,3 +100,5 @@ QNoDepthMask::~QNoDepthMask() } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qnodepthmask.cpp" diff --git a/src/render/renderstates/qpointsize.cpp b/src/render/renderstates/qpointsize.cpp index 7e085c723..1fee39c24 100644 --- a/src/render/renderstates/qpointsize.cpp +++ b/src/render/renderstates/qpointsize.cpp @@ -140,3 +140,5 @@ void QPointSize::setValue(float size) QT_END_NAMESPACE +#include "moc_qpointsize.cpp" + diff --git a/src/render/renderstates/qpolygonoffset.cpp b/src/render/renderstates/qpolygonoffset.cpp index d310c9c01..4b06b4846 100644 --- a/src/render/renderstates/qpolygonoffset.cpp +++ b/src/render/renderstates/qpolygonoffset.cpp @@ -141,3 +141,5 @@ void QPolygonOffset::setDepthSteps(float depthSteps) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qpolygonoffset.cpp" diff --git a/src/render/renderstates/qrastermode.cpp b/src/render/renderstates/qrastermode.cpp index 2ac14470c..b34ac7096 100644 --- a/src/render/renderstates/qrastermode.cpp +++ b/src/render/renderstates/qrastermode.cpp @@ -182,3 +182,5 @@ void QRasterMode::setFaceMode(QRasterMode::FaceMode faceMode) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrastermode.cpp" diff --git a/src/render/renderstates/qrenderstate.cpp b/src/render/renderstates/qrenderstate.cpp index c23c45319..23e887823 100644 --- a/src/render/renderstates/qrenderstate.cpp +++ b/src/render/renderstates/qrenderstate.cpp @@ -107,3 +107,5 @@ QRenderState::QRenderState(QRenderStatePrivate &dd, QNode *parent) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qrenderstate.cpp" diff --git a/src/render/renderstates/qscissortest.cpp b/src/render/renderstates/qscissortest.cpp index ee12d0c71..a8364838a 100644 --- a/src/render/renderstates/qscissortest.cpp +++ b/src/render/renderstates/qscissortest.cpp @@ -190,3 +190,5 @@ void QScissorTest::setHeight(int height) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qscissortest.cpp" diff --git a/src/render/renderstates/qseamlesscubemap.cpp b/src/render/renderstates/qseamlesscubemap.cpp index 8458aded8..b05e4b9ca 100644 --- a/src/render/renderstates/qseamlesscubemap.cpp +++ b/src/render/renderstates/qseamlesscubemap.cpp @@ -97,3 +97,5 @@ QSeamlessCubemap::~QSeamlessCubemap() QT_END_NAMESPACE +#include "moc_qseamlesscubemap.cpp" + diff --git a/src/render/renderstates/qstencilmask.cpp b/src/render/renderstates/qstencilmask.cpp index 9e664ebe2..c1c716920 100644 --- a/src/render/renderstates/qstencilmask.cpp +++ b/src/render/renderstates/qstencilmask.cpp @@ -144,3 +144,5 @@ uint QStencilMask::backOutputMask() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qstencilmask.cpp" diff --git a/src/render/renderstates/qstenciloperation.cpp b/src/render/renderstates/qstenciloperation.cpp index 720de88a9..5405a88aa 100644 --- a/src/render/renderstates/qstenciloperation.cpp +++ b/src/render/renderstates/qstenciloperation.cpp @@ -152,3 +152,5 @@ QStencilOperationArguments *QStencilOperation::back() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qstenciloperation.cpp" diff --git a/src/render/renderstates/qstenciloperationarguments.cpp b/src/render/renderstates/qstenciloperationarguments.cpp index d062203f5..d477f2bac 100644 --- a/src/render/renderstates/qstenciloperationarguments.cpp +++ b/src/render/renderstates/qstenciloperationarguments.cpp @@ -229,3 +229,5 @@ QStencilOperationArguments::Operation QStencilOperationArguments::allTestsPassOp } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qstenciloperationarguments.cpp" diff --git a/src/render/renderstates/qstenciltest.cpp b/src/render/renderstates/qstenciltest.cpp index 200d4461c..f680b5b11 100644 --- a/src/render/renderstates/qstenciltest.cpp +++ b/src/render/renderstates/qstenciltest.cpp @@ -153,3 +153,5 @@ QStencilTestArguments *QStencilTest::back() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qstenciltest.cpp" diff --git a/src/render/renderstates/qstenciltestarguments.cpp b/src/render/renderstates/qstenciltestarguments.cpp index dc8ff7292..9aeb0c5ac 100644 --- a/src/render/renderstates/qstenciltestarguments.cpp +++ b/src/render/renderstates/qstenciltestarguments.cpp @@ -217,3 +217,5 @@ QStencilTestArguments::StencilFaceMode QStencilTestArguments::faceMode() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qstenciltestarguments.cpp" diff --git a/src/render/shadergraph/qshaderlanguage.cpp b/src/render/shadergraph/qshaderlanguage.cpp index 1630e3de8..25c19cb18 100644 --- a/src/render/shadergraph/qshaderlanguage.cpp +++ b/src/render/shadergraph/qshaderlanguage.cpp @@ -55,3 +55,5 @@ void qt_register_ShaderLanguage_enums() } QT_END_NAMESPACE + +#include "moc_qshaderlanguage_p.cpp" diff --git a/src/render/texture/qabstracttexture.cpp b/src/render/texture/qabstracttexture.cpp index 506627105..98e6a3db4 100644 --- a/src/render/texture/qabstracttexture.cpp +++ b/src/render/texture/qabstracttexture.cpp @@ -1125,3 +1125,5 @@ void QAbstractTexture::updateData(const QTextureDataUpdate &update) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qabstracttexture.cpp" diff --git a/src/render/texture/qabstracttextureimage.cpp b/src/render/texture/qabstracttextureimage.cpp index 2d41af8e2..97b60566d 100644 --- a/src/render/texture/qabstracttextureimage.cpp +++ b/src/render/texture/qabstracttextureimage.cpp @@ -274,3 +274,5 @@ QAbstractTextureImage::QAbstractTextureImage(QAbstractTextureImagePrivate &dd, Q } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qabstracttextureimage.cpp" diff --git a/src/render/texture/qpaintedtextureimage.cpp b/src/render/texture/qpaintedtextureimage.cpp index a741205af..147f6c4c4 100644 --- a/src/render/texture/qpaintedtextureimage.cpp +++ b/src/render/texture/qpaintedtextureimage.cpp @@ -264,3 +264,5 @@ bool QPaintedTextureImageDataGenerator::operator ==(const QTextureImageDataGener QT_END_NAMESPACE +#include "moc_qpaintedtextureimage.cpp" + diff --git a/src/render/texture/qtexture.cpp b/src/render/texture/qtexture.cpp index 10e6c327e..b91398168 100644 --- a/src/render/texture/qtexture.cpp +++ b/src/render/texture/qtexture.cpp @@ -1514,8 +1514,8 @@ QTextureLoader::QTextureLoader(QNode *parent) // Regenerate the texture functor when properties we support overriding // from QAbstractTexture get changed. - Q_D(QTextureLoader); - auto regenerate = [=] () { + auto regenerate = [this] () { + Q_D(QTextureLoader); if (!notificationsBlocked()) // check the change doesn't come from the backend d->updateGenerator(); }; @@ -1775,3 +1775,5 @@ void QSharedGLTexture::setTextureId(int id) } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qtexture.cpp" diff --git a/src/render/texture/qtexturedataupdate.h b/src/render/texture/qtexturedataupdate.h index f222fd6ec..69715888f 100644 --- a/src/render/texture/qtexturedataupdate.h +++ b/src/render/texture/qtexturedataupdate.h @@ -65,7 +65,7 @@ public: { swap(other); return *this; } ~QTextureDataUpdate(); - void swap(QTextureDataUpdate &other) noexcept { qSwap(d_ptr, other.d_ptr); } + void swap(QTextureDataUpdate &other) noexcept { d_ptr.swap(other.d_ptr); } int x() const; int y() const; diff --git a/src/render/texture/qtextureimage.cpp b/src/render/texture/qtextureimage.cpp index c2d2308af..3f2f892e4 100644 --- a/src/render/texture/qtextureimage.cpp +++ b/src/render/texture/qtextureimage.cpp @@ -319,3 +319,5 @@ bool QImageTextureDataFunctor::isMirrored() const QT_END_NAMESPACE +#include "moc_qtextureimage.cpp" + diff --git a/src/render/texture/qtexturewrapmode.cpp b/src/render/texture/qtexturewrapmode.cpp index cb9272895..18a7f78a1 100644 --- a/src/render/texture/qtexturewrapmode.cpp +++ b/src/render/texture/qtexturewrapmode.cpp @@ -182,3 +182,5 @@ QTextureWrapMode::WrapMode QTextureWrapMode::z() const } // namespace Qt3DRender QT_END_NAMESPACE + +#include "moc_qtexturewrapmode.cpp" diff --git a/tests/auto/core/common/qbackendnodetester.cpp b/tests/auto/core/common/qbackendnodetester.cpp index 0f13b481f..fe752adba 100644 --- a/tests/auto/core/common/qbackendnodetester.cpp +++ b/tests/auto/core/common/qbackendnodetester.cpp @@ -58,3 +58,5 @@ void QBackendNodeTester::setPeerId(QBackendNode *backend, QNodeId id) } // namespace Qt3DCore QT_END_NAMESPACE + +#include "moc_qbackendnodetester.cpp" diff --git a/tests/auto/core/matrix4x4_sse/tst_matrix4x4_sse.cpp b/tests/auto/core/matrix4x4_sse/tst_matrix4x4_sse.cpp index a9000a18a..facde2855 100644 --- a/tests/auto/core/matrix4x4_sse/tst_matrix4x4_sse.cpp +++ b/tests/auto/core/matrix4x4_sse/tst_matrix4x4_sse.cpp @@ -28,6 +28,7 @@ #include <QtTest/QTest> #include <Qt3DCore/private/matrix4x4_sse_p.h> +#include <QVector4D> using namespace Qt3DCore; @@ -351,7 +352,7 @@ private Q_SLOTS: const Vector3D resultingVec = mat * vec3; // THEN - QCOMPARE(resultingVec.toQVector3D(), tmpMat * tmpVec3); + QCOMPARE(resultingVec.toQVector3D(), tmpMat.map(tmpVec3)); } void checkVector3DMatrixMultiplication() @@ -369,7 +370,7 @@ private Q_SLOTS: const Vector3D resultingVec = vec3 * mat; // THEN - QCOMPARE(resultingVec.toQVector3D(), tmpVec3 * tmpMat); + QCOMPARE(resultingVec.toQVector3D(), (QVector4D(tmpVec3, 1.f) * tmpMat).toVector3DAffine()); } void checkRows() diff --git a/tests/auto/core/nodes/tst_nodes.cpp b/tests/auto/core/nodes/tst_nodes.cpp index 1edaf42ce..b5458e2e7 100644 --- a/tests/auto/core/nodes/tst_nodes.cpp +++ b/tests/auto/core/nodes/tst_nodes.cpp @@ -40,6 +40,7 @@ #include <Qt3DCore/private/qnode_p.h> #include <Qt3DCore/private/qcomponent_p.h> #include <Qt3DCore/private/vector_helper_p.h> +#include <QSet> #include <QSignalSpy> #include <testarbiter.h> #include <vector> diff --git a/tests/auto/input/abstractaxisinput/CMakeLists.txt b/tests/auto/input/abstractaxisinput/CMakeLists.txt index 10dc60834..7d8bf5518 100644 --- a/tests/auto/input/abstractaxisinput/CMakeLists.txt +++ b/tests/auto/input/abstractaxisinput/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_abstractaxisinput SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_abstractaxisinput.cpp INCLUDE_DIRECTORIES @@ -30,5 +31,5 @@ qt_internal_add_test(tst_abstractaxisinput qt_internal_extend_target(tst_abstractaxisinput CONDITION QT_FEATURE_private_tests SOURCES ../../core/common/qbackendnodetester.cpp ../../core/common/qbackendnodetester.h - ../../core/common/testarbiter.h + ../../core/common/testarbiter.h ../commons/testdevice.cpp ) diff --git a/tests/auto/input/actioninput/CMakeLists.txt b/tests/auto/input/actioninput/CMakeLists.txt index f9564e2ac..aef9c7df4 100644 --- a/tests/auto/input/actioninput/CMakeLists.txt +++ b/tests/auto/input/actioninput/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_actioninput SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_actioninput.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/analogaxisinput/CMakeLists.txt b/tests/auto/input/analogaxisinput/CMakeLists.txt index 72cbbf68c..70645da56 100644 --- a/tests/auto/input/analogaxisinput/CMakeLists.txt +++ b/tests/auto/input/analogaxisinput/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_analogaxisinput SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_analogaxisinput.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/buttonaxisinput/CMakeLists.txt b/tests/auto/input/buttonaxisinput/CMakeLists.txt index 3329ff12c..6529b75b6 100644 --- a/tests/auto/input/buttonaxisinput/CMakeLists.txt +++ b/tests/auto/input/buttonaxisinput/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_buttonaxisinput SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_buttonaxisinput.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/commons/testdevice.cpp b/tests/auto/input/commons/testdevice.cpp new file mode 100644 index 000000000..898766fe7 --- /dev/null +++ b/tests/auto/input/commons/testdevice.cpp @@ -0,0 +1,30 @@ +/**************************************************************************** +** +** Copyright (C) 2022 Klaralvdalens Datakonsult AB (KDAB). +** Contact: https://www.qt.io/licensing/ +** +** This file is part of the Qt3D module of the Qt Toolkit. +** +** $QT_BEGIN_LICENSE:GPL-EXCEPT$ +** Commercial License Usage +** Licensees holding valid commercial Qt licenses may use this file in +** accordance with the commercial license agreement provided with the +** Software or, alternatively, in accordance with the terms contained in +** a written agreement between you and The Qt Company. For licensing terms +** and conditions see https://www.qt.io/terms-conditions. For further +** information use the contact form at https://www.qt.io/contact-us. +** +** GNU General Public License Usage +** Alternatively, this file may be used under the terms of the GNU +** General Public License version 3 as published by the Free Software +** Foundation with exceptions as appearing in the file LICENSE.GPL3-EXCEPT +** included in the packaging of this file. Please review the following +** information to ensure the GNU General Public License requirements will +** be met: https://www.gnu.org/licenses/gpl-3.0.html. +** +** $QT_END_LICENSE$ +** +****************************************************************************/ + +#include "moc_testdevice.cpp" +#include "moc_testdeviceproxy.cpp" diff --git a/tests/auto/input/inputchord/CMakeLists.txt b/tests/auto/input/inputchord/CMakeLists.txt index 49257f421..aeca88132 100644 --- a/tests/auto/input/inputchord/CMakeLists.txt +++ b/tests/auto/input/inputchord/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_inputchord SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_inputchord.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/inputsequence/CMakeLists.txt b/tests/auto/input/inputsequence/CMakeLists.txt index b0faec313..6e58f758b 100644 --- a/tests/auto/input/inputsequence/CMakeLists.txt +++ b/tests/auto/input/inputsequence/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_inputsequence SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_inputsequence.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/keyboardhandler/CMakeLists.txt b/tests/auto/input/keyboardhandler/CMakeLists.txt index 8726bd533..146177c86 100644 --- a/tests/auto/input/keyboardhandler/CMakeLists.txt +++ b/tests/auto/input/keyboardhandler/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_keyboardhandler SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_keyboardhandler.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/loadproxydevicejob/CMakeLists.txt b/tests/auto/input/loadproxydevicejob/CMakeLists.txt index edb18d443..54c71fa26 100644 --- a/tests/auto/input/loadproxydevicejob/CMakeLists.txt +++ b/tests/auto/input/loadproxydevicejob/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_loadproxydevicejob SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_loadproxydevicejob.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/physicaldeviceproxy/CMakeLists.txt b/tests/auto/input/physicaldeviceproxy/CMakeLists.txt index 263e6ef4b..0598f3045 100644 --- a/tests/auto/input/physicaldeviceproxy/CMakeLists.txt +++ b/tests/auto/input/physicaldeviceproxy/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_physicaldeviceproxy SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_physicaldeviceproxy.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qabstractaxisinput/CMakeLists.txt b/tests/auto/input/qabstractaxisinput/CMakeLists.txt index 28d7f53b2..30e354690 100644 --- a/tests/auto/input/qabstractaxisinput/CMakeLists.txt +++ b/tests/auto/input/qabstractaxisinput/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_qabstractaxisinput SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qabstractaxisinput.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qabstractphysicaldevicebackendnode/CMakeLists.txt b/tests/auto/input/qabstractphysicaldevicebackendnode/CMakeLists.txt index 2d42dd1f7..205c9c415 100644 --- a/tests/auto/input/qabstractphysicaldevicebackendnode/CMakeLists.txt +++ b/tests/auto/input/qabstractphysicaldevicebackendnode/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_qabstractphysicaldevicebackendnode SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qabstractphysicaldevicebackendnode.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qabstractphysicaldeviceproxy/CMakeLists.txt b/tests/auto/input/qabstractphysicaldeviceproxy/CMakeLists.txt index e1d6aac23..33ebd9fb8 100644 --- a/tests/auto/input/qabstractphysicaldeviceproxy/CMakeLists.txt +++ b/tests/auto/input/qabstractphysicaldeviceproxy/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_qabstractphysicaldeviceproxy SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qabstractphysicaldeviceproxy.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qaction/CMakeLists.txt b/tests/auto/input/qaction/CMakeLists.txt index 724ef0b7a..1a16130c8 100644 --- a/tests/auto/input/qaction/CMakeLists.txt +++ b/tests/auto/input/qaction/CMakeLists.txt @@ -9,6 +9,7 @@ qt_internal_add_test(tst_qt3d_qaction # special case end SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qaction.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qactioninput/CMakeLists.txt b/tests/auto/input/qactioninput/CMakeLists.txt index 186b30b49..8fb91057d 100644 --- a/tests/auto/input/qactioninput/CMakeLists.txt +++ b/tests/auto/input/qactioninput/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_qactioninput SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qactioninput.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qanalogaxisinput/CMakeLists.txt b/tests/auto/input/qanalogaxisinput/CMakeLists.txt index 147ff97c3..a4c66c558 100644 --- a/tests/auto/input/qanalogaxisinput/CMakeLists.txt +++ b/tests/auto/input/qanalogaxisinput/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_qanalogaxisinput SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qanalogaxisinput.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qaxisaccumulator/CMakeLists.txt b/tests/auto/input/qaxisaccumulator/CMakeLists.txt index 86337c38e..a26215f93 100644 --- a/tests/auto/input/qaxisaccumulator/CMakeLists.txt +++ b/tests/auto/input/qaxisaccumulator/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_qaxisaccumulator SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qaxisaccumulator.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qbuttonaxisinput/CMakeLists.txt b/tests/auto/input/qbuttonaxisinput/CMakeLists.txt index 36698b66a..0a0b1729a 100644 --- a/tests/auto/input/qbuttonaxisinput/CMakeLists.txt +++ b/tests/auto/input/qbuttonaxisinput/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_qbuttonaxisinput SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qbuttonaxisinput.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qkeyboardhandler/CMakeLists.txt b/tests/auto/input/qkeyboardhandler/CMakeLists.txt index 452292249..6285d9af0 100644 --- a/tests/auto/input/qkeyboardhandler/CMakeLists.txt +++ b/tests/auto/input/qkeyboardhandler/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_qkeyboardhandler SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qkeyboardhandler.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qmousedevice/CMakeLists.txt b/tests/auto/input/qmousedevice/CMakeLists.txt index 62e3247ec..a8f4ed6b6 100644 --- a/tests/auto/input/qmousedevice/CMakeLists.txt +++ b/tests/auto/input/qmousedevice/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_qmousedevice SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qmousedevice.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/qmouseevent/CMakeLists.txt b/tests/auto/input/qmouseevent/CMakeLists.txt index 8a2e0bb8b..39698ade4 100644 --- a/tests/auto/input/qmouseevent/CMakeLists.txt +++ b/tests/auto/input/qmouseevent/CMakeLists.txt @@ -9,6 +9,7 @@ qt_internal_add_test(tst_qt3d_qmouseevent #special case end SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_qmouseevent.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/input/utils/CMakeLists.txt b/tests/auto/input/utils/CMakeLists.txt index 0ff18ec4d..2576b2b88 100644 --- a/tests/auto/input/utils/CMakeLists.txt +++ b/tests/auto/input/utils/CMakeLists.txt @@ -7,6 +7,7 @@ qt_internal_add_test(tst_utils SOURCES ../commons/testdevice.h + ../commons/testdevice.cpp ../commons/testdeviceproxy.h tst_utils.cpp INCLUDE_DIRECTORIES diff --git a/tests/auto/quick3d/quick3dbuffer/tst_quick3dbuffer.cpp b/tests/auto/quick3d/quick3dbuffer/tst_quick3dbuffer.cpp index 8583bdf7b..1ac74593e 100644 --- a/tests/auto/quick3d/quick3dbuffer/tst_quick3dbuffer.cpp +++ b/tests/auto/quick3d/quick3dbuffer/tst_quick3dbuffer.cpp @@ -70,7 +70,7 @@ private Q_SLOTS: const QVector<QVector3D> dataArray = { QVector3D(327.0f, 350.0f, 355.0f), QVector3D(383.0f, 427.0f, 454.0f) }; - const int bufferByteSize = dataArray.size() * sizeof(QVector3D); + const int bufferByteSize = int(dataArray.size()) * sizeof(QVector3D); const QLatin1String filePath("binary_data.bin"); const bool writingSucceeded = writeBinaryFile(filePath, dataArray.constData(), bufferByteSize); Q_ASSERT(writingSucceeded); diff --git a/tests/auto/quick3d/quick3dnodeinstantiator/tst_quick3dnodeinstantiator.cpp b/tests/auto/quick3d/quick3dnodeinstantiator/tst_quick3dnodeinstantiator.cpp index 0071a2aad..f06ce70d3 100644 --- a/tests/auto/quick3d/quick3dnodeinstantiator/tst_quick3dnodeinstantiator.cpp +++ b/tests/auto/quick3d/quick3dnodeinstantiator/tst_quick3dnodeinstantiator.cpp @@ -253,3 +253,4 @@ void tst_quick3dnodeinstantiator::createAndRemove() QTEST_MAIN(tst_quick3dnodeinstantiator) #include "tst_quick3dnodeinstantiator.moc" +#include "moc_stringmodel.cpp" diff --git a/tests/auto/render/aspect/tst_aspect.cpp b/tests/auto/render/aspect/tst_aspect.cpp index ae8d7f099..280ae1ab7 100644 --- a/tests/auto/render/aspect/tst_aspect.cpp +++ b/tests/auto/render/aspect/tst_aspect.cpp @@ -113,7 +113,7 @@ private Q_SLOTS: 1 + // UpdateLayerEntity 1 + // PickBoundingVolume 1 + // RayCasting - 0 // No skeleton, no scene loading, no geometry, no buffers + 0U // No skeleton, no scene loading, no geometry, no buffers ); // WHEN @@ -127,7 +127,7 @@ private Q_SLOTS: 1 + // UpdateLevelOfDetail 1 + // PickBoundingVolume 1 + // RayCasting - 0 // No skeleton, no scene loading, no geometry, no buffers + 0U // No skeleton, no scene loading, no geometry, no buffers ); // WHEN @@ -147,7 +147,7 @@ private Q_SLOTS: 1 + // UpdateLevelOfDetail 1 + // PickBoundingVolume 1 + // RayCasting - 0 // No skeleton, no scene loading, no geometry, no buffers + 0U // No skeleton, no scene loading, no geometry, no buffers ); // WHEN @@ -165,7 +165,7 @@ private Q_SLOTS: 1 + // UpdateLevelOfDetail 1 + // PickBoundingVolume 1 + // RayCasting - 0 // No skeleton, no scene loading, no geometry, no buffers + 0U // No skeleton, no scene loading, no geometry, no buffers ); // WHEN @@ -182,7 +182,7 @@ private Q_SLOTS: 1 + // UpdateLevelOfDetail 1 + // PickBoundingVolume 1 + // RayCasting - 0 // No skeleton, no scene loading, no geometry, no buffers + 0U // No skeleton, no scene loading, no geometry, no buffers ); } }; diff --git a/tests/auto/render/buffer/tst_buffer.cpp b/tests/auto/render/buffer/tst_buffer.cpp index ba9e657da..e8f049e33 100644 --- a/tests/auto/render/buffer/tst_buffer.cpp +++ b/tests/auto/render/buffer/tst_buffer.cpp @@ -62,7 +62,7 @@ private Q_SLOTS: QCOMPARE(renderBuffer.isDirty(), true); QCOMPARE(renderBuffer.usage(), buffer.usage()); QCOMPARE(renderBuffer.data(), buffer.data()); - QCOMPARE(renderBuffer.pendingBufferUpdates().size(), 1); + QCOMPARE(renderBuffer.pendingBufferUpdates().size(), 1U); QCOMPARE(renderBuffer.pendingBufferUpdates().front().offset, -1); } @@ -145,7 +145,7 @@ private Q_SLOTS: simulateInitializationSync(&frontendBuffer, &backendBuffer); // THEN - QCOMPARE(backendBuffer.pendingBufferUpdates().size(), 1); + QCOMPARE(backendBuffer.pendingBufferUpdates().size(), 1U); Qt3DCore::QBufferUpdate fullUpdate = backendBuffer.pendingBufferUpdates().front(); QCOMPARE(fullUpdate.offset, -1); QVERIFY(fullUpdate.data.isEmpty()); @@ -159,7 +159,7 @@ private Q_SLOTS: // THEN QCOMPARE(frontendBuffer.data(), QByteArray("100456789\0")); - QCOMPARE(backendBuffer.pendingBufferUpdates().size(), 1); + QCOMPARE(backendBuffer.pendingBufferUpdates().size(), 1U); fullUpdate = backendBuffer.pendingBufferUpdates().front(); QCOMPARE(fullUpdate.offset, 1); QCOMPARE(fullUpdate.data, QByteArray("00\0")); @@ -214,7 +214,7 @@ private Q_SLOTS: // THEN QCOMPARE(backendBuffer.data(), QByteArrayLiteral("LS9SL")); QVERIFY(backendBuffer.isDirty()); - QCOMPARE(backendBuffer.pendingBufferUpdates().size(), 1); + QCOMPARE(backendBuffer.pendingBufferUpdates().size(), 1U); QCOMPARE(backendBuffer.pendingBufferUpdates().front().offset, -1); backendBuffer.pendingBufferUpdates().clear(); @@ -314,7 +314,7 @@ private Q_SLOTS: renderBuffer.syncFromFrontEnd(&buffer, false); // THEN - QCOMPARE(renderBuffer.pendingBufferUpdates().size(), 2); + QCOMPARE(renderBuffer.pendingBufferUpdates().size(), 2U); QCOMPARE(renderBuffer.pendingBufferUpdates().front().offset, 0); QCOMPARE(renderBuffer.pendingBufferUpdates().front().data, QByteArray("012")); QCOMPARE(renderBuffer.pendingBufferUpdates().back().offset, 3); diff --git a/tests/auto/render/filterentitybycomponent/tst_filterentitybycomponent.cpp b/tests/auto/render/filterentitybycomponent/tst_filterentitybycomponent.cpp index 7cfcd3e23..3ed201aa5 100644 --- a/tests/auto/render/filterentitybycomponent/tst_filterentitybycomponent.cpp +++ b/tests/auto/render/filterentitybycomponent/tst_filterentitybycomponent.cpp @@ -87,7 +87,7 @@ private Q_SLOTS: filterJob.run(); // THEN - QCOMPARE(filterJob.filteredEntities().size(), 2); + QCOMPARE(filterJob.filteredEntities().size(), 2U); QCOMPARE(filterJob.filteredEntities().front()->peerId(), childEntity1->id()); QCOMPARE(filterJob.filteredEntities().back()->peerId(), childEntity2->id()); } @@ -99,7 +99,7 @@ private Q_SLOTS: filterJob.run(); // THEN - QCOMPARE(filterJob.filteredEntities().size(), 1); + QCOMPARE(filterJob.filteredEntities().size(), 1U); QCOMPARE(filterJob.filteredEntities().front()->peerId(), childEntity1->id()); } @@ -110,7 +110,7 @@ private Q_SLOTS: filterJob.run(); // THEN - QCOMPARE(filterJob.filteredEntities().size(), 0); + QCOMPARE(filterJob.filteredEntities().size(), 0U); } { @@ -120,7 +120,7 @@ private Q_SLOTS: filterJob.run(); // THEN - QCOMPARE(filterJob.filteredEntities().size(), 1); + QCOMPARE(filterJob.filteredEntities().size(), 1U); QCOMPARE(filterJob.filteredEntities().front()->peerId(), childEntity3->id()); } } diff --git a/tests/auto/render/framegraphvisitor/tst_framegraphvisitor.cpp b/tests/auto/render/framegraphvisitor/tst_framegraphvisitor.cpp index 417260a61..f13dc1948 100644 --- a/tests/auto/render/framegraphvisitor/tst_framegraphvisitor.cpp +++ b/tests/auto/render/framegraphvisitor/tst_framegraphvisitor.cpp @@ -148,7 +148,7 @@ private Q_SLOTS: const std::vector<Qt3DRender::Render::FrameGraphNode *> fgNodes = visitor.traverse(backendFGRoot); // THEN - QCOMPARE(fgNodeIdsPerBranch.size(), fgNodes.size()); + QCOMPARE(size_t(fgNodeIdsPerBranch.size()), fgNodes.size()); for (int i = 0; i < fgNodeIdsPerBranch.size(); ++i) { const BranchIdsAndTypes brandIdsAndTypes = fgNodeIdsPerBranch.at(i); diff --git a/tests/auto/render/layerfiltering/tst_layerfiltering.cpp b/tests/auto/render/layerfiltering/tst_layerfiltering.cpp index 24f6e5cbb..75150d0d7 100644 --- a/tests/auto/render/layerfiltering/tst_layerfiltering.cpp +++ b/tests/auto/render/layerfiltering/tst_layerfiltering.cpp @@ -53,8 +53,8 @@ private Q_SLOTS: // THEN QVERIFY(updateEntityLayerJob.manager() == nullptr); QCOMPARE(filterJob.hasLayerFilter(), false); - QCOMPARE(filterJob.filteredEntities().size(), 0); - QCOMPARE(filterJob.layerFilters().size(), 0); + QCOMPARE(filterJob.filteredEntities().size(), 0U); + QCOMPARE(filterJob.layerFilters().size(), 0U); QCOMPARE(frontendLayer.recursive(), false); } diff --git a/tests/auto/render/opengl/glshadermanager/tst_glshadermanager.cpp b/tests/auto/render/opengl/glshadermanager/tst_glshadermanager.cpp index 6b37db64c..fb11157e8 100644 --- a/tests/auto/render/opengl/glshadermanager/tst_glshadermanager.cpp +++ b/tests/auto/render/opengl/glshadermanager/tst_glshadermanager.cpp @@ -69,7 +69,7 @@ void tst_GLShaderManager::adopt() // THEN QVERIFY(glShader1 != nullptr); std::vector<Qt3DCore::QNodeId> shaderNodeIds = cache.shaderIdsForProgram(glShader1); - QCOMPARE(shaderNodeIds.size(), 1); + QCOMPARE(shaderNodeIds.size(), 1U); QCOMPARE(shaderNodeIds.front(), backendShaderNode1.peerId()); // WHEN @@ -79,7 +79,7 @@ void tst_GLShaderManager::adopt() QCOMPARE(glShader1, glShader2); shaderNodeIds = cache.shaderIdsForProgram(glShader2); - QCOMPARE(shaderNodeIds.size(), 2); + QCOMPARE(shaderNodeIds.size(), 2U); QCOMPARE(shaderNodeIds.front(), backendShaderNode1.peerId()); QCOMPARE(shaderNodeIds.back(), backendShaderNode2.peerId()); } @@ -109,7 +109,7 @@ void tst_GLShaderManager::lookupResource() QVERIFY(glShader1 != nullptr); QCOMPARE(glShader1, glShader2); const std::vector<Qt3DCore::QNodeId> shaderNodeIds = cache.shaderIdsForProgram(glShader1); - QCOMPARE(shaderNodeIds.size(), 2); + QCOMPARE(shaderNodeIds.size(), 2U); QVERIFY(std::find(shaderNodeIds.begin(), shaderNodeIds.end(), frontendShader1.id()) != shaderNodeIds.end()); @@ -142,7 +142,7 @@ void tst_GLShaderManager::abandon() // THEN std::vector<Qt3DCore::QNodeId> shaderNodeIds = cache.shaderIdsForProgram(glShader); QVERIFY(cache.takeAbandonned().empty()); - QCOMPARE(shaderNodeIds.size(), 1); + QCOMPARE(shaderNodeIds.size(), 1U); QCOMPARE(shaderNodeIds.front(), backendShaderNode2.peerId()); // WHEN @@ -150,9 +150,9 @@ void tst_GLShaderManager::abandon() // THEN shaderNodeIds = cache.shaderIdsForProgram(glShader); - QCOMPARE(shaderNodeIds.size(), 0); + QCOMPARE(shaderNodeIds.size(), 0U); const std::vector<Qt3DRender::Render::OpenGL::GLShader *> releasedShaders = cache.takeAbandonned(); - QCOMPARE(releasedShaders.size(), 1); + QCOMPARE(releasedShaders.size(), 1U); QCOMPARE(releasedShaders.front(), glShader); } diff --git a/tests/auto/render/opengl/gltexturemanager/tst_gltexturemanager.cpp b/tests/auto/render/opengl/gltexturemanager/tst_gltexturemanager.cpp index 676720369..315f1c108 100644 --- a/tests/auto/render/opengl/gltexturemanager/tst_gltexturemanager.cpp +++ b/tests/auto/render/opengl/gltexturemanager/tst_gltexturemanager.cpp @@ -96,7 +96,7 @@ private Q_SLOTS: t->setImages({img}); // THEN - QCOMPARE(t->images().size(), 1); + QCOMPARE(t->images().size(), 1U); QCOMPARE(t->dirtyFlags(), Qt3DRender::Render::OpenGL::GLTexture::TextureImageData); // WHEN diff --git a/tests/auto/render/opengl/graphicshelpergl2/tst_graphicshelpergl2.cpp b/tests/auto/render/opengl/graphicshelpergl2/tst_graphicshelpergl2.cpp index a7690924a..1a4960c3c 100644 --- a/tests/auto/render/opengl/graphicshelpergl2/tst_graphicshelpergl2.cpp +++ b/tests/auto/render/opengl/graphicshelpergl2/tst_graphicshelpergl2.cpp @@ -730,7 +730,7 @@ private Q_SLOTS: std::vector<ShaderAttribute> activeAttributes = m_glHelper.programAttributesAndLocations(shaderProgram.programId()); // THEN - QCOMPARE(activeAttributes.size(), 2); + QCOMPARE(activeAttributes.size(), 2U); std::sort(activeAttributes.begin(), activeAttributes.end(), [] (const ShaderAttribute &a, const ShaderAttribute &b) { return a.m_name < b.m_name; }); const ShaderAttribute attribute1 = activeAttributes.at(0); @@ -761,7 +761,7 @@ private Q_SLOTS: std::vector<ShaderUniform> activeUniforms = m_glHelper.programUniformsAndLocations(shaderProgram.programId()); // THEN - QCOMPARE(activeUniforms.size(), 4); + QCOMPARE(activeUniforms.size(), 4U); std::sort(activeUniforms.begin(), activeUniforms.end(), [] (const ShaderUniform &a, const ShaderUniform &b) { return a.m_name < b.m_name; }); const ShaderUniform uniform1 = activeUniforms.at(0); diff --git a/tests/auto/render/opengl/graphicshelpergl3_2/tst_graphicshelpergl3_2.cpp b/tests/auto/render/opengl/graphicshelpergl3_2/tst_graphicshelpergl3_2.cpp index 54662e4e0..18ed1986d 100644 --- a/tests/auto/render/opengl/graphicshelpergl3_2/tst_graphicshelpergl3_2.cpp +++ b/tests/auto/render/opengl/graphicshelpergl3_2/tst_graphicshelpergl3_2.cpp @@ -978,7 +978,7 @@ private Q_SLOTS: const std::vector<ShaderUniformBlock> activeUniformBlocks = m_glHelper.programUniformBlocks(shaderProgram.programId()); // THEN - QCOMPARE(activeUniformBlocks.size(), 1); + QCOMPARE(activeUniformBlocks.size(), 1U); const ShaderUniformBlock uniformBlock = activeUniformBlocks.front(); QCOMPARE(uniformBlock.m_activeUniformsCount, 1); @@ -1006,7 +1006,7 @@ private Q_SLOTS: std::vector<ShaderAttribute> activeAttributes = m_glHelper.programAttributesAndLocations(shaderProgram.programId()); // THEN - QCOMPARE(activeAttributes.size(), 2); + QCOMPARE(activeAttributes.size(), 2U); std::sort(activeAttributes.begin(), activeAttributes.end(), [] (const ShaderAttribute &a, const ShaderAttribute &b) { return a.m_name < b.m_name; }); const ShaderAttribute attribute1 = activeAttributes.at(0); @@ -1037,7 +1037,7 @@ private Q_SLOTS: std::vector<ShaderUniform> activeUniforms = m_glHelper.programUniformsAndLocations(shaderProgram.programId()); // THEN - QCOMPARE(activeUniforms.size(), 4); + QCOMPARE(activeUniforms.size(), 4U); std::sort(activeUniforms.begin(), activeUniforms.end(), [] (const ShaderUniform &a, const ShaderUniform &b) { return a.m_name < b.m_name; }); const ShaderUniform uniform1 = activeUniforms.at(0); diff --git a/tests/auto/render/opengl/graphicshelpergl3_3/tst_graphicshelpergl3_3.cpp b/tests/auto/render/opengl/graphicshelpergl3_3/tst_graphicshelpergl3_3.cpp index 6cd62a170..ccd5cd64e 100644 --- a/tests/auto/render/opengl/graphicshelpergl3_3/tst_graphicshelpergl3_3.cpp +++ b/tests/auto/render/opengl/graphicshelpergl3_3/tst_graphicshelpergl3_3.cpp @@ -1076,7 +1076,7 @@ private Q_SLOTS: const std::vector<ShaderUniformBlock> activeUniformBlocks = m_glHelper.programUniformBlocks(shaderProgram.programId()); // THEN - QCOMPARE(activeUniformBlocks.size(), 1); + QCOMPARE(activeUniformBlocks.size(), 1U); const ShaderUniformBlock uniformBlock = activeUniformBlocks.front(); QCOMPARE(uniformBlock.m_activeUniformsCount, 1); @@ -1104,7 +1104,7 @@ private Q_SLOTS: std::vector<ShaderAttribute> activeAttributes = m_glHelper.programAttributesAndLocations(shaderProgram.programId()); // THEN - QCOMPARE(activeAttributes.size(), 2); + QCOMPARE(activeAttributes.size(), 2U); std::sort(activeAttributes.begin(), activeAttributes.end(), [] (const ShaderAttribute &a, const ShaderAttribute &b) { return a.m_name < b.m_name; }); const ShaderAttribute attribute1 = activeAttributes.at(0); @@ -1135,7 +1135,7 @@ private Q_SLOTS: std::vector<ShaderUniform> activeUniforms = m_glHelper.programUniformsAndLocations(shaderProgram.programId()); // THEN - QCOMPARE(activeUniforms.size(), 4); + QCOMPARE(activeUniforms.size(), 4U); std::sort(activeUniforms.begin(), activeUniforms.end(), [] (const ShaderUniform &a, const ShaderUniform &b) { return a.m_name < b.m_name; }); const ShaderUniform uniform1 = activeUniforms.at(0); diff --git a/tests/auto/render/opengl/graphicshelpergl4/tst_graphicshelpergl4.cpp b/tests/auto/render/opengl/graphicshelpergl4/tst_graphicshelpergl4.cpp index 2b1aa2b8f..1a29c12ca 100644 --- a/tests/auto/render/opengl/graphicshelpergl4/tst_graphicshelpergl4.cpp +++ b/tests/auto/render/opengl/graphicshelpergl4/tst_graphicshelpergl4.cpp @@ -1360,7 +1360,7 @@ private Q_SLOTS: const std::vector<ShaderUniformBlock> activeUniformBlocks = m_glHelper.programUniformBlocks(shaderProgram.programId()); // THEN - QCOMPARE(activeUniformBlocks.size(), 1); + QCOMPARE(activeUniformBlocks.size(), 1U); const ShaderUniformBlock uniformBlock = activeUniformBlocks.front(); QCOMPARE(uniformBlock.m_activeUniformsCount, 1); @@ -1383,7 +1383,7 @@ private Q_SLOTS: std::vector<ShaderAttribute> activeAttributes = m_glHelper.programAttributesAndLocations(shaderProgram.programId()); // THEN - QCOMPARE(activeAttributes.size(), 2); + QCOMPARE(activeAttributes.size(), 2U); std::sort(activeAttributes.begin(), activeAttributes.end(), [] (const ShaderAttribute &a, const ShaderAttribute &b) { return a.m_location < b.m_location; }); const ShaderAttribute attribute1 = activeAttributes.at(0); @@ -1414,7 +1414,7 @@ private Q_SLOTS: std::vector<ShaderUniform> activeUniforms = m_glHelper.programUniformsAndLocations(shaderProgram.programId()); // THEN - QCOMPARE(activeUniforms.size(), 4); + QCOMPARE(activeUniforms.size(), 4U); std::sort(activeUniforms.begin(), activeUniforms.end(), [] (const ShaderUniform &a, const ShaderUniform &b) { return a.m_location < b.m_location; }); const ShaderUniform uniform1 = activeUniforms.at(0); diff --git a/tests/auto/render/opengl/materialparametergathererjob/tst_materialparametergathererjob.cpp b/tests/auto/render/opengl/materialparametergathererjob/tst_materialparametergathererjob.cpp index 73017bead..d08536069 100644 --- a/tests/auto/render/opengl/materialparametergathererjob/tst_materialparametergathererjob.cpp +++ b/tests/auto/render/opengl/materialparametergathererjob/tst_materialparametergathererjob.cpp @@ -237,7 +237,7 @@ private Q_SLOTS: testAspect.initializeRenderer(); // THEN - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 0); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 0U); // WHEN gatherer->run(); @@ -257,7 +257,7 @@ private Q_SLOTS: testAspect.initializeRenderer(); // THEN - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); // WHEN gatherer->setHandles(testAspect.nodeManagers()->materialManager()->activeHandles()); @@ -279,7 +279,7 @@ private Q_SLOTS: testAspect.initializeRenderer(); // THEN - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); // WHEN gatherer->setHandles(testAspect.nodeManagers()->materialManager()->activeHandles()); @@ -311,7 +311,7 @@ private Q_SLOTS: testAspect.initializeRenderer(); // THEN - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::TechniqueFilter *backendTechniqueFilter = static_cast<Qt3DRender::Render::TechniqueFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(frameGraphFilter->id())); QVERIFY(backendTechniqueFilter != nullptr); @@ -351,7 +351,7 @@ private Q_SLOTS: testAspect.initializeRenderer(); // THEN - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::TechniqueFilter *backendTechniqueFilter = static_cast<Qt3DRender::Render::TechniqueFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(frameGraphFilter->id())); QVERIFY(backendTechniqueFilter != nullptr); @@ -387,7 +387,7 @@ private Q_SLOTS: testAspect.initializeRenderer(); // THEN - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::TechniqueFilter *backendTechniqueFilter = static_cast<Qt3DRender::Render::TechniqueFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(frameGraphFilter->id())); QVERIFY(backendTechniqueFilter != nullptr); @@ -421,7 +421,7 @@ private Q_SLOTS: testAspect.initializeRenderer(); // THEN - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::RenderPassFilter *backendPassFilter = static_cast<Qt3DRender::Render::RenderPassFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(frameGraphFilter->id())); QVERIFY(backendPassFilter != nullptr); @@ -461,7 +461,7 @@ private Q_SLOTS: testAspect.initializeRenderer(); // THEN - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::RenderPassFilter *backendPassFilter = static_cast<Qt3DRender::Render::RenderPassFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(frameGraphFilter->id())); QVERIFY(backendPassFilter != nullptr); @@ -512,7 +512,7 @@ private Q_SLOTS: Qt3DRender::Render::MaterialParameterGathererJobPtr gatherer = testAspect.materialGathererJob(); testAspect.initializeRenderer(); - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::TechniqueFilter *backendTechniqueFilter = static_cast<Qt3DRender::Render::TechniqueFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(techniqueFilterFG->id())); Qt3DRender::Render::RenderPassFilter *backendRenderPassFilter = static_cast<Qt3DRender::Render::RenderPassFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(renderPassFG->id())); QVERIFY(backendTechniqueFilter != nullptr); @@ -527,7 +527,7 @@ private Q_SLOTS: QCOMPARE(gatherer->materialToPassAndParameter().size(), 1); const std::vector<Qt3DRender::Render::RenderPassParameterData> passParameterData = gatherer->materialToPassAndParameter().begin().value(); - QCOMPARE(passParameterData.size(), 1); + QCOMPARE(passParameterData.size(), 1U); const Qt3DRender::Render::RenderPassParameterData data = passParameterData.front(); @@ -568,7 +568,7 @@ private Q_SLOTS: Qt3DRender::Render::MaterialParameterGathererJobPtr gatherer = testAspect.materialGathererJob(); testAspect.initializeRenderer(); - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::TechniqueFilter *backendTechniqueFilter = static_cast<Qt3DRender::Render::TechniqueFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(techniqueFilterFG->id())); Qt3DRender::Render::RenderPassFilter *backendRenderPassFilter = static_cast<Qt3DRender::Render::RenderPassFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(renderPassFG->id())); QVERIFY(backendTechniqueFilter != nullptr); @@ -583,7 +583,7 @@ private Q_SLOTS: QCOMPARE(gatherer->materialToPassAndParameter().size(), 1); const std::vector<Qt3DRender::Render::RenderPassParameterData> passParameterData = gatherer->materialToPassAndParameter().begin().value(); - QCOMPARE(passParameterData.size(), 1); + QCOMPARE(passParameterData.size(), 1U); const Qt3DRender::Render::RenderPassParameterData data = passParameterData.front(); @@ -623,7 +623,7 @@ private Q_SLOTS: Qt3DRender::Render::MaterialParameterGathererJobPtr gatherer = testAspect.materialGathererJob(); testAspect.initializeRenderer(); - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::TechniqueFilter *backendTechniqueFilter = static_cast<Qt3DRender::Render::TechniqueFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(techniqueFilterFG->id())); Qt3DRender::Render::RenderPassFilter *backendRenderPassFilter = static_cast<Qt3DRender::Render::RenderPassFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(renderPassFG->id())); QVERIFY(backendTechniqueFilter != nullptr); @@ -638,7 +638,7 @@ private Q_SLOTS: QCOMPARE(gatherer->materialToPassAndParameter().size(), 1); const std::vector<Qt3DRender::Render::RenderPassParameterData> passParameterData = gatherer->materialToPassAndParameter().begin().value(); - QCOMPARE(passParameterData.size(), 1); + QCOMPARE(passParameterData.size(), 1U); const Qt3DRender::Render::RenderPassParameterData data = passParameterData.front(); @@ -677,7 +677,7 @@ private Q_SLOTS: Qt3DRender::Render::MaterialParameterGathererJobPtr gatherer = testAspect.materialGathererJob(); testAspect.initializeRenderer(); - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::TechniqueFilter *backendTechniqueFilter = static_cast<Qt3DRender::Render::TechniqueFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(techniqueFilterFG->id())); Qt3DRender::Render::RenderPassFilter *backendRenderPassFilter = static_cast<Qt3DRender::Render::RenderPassFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(renderPassFG->id())); QVERIFY(backendTechniqueFilter != nullptr); @@ -692,7 +692,7 @@ private Q_SLOTS: QCOMPARE(gatherer->materialToPassAndParameter().size(), 1); const std::vector<Qt3DRender::Render::RenderPassParameterData> passParameterData = gatherer->materialToPassAndParameter().begin().value(); - QCOMPARE(passParameterData.size(), 1); + QCOMPARE(passParameterData.size(), 1U); const Qt3DRender::Render::RenderPassParameterData data = passParameterData.front(); @@ -727,7 +727,7 @@ private Q_SLOTS: Qt3DRender::Render::MaterialParameterGathererJobPtr gatherer = testAspect.materialGathererJob(); testAspect.initializeRenderer(); - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::TechniqueFilter *backendTechniqueFilter = static_cast<Qt3DRender::Render::TechniqueFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(techniqueFilterFG->id())); Qt3DRender::Render::RenderPassFilter *backendRenderPassFilter = static_cast<Qt3DRender::Render::RenderPassFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(renderPassFG->id())); QVERIFY(backendTechniqueFilter != nullptr); @@ -742,7 +742,7 @@ private Q_SLOTS: QCOMPARE(gatherer->materialToPassAndParameter().size(), 1); const std::vector<Qt3DRender::Render::RenderPassParameterData> passParameterData = gatherer->materialToPassAndParameter().begin().value(); - QCOMPARE(passParameterData.size(), 1); + QCOMPARE(passParameterData.size(), 1U); const Qt3DRender::Render::RenderPassParameterData data = passParameterData.front(); @@ -771,7 +771,7 @@ private Q_SLOTS: Qt3DRender::Render::MaterialParameterGathererJobPtr gatherer = testAspect.materialGathererJob(); testAspect.initializeRenderer(); - QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1); + QCOMPARE(testAspect.nodeManagers()->materialManager()->activeHandles().size(), 1U); Qt3DRender::Render::TechniqueFilter *backendTechniqueFilter = static_cast<Qt3DRender::Render::TechniqueFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(techniqueFilterFG->id())); Qt3DRender::Render::RenderPassFilter *backendRenderPassFilter = static_cast<Qt3DRender::Render::RenderPassFilter *>(testAspect.nodeManagers()->frameGraphManager()->lookupNode(renderPassFG->id())); QVERIFY(backendTechniqueFilter != nullptr); @@ -786,7 +786,7 @@ private Q_SLOTS: QCOMPARE(gatherer->materialToPassAndParameter().size(), 1); const std::vector<Qt3DRender::Render::RenderPassParameterData> passParameterData = gatherer->materialToPassAndParameter().begin().value(); - QCOMPARE(passParameterData.size(), 1); + QCOMPARE(passParameterData.size(), 1U); const Qt3DRender::Render::RenderPassParameterData data = passParameterData.front(); diff --git a/tests/auto/render/opengl/renderer/tst_renderer.cpp b/tests/auto/render/opengl/renderer/tst_renderer.cpp index 69855f346..dd85cab32 100644 --- a/tests/auto/render/opengl/renderer/tst_renderer.cpp +++ b/tests/auto/render/opengl/renderer/tst_renderer.cpp @@ -81,14 +81,14 @@ private Q_SLOTS: std::vector<Qt3DCore::QAspectJobPtr> jobs = renderer.preRenderingJobs(); // THEN - QCOMPARE(jobs.size(), 0); + QCOMPARE(jobs.size(), 0U); // WHEN renderer.m_sendBufferCaptureJob->addRequest({Qt3DCore::QNodeId(), {}}); jobs = renderer.preRenderingJobs(); // THEN - QCOMPARE(jobs.size(), 1); // SendBufferCaptureJob + QCOMPARE(jobs.size(), 1U); // SendBufferCaptureJob // Note: pending render buffer captures are only cleared when the job is run // WHEN @@ -97,7 +97,7 @@ private Q_SLOTS: // THEN QCOMPARE(jobs.size(), - 1); // SendBufferCaptureJob´ + 1U); // SendBufferCaptureJob´ // Note: pending set fence handles are only cleared when the job is run // Properly shutdown command thread @@ -138,16 +138,16 @@ private Q_SLOTS: // NOTE: FilterCompatibleTechniqueJob and ShaderGathererJob cannot run because the context // is not initialized in this test - const int renderViewBuilderMaterialCacheJobCount = 1 + 1; + const uint renderViewBuilderMaterialCacheJobCount = 1 + 1; // syncMaterialGathererJob // n * materialGathererJob (where n depends on the numbers of available threads and the number of materials) - const int layerCacheJobCount = 2; + const uint layerCacheJobCount = 2; // filterEntityByLayerJob, // syncFilterEntityByLayerJob - const int singleRenderViewCommandRebuildJobCount = 1 + Qt3DCore::QAspectJobManager::idealThreadCount(); + const uint singleRenderViewCommandRebuildJobCount = 1 + Qt3DCore::QAspectJobManager::idealThreadCount(); - const int singleRenderViewJobCount = 8 + 1 * Qt3DCore::QAspectJobManager::idealThreadCount(); + const uint singleRenderViewJobCount = 8 + 1 * Qt3DCore::QAspectJobManager::idealThreadCount(); // RenderViewBuilder renderViewJob, // syncRenderViewInitializationJob, // syncFrustumCullingJob, diff --git a/tests/auto/render/opengl/renderqueue/tst_renderqueue.cpp b/tests/auto/render/opengl/renderqueue/tst_renderqueue.cpp index ca176f7c2..5df720f14 100644 --- a/tests/auto/render/opengl/renderqueue/tst_renderqueue.cpp +++ b/tests/auto/render/opengl/renderqueue/tst_renderqueue.cpp @@ -199,7 +199,8 @@ void tst_RenderQueue::concurrentQueueAccess() // WHEN unlocked // THEN QVERIFY (renderQueue->isFrameQueueComplete()); - QCOMPARE(renderQueue->nextFrameQueue().size(), renderQueue->targetRenderViewCount()); + QCOMPARE(renderQueue->nextFrameQueue().size(), + size_t(renderQueue->targetRenderViewCount())); // reset queue for next frame renderQueue->reset(); diff --git a/tests/auto/render/opengl/renderviewbuilder/tst_renderviewbuilder.cpp b/tests/auto/render/opengl/renderviewbuilder/tst_renderviewbuilder.cpp index 62b0bed05..1e9cf7923 100644 --- a/tests/auto/render/opengl/renderviewbuilder/tst_renderviewbuilder.cpp +++ b/tests/auto/render/opengl/renderviewbuilder/tst_renderviewbuilder.cpp @@ -251,8 +251,8 @@ private Q_SLOTS: QVERIFY(renderViewBuilder.syncRenderViewPostCommandUpdateJob().isNull()); QVERIFY(renderViewBuilder.syncRenderViewPostInitializationJob().isNull()); - QCOMPARE(renderViewBuilder.renderViewCommandUpdaterJobs().size(), 0); - QCOMPARE(renderViewBuilder.materialGathererJobs().size(), 0); + QCOMPARE(renderViewBuilder.renderViewCommandUpdaterJobs().size(), 0U); + QCOMPARE(renderViewBuilder.materialGathererJobs().size(), 0U); // WHEN renderViewBuilder.prepareJobs(); @@ -264,9 +264,9 @@ private Q_SLOTS: QVERIFY(renderViewBuilder.filterEntityByLayerJob().isNull()); QVERIFY(renderViewBuilder.syncFilterEntityByLayerJob().isNull()); - QCOMPARE(renderViewBuilder.renderViewCommandUpdaterJobs().size(), Qt3DCore::QAspectJobManager::idealThreadCount()); - QCOMPARE(renderViewBuilder.materialGathererJobs().size(), 0); - QCOMPARE(renderViewBuilder.buildJobHierachy().size(), 8 + 1 * Qt3DCore::QAspectJobManager::idealThreadCount()); + QCOMPARE(renderViewBuilder.renderViewCommandUpdaterJobs().size(), size_t(Qt3DCore::QAspectJobManager::idealThreadCount())); + QCOMPARE(renderViewBuilder.materialGathererJobs().size(), 0U); + QCOMPARE(renderViewBuilder.buildJobHierachy().size(), 8U + 1 * Qt3DCore::QAspectJobManager::idealThreadCount()); } { @@ -282,7 +282,7 @@ private Q_SLOTS: QVERIFY(!renderViewBuilder.syncFilterEntityByLayerJob().isNull()); // mark jobs dirty and recheck - QCOMPARE(renderViewBuilder.buildJobHierachy().size(), 10 + renderViewBuilder.optimalJobCount()); + QCOMPARE(renderViewBuilder.buildJobHierachy().size(), 10U + renderViewBuilder.optimalJobCount()); } { @@ -296,11 +296,11 @@ private Q_SLOTS: QCOMPARE(renderViewBuilder.materialGathererCacheNeedsToBeRebuilt(), true); // We have elementsPerJob = qMax(materialHandles.size() / m_optimalParallelJobCount, 1) // Given we have 2 materials -> 1 element per job -> so we need 2 jobs - QCOMPARE(renderViewBuilder.materialGathererJobs().size(), 2); + QCOMPARE(renderViewBuilder.materialGathererJobs().size(), 2U); QVERIFY(!renderViewBuilder.syncMaterialGathererJob().isNull()); // mark jobs dirty and recheck - QCOMPARE(renderViewBuilder.buildJobHierachy().size(), 13); + QCOMPARE(renderViewBuilder.buildJobHierachy().size(), 13U); } } @@ -328,10 +328,10 @@ private Q_SLOTS: // THEN // Step 1 - QCOMPARE(renderViewBuilder.renderViewJob()->dependencies().size(), 1); // Depends upon skinning palette update + QCOMPARE(renderViewBuilder.renderViewJob()->dependencies().size(), 1U); // Depends upon skinning palette update // Step 2 - QCOMPARE(renderViewBuilder.syncRenderViewPostInitializationJob()->dependencies().size(), 1); + QCOMPARE(renderViewBuilder.syncRenderViewPostInitializationJob()->dependencies().size(), 1U); QCOMPARE(renderViewBuilder.syncRenderViewPostInitializationJob()->dependencies().front().toStrongRef().data(), renderViewBuilder.renderViewJob().data()); @@ -339,21 +339,21 @@ private Q_SLOTS: QVERIFY(renderViewBuilder.filterEntityByLayerJob().isNull()); QVERIFY(renderViewBuilder.syncFilterEntityByLayerJob().isNull()); - QCOMPARE(renderViewBuilder.filterProximityJob()->dependencies().size(), 2); + QCOMPARE(renderViewBuilder.filterProximityJob()->dependencies().size(), 2U); QVERIFY(containsDependency(renderViewBuilder.filterProximityJob()->dependencies(), renderViewBuilder.syncRenderViewPostInitializationJob())); QVERIFY(containsDependency(renderViewBuilder.filterProximityJob()->dependencies(), expandBVJob)); - QCOMPARE(renderViewBuilder.setClearDrawBufferIndexJob()->dependencies().size(), 1); + QCOMPARE(renderViewBuilder.setClearDrawBufferIndexJob()->dependencies().size(), 1U); QCOMPARE(renderViewBuilder.setClearDrawBufferIndexJob()->dependencies().front().toStrongRef().data(), renderViewBuilder.syncRenderViewPostInitializationJob().data()); - QCOMPARE(renderViewBuilder.syncPreFrustumCullingJob()->dependencies().size(), 3); + QCOMPARE(renderViewBuilder.syncPreFrustumCullingJob()->dependencies().size(), 3U); QVERIFY(containsDependency(renderViewBuilder.syncPreFrustumCullingJob()->dependencies(), renderViewBuilder.syncRenderViewPostInitializationJob())); QVERIFY(containsDependency(renderViewBuilder.syncPreFrustumCullingJob()->dependencies(), wordTransformJob)); QVERIFY(containsDependency(renderViewBuilder.syncPreFrustumCullingJob()->dependencies(), testAspect.renderer()->updateShaderDataTransformJob())); // Step 4 - QCOMPARE(renderViewBuilder.frustumCullingJob()->dependencies().size(), 2); + QCOMPARE(renderViewBuilder.frustumCullingJob()->dependencies().size(), 2U); QVERIFY(containsDependency(renderViewBuilder.frustumCullingJob()->dependencies(), renderViewBuilder.syncPreFrustumCullingJob())); QVERIFY(containsDependency(renderViewBuilder.frustumCullingJob()->dependencies(), expandBVJob)); @@ -368,7 +368,7 @@ private Q_SLOTS: // Step 5 for (const auto &renderViewBuilderJob : renderViewBuilder.renderViewCommandUpdaterJobs()) { - QCOMPARE(renderViewBuilderJob->dependencies().size(), 1); + QCOMPARE(renderViewBuilderJob->dependencies().size(), 1U); QCOMPARE(renderViewBuilderJob->dependencies().front().toStrongRef().data(), renderViewBuilder.syncRenderViewPreCommandUpdateJob().data()); } @@ -389,44 +389,44 @@ private Q_SLOTS: // THEN // Step 1 - QCOMPARE(renderViewBuilder.renderViewJob()->dependencies().size(), 1); // Depends upon skinning palette update + QCOMPARE(renderViewBuilder.renderViewJob()->dependencies().size(), 1U); // Depends upon skinning palette update // Step 2 - QCOMPARE(renderViewBuilder.syncRenderViewPostInitializationJob()->dependencies().size(), 1); + QCOMPARE(renderViewBuilder.syncRenderViewPostInitializationJob()->dependencies().size(), 1U); QCOMPARE(renderViewBuilder.syncRenderViewPostInitializationJob()->dependencies().front().toStrongRef().data(), renderViewBuilder.renderViewJob().data()); // Step 3 - QCOMPARE(renderViewBuilder.filterEntityByLayerJob()->dependencies().size(), 3); + QCOMPARE(renderViewBuilder.filterEntityByLayerJob()->dependencies().size(), 3U); QVERIFY(containsDependency(renderViewBuilder.filterEntityByLayerJob()->dependencies(), updateEntityLayerJob)); QVERIFY(containsDependency(renderViewBuilder.filterEntityByLayerJob()->dependencies(), renderViewBuilder.syncRenderViewPostInitializationJob())); QVERIFY(containsDependency(renderViewBuilder.filterEntityByLayerJob()->dependencies(), updateTreeEnabledJob)); - QCOMPARE(renderViewBuilder.syncFilterEntityByLayerJob()->dependencies().size(), 1); + QCOMPARE(renderViewBuilder.syncFilterEntityByLayerJob()->dependencies().size(), 1U); QVERIFY(containsDependency(renderViewBuilder.syncFilterEntityByLayerJob()->dependencies(), renderViewBuilder.filterEntityByLayerJob())); - QCOMPARE(renderViewBuilder.filterProximityJob()->dependencies().size(), 2); + QCOMPARE(renderViewBuilder.filterProximityJob()->dependencies().size(), 2U); QVERIFY(containsDependency(renderViewBuilder.filterProximityJob()->dependencies(), renderViewBuilder.syncRenderViewPostInitializationJob())); QVERIFY(containsDependency(renderViewBuilder.filterProximityJob()->dependencies(), expandBVJob)); - QCOMPARE(renderViewBuilder.setClearDrawBufferIndexJob()->dependencies().size(), 1); + QCOMPARE(renderViewBuilder.setClearDrawBufferIndexJob()->dependencies().size(), 1U); QCOMPARE(renderViewBuilder.setClearDrawBufferIndexJob()->dependencies().front().toStrongRef().data(), renderViewBuilder.syncRenderViewPostInitializationJob().data()); - QCOMPARE(renderViewBuilder.syncPreFrustumCullingJob()->dependencies().size(), 3); + QCOMPARE(renderViewBuilder.syncPreFrustumCullingJob()->dependencies().size(), 3U); QVERIFY(containsDependency(renderViewBuilder.syncPreFrustumCullingJob()->dependencies(), renderViewBuilder.syncRenderViewPostInitializationJob())); QVERIFY(containsDependency(renderViewBuilder.syncPreFrustumCullingJob()->dependencies(), wordTransformJob)); QVERIFY(containsDependency(renderViewBuilder.syncPreFrustumCullingJob()->dependencies(), testAspect.renderer()->updateShaderDataTransformJob())); for (const auto &materialGatherer : renderViewBuilder.materialGathererJobs()) { - QCOMPARE(materialGatherer->dependencies().size(), 3); + QCOMPARE(materialGatherer->dependencies().size(), 3U); QVERIFY(containsDependency(materialGatherer->dependencies(), renderViewBuilder.syncRenderViewPostInitializationJob())); QVERIFY(containsDependency(materialGatherer->dependencies(), testAspect.renderer()->introspectShadersJob())); QVERIFY(containsDependency(materialGatherer->dependencies(), testAspect.renderer()->filterCompatibleTechniqueJob())); } // Step 4 - QCOMPARE(renderViewBuilder.frustumCullingJob()->dependencies().size(), 2); + QCOMPARE(renderViewBuilder.frustumCullingJob()->dependencies().size(), 2U); QVERIFY(containsDependency(renderViewBuilder.frustumCullingJob()->dependencies(), renderViewBuilder.syncPreFrustumCullingJob())); QVERIFY(containsDependency(renderViewBuilder.frustumCullingJob()->dependencies(), expandBVJob)); @@ -440,7 +440,7 @@ private Q_SLOTS: // Step 5 for (const auto &renderViewBuilderJob : renderViewBuilder.renderViewCommandUpdaterJobs()) { - QCOMPARE(renderViewBuilderJob->dependencies().size(), 1); + QCOMPARE(renderViewBuilderJob->dependencies().size(), 1U); QCOMPARE(renderViewBuilderJob->dependencies().front().toStrongRef().data(), renderViewBuilder.syncRenderViewPreCommandUpdateJob().data()); } @@ -491,7 +491,7 @@ private Q_SLOTS: // THEN Qt3DRender::Render::RendererCache<Qt3DRender::Render::OpenGL::RenderCommand> *cache = renderer->cache(); - QCOMPARE(cache->gatheredLights.size(), 2); + QCOMPARE(cache->gatheredLights.size(), 2U); QVERIFY(cache->environmentLight != nullptr); } @@ -512,7 +512,7 @@ private Q_SLOTS: // THEN Qt3DRender::Render::RendererCache<Qt3DRender::Render::OpenGL::RenderCommand> *cache = renderer->cache(); - QCOMPARE(cache->renderableEntities.size(), 1); + QCOMPARE(cache->renderableEntities.size(), 1U); } void checkComputableEntitiesFilteringExecution() @@ -532,7 +532,7 @@ private Q_SLOTS: // THEN Qt3DRender::Render::RendererCache<Qt3DRender::Render::OpenGL::RenderCommand> *cache = renderer->cache(); - QCOMPARE(cache->computeEntities.size(), 1); + QCOMPARE(cache->computeEntities.size(), 1U); } void checkSyncRenderViewInitializationExecution() @@ -675,8 +675,8 @@ private Q_SLOTS: std::vector<Qt3DRender::Render::Entity *> filteredEntity = renderViewBuilder.filterEntityByLayerJob()->filteredEntities(); // THEN - QCOMPARE(renderableEntity.size(), 200); - QCOMPARE(filteredEntity.size(), 100); + QCOMPARE(renderableEntity.size(), 200U); + QCOMPARE(filteredEntity.size(), 100U); std::sort(renderableEntity.begin(), renderableEntity.end()); @@ -684,7 +684,7 @@ private Q_SLOTS: renderableEntity = Qt3DRender::Render::entitiesInSubset(renderableEntity, filteredEntity); // THEN - QCOMPARE(renderableEntity.size(), 100); + QCOMPARE(renderableEntity.size(), 100U); for (const auto entity : renderableEntity) { QVERIFY(std::find(filteredEntity.begin(), filteredEntity.end(), diff --git a/tests/auto/render/opengl/renderviewutils/tst_renderviewutils.cpp b/tests/auto/render/opengl/renderviewutils/tst_renderviewutils.cpp index 629952422..85a5fd48f 100644 --- a/tests/auto/render/opengl/renderviewutils/tst_renderviewutils.cpp +++ b/tests/auto/render/opengl/renderviewutils/tst_renderviewutils.cpp @@ -721,7 +721,8 @@ void tst_RenderViewUtils::topLevelStructValue() blockBuilder.buildActiveUniformNameValueMapStructHelper(backendShaderData, blockName); // THEN - QCOMPARE(blockBuilder.activeUniformNamesToValue.count(), shaderData->buildUniformMapNameIds(blockName).size()); + QCOMPARE(size_t(blockBuilder.activeUniformNamesToValue.count()), + shaderData->buildUniformMapNameIds(blockName).size()); // WHEN Qt3DRender::Render::UniformBlockValueBuilderHash::const_iterator it = blockBuilder.activeUniformNamesToValue.begin(); diff --git a/tests/auto/render/pickboundingvolumejob/tst_pickboundingvolumejob.cpp b/tests/auto/render/pickboundingvolumejob/tst_pickboundingvolumejob.cpp index df0eab407..fe8393ea5 100644 --- a/tests/auto/render/pickboundingvolumejob/tst_pickboundingvolumejob.cpp +++ b/tests/auto/render/pickboundingvolumejob/tst_pickboundingvolumejob.cpp @@ -329,7 +329,7 @@ private Q_SLOTS: const std::vector<Qt3DRender::Render::PickingUtils::ViewportCameraAreaDetails> &results = gatherer.gather(test->frameGraphRoot()); // THEN - QCOMPARE(results.size(), 1); + QCOMPARE(results.size(), 1U); auto vca = results.front(); QCOMPARE(vca.area, QSize(600, 600)); QCOMPARE(vca.cameraId, camera->id()); @@ -392,7 +392,7 @@ private Q_SLOTS: { // WHEN - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -406,7 +406,7 @@ private Q_SLOTS: { // WHEN - auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); + auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(207., 303.), QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -417,7 +417,7 @@ private Q_SLOTS: { // WHEN - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(390., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(390., 300.), QPointF(390., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -431,7 +431,7 @@ private Q_SLOTS: { // WHEN - auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(390., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); + auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(390., 300.), QPointF(390., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -491,7 +491,7 @@ private Q_SLOTS: QVERIFY(earlyReturn); // WHEN - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(400., 440.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(400., 440.), QPointF(400., 440.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); earlyReturn = !pickBVJob.runHelper(); @@ -540,7 +540,7 @@ private Q_SLOTS: Qt3DRender::Render::PickBoundingVolumeJob pickBVJob; initializePickBoundingVolumeJob(&pickBVJob, test.data()); - auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(207., 303.), + auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(207., 303.), QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); @@ -596,7 +596,7 @@ private Q_SLOTS: Qt3DRender::Render::PickBoundingVolumeJob pickBVJob; initializePickBoundingVolumeJob(&pickBVJob, test.data()); - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -646,7 +646,7 @@ private Q_SLOTS: { // WHEN - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -658,7 +658,7 @@ private Q_SLOTS: { // WHEN - auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(207., 303.), + auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(207., 303.), QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -709,7 +709,7 @@ private Q_SLOTS: { // WHEN - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -721,7 +721,7 @@ private Q_SLOTS: { // WHEN - auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(207., 303.), + auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(207., 303.), QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -771,7 +771,7 @@ private Q_SLOTS: Qt3DRender::Render::PickBoundingVolumeJob pickBVJob; initializePickBoundingVolumeJob(&pickBVJob, test.data()); - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207., 303.), QPointF(207., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); const bool earlyReturn = !pickBVJob.runHelper(); @@ -846,7 +846,7 @@ private Q_SLOTS: QVERIFY(mouseClickedSpy.isValid()); { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207.0, 303.0), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207.0, 303.0), QPointF(207.0, 303.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -864,7 +864,7 @@ private Q_SLOTS: { // WHEN -> Move on same object - auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(207.0, 303.0), + auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(207.0, 303.0), QPointF(207.0, 303.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -882,7 +882,7 @@ private Q_SLOTS: { // WHEN -> Release on object - auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(207.0, 303.0), + auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(207.0, 303.0), QPointF(207.0, 303.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -905,10 +905,10 @@ private Q_SLOTS: { // WHEN -> Release outside of object - auto event1 = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207.0, 303.0), + auto event1 = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207.0, 303.0), QPointF(207.0, 303.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event1); - auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(0.0, 0.0), + auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(0.0, 0.0), QPointF(0.0, 0.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event2); bool earlyReturn = !pickBVJob.runHelper(); @@ -974,7 +974,7 @@ private Q_SLOTS: initializePickBoundingVolumeJob(&pickBVJob, test.data()); { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207.0, 303.0), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(207.0, 303.0), QPointF(207.0, 303.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -991,7 +991,7 @@ private Q_SLOTS: { // WHEN -> Releasing out of the viewport - auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(10000.0, 10000.0), + auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(10000.0, 10000.0), QPointF(10000.0, 10000.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1012,10 +1012,11 @@ private Q_SLOTS: { // WHEN -> Releasing out of the viewport - auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(10000.0, 10000.0), + auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(10000.0, 10000.0), QPointF(10000.0, 10000.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); + Q_UNUSED(earlyReturn); Qt3DCore::QAspectJobPrivate::get(&pickBVJob)->postFrame(test->aspectManager()); // THEN -> Should have received nothing @@ -1084,7 +1085,7 @@ private Q_SLOTS: initializePickBoundingVolumeJob(&pickBVJob, test.data()); { - auto event = QMouseEvent(QMouseEvent::HoverMove, QPointF(207.0, 303.0), + auto event = QMouseEvent(QMouseEvent::HoverMove, QPointF(207.0, 303.0), QPointF(207.0, 303.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1100,7 +1101,7 @@ private Q_SLOTS: { // WHEN -> HoverMove Out - auto event = QMouseEvent(QEvent::HoverMove, QPointF(20.0, 40.0), + auto event = QMouseEvent(QEvent::HoverMove, QPointF(20.0, 40.0), QPointF(20.0, 40.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1119,10 +1120,10 @@ private Q_SLOTS: // WHEN -> HoverMove In + Pressed other { - auto event1 = QMouseEvent(QEvent::HoverMove, QPointF(207.0, 303.0), + auto event1 = QMouseEvent(QEvent::HoverMove, QPointF(207.0, 303.0), QPointF(207.0, 303.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event1); - auto event2 = QMouseEvent(QEvent::MouseButtonPress, QPointF(0.0, 0.0), + auto event2 = QMouseEvent(QEvent::MouseButtonPress, QPointF(0.0, 0.0), QPointF(0.0, 0.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event2); bool earlyReturn = !pickBVJob.runHelper(); @@ -1200,7 +1201,7 @@ private Q_SLOTS: initializePickBoundingVolumeJob(&pickBVJob, test.data()); { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(400.0, 300.0), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(400.0, 300.0), QPointF(400.0, 300.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1220,7 +1221,7 @@ private Q_SLOTS: { // WHEN -> Move on same object - auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(400.0, 300.0), + auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(400.0, 300.0), QPointF(400.0, 300.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1240,7 +1241,7 @@ private Q_SLOTS: // WHEN -> Release on object { - auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(400.0, 300.0), + auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(400.0, 300.0), QPointF(400.0, 300.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1262,10 +1263,10 @@ private Q_SLOTS: mouseButtonReleasedSpy.clear(); { - auto event1 = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(400., 300.), + auto event1 = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(400., 300.), QPointF(400., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event1); - auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(0., 0.), + auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(0., 0.), QPointF(0., 0.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event2); bool earlyReturn = !pickBVJob.runHelper(); @@ -1374,7 +1375,7 @@ private Q_SLOTS: initializePickBoundingVolumeJob(&pickBVJob, test.data()); { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(320., 303.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(320., 303.), QPointF(320., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1395,7 +1396,7 @@ private Q_SLOTS: { // WHEN -> Move on next object, show stay on previous picker unless all picks are requested - auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(280., 303.), + auto event = QMouseEvent(QMouseEvent::MouseMove, QPointF(280., 303.), QPointF(280., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1474,7 +1475,7 @@ private Q_SLOTS: Qt3DRender::Render::PickBoundingVolumeJob pickBVJob; initializePickBoundingVolumeJob(&pickBVJob, test.data()); - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(400., 300.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(400., 300.), QPointF(400., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1543,7 +1544,7 @@ private Q_SLOTS: initializePickBoundingVolumeJob(&pickBVJob, test.data()); { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(280., 300.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(280., 300.), QPointF(280., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1566,7 +1567,7 @@ private Q_SLOTS: backendPicker->setEnabled(true); { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(320., 300.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(320., 300.), QPointF(320., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1628,7 +1629,7 @@ private Q_SLOTS: initializePickBoundingVolumeJob(&pickBVJob, test.data()); { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(150., 300.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(150., 300.), QPointF(150., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1643,14 +1644,14 @@ private Q_SLOTS: QCOMPARE(mouseButtonPressedSpy1.count(), 1); QCOMPARE(mouseButtonPressedSpy2.count(), 0); - auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(150., 300.), + auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(150., 300.), QPointF(150., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event2); pickBVJob.runHelper(); } { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(450., 300.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(450., 300.), QPointF(450., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1735,7 +1736,7 @@ private Q_SLOTS: // WHEN -> Pressed on object1 in VP1 { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(200.0f, 300.0f), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(200.0, 300.0), QPointF(200.0, 300.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1759,15 +1760,15 @@ private Q_SLOTS: QCOMPARE(mouseButtonPressedSpy4.count(), 0); QCOMPARE(mouseButtonPressedSpy5.count(), 0); - auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(200.0f, 300.0f), - Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); + auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(200.0, 300.0), QPointF(200.0, 300.0), + Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event2); pickBVJob.runHelper(); } // WHEN -> Pressed on object2 in VP2 { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(541.0f, 183.0f), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(541.0, 183.0), QPointF(541.0, 183.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1791,7 +1792,7 @@ private Q_SLOTS: QCOMPARE(mouseButtonPressedSpy4.count(), 0); QCOMPARE(mouseButtonPressedSpy5.count(), 0); - auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(541.0f, 183.0f), + auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(541.0, 183.0), QPointF(541.0, 183.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event2); pickBVJob.runHelper(); @@ -1799,7 +1800,7 @@ private Q_SLOTS: // WHEN -> Pressed on object3 in VP1 { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(80.0f, 150.0f), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(80.0, 150.0), QPointF(80.0, 150.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1826,7 +1827,7 @@ private Q_SLOTS: // WHEN -> Pressed on object3 in VP2 { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(504.0f, 263.0f), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(504.0, 263.0), QPointF(504.0, 263.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1853,7 +1854,7 @@ private Q_SLOTS: // WHEN -> Pressed on object4 in VP1 { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(160.0f, 431.0f), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(160.0, 431.0), QPointF(160.0, 431.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1877,7 +1878,7 @@ private Q_SLOTS: QCOMPARE(mouseButtonPressedSpy4.count(), 1); QCOMPARE(mouseButtonPressedSpy5.count(), 0); - auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(160.0f, 431.0f), + auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(160.0, 431.0), QPointF(160.0, 431.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event2); pickBVJob.runHelper(); @@ -1885,7 +1886,7 @@ private Q_SLOTS: // WHEN -> Pressed on object4 in VP2 { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(447.0f, 472.0f), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(447.0, 472.0), QPointF(447.0, 472.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1909,7 +1910,7 @@ private Q_SLOTS: QCOMPARE(mouseButtonPressedSpy4.count(), 2); QCOMPARE(mouseButtonPressedSpy5.count(), 0); - auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(447.0f, 472.0f), + auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(447.0, 472.0), QPointF(447.0, 472.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event2); pickBVJob.runHelper(); @@ -1917,7 +1918,7 @@ private Q_SLOTS: // WHEN -> Pressed on object5 in VP1 { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(153.0f, 195.0f), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(153.0, 195.0), QPointF(153.0, 195.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -1941,7 +1942,7 @@ private Q_SLOTS: QCOMPARE(mouseButtonPressedSpy4.count(), 2); QCOMPARE(mouseButtonPressedSpy5.count(), 1); - auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(153.0f, 195.0f), + auto event2 = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(153.0, 195.0), QPointF(153.0, 195.0), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event2); pickBVJob.runHelper(); @@ -1959,12 +1960,12 @@ private Q_SLOTS: QMatrix4x4 m; m.rotate(360.f / float(n) * float(j), 0.f, 0.f, 1.f); for (int i=0; i<n; i++) { - const double angle = M_PI * 2. / double(n) * i; - const double x = std::sin(angle) * 10.; - const double z = std::cos(angle) * 10.; + const float angle = float(M_PI) * 2.f / float(n) * float(i); + const float x = std::sin(angle) * 10.f; + const float z = std::cos(angle) * 10.f; QVector3D pos(x, 0.f, z); QVector3D up(0.f, 1.f, 0.f); - QTest::newRow(QString::number(k++).toLatin1().data()) << m * pos << m * up; + QTest::newRow(QString::number(k++).toLatin1().data()) << m.map(pos) << m.map(up); } } } @@ -2025,7 +2026,7 @@ private Q_SLOTS: Qt3DRender::Render::PickBoundingVolumeJob pickBVJob; initializePickBoundingVolumeJob(&pickBVJob, test.data()); - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(303., 303.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(303., 303.), QPointF(303., 303.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -2112,7 +2113,7 @@ private Q_SLOTS: // WHEN -> Pressed on object { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(300., 300.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(300., 300.), QPointF(300., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -2140,7 +2141,7 @@ private Q_SLOTS: } { - auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(300., 300.), + auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(300., 300.), QPointF(300., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); pickBVJob.runHelper(); @@ -2180,7 +2181,7 @@ private Q_SLOTS: // WHEN -> Pressed on object { - auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(300., 300.), + auto event = QMouseEvent(QMouseEvent::MouseButtonPress, QPointF(300., 300.), QPointF(300., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); bool earlyReturn = !pickBVJob.runHelper(); @@ -2208,7 +2209,7 @@ private Q_SLOTS: } { - auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(300., 300.), + auto event = QMouseEvent(QMouseEvent::MouseButtonRelease, QPointF(300., 300.), QPointF(300., 300.), Qt::LeftButton, Qt::LeftButton, Qt::NoModifier); pickBVJob.processMouseEvent(nullptr, &event); pickBVJob.runHelper(); @@ -2275,7 +2276,7 @@ private Q_SLOTS: // THEN QCOMPARE(results.size(), 1); - auto vca = results.front(); + const auto &vca = results.front(); QCOMPARE(vca.area, QSize(600, 600)); QCOMPARE(vca.cameraId, camera->id()); QCOMPARE(vca.viewport, QRectF(0., 0., 1., 1.)); diff --git a/tests/auto/render/proximityfiltering/tst_proximityfiltering.cpp b/tests/auto/render/proximityfiltering/tst_proximityfiltering.cpp index 0bf7f7c69..417e7d648 100644 --- a/tests/auto/render/proximityfiltering/tst_proximityfiltering.cpp +++ b/tests/auto/render/proximityfiltering/tst_proximityfiltering.cpp @@ -108,8 +108,8 @@ private Q_SLOTS: // THEN QCOMPARE(filterJob.hasProximityFilter(), false); - QCOMPARE(filterJob.filteredEntities().size(), 0); - QCOMPARE(filterJob.proximityFilterIds().size(), 0); + QCOMPARE(filterJob.filteredEntities().size(), 0U); + QCOMPARE(filterJob.proximityFilterIds().size(), 0U); QVERIFY(filterJob.manager() == nullptr); } @@ -329,7 +329,7 @@ private Q_SLOTS: // THEN const std::vector<Qt3DRender::Render::Entity *> &filterEntities = filterJob.filteredEntities(); - QCOMPARE(filterEntities.size(), expectedSelectedEntities.size()); + QCOMPARE(filterEntities.size(), size_t(expectedSelectedEntities.size())); for (int i = 0, m = expectedSelectedEntities.size(); i < m; ++i) QCOMPARE(filterEntities.at(i)->peerId(), expectedSelectedEntities.at(i)); diff --git a/tests/auto/render/qmesh/tst_qmesh.cpp b/tests/auto/render/qmesh/tst_qmesh.cpp index 16545046d..1660c32f5 100644 --- a/tests/auto/render/qmesh/tst_qmesh.cpp +++ b/tests/auto/render/qmesh/tst_qmesh.cpp @@ -116,7 +116,7 @@ private Q_SLOTS: Qt3DRender::QMesh mesh; arbiter.setArbiterOnNode(&mesh); - Qt3DCore::QAspectEngine *engine = reinterpret_cast<Qt3DCore::QAspectEngine*>(0xdeadbeef); + Qt3DCore::QAspectEngine *engine = reinterpret_cast<Qt3DCore::QAspectEngine*>(0xdeadbeefL); Qt3DCore::QScene *scene = new Qt3DCore::QScene(engine); Qt3DCore::QNodePrivate *meshd = Qt3DCore::QNodePrivate::get(&mesh); meshd->setScene(scene); @@ -153,7 +153,7 @@ private Q_SLOTS: Qt3DRender::QMesh mesh; arbiter.setArbiterOnNode(&mesh); - Qt3DCore::QAspectEngine *engine = reinterpret_cast<Qt3DCore::QAspectEngine*>(0xdeadbeef); + Qt3DCore::QAspectEngine *engine = reinterpret_cast<Qt3DCore::QAspectEngine*>(0xdeadbeefL); Qt3DCore::QScene *scene = new Qt3DCore::QScene(engine); Qt3DCore::QNodePrivate *meshd = Qt3DCore::QNodePrivate::get(&mesh); meshd->setScene(scene); diff --git a/tests/auto/render/qmlscenereader/qmlscenereader.cpp b/tests/auto/render/qmlscenereader/qmlscenereader.cpp index 182782edb..417a75880 100644 --- a/tests/auto/render/qmlscenereader/qmlscenereader.cpp +++ b/tests/auto/render/qmlscenereader/qmlscenereader.cpp @@ -82,3 +82,5 @@ void QmlSceneReader::loadComplete() } QT_END_NAMESPACE + +#include "moc_qmlscenereader.cpp" diff --git a/tests/auto/render/qmlscenereader/qmlscenereader.h b/tests/auto/render/qmlscenereader/qmlscenereader.h index 9d4643d93..75a74d03a 100644 --- a/tests/auto/render/qmlscenereader/qmlscenereader.h +++ b/tests/auto/render/qmlscenereader/qmlscenereader.h @@ -37,6 +37,9 @@ ** ****************************************************************************/ +#ifndef QMLSCENEREADER_H +#define QMLSCENEREADER_H + #include <QObject> QT_BEGIN_NAMESPACE @@ -61,3 +64,5 @@ private: }; QT_END_NAMESPACE + +#endif diff --git a/tests/auto/render/technique/tst_technique.cpp b/tests/auto/render/technique/tst_technique.cpp index 47a0a2413..58172832c 100644 --- a/tests/auto/render/technique/tst_technique.cpp +++ b/tests/auto/render/technique/tst_technique.cpp @@ -140,7 +140,7 @@ private Q_SLOTS: QCOMPARE(backendTechnique.renderPasses().first(), pass.id()); QCOMPARE(backendTechnique.isCompatibleWithRenderer(), false); const std::vector<Qt3DCore::QNodeId> dirtyTechniques = nodeManagers.techniqueManager()->takeDirtyTechniques(); - QCOMPARE(dirtyTechniques.size(), 1); + QCOMPARE(dirtyTechniques.size(), 1U); QCOMPARE(dirtyTechniques.front(), backendTechnique.peerId()); QVERIFY(renderer.dirtyBits() & Qt3DRender::Render::AbstractRenderer::TechniquesDirty); } @@ -198,12 +198,12 @@ private Q_SLOTS: QCOMPARE(backendTechnique.isEnabled(), newValue); QVERIFY(renderer.dirtyBits() & Qt3DRender::Render::AbstractRenderer::TechniquesDirty); renderer.clearDirtyBits(Qt3DRender::Render::AbstractRenderer::AllDirty); - QCOMPARE(nodeManagers.techniqueManager()->takeDirtyTechniques().size(), 1); + QCOMPARE(nodeManagers.techniqueManager()->takeDirtyTechniques().size(), 1U); } { // WHEN backendTechnique.setCompatibleWithRenderer(true); - QCOMPARE(nodeManagers.techniqueManager()->takeDirtyTechniques().size(), 0); + QCOMPARE(nodeManagers.techniqueManager()->takeDirtyTechniques().size(), 0U); technique.graphicsApiFilter()->setMajorVersion(4); technique.graphicsApiFilter()->setMinorVersion(5); @@ -218,7 +218,7 @@ private Q_SLOTS: QCOMPARE(backendTechnique.isCompatibleWithRenderer(), false); const std::vector<Qt3DCore::QNodeId> dirtyTechniques = nodeManagers.techniqueManager()->takeDirtyTechniques(); - QCOMPARE(dirtyTechniques.size(), 1); + QCOMPARE(dirtyTechniques.size(), 1U); QCOMPARE(dirtyTechniques.front(), backendTechnique.peerId()); QVERIFY(renderer.dirtyBits() & Qt3DRender::Render::AbstractRenderer::TechniquesDirty); diff --git a/tests/auto/render/texture/tst_texture.cpp b/tests/auto/render/texture/tst_texture.cpp index ed38f4822..131101a9b 100644 --- a/tests/auto/render/texture/tst_texture.cpp +++ b/tests/auto/render/texture/tst_texture.cpp @@ -461,7 +461,7 @@ void tst_RenderTexture::checkPropertyChanges() // THEN const std::vector<Qt3DRender::QTextureDataUpdate> pendingUpdates = backend.takePendingTextureDataUpdates(); - QCOMPARE(pendingUpdates.size(), 1); + QCOMPARE(pendingUpdates.size(), 1U); QCOMPARE(pendingUpdates.front(), updateData); QVERIFY(renderer.dirtyBits() & Qt3DRender::Render::AbstractRenderer::TexturesDirty); QVERIFY(backend.dirtyFlags() == Qt3DRender::Render::Texture::DirtyPendingDataUpdates); @@ -514,7 +514,7 @@ void tst_RenderTexture::checkInitialUpdateData() // THEN -> should have received the update as part of the initial data const std::vector<Qt3DRender::QTextureDataUpdate> pendingUpdates = backend.takePendingTextureDataUpdates(); - QCOMPARE(pendingUpdates.size(), 1); + QCOMPARE(pendingUpdates.size(), 1U); QCOMPARE(pendingUpdates.front(), updateData); QVERIFY(backend.dirtyFlags() & Qt3DRender::Render::Texture::DirtyPendingDataUpdates); } diff --git a/tests/auto/shared/util.cpp b/tests/auto/shared/util.cpp index 55041eeb4..d4a19164a 100644 --- a/tests/auto/shared/util.cpp +++ b/tests/auto/shared/util.cpp @@ -123,3 +123,5 @@ QQmlTestMessageHandler::~QQmlTestMessageHandler() qInstallMessageHandler(m_oldHandler); QQmlTestMessageHandler::m_instance = 0; } + +#include "moc_util.cpp" |