| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| | |
Change-Id: If10a4fd620a4573be795ed8ffe1b8ed522976db7
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Right now the bounding volumes would be computed only when a geometry
is marked dirty, which essentially means only when the geometry is
first loaded. However, if a geometry buffer were to change, we need
to recompute the bounding volume.
Change-Id: Ie3fb83d1cc11a3bbfbe2b9828e9f8d7c302d175b
Reviewed-by: Mike Krus <mike.krus@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The viewport rect is computed in GL coordinates. Therefore we need
to check if the mouse is contained with the position in GL coordinates.
The error is not noticeable unless you are using non full height viewport.
Change-Id: I1c39ff91da4a3649288826b939071a298c83c723
Task-number: QTBUG-72856
Reviewed-by: Mike Krus <mike.krus@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a QRenderCapture is deleted its destructor runs, then the
QFrameGraphNode destructor, then the QNode destructor and finally the
QObject destructor. The QObject destructor deletes its QObjectPrivate
member, which destructs QRenderCapturePrivate. At that point the
QRenderCapturePrivate tries to disconnect on an invalid pointer to the
QRenderCapture (which was already deleted).
Change-Id: Ib5835e3f86a282b963220b0dab656258111a61ab
Reviewed-by: Antti Määttä <antti.maatta@qt.io>
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
|
| |
| |
| |
| |
| |
| |
| | |
call functions to resolve/verify the determined parameters.
Change-Id: I1d0773b47e048a8b017c12216bd03625651921e4
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
it's rather pointless.
Change-Id: I7fe3fbd402cadb60d81f778fd30760c49dfe8c29
Reviewed-by: Svenn-Arne Dragly <svenn-arne.dragly@qt.io>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Loading the animation aspect the same way logic and input aspect are
handled. Otherwise aspect is not registered with the factory.
Note: not ideal, should really fix the static registering of all aspects
and not have any specific code like this
Change-Id: Ic92256e344671ee3d550d32a06d91b1ddf396abf
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This makes future ES2 PBR implementation possible as textureSize()
is not available on ES2
Change-Id: Ibf2b36240778a3f30f4316a67819f9052e46bdf1
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Kevin Ottens <kevin.ottens@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Which resulted in incorrect specular texture bookkeeping.
Change-Id: Iceed7e44e791f373f04c35f1a46f5c9ba97d012d
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Kevin Ottens <kevin.ottens@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Format was initialized to RGBA8_UNorm on TextureProperties.
This had the side effect that if you created a TextureLoader entry
with no source yet set, the backend would try to load and return
early since no texture data had yet been generated. Yet it would still
send a notification change with the format (which was RGBA8_UNorm
instead of NoFormat) back to the frontend QTextureLoader. This would
prevent the QTextureLoader from later being loaded correctly with the
format actually read from the image file.
Also updated QTextureData/QTextureImageData/QTextureFromSourceLoader
for consistency.
Change-Id: I23e2287fac297b9b8901476715b1bc1e78c6342b
Task-number: QTBUG-72651
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Kevin Ottens <kevin.ottens@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
These textures have a FourCC flag set but havign a fourCC flag
doesn't mean the content is actually compressed. Adjust supported
formats accordingly.
Change-Id: Ided96d64acb6b5ad2f13cfaa9445bbc83c7bb93d
Task-number: QTBUG-72650
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
Reviewed-by: Kevin Ottens <kevin.ottens@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Found by ICC.
Change-Id: I4ac1156702324f0fb814fffd156f815f33110f71
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@qt.io>
|
|/
|
|
|
|
|
|
|
|
| |
Add the accessor to the property macro, fixing warning:
Property declaration sourceComponent has no READ accessor function or associated MEMBER variable. The property will be invalid.
Amends 4030e1796ca10c0eeab4fcb6cc6000b5bdb08028.
Change-Id: Icc5048d34ecae4f7d0648002727362eaa97614a8
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
|
|
|
|
|
|
| |
Change-Id: I1cc6700c9d16db1ad3e17f63a89d65c02bd8a202
Task-number: QTBUG-64390
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
|
|
|
|
| |
Change-Id: I008d42f09b587c0a6317ddb583b640b15e3b32ba
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
|
|
|
|
| |
Change-Id: Ibb45e3daf0712d87ebfdab5376d60db93abe006e
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
|
|
|
|
|
|
|
| |
Follow the example of qtdeclarative and always use the minor Qt version
as import.
Change-Id: I0adb53a793ddf6a4a9706e2ec1a147799a941e6a
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
|\
| |
| |
| | |
Change-Id: I03355d00bd7219180e70345940855499be488d83
|
| |
| |
| |
| |
| |
| |
| |
| | |
Also remove two '*' that ended up in the generated docs.
Task-number: QTBUG-65413
Change-Id: Ia0870405f73166dbb73ee09e34e7625c51486b41
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
|\ \
| | |
| | |
| | | |
Change-Id: I9f4dd807f0179d7bd95a5263e57c37198e7432f4
|
| | |
| | |
| | |
| | |
| | |
| | | |
Change-Id: Iec70e84024caf879358183fee34638def5038aef
Task-number: QTBUG-72160
Reviewed-by: Mike Krus <mike.krus@kdab.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
FirstVertex and FirstInstance parameters were swapped making any
draw call that requires baseInstance or baseVertex unusable.
Change-Id: Icf52f96981d8868bec4c6888bd129ed6e43d39e9
Task-number: QTBUG-71994
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ie7f469278b0a74b4c059ad99ad182059c6752cd8
Reviewed-by: Mike Krus <mike.krus@kdab.com>
|
|\ \ \
| | | |
| | | |
| | | | |
refs/staging/5.12
|
| |\| |
| | | |
| | | |
| | | | |
Change-Id: Ia208586ec402c9ce29bafc9085804d8b1a62b155
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
-Reorder sleep and locks
-Properly protect isFrameQueueComplete lookup
-Reread queueIsEmpty which could have been updated
Change-Id: I2b5a52284bbb3ddb48483c5bf73779e335c8bdda
Task-number: QTBUG-71294
Reviewed-by: Christian Andersen <csandersen3@gmail.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Because Texture3D doesn't support layers and that results in a warning
being added to the console.
Change-Id: I54d34ccccc2bc1f022814689b97aaaf624026249
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
|/ / /
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Also fix the shaders to work on macOS
Change-Id: If1fb183741c21b284474c9d747c8dd4c70b9d779
Reviewed-by: Wieland Hagen <wieland.hagen@kdab.com>
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The use of QT_INSTALL_HEADERS caused documentation build failures
in certain configurations. Use an alternative method to pass the
required include paths to QDoc; make the documentation subproject
depend on (a subset of) Qt 3D modules to retrieve them.
Task-number: QTBUG-67925
Change-Id: I2fb745fb59c319b85c51b544acdab95cded2207e
Reviewed-by: Martin Smith <martin.smith@qt.io>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: I3eecd06bba9438b5aa472f3ba7ecaecdeda985e2
Reviewed-by: Martin Smith <martin.smith@qt.io>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This adds an InvalidateFrame QNodeCommand in QRenderSettings that is
sent to the RenderSettings backend node. The command will mark the
current frame as dirty. This ensures that whenever an expose event is
received, a redraw happens some time in the future.
Task-number: QTBUG-70885
Fixes: QTBUG-59785
Change-Id: I9fd2e19dbc282300479131d95ff8320269f95f24
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
|
| | |
| | |
| | |
| | |
| | | |
Change-Id: Ibd59dd30e31ded3cbf169fa583d537a7d67fee96
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
- qcomponent.cpp
- qbackendnode.cpp
- qjoint.cpp
- qskeletonloader.cpp
- qframeaction.cpp
- qscene2d.h
- qrenderaspect.cpp
Change-Id: I25881dee19d2d01f948bfaf4a156a97f6caaea73
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
|
| |/
|/|
| |
| |
| |
| |
| |
| | |
Adds doc for undocumented methods in qnode.h and qnodecommand.h
Task-number: QTBUG-36985
Change-Id: I1eb28916ba8862a414dccd58a3c56b84a89f99d0
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I5499524c9f4553342d192d554d4455fd7933eaa9
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Protects access to m_renderQueue using the m_renderQueue mutex on
shutdown. When a Qt3DWindow is deleted it signals the aspect thread to
do early cleanup, the aspect thread calls Renderer::shutdown which in
turn resets m_renderQueue. Meanwhile the render thread may be working on
m_renderQueue, this leads to a double free of the front render view in
m_renderQueue (and potentially other stuff).
Fixes: QTBUG-69877
Change-Id: Ifd018597dbdb2f1538494932c907c63e8db9c715
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Adds warning printout of the format that triggered the error. The
graphics card may produce a proper image, but readFrameBuffer doesn't
know how to interpret it. Additionally adds printout of the format when
the code doesn't know the equivalent OpenGL ES 2.0 format.
Fixes: QTBUG-66515
Change-Id: I65559f7d397a9297521ae0b1ebaf120629be3873
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
|
| |
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-70910
Change-Id: Id4976cd860f824b1a73ddc8561f1709c76dc4466
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
qframegraphnode.cpp:217: Cannot tie this documentation to anything
qcallbackmapping.cpp:104: Can't link to 'QAnimationCallback::onValueChanged()'
Change-Id: I20fb3a5688c16e86c2a62201991d30f735358d76
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
- added links
- minor syntax correction
Change-Id: I68f43b5a5091f402488b656a30d5fec40deae8cd
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
|
|\|
| |
| |
| | |
Change-Id: If9d27bf336dd4d22a06662a5e189ca18b2ba2e76
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Qt3DAnimation::QAbstractAnimationClip was not registered as metatype resulting
in the following error when calling QClipAnimator::setClip:
QMetaProperty::read: Unable to handle unregistered datatype 'Qt3DAnimation::QAbstractAnimationClip*' for property 'Qt3DAnimation::QClipAnimator::clip
Change-Id: If92d781fdab5be06ce11ec88f0b3921cfbd557ff
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
Reviewed-by: Mike Krus <mike.krus@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
by running
for path in `find . -name "Makefile*" -print`; do pushd `dirname $path`; make -f `basename $path` qmltypes; popd; done
in the build directory.
Fixes: QTBUG-64035
Fixes: QTBUG-69259
Task-number: QTBUG-70264
Change-Id: Ib36a8e66121c310dee28b84953ca381e231139cf
Reviewed-by: Christian Stromme <christian.stromme@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I2a92242b0d6be4f4e7f07f0f020fa6751ada9bc3
|
| |
| |
| |
| |
| | |
Change-Id: Iad160f2d454633b558bee91b1e01c287d4202451
Reviewed-by: Antti Määttä <antti.maatta@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Id6dc461bbc61712f59484898c54a85d07fd8fc22
Reviewed-by: Mike Krus <mike.krus@kdab.com>
|
| |
| |
| |
| |
| |
| | |
Change-Id: I62e83c360619a2e096401330a61a6f2602b743d2
Task-number: QTBUG-70660
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
| |
| |
| |
| |
| |
| |
| | |
Change-Id: I09f15de230c571adb580bdbb3250405f562f255b
Task-number: QTBUG-70892
Reviewed-by: Juan José Casafranca <juan.casafranca@kdab.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When all observers for a node have been removed, we should also remove
its entry in m_nodeObservations hash.
Change-Id: I56762bb345e6a3eba74d5174b225dc86acd17e8f
Task-number: QTBUG-70892
Reviewed-by: Juan José Casafranca <juan.casafranca@kdab.com>
Reviewed-by: Sean Harmer <sean.harmer@kdab.com>
|
| |
| |
| |
| |
| |
| |
| |
| | |
Replace the removed phong.frag with graph-based fragment shader.
Task-number: QTBUG-69751
Change-Id: I196be25aff656d6934d6179e4f082430b109b2a1
Reviewed-by: Paul Lemire <paul.lemire@kdab.com>
|