From 4b762f3915e29c282af3dbbe5a15906f8dae9c42 Mon Sep 17 00:00:00 2001 From: Volker Krause Date: Wed, 11 Jan 2017 14:52:45 +0100 Subject: Prevent copying of QAbstractFunctor It's a polymorphic class, so copying risks slicing. Found by clazy in application code. Change-Id: I2f3c03e2a0aa847c35a3192f3e5a4fbd8beae0cd Reviewed-by: Paul Lemire --- src/render/frontend/qabstractfunctor.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/render/frontend/qabstractfunctor.h b/src/render/frontend/qabstractfunctor.h index 7d0dbc1f1..d9c4d65a4 100644 --- a/src/render/frontend/qabstractfunctor.h +++ b/src/render/frontend/qabstractfunctor.h @@ -76,6 +76,7 @@ qintptr functorTypeId() class QT3DRENDERSHARED_EXPORT QAbstractFunctor { public: + QAbstractFunctor() = default; virtual ~QAbstractFunctor(); virtual qintptr id() const = 0; @@ -86,6 +87,8 @@ public: return static_cast(other); return nullptr; } +private: + Q_DISABLE_COPY(QAbstractFunctor) }; template -- cgit v1.2.3