From 62e0265408724f13c472904e0563007f19549fba Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Thu, 28 Apr 2016 13:53:32 +0200 Subject: QRayCastingService: don't iterate over QHash::values() ... iterate over the container itself instead. Avoids creation of a temporary QList. Saves almost 1.5KiB in text size on optimized GCC 6.0 Linux AMD64 builds. Change-Id: I771383f9848999bdbdd96e52f7956d44d5b3b15a Reviewed-by: Sean Harmer --- src/render/raycasting/qraycastingservice.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/render/raycasting/qraycastingservice.cpp b/src/render/raycasting/qraycastingservice.cpp index 3b505b548..31df3df47 100644 --- a/src/render/raycasting/qraycastingservice.cpp +++ b/src/render/raycasting/qraycastingservice.cpp @@ -204,11 +204,10 @@ QVector QRayCastingService::fetchAllResults() const { Q_D(const QRayCastingService); - const QList futureResults = d->m_results.values(); QVector results; - results.reserve(futureResults.size()); + results.reserve(d->m_results.size()); - Q_FOREACH (const FutureQueryResult &future, futureResults) + for (const FutureQueryResult &future : d->m_results) results.append(future.result()); return results; -- cgit v1.2.3