From a52648e549e23beb79c3ba0060a8e131ce22cc7d Mon Sep 17 00:00:00 2001 From: Laszlo Agocs Date: Wed, 23 Aug 2017 15:00:41 +0200 Subject: Remove ill-timed viewVec-upVec check in QCamera The check for parallel view and up vectors is well-intentioned, but it cannot be done this way: the view matrix is updated already after setting any of position, view center, or up vector. The (failing) check can thus be triggered right after setting a position or view center that (temporarily) results in a vector colinear to the (not yet final) up vector. Change-Id: I083200bf05582517880a88816b7987874810c2bb Reviewed-by: Sean Harmer --- src/render/frontend/qcamera_p.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/render/frontend/qcamera_p.h b/src/render/frontend/qcamera_p.h index a310fc765..2ef53818c 100644 --- a/src/render/frontend/qcamera_p.h +++ b/src/render/frontend/qcamera_p.h @@ -69,8 +69,6 @@ public: void updateViewMatrix() { - if (m_upVector.isNull() || QVector3D::crossProduct(m_cameraToCenter, m_upVector).normalized().isNull()) - qWarning() << "Camera up vector must not be colinear with the view vector"; QMatrix4x4 m; m.lookAt(m_position, m_viewCenter, m_upVector); m_transform->setMatrix(m); -- cgit v1.2.3