From f8c49bc0b2426c113e019ebc1a722afa28f06788 Mon Sep 17 00:00:00 2001 From: Paul Lemire Date: Thu, 13 Oct 2022 07:33:07 +0200 Subject: GLTFGeometryLoader: prevent early return on option bufferview target property The glTF specs mention that the target property on a buffer view is not required: https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html#reference-bufferview Therefore, since the parser would return early if no target was specified, preventing any mesh from being loaded. This patch removes the target checking which serves no purpose. Change-Id: I7b1781060b79d1d102c1366dc1884a9f283a7f9f Reviewed-by: Sean Harmer (cherry picked from commit cffc59ff37fbce8fe987e2b4ee64b3d03b3928e9) Reviewed-by: Qt Cherry-pick Bot --- src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp b/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp index fefe335bd..b35e949b4 100644 --- a/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp +++ b/src/plugins/geometryloaders/gltf/gltfgeometryloader.cpp @@ -306,15 +306,6 @@ void GLTFGeometryLoader::processJSONBufferViewV2(const QJsonObject &json) } const auto bufferData = m_gltf2.m_bufferDatas[bufferIndex]; - int target = json.value(KEY_TARGET).toInt(); - switch (target) { - case GL_ARRAY_BUFFER: - case GL_ELEMENT_ARRAY_BUFFER: - break; - default: - return; - } - quint64 offset = 0; const auto byteOffset = json.value(KEY_BYTE_OFFSET); if (!byteOffset.isUndefined()) { -- cgit v1.2.3