From 39d0041f15601cee499c959702b004cbd721bed9 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Wed, 8 Jul 2020 15:56:06 +0200 Subject: Use QList instead of QVector in implementation and docs Fix some const correctness. Use list-initialization. Task-number: QTBUG-84469 Change-Id: I9c56742581f48f89a3b02e4121fae414117c7a25 Reviewed-by: Sean Harmer --- src/core/aspects/aspectcommanddebugger_p.h | 2 +- src/core/aspects/qabstractaspect.cpp | 6 +++--- src/core/aspects/qabstractaspect_p.h | 8 ++++---- src/core/aspects/qaspectengine_p.h | 2 +- src/core/aspects/qaspectmanager.cpp | 18 +++++++++--------- src/core/aspects/qaspectmanager_p.h | 16 ++++++++-------- src/core/geometry/qgeometry_p.h | 2 +- src/core/jobs/calcboundingvolumejob.cpp | 2 +- src/core/jobs/qaspectjobmanager.cpp | 4 ++-- src/core/jobs/qaspectjobmanager_p.h | 1 - src/core/jobs/qaspectjobproviderinterface_p.h | 1 - src/core/jobs/qthreadpooler.cpp | 8 ++++---- src/core/jobs/qthreadpooler_p.h | 4 ++-- src/core/jobs/task_p.h | 2 +- src/core/nodes/propertychangehandler_p.h | 1 - src/core/nodes/qabstractnodefactory.cpp | 4 ++-- src/core/nodes/qabstractnodefactory_p.h | 2 +- src/core/nodes/qcomponent_p.h | 2 +- src/core/nodes/qdestructionidandtypecollector_p.h | 4 ++-- src/core/nodes/qentity_p.h | 4 ++-- src/core/nodes/qnode_p.h | 4 ++-- src/core/qchangearbiter.cpp | 4 ++-- src/core/qchangearbiter_p.h | 10 +++++----- src/core/qscene.cpp | 8 ++++---- src/core/qscene_p.h | 4 ++-- src/core/qscheduler.cpp | 2 +- src/core/resources/qframeallocator_p.h | 1 - src/core/resources/qframeallocator_p_p.h | 4 ++-- src/core/services/qdownloadnetworkworker_p.h | 2 +- src/core/services/qsysteminformationservice.cpp | 10 +++++----- src/core/services/qsysteminformationservice_p_p.h | 6 +++--- src/core/transforms/qabstractskeleton_p.h | 4 ++-- src/core/transforms/qjoint_p.h | 2 +- src/core/transforms/sqt_p.h | 8 ++++---- 34 files changed, 79 insertions(+), 83 deletions(-) (limited to 'src/core') diff --git a/src/core/aspects/aspectcommanddebugger_p.h b/src/core/aspects/aspectcommanddebugger_p.h index b39708ab1..3d26e0441 100644 --- a/src/core/aspects/aspectcommanddebugger_p.h +++ b/src/core/aspects/aspectcommanddebugger_p.h @@ -92,7 +92,7 @@ private: void onCommandReceived(QTcpSocket *socket); void executeCommand(const QString &command, QTcpSocket *socket); - QVector m_connections; + QList m_connections; QSystemInformationService *m_service; ReadBuffer m_readBuffer; diff --git a/src/core/aspects/qabstractaspect.cpp b/src/core/aspects/qabstractaspect.cpp index 6822c938f..31938696b 100644 --- a/src/core/aspects/qabstractaspect.cpp +++ b/src/core/aspects/qabstractaspect.cpp @@ -207,7 +207,7 @@ QBackendNodeMapperPtr QAbstractAspectPrivate::mapperForNode(const QMetaObject *m return mapper; } -void QAbstractAspectPrivate::syncDirtyFrontEndNodes(const QVector &nodes) +void QAbstractAspectPrivate::syncDirtyFrontEndNodes(const QList &nodes) { for (auto node: qAsConst(nodes)) { const QMetaObject *metaObj = QNodePrivate::get(node)->m_typeInfo; @@ -229,7 +229,7 @@ void QAbstractAspectPrivate::syncDirtyFrontEndNode(QNode *node, QBackendNode *ba backend->syncFromFrontEnd(node, firstTime); } -void QAbstractAspectPrivate::syncDirtyEntityComponentNodes(const QVector &changes) +void QAbstractAspectPrivate::syncDirtyEntityComponentNodes(const QList &changes) { auto getBackend = [this] (QNode *node) -> QBackendNode* { const QMetaObject *metaObj = QNodePrivate::get(node)->m_typeInfo; @@ -308,7 +308,7 @@ void QAbstractAspectPrivate::clearBackendNode(const NodeTreeChange &change) cons backendNodeMapper->destroy(change.id); } -void QAbstractAspectPrivate::setRootAndCreateNodes(QEntity *rootObject, const QVector &nodesChanges) +void QAbstractAspectPrivate::setRootAndCreateNodes(QEntity *rootObject, const QList &nodesChanges) { qCDebug(Aspects) << Q_FUNC_INFO << "rootObject =" << rootObject; if (rootObject == m_root) diff --git a/src/core/aspects/qabstractaspect_p.h b/src/core/aspects/qabstractaspect_p.h index f5e295ba3..528d66a8a 100644 --- a/src/core/aspects/qabstractaspect_p.h +++ b/src/core/aspects/qabstractaspect_p.h @@ -60,7 +60,7 @@ #include #include -#include +#include QT_BEGIN_NAMESPACE @@ -119,7 +119,7 @@ public: QAbstractAspectPrivate(); ~QAbstractAspectPrivate(); - void setRootAndCreateNodes(QEntity *rootObject, const QVector &nodesTreeChanges); + void setRootAndCreateNodes(QEntity *rootObject, const QList &nodesTreeChanges); QServiceLocator *services() const; QAbstractAspectJobManager *jobManager() const; @@ -130,8 +130,8 @@ public: QBackendNode *createBackendNode(const NodeTreeChange &change) const; void clearBackendNode(const NodeTreeChange &change) const; - void syncDirtyFrontEndNodes(const QVector &nodes); - void syncDirtyEntityComponentNodes(const QVector &nodes); + void syncDirtyFrontEndNodes(const QList &nodes); + void syncDirtyEntityComponentNodes(const QList &nodes); virtual void syncDirtyFrontEndNode(QNode *node, QBackendNode *backend, bool firstTime) const; void sendPropertyMessages(QNode *node, QBackendNode *backend) const; diff --git a/src/core/aspects/qaspectengine_p.h b/src/core/aspects/qaspectengine_p.h index 47a756511..e38f7fd30 100644 --- a/src/core/aspects/qaspectengine_p.h +++ b/src/core/aspects/qaspectengine_p.h @@ -79,7 +79,7 @@ public: QAspectManager *m_aspectManager; QScene *m_scene; QSharedPointer m_root; - QVector m_aspects; + QList m_aspects; QHash m_namedAspects; bool m_initialized; QAspectEngine::RunMode m_runMode; diff --git a/src/core/aspects/qaspectmanager.cpp b/src/core/aspects/qaspectmanager.cpp index f4221cfe2..3931fb311 100644 --- a/src/core/aspects/qaspectmanager.cpp +++ b/src/core/aspects/qaspectmanager.cpp @@ -266,7 +266,7 @@ void QAspectManager::shutdown() } // MainThread called by QAspectEngine::setRootEntity -void QAspectManager::setRootEntity(Qt3DCore::QEntity *root, const QVector &nodes) +void QAspectManager::setRootEntity(Qt3DCore::QEntity *root, const QList &nodes) { qCDebug(Aspects) << Q_FUNC_INFO; @@ -282,7 +282,7 @@ void QAspectManager::setRootEntity(Qt3DCore::QEntity *root, const QVector nodeTreeChanges; + QList nodeTreeChanges; nodeTreeChanges.reserve(nodes.size()); for (QNode *n : nodes) { @@ -301,14 +301,14 @@ void QAspectManager::setRootEntity(Qt3DCore::QEntity *root, const QVector immediately following node insertion -void QAspectManager::addNodes(const QVector &nodes) +void QAspectManager::addNodes(const QList &nodes) { // We record the nodes added information, which we will actually use when // processFrame is called (later but within the same loop of the even loop // as this call) The idea is we want to avoid modifying the backend tree if // the Renderer hasn't allowed processFrame to continue yet - QVector treeChanges; + QList treeChanges; treeChanges.reserve(nodes.size()); for (QNode *node : nodes) { @@ -322,7 +322,7 @@ void QAspectManager::addNodes(const QVector &nodes) } // Main Thread -> immediately following node destruction (call from QNode dtor) -void QAspectManager::removeNodes(const QVector &nodes) +void QAspectManager::removeNodes(const QList &nodes) { // We record the nodes removed information, which we will actually use when // processFrame is called (later but within the same loop of the even loop @@ -391,7 +391,7 @@ void QAspectManager::unregisterAspect(Qt3DCore::QAbstractAspect *aspect) qCDebug(Aspects) << "Completed unregistering aspect"; } -const QVector &QAspectManager::aspects() const +const QList &QAspectManager::aspects() const { return m_aspects; } @@ -440,13 +440,13 @@ QNode *QAspectManager::lookupNode(QNodeId id) const return d->m_scene ? d->m_scene->lookupNode(id) : nullptr; } -QVector QAspectManager::lookupNodes(const QVector &ids) const +QList QAspectManager::lookupNodes(const QList &ids) const { if (!m_root) return {}; QNodePrivate *d = QNodePrivate::get(m_root); - return d->m_scene ? d->m_scene->lookupNodes(ids) : QVector{}; + return d->m_scene ? d->m_scene->lookupNodes(ids) : QList{}; } QScene *QAspectManager::scene() const @@ -528,7 +528,7 @@ void QAspectManager::processFrame() m_postConstructorInit->processNodes(); // Add and Remove Nodes - const QVector nodeTreeChanges = std::move(m_nodeTreeChanges); + const QList nodeTreeChanges = std::move(m_nodeTreeChanges); for (const NodeTreeChange &change : nodeTreeChanges) { // Buckets ensure that even if we have intermingled node added / removed // buckets, we preserve the order of the sequences diff --git a/src/core/aspects/qaspectmanager_p.h b/src/core/aspects/qaspectmanager_p.h index d1533787e..ab1d1494c 100644 --- a/src/core/aspects/qaspectmanager_p.h +++ b/src/core/aspects/qaspectmanager_p.h @@ -55,11 +55,11 @@ #include #include #include +#include #include #include #include #include -#include #include @@ -104,14 +104,14 @@ public Q_SLOTS: void shutdown(); void processFrame(); - void setRootEntity(Qt3DCore::QEntity *root, const QVector &nodes); - void addNodes(const QVector &nodes); - void removeNodes(const QVector &nodes); + void setRootEntity(Qt3DCore::QEntity *root, const QList &nodes); + void addNodes(const QList &nodes); + void removeNodes(const QList &nodes); void registerAspect(Qt3DCore::QAbstractAspect *aspect); void unregisterAspect(Qt3DCore::QAbstractAspect *aspect); public: - const QVector &aspects() const; + const QList &aspects() const; QAbstractAspect *aspect(const QString &name) const; QAbstractAspect *aspect(const QMetaObject *metaType) const; QAbstractAspectJobManager *jobManager() const; @@ -120,7 +120,7 @@ public: void setPostConstructorInit(NodePostConstructorInit *postConstructorInit); QNode *lookupNode(QNodeId id) const override; - QVector lookupNodes(const QVector &ids) const override; + QList lookupNodes(const QList &ids) const override; QScene *scene() const; int jobsInLastFrame() const { return m_jobsInLastFrame; } @@ -133,7 +133,7 @@ private: void requestNextFrame(); QAspectEngine *m_engine; - QVector m_aspects; + QList m_aspects; QEntity *m_root; QVariantMap m_data; QScheduler *m_scheduler; @@ -142,7 +142,7 @@ private: QScopedPointer m_serviceLocator; bool m_simulationLoopRunning; QAspectEngine::RunMode m_driveMode; - QVector m_nodeTreeChanges; + QList m_nodeTreeChanges; NodePostConstructorInit* m_postConstructorInit; #if QT_CONFIG(animation) diff --git a/src/core/geometry/qgeometry_p.h b/src/core/geometry/qgeometry_p.h index ed13b3feb..a30f9f588 100644 --- a/src/core/geometry/qgeometry_p.h +++ b/src/core/geometry/qgeometry_p.h @@ -74,7 +74,7 @@ public: void setExtent(const QVector3D &minExtent, const QVector3D &maxExtent); static QGeometryPrivate *get(QGeometry *q); - QVector m_attributes; + QList m_attributes; QAttribute *m_boundingVolumePositionAttribute; QVector3D m_minExtent; QVector3D m_maxExtent; diff --git a/src/core/jobs/calcboundingvolumejob.cpp b/src/core/jobs/calcboundingvolumejob.cpp index 0839b18ec..daab9e35a 100644 --- a/src/core/jobs/calcboundingvolumejob.cpp +++ b/src/core/jobs/calcboundingvolumejob.cpp @@ -82,7 +82,7 @@ BoundingVolumeComputeData findBoundingVolumeComputeData(QGeometryView *node) int drawVertexCount = node->vertexCount(); // may be 0, gets changed below if so QAttribute *positionAttribute = dgeom->m_boundingVolumePositionAttribute; - const QVector attributes = geom->attributes(); + const QList attributes = geom->attributes(); // Use the default position attribute if attribute is null if (!positionAttribute) { diff --git a/src/core/jobs/qaspectjobmanager.cpp b/src/core/jobs/qaspectjobmanager.cpp index ed8846bb6..e99ba4480 100644 --- a/src/core/jobs/qaspectjobmanager.cpp +++ b/src/core/jobs/qaspectjobmanager.cpp @@ -76,7 +76,7 @@ void QAspectJobManager::enqueueJobs(const std::vector &jobQueue) // Convert QJobs to Tasks QHash tasksMap; - QVector taskList; + QList taskList; taskList.reserve(jobQueue.size()); for (const QAspectJobPtr &job : jobQueue) { AspectTaskRunnable *task = new AspectTaskRunnable(systemService); @@ -118,7 +118,7 @@ void QAspectJobManager::waitForPerThreadFunction(JobFunction func, void *arg) const int threadCount = m_threadPooler->maxThreadCount(); QAtomicInt atomicCount(threadCount); - QVector taskList; + QList taskList; for (int i = 0; i < threadCount; ++i) { SyncTaskRunnable *syncTask = new SyncTaskRunnable(func, arg, &atomicCount); taskList << syncTask; diff --git a/src/core/jobs/qaspectjobmanager_p.h b/src/core/jobs/qaspectjobmanager_p.h index 0205b7e5a..e27c850f3 100644 --- a/src/core/jobs/qaspectjobmanager_p.h +++ b/src/core/jobs/qaspectjobmanager_p.h @@ -52,7 +52,6 @@ // #include -#include #include #include diff --git a/src/core/jobs/qaspectjobproviderinterface_p.h b/src/core/jobs/qaspectjobproviderinterface_p.h index 4cc7f2047..9873c785c 100644 --- a/src/core/jobs/qaspectjobproviderinterface_p.h +++ b/src/core/jobs/qaspectjobproviderinterface_p.h @@ -52,7 +52,6 @@ // #include -#include #include diff --git a/src/core/jobs/qthreadpooler.cpp b/src/core/jobs/qthreadpooler.cpp index 59c905f71..b4c7a2b05 100644 --- a/src/core/jobs/qthreadpooler.cpp +++ b/src/core/jobs/qthreadpooler.cpp @@ -64,13 +64,13 @@ QThreadPooler::~QThreadPooler() locker.unlock(); } -void QThreadPooler::enqueueTasks(const QVector &tasks) +void QThreadPooler::enqueueTasks(const QList &tasks) { // The caller have to set the mutex - const QVector::const_iterator end = tasks.cend(); + const QList::const_iterator end = tasks.cend(); m_totalRunJobs = 0; - for (QVector::const_iterator it = tasks.cbegin(); + for (QList::const_iterator it = tasks.cbegin(); it != end; ++it) { // Only AspectTaskRunnables are checked for dependencies. @@ -147,7 +147,7 @@ void QThreadPooler::taskFinished(RunnableInterface *task) } } -QFuture QThreadPooler::mapDependables(QVector &taskQueue) +QFuture QThreadPooler::mapDependables(QList &taskQueue) { const QMutexLocker locker(&m_mutex); diff --git a/src/core/jobs/qthreadpooler_p.h b/src/core/jobs/qthreadpooler_p.h index ea69b5b78..058da2fc9 100644 --- a/src/core/jobs/qthreadpooler_p.h +++ b/src/core/jobs/qthreadpooler_p.h @@ -72,7 +72,7 @@ public: explicit QThreadPooler(QObject *parent = nullptr); ~QThreadPooler(); - QFuture mapDependables(QVector &taskQueue); + QFuture mapDependables(QList &taskQueue); int waitForAllJobs(); void taskFinished(RunnableInterface *task); QFuture future(); @@ -80,7 +80,7 @@ public: static int maxThreadCount(); private: - void enqueueTasks(const QVector &tasks); + void enqueueTasks(const QList &tasks); void skipTask(RunnableInterface *task); void enqueueDepencies(RunnableInterface *task); void acquire(int add); diff --git a/src/core/jobs/task_p.h b/src/core/jobs/task_p.h index cd5d9c1a8..ce83a8009 100644 --- a/src/core/jobs/task_p.h +++ b/src/core/jobs/task_p.h @@ -112,7 +112,7 @@ public: public: QSharedPointer m_job; - QVector m_dependers; + QList m_dependers; int m_dependerCount = 0; private: diff --git a/src/core/nodes/propertychangehandler_p.h b/src/core/nodes/propertychangehandler_p.h index 6a3911dbd..8b7e73cd8 100644 --- a/src/core/nodes/propertychangehandler_p.h +++ b/src/core/nodes/propertychangehandler_p.h @@ -56,7 +56,6 @@ #include #include #include -#include QT_BEGIN_NAMESPACE diff --git a/src/core/nodes/qabstractnodefactory.cpp b/src/core/nodes/qabstractnodefactory.cpp index dbdfc641b..769a9beb0 100644 --- a/src/core/nodes/qabstractnodefactory.cpp +++ b/src/core/nodes/qabstractnodefactory.cpp @@ -60,7 +60,7 @@ QAbstractNodeFactory::~QAbstractNodeFactory() { } -QVector node_factories; +QList node_factories; /* * Registers the given \a factory @@ -73,7 +73,7 @@ void QAbstractNodeFactory::registerNodeFactory(QAbstractNodeFactory *factory) /* * \return the node factories. */ -QVector QAbstractNodeFactory::nodeFactories() +QList QAbstractNodeFactory::nodeFactories() { return node_factories; } diff --git a/src/core/nodes/qabstractnodefactory_p.h b/src/core/nodes/qabstractnodefactory_p.h index de1b758a9..9dcc0a500 100644 --- a/src/core/nodes/qabstractnodefactory_p.h +++ b/src/core/nodes/qabstractnodefactory_p.h @@ -67,7 +67,7 @@ public: virtual QNode *createNode(const char *type) = 0; static void registerNodeFactory(QAbstractNodeFactory *factory); - static QVector nodeFactories(); + static QList nodeFactories(); template static T *createNode(const char *type) { diff --git a/src/core/nodes/qcomponent_p.h b/src/core/nodes/qcomponent_p.h index d28433d23..a3b7c88e6 100644 --- a/src/core/nodes/qcomponent_p.h +++ b/src/core/nodes/qcomponent_p.h @@ -70,7 +70,7 @@ public: Q_DECLARE_PUBLIC(QComponent) bool m_shareable; - QVector m_entities; + QList m_entities; }; } diff --git a/src/core/nodes/qdestructionidandtypecollector_p.h b/src/core/nodes/qdestructionidandtypecollector_p.h index 8557c27f0..ac09bc0a0 100644 --- a/src/core/nodes/qdestructionidandtypecollector_p.h +++ b/src/core/nodes/qdestructionidandtypecollector_p.h @@ -60,7 +60,7 @@ class QDestructionIdAndTypeCollector public: QDestructionIdAndTypeCollector(QNode *rootNode); - QVector subtreeIdsAndTypes() const { return m_subtreeIdsAndTypes; } + QList subtreeIdsAndTypes() const { return m_subtreeIdsAndTypes; } private: void collectIdAndType(QNode *node) @@ -73,7 +73,7 @@ private: QNodePrivate::get(node)->m_hasBackendNode = false; } - QVector m_subtreeIdsAndTypes; + QList m_subtreeIdsAndTypes; }; } // namespace Qt3DCore diff --git a/src/core/nodes/qentity_p.h b/src/core/nodes/qentity_p.h index a899fb154..32fd36fa7 100644 --- a/src/core/nodes/qentity_p.h +++ b/src/core/nodes/qentity_p.h @@ -74,9 +74,9 @@ public : void updateComponentRelationShip(QComponent *component, ComponentRelationshipChange::RelationShip change); template - QVector componentsOfType() const + QList componentsOfType() const { - QVector typedComponents; + QList typedComponents; for (QComponent *comp : m_components) { T *typedComponent = qobject_cast(comp); if (typedComponent != nullptr) diff --git a/src/core/nodes/qnode_p.h b/src/core/nodes/qnode_p.h index 2e84f042d..67d52cec7 100644 --- a/src/core/nodes/qnode_p.h +++ b/src/core/nodes/qnode_p.h @@ -125,7 +125,7 @@ public: } template - void registerDestructionHelper(NodeType *node, DestructionFunctionPointer func, QVector &) + void registerDestructionHelper(NodeType *node, DestructionFunctionPointer func, QList &) { // If the node is destoyed, we make sure not to keep a dangling pointer to it Q_Q(QNode); @@ -190,7 +190,7 @@ private: friend class PropertyChangeHandler; bool m_propertyChangesSetup; PropertyChangeHandler m_signals; - QVector> m_destructionConnections; + QList> m_destructionConnections; }; class NodePostConstructorInit : public QObject diff --git a/src/core/qchangearbiter.cpp b/src/core/qchangearbiter.cpp index 678178a44..74b2490bf 100644 --- a/src/core/qchangearbiter.cpp +++ b/src/core/qchangearbiter.cpp @@ -99,12 +99,12 @@ void QChangeArbiter::removeDirtyFrontEndNode(QNode *node) }), m_dirtyEntityComponentNodeChanges.end()); } -QVector QChangeArbiter::takeDirtyFrontEndNodes() +QList QChangeArbiter::takeDirtyFrontEndNodes() { return std::move(m_dirtyFrontEndNodes); } -QVector QChangeArbiter::takeDirtyEntityComponentNodes() +QList QChangeArbiter::takeDirtyEntityComponentNodes() { return std::move(m_dirtyEntityComponentNodeChanges); } diff --git a/src/core/qchangearbiter_p.h b/src/core/qchangearbiter_p.h index 91c232d2a..ebc0304af 100644 --- a/src/core/qchangearbiter_p.h +++ b/src/core/qchangearbiter_p.h @@ -53,13 +53,13 @@ #include #include +#include #include #include #include #include #include #include -#include #include @@ -101,8 +101,8 @@ public: ComponentRelationshipChange::RelationShip change); void removeDirtyFrontEndNode(QNode *node); - QVector takeDirtyFrontEndNodes(); - QVector takeDirtyEntityComponentNodes(); + QList takeDirtyFrontEndNodes(); + QList takeDirtyEntityComponentNodes(); void setScene(Qt3DCore::QScene *scene); @@ -113,8 +113,8 @@ Q_SIGNALS: protected: QScene *m_scene; - QVector m_dirtyFrontEndNodes; - QVector m_dirtyEntityComponentNodeChanges; + QList m_dirtyFrontEndNodes; + QList m_dirtyEntityComponentNodeChanges; }; } // namespace Qt3DCore diff --git a/src/core/qscene.cpp b/src/core/qscene.cpp index 20b818917..475f63214 100644 --- a/src/core/qscene.cpp +++ b/src/core/qscene.cpp @@ -119,11 +119,11 @@ QNode *QScene::lookupNode(QNodeId id) const return d->m_nodeLookupTable.value(id); } -QVector QScene::lookupNodes(const QVector &ids) const +QList QScene::lookupNodes(const QList &ids) const { Q_D(const QScene); QReadLocker lock(&d->m_lock); - QVector nodes(ids.size()); + QList nodes(ids.size()); int index = 0; for (QNodeId id : ids) nodes[index++] = d->m_nodeLookupTable.value(id); @@ -148,11 +148,11 @@ QChangeArbiter *QScene::arbiter() const return d->m_arbiter; } -QVector QScene::entitiesForComponent(QNodeId id) const +QList QScene::entitiesForComponent(QNodeId id) const { Q_D(const QScene); QReadLocker lock(&d->m_lock); - QVector result; + QList result; const auto p = d->m_componentToEntities.equal_range(id); for (auto it = p.first; it != p.second; ++it) result.push_back(*it); diff --git a/src/core/qscene_p.h b/src/core/qscene_p.h index ed014a916..f31fc42e1 100644 --- a/src/core/qscene_p.h +++ b/src/core/qscene_p.h @@ -89,7 +89,7 @@ public: void removeObservable(QNode *observable); QNode *lookupNode(QNodeId id) const override; - QVector lookupNodes(const QVector &ids) const override; + QList lookupNodes(const QList &ids) const override; QNode *rootNode() const; @@ -97,7 +97,7 @@ public: QChangeArbiter *arbiter() const; // Component -> Entities - QVector entitiesForComponent(QNodeId id) const; + QList entitiesForComponent(QNodeId id) const; void addEntityForComponent(QNodeId componentUuid, QNodeId entityUuid); void removeEntityForComponent(QNodeId componentUuid, QNodeId entityUuid); bool hasEntityForComponent(QNodeId componentUuid, QNodeId entityUuid); diff --git a/src/core/qscheduler.cpp b/src/core/qscheduler.cpp index 543e9f2ef..b9d3b75aa 100644 --- a/src/core/qscheduler.cpp +++ b/src/core/qscheduler.cpp @@ -120,7 +120,7 @@ int QScheduler::scheduleAndWaitForFrameAspectJobs(qint64 time, bool dumpJobs) // TODO: Set up dependencies between jobs as needed // For now just queue them up as they are - const QVector &aspects = m_aspectManager->aspects(); + const QList &aspects = m_aspectManager->aspects(); for (QAbstractAspect *aspect : aspects) { const std::vector aspectJobs = QAbstractAspectPrivate::get(aspect)->jobsToExecute(time); jobQueue.insert(jobQueue.end(), diff --git a/src/core/resources/qframeallocator_p.h b/src/core/resources/qframeallocator_p.h index 4c2b5a961..e8bc2e79b 100644 --- a/src/core/resources/qframeallocator_p.h +++ b/src/core/resources/qframeallocator_p.h @@ -58,7 +58,6 @@ #include #include -#include #include diff --git a/src/core/resources/qframeallocator_p_p.h b/src/core/resources/qframeallocator_p_p.h index bf4e0a2b1..daf204f22 100644 --- a/src/core/resources/qframeallocator_p_p.h +++ b/src/core/resources/qframeallocator_p_p.h @@ -101,7 +101,7 @@ private: private: uint m_blockSize; uchar m_nbrBlock; - QVector m_chunks; + QList m_chunks; QFrameChunk *m_lastAllocatedChunck; QFrameChunk *m_lastFreedChunck; }; @@ -128,7 +128,7 @@ public: uint m_maxObjectSize; uint m_alignment; - QVector m_allocatorPool; + QList m_allocatorPool; }; } // Qt3D diff --git a/src/core/services/qdownloadnetworkworker_p.h b/src/core/services/qdownloadnetworkworker_p.h index faecbca2f..7a425db2d 100644 --- a/src/core/services/qdownloadnetworkworker_p.h +++ b/src/core/services/qdownloadnetworkworker_p.h @@ -90,7 +90,7 @@ private Q_SLOTS: private: QNetworkAccessManager *m_networkManager; - QVector< QPair > m_requests; + QList< QPair > m_requests; QMutex m_mutex; }; diff --git a/src/core/services/qsysteminformationservice.cpp b/src/core/services/qsysteminformationservice.cpp index 87cc08e59..02571482f 100644 --- a/src/core/services/qsysteminformationservice.cpp +++ b/src/core/services/qsysteminformationservice.cpp @@ -118,7 +118,7 @@ void QSystemInformationServicePrivate::addJobLogStatsEntry(QSystemInformationSer return; if (!m_jobStatsCached.hasLocalData()) { - auto jobVector = new QVector; + auto jobVector = new QList; m_jobStatsCached.setLocalData(jobVector); QMutexLocker lock(&m_localStoragesMutex); m_localStorages.push_back(jobVector); @@ -134,13 +134,13 @@ void QSystemInformationServicePrivate::addSubmissionLogStatsEntry(QSystemInforma QMutexLocker lock(&m_localStoragesMutex); if (!m_jobStatsCached.hasLocalData()) { - m_submissionStorage = new QVector; + m_submissionStorage = new QList; m_jobStatsCached.setLocalData(m_submissionStorage); } // Handle the case where submission thread is also the main thread (Scene/Manual drive modes with no RenderThread) if (m_submissionStorage == nullptr && m_jobStatsCached.hasLocalData()) - m_submissionStorage = new QVector; + m_submissionStorage = new QList; // When having no submission thread this can be null m_submissionStorage->push_back(stats); @@ -174,12 +174,12 @@ void QSystemInformationServicePrivate::writeFrameJobLogStats() header.frameId = m_frameId; header.jobCount = 0; - for (const QVector *storage : qAsConst(m_localStorages)) + for (const QList *storage : qAsConst(m_localStorages)) header.jobCount += storage->size(); m_traceFile->write(reinterpret_cast(&header), sizeof(FrameHeader)); - for (QVector *storage : qAsConst(m_localStorages)) { + for (QList *storage : qAsConst(m_localStorages)) { for (const JobRunStats &stat : *storage) m_traceFile->write(reinterpret_cast(&stat), sizeof(JobRunStats)); storage->clear(); diff --git a/src/core/services/qsysteminformationservice_p_p.h b/src/core/services/qsysteminformationservice_p_p.h index 062a693d5..3ea52b20f 100644 --- a/src/core/services/qsysteminformationservice_p_p.h +++ b/src/core/services/qsysteminformationservice_p_p.h @@ -111,10 +111,10 @@ public: bool m_graphicsTraceEnabled; QElapsedTimer m_jobsStatTimer; - QThreadStorage *> m_jobStatsCached; + QThreadStorage *> m_jobStatsCached; - QVector *> m_localStorages; - QVector *m_submissionStorage; + QList *> m_localStorages; + QList *m_submissionStorage; QMutex m_localStoragesMutex; diff --git a/src/core/transforms/qabstractskeleton_p.h b/src/core/transforms/qabstractskeleton_p.h index 333fa5fdf..01d8fc74e 100644 --- a/src/core/transforms/qabstractskeleton_p.h +++ b/src/core/transforms/qabstractskeleton_p.h @@ -78,8 +78,8 @@ public: SkeletonType m_type; int m_jointCount; - QVector m_localPoses; - QVector m_jointNames; + QList m_localPoses; + QList m_jointNames; }; } // namespace Qt3DCore diff --git a/src/core/transforms/qjoint_p.h b/src/core/transforms/qjoint_p.h index cb0bfe847..60faac726 100644 --- a/src/core/transforms/qjoint_p.h +++ b/src/core/transforms/qjoint_p.h @@ -68,7 +68,7 @@ public: Q_DECLARE_PUBLIC(QJoint) QMatrix4x4 m_inverseBindMatrix; - QVector m_childJoints; + QList m_childJoints; QQuaternion m_rotation; QVector3D m_translation; QVector3D m_scale; diff --git a/src/core/transforms/sqt_p.h b/src/core/transforms/sqt_p.h index e602cc71e..a3aadd01d 100644 --- a/src/core/transforms/sqt_p.h +++ b/src/core/transforms/sqt_p.h @@ -54,7 +54,7 @@ #include #include #include -#include +#include QT_BEGIN_NAMESPACE @@ -95,15 +95,15 @@ struct Sqt struct JointNamesAndLocalPoses { - QVector names; - QVector localPoses; + QList names; + QList localPoses; }; } // namespace Qt3DCore QT_END_NAMESPACE -Q_DECLARE_METATYPE(QVector) +Q_DECLARE_METATYPE(QList) Q_DECLARE_METATYPE(Qt3DCore::JointNamesAndLocalPoses) #endif // QT3DCORE_SQT_P_H -- cgit v1.2.3