From fe017d37c909c3f7a059d8675e57cb6c03cf959e Mon Sep 17 00:00:00 2001 From: Sean Harmer Date: Mon, 9 May 2016 11:40:37 +0100 Subject: Rename NodeAdded/NodeRemoved ChangeFlags These are not just for adding/removing QNodes. They are more general in purpose and are used for adding/removing values to/from collection based properties e.g. QVector. The addition/removal of QNode pointers (which we translate to QNodeIds) is just the most common case. If Q_PROPERTY/QObject gains support for properties of collections and the typical operations on them, then we will be able to catch and handle most uses of these change types in QNodePrivate just like we do for setting a Q_PROPERTY. Task-number: QTBUG-51494 Change-Id: I707de1647554a61accf81dc79bfe58b289dbff7b Reviewed-by: Paul Lemire --- tests/auto/core/nodes/tst_nodes.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'tests/auto/core/nodes/tst_nodes.cpp') diff --git a/tests/auto/core/nodes/tst_nodes.cpp b/tests/auto/core/nodes/tst_nodes.cpp index 2a8714f5c..64f01a936 100644 --- a/tests/auto/core/nodes/tst_nodes.cpp +++ b/tests/auto/core/nodes/tst_nodes.cpp @@ -598,7 +598,7 @@ void tst_Nodes::checkParentChangeToOtherParent() // CHECK event 1 is a Node Removed event QVERIFY(spyParent1.events.first().wasLocked()); const Qt3DCore::QNodeRemovedPropertyChangePtr event = spyParent1.events.takeFirst().change().dynamicCast(); - QCOMPARE(event->type(), Qt3DCore::NodeRemoved); + QCOMPARE(event->type(), Qt3DCore::PropertyValueRemoved); QCOMPARE(event->subjectId(), parent1->id()); QCOMPARE(event->removedNodeId(), child->id()); QCOMPARE(event->metaObject(), child->metaObject()); @@ -606,7 +606,7 @@ void tst_Nodes::checkParentChangeToOtherParent() // CHECK event 2 is a Node Added event QVERIFY(spyParent2.events.last().wasLocked()); const Qt3DCore::QNodeAddedPropertyChangePtr event2 = spyParent2.events.last().change().dynamicCast(); - QCOMPARE(event2->type(), Qt3DCore::NodeAdded); + QCOMPARE(event2->type(), Qt3DCore::PropertyValueAdded); QCOMPARE(event2->subjectId(), parent2->id()); QCOMPARE(event2->addedNodeId(), child->id()); QCOMPARE(event2->metaObject(), child->metaObject()); -- cgit v1.2.3