From 596bc5734ba525f3d3df45980087c2b3fd90a98f Mon Sep 17 00:00:00 2001
From: Paul Lemire <paul.lemire@kdab.com>
Date: Thu, 13 Feb 2020 11:51:38 +0100
Subject: Destroy FBOs when RenderTarget node is destroyed

It appears we never destroyed FBOs which lead to bugs
when destroying and recreating a RenderTarget

Change-Id: I507b045d9b9e1088ff49f719c8846cc43c4fc8f2
Reviewed-by: Mike Krus <mike.krus@kdab.com>
---
 .../auto/render/rendertarget/tst_rendertarget.cpp  | 42 ++++++++++++++++++++++
 1 file changed, 42 insertions(+)

(limited to 'tests')

diff --git a/tests/auto/render/rendertarget/tst_rendertarget.cpp b/tests/auto/render/rendertarget/tst_rendertarget.cpp
index 31eee6ec5..9b436aa5b 100644
--- a/tests/auto/render/rendertarget/tst_rendertarget.cpp
+++ b/tests/auto/render/rendertarget/tst_rendertarget.cpp
@@ -32,6 +32,7 @@
 #include <Qt3DRender/qrendertargetoutput.h>
 #include <Qt3DRender/private/qrendertarget_p.h>
 #include <Qt3DRender/private/rendertarget_p.h>
+#include <Qt3DRender/private/managers_p.h>
 #include "qbackendnodetester.h"
 #include "testrenderer.h"
 
@@ -205,6 +206,47 @@ private Q_SLOTS:
         }
     }
 
+    void checkRenderTargetManager()
+    {
+        // GIVEN
+        Qt3DRender::QRenderTarget renderTarget;
+        TestRenderer renderer;
+        Qt3DRender::Render::RenderTargetManager manager;
+        Qt3DRender::Render::RenderTargetFunctor creationFunctor(&renderer, &manager);
+
+        // THEN
+        QVERIFY(manager.renderTargetIdsToCleanup().isEmpty());
+
+        // WHEN
+        Qt3DCore::QNodeCreatedChangeBase changeObj(&renderTarget);
+        Qt3DCore::QNodeCreatedChangeBasePtr changePtr(&changeObj, [](Qt3DCore::QNodeCreatedChangeBase *) {});
+        auto backend = creationFunctor.create(changePtr);
+
+        // THEN
+        QVERIFY(backend != nullptr);
+        QVERIFY(manager.renderTargetIdsToCleanup().isEmpty());
+
+        {
+            // WHEN
+            auto sameBackend = creationFunctor.get(renderTarget.id());
+            // THEN
+            QCOMPARE(backend, sameBackend);
+        }
+
+        // WHEN
+        creationFunctor.destroy(renderTarget.id());
+
+        // THEN -> Should be in list of ids to remove and return null on get
+        QVERIFY(manager.renderTargetIdsToCleanup().contains(renderTarget.id()));
+        QVERIFY(creationFunctor.get(renderTarget.id()) == nullptr);
+
+        // WHEN -> Should be removed from list of ids to remove
+        creationFunctor.create(changePtr);
+
+        // THEN
+        QVERIFY(manager.renderTargetIdsToCleanup().isEmpty());
+        QVERIFY(creationFunctor.get(renderTarget.id()) != nullptr);
+    }
 };
 
 QTEST_MAIN(tst_RenderTarget)
-- 
cgit v1.2.3