Fix shellcheck complaints in common macos provisioning scripts

Change-Id: I9d6891a2956f66ebf2ca759c4085acad30a84618
Reviewed-by: Joni Jäntti <joni.jantti@qt.io>
Reviewed-by: Simo Fält <simo.falt@qt.io>

1 files changed, 5 insertions, 4 deletions

diff --git a/coin/provisioning/common/macos/install-commandlinetools.sh b/coin/provisioning/common/macos/install-commandlinetools.sh
index 18ff1036..2be234e7 100755
--- a/coin/provisioning/common/macos/install-commandlinetools.sh
+++ b/coin/provisioning/common/macos/install-commandlinetools.sh
@@ -32,6 +32,7 @@
 ## $QT_END_LICENSE$
 ##
 #############################################################################
+# shellcheck source=../unix/DownloadURL.sh
 source "${BASH_SOURCE%/*}/../unix/DownloadURL.sh"
 set -ex
 
@@ -44,19 +45,19 @@ function InstallCommandLineTools {
     packageName=$4
     version=$5
 
-    DownloadURL $url $url_alt $expectedSha1 /tmp/$packageName
+    DownloadURL "$url" "$url_alt" "$expectedSha1" "/tmp/$packageName"
     echo "Mounting $packageName"
-    hdiutil attach /tmp/$packageName
+    hdiutil attach "/tmp/$packageName"
     cd "/Volumes/Command Line Developer Tools"
     echo "Installing"
-    sudo installer -verbose -pkg *.pkg -target /
+    sudo installer -verbose -pkg ./*.pkg -target /
     cd /
     # Let's fait for 5 second before unmounting. Sometimes resource is busy and cant be unmounted
     sleep 3
     echo "Unmounting"
     umount /Volumes/Command\ Line\ Developer\ Tools/
     echo "Removing $packageName"
-    rm /tmp/$packageName
+    rm "/tmp/$packageName"
 
     echo "Command Line Tools = $version" >> ~/versions.txt
 }