diff options
| author | Juha Karjalainen <juha.karjalainen@qt.io> | 2018-11-22 16:21:17 +0200 |
|---|---|---|
| committer | Liang Qi <liang.qi@qt.io> | 2018-12-12 13:49:42 +0000 |
| commit | e21401751a7852b13070e3a95ff08058dd19dd5c (patch) | |
| tree | 51c3efbafe4cf72a6bffc01930fed18dcd510725 /coin | |
| parent | bc12bb763f80b99470d121bea496bb31824fe6d5 (diff) | |
Provisioning: Change how executables are waited to finish
This patch only affects Windows.
Python3 provisioning took over 30-35 minutes. As both
32 and 64 bit versions are provisioned it took over 1h
this change lowers time taken to 5 minutes.
start-process with -wait flag waits for given process and its
sub-processes to exit. Wait-process insteads just waits for
process to exit.
Change-Id: Ib9a323dcf9e2d07318a0d259a72ca4c4d0a4ed80
Reviewed-by: Simo Fält <simo.falt@qt.io>
Diffstat (limited to 'coin')
| -rw-r--r-- | coin/provisioning/common/windows/helpers.ps1 | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/coin/provisioning/common/windows/helpers.ps1 b/coin/provisioning/common/windows/helpers.ps1 index 794f1b5d..cbf2371f 100644 --- a/coin/provisioning/common/windows/helpers.ps1 +++ b/coin/provisioning/common/windows/helpers.ps1 @@ -27,7 +27,8 @@ function Run-Executable $p = Start-Process -FilePath "$Executable" -Wait -PassThru } else { Write-Host "Running `"$Executable`" with arguments `"$Arguments`"" - $p = Start-Process -FilePath "$Executable" -ArgumentList $Arguments -Wait -PassThru + $p = Start-Process -FilePath "$Executable" -ArgumentList $Arguments -PassThru + Wait-Process -InputObject $p } if ($p.ExitCode -ne 0) { throw "Process $($Executable) exited with exit code $($p.ExitCode)" |