summaryrefslogtreecommitdiffstats
path: root/.cmake.conf
diff options
context:
space:
mode:
authorCraig Scott <craig.scott@qt.io>2020-11-30 18:46:49 +1100
committerCraig Scott <craig.scott@qt.io>2020-12-07 13:22:57 +1100
commit3859f15ec9fd333089e6eb1152a76592cd5f83c0 (patch)
treeab1a3efb43ae5fac1dff489ce8832fd8e20bf021 /.cmake.conf
parentec02de374da3f796a2155b45779be222a90be2cd (diff)
CMake: Enable NEW policies by CMake version with a global default
When a CMake release introduces a new policy that affects most Qt modules, it may be appropriate to make each module aware of that newer CMake version and use the NEW policy without raising the minimum CMake version requirement. To reduce the churn associated with making that change across all Qt modules individually, this change allows it to be updated in a central place (qtbase), but in a way that allows a Qt module to override it in its own .cmake.conf file if required (e.g. to address the issues identified by policy warnings at a later time). The policies are modified at the start of the call to qt_build_repo_begin(). For commands defined by the qtbase module, qtbase needs to be in control of the policy settings at the point where those commands are defined. The above mechanism should not affect the policy settings for these commands, so the various *Config.cmake.in files must not specify policy ranges in a way that a Qt module's .cmake.conf file could influence. Starting with CMake 3.12, policies can be specified as a version range with the cmake_minimum_required() and cmake_policy() commands. All policies introduced in CMake versions up to the upper limit of that range will be set to NEW. The actual version of CMake being used only has to be at least the lower limit of the specified version range. This change uses cmake_minimum_required() rather than cmake_policy() due to the latter not halting further processing upon failure. See the following: https://gitlab.kitware.com/cmake/cmake/-/issues/21557 Task-number: QTBUG-88700 Pick-to: 6.0 Change-Id: I0a1f2611dd629f847a18186394f500d7f52753bc Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to '.cmake.conf')
-rw-r--r--.cmake.conf14
1 files changed, 14 insertions, 0 deletions
diff --git a/.cmake.conf b/.cmake.conf
index b8e9ae6735..2680c4a33d 100644
--- a/.cmake.conf
+++ b/.cmake.conf
@@ -1,2 +1,16 @@
set(QT_REPO_MODULE_VERSION "6.0.0")
+
+# Minimum requirement for building Qt
set(QT_MIN_SUPPORTED_CMAKE_VERSION "3.18")
+
+# Policy settings for commands defined by qtbase. These will also be injected
+# into the top level policy scope of each Qt module when building Qt so that
+# modules have the same policy settings as qtbase by default. They can be
+# overridden by individual Qt modules in their own .cmake.conf files if needed.
+#
+# NOTE: These two values are also hard-coded in QtBuildInternalsConfig.cmake
+# because that file is used in-place by a superbuild, so there is no
+# opportunity for substituting the values from here. Keep both locations
+# in sync.
+set(QT_MIN_NEW_POLICY_CMAKE_VERSION "3.14")
+set(QT_MAX_NEW_POLICY_CMAKE_VERSION "3.19")