summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGiuseppe D'Angelo <giuseppe.dangelo@kdab.com>2021-01-01 18:03:02 +0100
committerGiuseppe D'Angelo <giuseppe.dangelo@kdab.com>2021-01-10 15:02:47 +0100
commitc34c6af3740052617ee9f0876e2720046f0e6bb7 (patch)
tree1226e9e7611c606a94ed22f42a44e78ba968a494
parentb211148e4b4167483e1a78a45ae8fef97e5a4f2d (diff)
Replace some more erase/remove patterns with removeIf
Change-Id: I6c6f33450fbfd798e5ef71a8ba18f590581dc3a2 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
-rw-r--r--examples/network/torrent/torrentclient.cpp4
-rw-r--r--qmake/library/qmakebuiltins.cpp2
-rw-r--r--src/corelib/itemmodels/qsortfilterproxymodel.cpp5
-rw-r--r--tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp6
4 files changed, 5 insertions, 12 deletions
diff --git a/examples/network/torrent/torrentclient.cpp b/examples/network/torrent/torrentclient.cpp
index 6ae5339d28..a63e927e09 100644
--- a/examples/network/torrent/torrentclient.cpp
+++ b/examples/network/torrent/torrentclient.cpp
@@ -1501,9 +1501,7 @@ void TorrentClient::addToPeerList(const QList<TorrentPeer> &peerList)
};
// Remove inactive peers from the peer list until we're below
// the max connections count.
- d->peers.erase(std::remove_if(d->peers.begin(), d->peers.end(),
- firstNInactivePeers),
- d->peers.end());
+ d->peers.removeIf(firstNInactivePeers);
// If we still have too many peers, remove the oldest ones.
d->peers.erase(d->peers.begin(), d->peers.begin() + tooMany);
}
diff --git a/qmake/library/qmakebuiltins.cpp b/qmake/library/qmakebuiltins.cpp
index ca4de7b1c6..d1c7b2c328 100644
--- a/qmake/library/qmakebuiltins.cpp
+++ b/qmake/library/qmakebuiltins.cpp
@@ -1508,7 +1508,7 @@ QMakeEvaluator::VisitReturn QMakeEvaluator::evaluateBuiltinConditional(
auto isFrom = [pro](const ProString &s) {
return s.sourceFile() == pro;
};
- vit->erase(std::remove_if(vit->begin(), vit->end(), isFrom), vit->end());
+ vit->removeIf(isFrom);
if (vit->isEmpty()) {
// When an initially non-empty variable becomes entirely empty,
// undefine it altogether.
diff --git a/src/corelib/itemmodels/qsortfilterproxymodel.cpp b/src/corelib/itemmodels/qsortfilterproxymodel.cpp
index 2777709a80..38417bbba6 100644
--- a/src/corelib/itemmodels/qsortfilterproxymodel.cpp
+++ b/src/corelib/itemmodels/qsortfilterproxymodel.cpp
@@ -641,10 +641,7 @@ QList<QPair<int, int>> QSortFilterProxyModelPrivate::proxy_intervals_for_source_
interval.first = interval.second = -1;
}
}
- proxy_intervals.erase(
- std::remove_if(proxy_intervals.begin(), proxy_intervals.end(),
- [](QPair<int, int> &interval) { return interval.first < 0; }),
- proxy_intervals.end());
+ proxy_intervals.removeIf([](QPair<int, int> interval) { return interval.first < 0; });
return proxy_intervals;
}
diff --git a/tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp b/tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp
index ebdb3b83c4..e522ec6d05 100644
--- a/tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp
+++ b/tests/auto/widgets/kernel/qwidget/tst_qwidget.cpp
@@ -5204,10 +5204,8 @@ void tst_QWidget::setWindowGeometry_data()
const bool skipEmptyRects = (m_platform == QStringLiteral("windows"));
for (Rects l : qAsConst(rects)) {
- if (skipEmptyRects) {
- l.erase(std::remove_if(l.begin(), l.end(), [] (const QRect &r) { return r.isEmpty(); }),
- l.end());
- }
+ if (skipEmptyRects)
+ l.removeIf([] (const QRect &r) { return r.isEmpty(); });
const QRect &rect = l.constFirst();
for (int windowFlag : windowFlags) {
QTest::newRow(QString("%1,%2 %3x%4, flags %5")