summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTor Arne Vestbø <tor.arne.vestbo@qt.io>2023-09-11 13:18:25 +0200
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2023-09-12 07:59:14 +0000
commitba75281542fbfcac2b25b02177bc01c4b92f4a8c (patch)
treeb583d46c6c5248c55f043003d0b8854a3ffad879
parent4c562f94c043d6b0594a61ffeae4368e05e29df4 (diff)
cmake: Don't pass -undefined,error to Apple linker
Error is the default for this option in ld64, and with the new linker in Xcode 15 the option was deprecated, causing a warning, so let's just skip adding it and assume undefined symbols results in errors. Fixes: QTBUG-116732 Change-Id: I736a891ae102fe1dfb2cdf869f42c665e231adba Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit c00b17de6620c9339be39ca35fea98e19951e72f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 9f3c74bfab9b8fdc3dbbf6c3c8176574036cec44)
-rw-r--r--cmake/QtFlagHandlingHelpers.cmake5
1 files changed, 5 insertions, 0 deletions
diff --git a/cmake/QtFlagHandlingHelpers.cmake b/cmake/QtFlagHandlingHelpers.cmake
index 6784232ca9..4ef1bd7869 100644
--- a/cmake/QtFlagHandlingHelpers.cmake
+++ b/cmake/QtFlagHandlingHelpers.cmake
@@ -80,6 +80,11 @@ function(qt_internal_add_link_flags_no_undefined target)
if (NOT QT_BUILD_SHARED_LIBS OR WASM)
return()
endif()
+ if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
+ # ld64 defaults to -undefined,error, and in Xcode 15
+ # passing this option is deprecated, causing a warning.
+ return()
+ endif()
if ((GCC OR CLANG) AND NOT MSVC)
if(CLANG AND QT_FEATURE_sanitizer)
return()