diff options
| author | Alexandru Croitor <alexandru.croitor@qt.io> | 2021-06-11 17:25:59 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-06-17 19:13:07 +0000 |
| commit | 70ad80660e554a558ac6ce3986198aaef7241044 (patch) | |
| tree | b417b16a13623ed1e632e56b7cdeabcd4c2db8d6 | |
| parent | 9dd2541bebdbbc4bcbac983d79700fb77aa89e8c (diff) | |
CMake: Add TODO to apply generalized object library linking approach
Change-Id: I1ea368e81d8b055ef353a0f021f188b45588c937
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
(cherry picked from commit a37957df5c1d3d8624fae2222734a127ec340a72)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
| -rw-r--r-- | cmake/QtPublicPluginHelpers.cmake | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/cmake/QtPublicPluginHelpers.cmake b/cmake/QtPublicPluginHelpers.cmake index 8c98852c49..ce8ddf0bee 100644 --- a/cmake/QtPublicPluginHelpers.cmake +++ b/cmake/QtPublicPluginHelpers.cmake @@ -195,6 +195,9 @@ function(__qt_internal_add_static_plugin_import_macro __qt_internal_get_static_plugin_init_target_name("${plugin_target}" plugin_init_target) set(objs_genex "$<TARGET_OBJECTS:${QT_CMAKE_EXPORT_NAMESPACE}::${plugin_init_target}>") + # TODO: Replace the target_sources call here with the more generalized approach that will be + # added to __qt_propagate_generated_resource (the one that determines whether to use + # target_sources or target_link_libraries depending on the CMake version). target_sources(${QT_CMAKE_EXPORT_NAMESPACE}::${plugin_target} INTERFACE "${objs_genex}") endfunction() |