summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVolker Hilsheimer <volker.hilsheimer@qt.io>2020-02-25 16:42:15 +0100
committerVolker Hilsheimer <volker.hilsheimer@qt.io>2020-02-28 21:36:51 +0100
commit2090b770daa87039f27c15aad6bdbc42e5fe702c (patch)
treeeebd7d2a95950dbdd9c612f5eb45d778d3423723
parent7e5f38aec667d3fd71efc0d2c586a08c3a87574c (diff)
Make QProcess::splitCommand accept QStringView, as per header review
A static function that only parses the string to create the list, so no need for a QString overload. Change-Id: I1df297adb795095d6eec94ccfcad52498178a7b1 Reviewed-by: Lars Knoll <lars.knoll@qt.io> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
-rw-r--r--src/corelib/io/qprocess.cpp2
-rw-r--r--src/corelib/io/qprocess.h2
2 files changed, 2 insertions, 2 deletions
diff --git a/src/corelib/io/qprocess.cpp b/src/corelib/io/qprocess.cpp
index 40ef911894..df8b306a8d 100644
--- a/src/corelib/io/qprocess.cpp
+++ b/src/corelib/io/qprocess.cpp
@@ -2255,7 +2255,7 @@ void QProcessPrivate::start(QIODevice::OpenMode mode)
Tokens with spaces can be surrounded by double quotes; three
consecutive double quotes represent the quote character itself.
*/
-QStringList QProcess::splitCommand(const QString &command)
+QStringList QProcess::splitCommand(QStringView command)
{
QStringList args;
QString tmp;
diff --git a/src/corelib/io/qprocess.h b/src/corelib/io/qprocess.h
index 504b4a8061..8c55080252 100644
--- a/src/corelib/io/qprocess.h
+++ b/src/corelib/io/qprocess.h
@@ -282,7 +282,7 @@ public:
static QString nullDevice();
- static QStringList splitCommand(const QString &command);
+ static QStringList splitCommand(QStringView command);
public Q_SLOTS:
void terminate();