summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMark Brand <mabrand@mabrand.nl>2012-02-15 10:22:15 +0100
committerQt by Nokia <qt-info@nokia.com>2012-02-23 23:42:59 +0100
commit3a863280dc7f1845bf3daa74fe235b1df9bc26ae (patch)
tree13e61ab2a353ad24108d1989b81cc8fedc91a57a
parent5d516234bef7bf9d86cb1dbb1cddeb7e4c8fc8ec (diff)
QSqlTableModel: avoid extra QMap lookup
The consensus on #qt-labs seems to be that there is little or no point in checking with contains() before using value(), even if the map does not contain the key in most cases. Change-Id: I34740a91d5c3af65e20937a5ae3b4bab32406440 Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
-rw-r--r--src/sql/models/qsqltablemodel.cpp12
1 files changed, 5 insertions, 7 deletions
diff --git a/src/sql/models/qsqltablemodel.cpp b/src/sql/models/qsqltablemodel.cpp
index f30352e2fe..0cb7c3921b 100644
--- a/src/sql/models/qsqltablemodel.cpp
+++ b/src/sql/models/qsqltablemodel.cpp
@@ -439,13 +439,11 @@ QVariant QSqlTableModel::headerData(int section, Qt::Orientation orientation, in
{
Q_D(const QSqlTableModel);
if (orientation == Qt::Vertical && role == Qt::DisplayRole) {
- if (d->cache.contains(section)) {
- const QSqlTableModelPrivate::Op op = d->cache.value(section).op();
- if (op == QSqlTableModelPrivate::Insert)
- return QLatin1String("*");
- else if (op == QSqlTableModelPrivate::Delete)
- return QLatin1String("!");
- }
+ const QSqlTableModelPrivate::Op op = d->cache.value(section).op();
+ if (op == QSqlTableModelPrivate::Insert)
+ return QLatin1String("*");
+ else if (op == QSqlTableModelPrivate::Delete)
+ return QLatin1String("!");
}
return QSqlQueryModel::headerData(section, orientation, role);
}