diff options
| author | Alexander Volkov <a.volkov@rusbitech.ru> | 2014-11-05 12:56:26 +0400 |
|---|---|---|
| committer | Alexander Volkov <a.volkov@rusbitech.ru> | 2014-11-06 08:35:22 +0100 |
| commit | 3c0ea78283b6c231854192e4e8519e02d70887d8 (patch) | |
| tree | 7d7fb0b988c9091cc797c97e18b83acecb2dfe62 | |
| parent | 0b54de41bc6beeddc0453a3f31527eaaf53ffee5 (diff) | |
Do not pass a null pointer to unlink()
Found by clang static analyzer.
Change-Id: I8f15ae1a8e6afb91eafa6cee1d1b21e3539af6c1
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com>
Reviewed-by: Andy Shaw <andy.shaw@digia.com>
| -rw-r--r-- | src/plugins/printsupport/cups/qppdprintdevice.cpp | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/plugins/printsupport/cups/qppdprintdevice.cpp b/src/plugins/printsupport/cups/qppdprintdevice.cpp index 7a6acf8b78..d20fbb558b 100644 --- a/src/plugins/printsupport/cups/qppdprintdevice.cpp +++ b/src/plugins/printsupport/cups/qppdprintdevice.cpp @@ -470,9 +470,10 @@ void QPpdPrintDevice::loadPrinter() m_cupsDest = cupsGetNamedDest(CUPS_HTTP_DEFAULT, m_cupsName, m_cupsInstance); if (m_cupsDest) { const char *ppdFile = cupsGetPPD(m_cupsName); - if (ppdFile) + if (ppdFile) { m_ppd = ppdOpenFile(ppdFile); - unlink(ppdFile); + unlink(ppdFile); + } if (m_ppd) { ppdMarkDefaults(m_ppd); } else { |