summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThiago Macieira <thiago.macieira@intel.com>2015-08-11 12:39:29 -0700
committerThiago Macieira <thiago.macieira@intel.com>2015-08-19 22:13:23 +0000
commit5bf5fe964bc495f4390462d3287575bb99aab18e (patch)
treeccc90ecbf07115df4c22c64669dabf5636c3e847
parente525d1f44d2678f0360a0ee6c9ce2c9cb44f52a2 (diff)
Fix Clang warning about copy elision
Found by Clang 3.7: qcommandlineoption.cpp:287:12: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move] Change-Id: I7de033f80b0e4431b7f1ffff13f97fb480001d36 Reviewed-by: David Faure <david.faure@kdab.com>
-rw-r--r--src/corelib/tools/qcommandlineoption.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/tools/qcommandlineoption.cpp b/src/corelib/tools/qcommandlineoption.cpp
index eb50cee5bb..5eda114087 100644
--- a/src/corelib/tools/qcommandlineoption.cpp
+++ b/src/corelib/tools/qcommandlineoption.cpp
@@ -284,7 +284,7 @@ QStringList QCommandLineOptionPrivate::removeInvalidNames(QStringList nameList)
else
nameList.erase(std::remove_if(nameList.begin(), nameList.end(), IsInvalidName()),
nameList.end());
- return qMove(nameList);
+ return nameList;
}
/*!