summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAnton Kudryavtsev <a.kudryavtsev@netris.ru>2016-01-19 14:21:38 +0300
committerAnton Kudryavtsev <a.kudryavtsev@netris.ru>2016-01-29 05:31:15 +0000
commit74a7454b37e1407f4ab352a4d003a4965ddcbffd (patch)
tree1e06fb48947272eec8f7b76a55436af9bc202ada
parente5cd556cd1f6f656f43d0a9d8ddd2845794c31f9 (diff)
QNetworkProxyFactory: don't re-call QUrl::scheme() in if-else chain.
... Just cache it. Change-Id: Iae70e09233b237d904ab100f46f8dc7ab9ac8e04 Reviewed-by: Marc Mutz <marc.mutz@kdab.com> Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
-rw-r--r--src/network/kernel/qnetworkproxy_libproxy.cpp11
1 files changed, 6 insertions, 5 deletions
diff --git a/src/network/kernel/qnetworkproxy_libproxy.cpp b/src/network/kernel/qnetworkproxy_libproxy.cpp
index c7d1d48605..06ce10e2f9 100644
--- a/src/network/kernel/qnetworkproxy_libproxy.cpp
+++ b/src/network/kernel/qnetworkproxy_libproxy.cpp
@@ -121,14 +121,15 @@ QList<QNetworkProxy> QNetworkProxyFactory::systemProxyForQuery(const QNetworkPro
bool haveDirectConnection = false;
foreach (const QUrl& url, rawProxies) {
QNetworkProxy::ProxyType type;
- if (url.scheme() == QLatin1String("http")) {
+ const QString scheme = url.scheme();
+ if (scheme == QLatin1String("http")) {
type = QNetworkProxy::HttpProxy;
- } else if (url.scheme() == QLatin1String("socks")
- || url.scheme() == QLatin1String("socks5")) {
+ } else if (scheme == QLatin1String("socks")
+ || scheme == QLatin1String("socks5")) {
type = QNetworkProxy::Socks5Proxy;
- } else if (url.scheme() == QLatin1String("ftp")) {
+ } else if (scheme == QLatin1String("ftp")) {
type = QNetworkProxy::FtpCachingProxy;
- } else if (url.scheme() == QLatin1String("direct")) {
+ } else if (scheme == QLatin1String("direct")) {
type = QNetworkProxy::NoProxy;
haveDirectConnection = true;
} else {