diff options
| author | Li Xinwei <1326710505@qq.com> | 2021-04-20 14:46:20 +0800 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2021-04-20 19:15:42 +0000 |
| commit | 83dbe0af2004a730d663e74914d02089ac81300d (patch) | |
| tree | 19cee4ad98ebf16a73c45f1c8fb5e54bf27b0c7b /cmake/QtModuleHelpers.cmake | |
| parent | 20a9f74851685d2619af04bebeb5b615f3c1a8e0 (diff) | |
MSVC: define _CRT_SECURE_NO_WARNINGS for all internal CMake targets
In commit 013abe320680b3dcd3f6d7e4fb4880e590ba10e6, I add
_CRT_SECURE_NO_WARNINGS definition for all Qt internal module targets,
to suppress MSVC warnings like:
warning C4996: 'strncpy': This function or variable may be unsafe.
However, when compiling some internal tools, such as qmake and qdoc,
such warnings also exist. To suppress this kind of warning entirely,
_CRT_SECURE_NO_WARNINGS definition should be added for all Qt internal
targets when using MSVC compiler.
Change-Id: I9c37b20672f9d0f470e3e9ea847e5221f43bfc04
Reviewed-by: Yuhang Zhao <2546789017@qq.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
(cherry picked from commit c7a27678d6916a51848c991fb3ee21acc6a6f8ca)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'cmake/QtModuleHelpers.cmake')
| -rw-r--r-- | cmake/QtModuleHelpers.cmake | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/cmake/QtModuleHelpers.cmake b/cmake/QtModuleHelpers.cmake index 3952166fe2..f9af1758d2 100644 --- a/cmake/QtModuleHelpers.cmake +++ b/cmake/QtModuleHelpers.cmake @@ -357,10 +357,6 @@ function(qt_internal_add_module target) ) endif() - if(MSVC) - list(APPEND defines_for_extend_target _CRT_SECURE_NO_WARNINGS) - endif() - qt_internal_extend_target("${target}" ${header_module} SOURCES ${arg_SOURCES} |