summaryrefslogtreecommitdiffstats
path: root/cmake
diff options
context:
space:
mode:
authorAlexey Edelev <alexey.edelev@qt.io>2021-09-16 19:15:05 +0200
committerAlexey Edelev <alexey.edelev@qt.io>2021-09-17 13:57:17 +0200
commit2f1d6e4c3f03f3c2b428bebc75d437e644b2520b (patch)
tree7968aa27101e0b12e15aee638fdbd240d868a077 /cmake
parentf16c8fdf18ea296e9ebffe31a71e564fe841046c (diff)
Do not generate cpp exports for pure STATIC modules
Static libraries don't need to export their symbols, and corner cases when sources are also used in shared libraries, should be handled manually. Task-number: QTBUG-90492 Change-Id: I5cb0a3f7e280b042b678bdbe4475f2bbf9f6b9ba Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Diffstat (limited to 'cmake')
-rw-r--r--cmake/QtModuleHelpers.cmake5
1 files changed, 4 insertions, 1 deletions
diff --git a/cmake/QtModuleHelpers.cmake b/cmake/QtModuleHelpers.cmake
index 502af4f05e..deb5b001e1 100644
--- a/cmake/QtModuleHelpers.cmake
+++ b/cmake/QtModuleHelpers.cmake
@@ -312,7 +312,10 @@ function(qt_internal_add_module target)
set_property(TARGET ${target} APPEND PROPERTY
_qt_module_timestamp_dependencies "${module_headers_public}")
- if(arg_GENERATE_CPP_EXPORTS)
+ # We should not generate export headers if module is defined as pure STATIC.
+ # Static libraries don't need to export their symbols, and corner cases when sources are
+ # also used in shared libraries, should be handled manually.
+ if(arg_GENERATE_CPP_EXPORTS AND NOT arg_STATIC)
if(arg_CPP_EXPORT_HEADER_BASE_NAME)
set(cpp_export_header_base_name
"CPP_EXPORT_HEADER_BASE_NAME;${arg_CPP_EXPORT_HEADER_BASE_NAME}"