summaryrefslogtreecommitdiffstats
path: root/config.tests/x11
diff options
context:
space:
mode:
authorDavid Faure <david.faure@kdab.com>2020-10-23 19:07:05 +0200
committerDavid Faure <david.faure@kdab.com>2020-10-27 02:55:10 +0100
commit72e0d699cec09458ca9325035d477d4899e8e47b (patch)
tree77225cea6d416aff158f9dc1e91b39e349b73f0c /config.tests/x11
parentfeda3e7673137c3f6a9f3561276b6d21447fd881 (diff)
QAbstractItemModelTester: don't rely on hasChildren()
Dynamic models which use fetchMore to asynchronously fill subdirs (like KDirModel) return true in hasChildren() for dirs that are expected to have children (so that the "+" shows in the treeview) but do not actually have children readily available. They will be inserted later on once the async listing job is done (as a result of fetchMore triggering that job). So QAbstractItemModelTester should use rowCount instead, to find out if there are children present. This detected a bug in QConcatenateTablesProxyModel: it returned a non-zero rowCount for its items, while it's flat. Change-Id: Idcdc86159f1fc79ed5297075dfcf30c09896287a Pick-to: 5.15 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'config.tests/x11')
0 files changed, 0 insertions, 0 deletions