diff options
| author | Thiago Macieira <thiago.macieira@intel.com> | 2017-07-02 10:36:46 -0700 |
|---|---|---|
| committer | Thiago Macieira <thiago.macieira@intel.com> | 2017-08-05 16:41:42 +0000 |
| commit | a3c71b71e2033b92c74e54fc316ea42df2344ed2 (patch) | |
| tree | 70cebe91a82f7652b96b18ce61a47f7480cb29f8 /config.tests | |
| parent | 6c3a3d498a8797c481a394418fff8f7bf1886c61 (diff) | |
QFileSystemEngine::setFileTime/Unix: remove the fallback to futimesat
The use as in the code:
futimesat(fd, NULL, &tv)
is not documented to work. The file descriptor should be a directory's
one, not an open file (though the Linux source code seems to handle that
case). This call was done as a fallback to futimes, so it's very
unlikely a system would have futimesat and not futimes.
Both the Linux and the FreeBSD man pages say it's deprecated anyway.
Change-Id: I8d96dea9955d4c749b99fffd14cd94068dc7668a
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Diffstat (limited to 'config.tests')
| -rw-r--r-- | config.tests/unix/futimesat/futimesat.cpp | 47 | ||||
| -rw-r--r-- | config.tests/unix/futimesat/futimesat.pro | 1 |
2 files changed, 0 insertions, 48 deletions
diff --git a/config.tests/unix/futimesat/futimesat.cpp b/config.tests/unix/futimesat/futimesat.cpp deleted file mode 100644 index a0e2c5848d..0000000000 --- a/config.tests/unix/futimesat/futimesat.cpp +++ /dev/null @@ -1,47 +0,0 @@ -/**************************************************************************** -** -** Copyright (C) 2015 Raphael Gozzo <raphael.rg91@gmail.com> -** Contact: http://www.qt.io/licensing/ -** -** This file is part of the config.tests of the Qt Toolkit. -** -** $QT_BEGIN_LICENSE:LGPL$ -** Commercial License Usage -** Licensees holding valid commercial Qt licenses may use this file in -** accordance with the commercial license agreement provided with the -** Software or, alternatively, in accordance with the terms contained in -** a written agreement between you and The Qt Company. For licensing terms -** and conditions see https://www.qt.io/terms-conditions. For further -** information use the contact form at https://www.qt.io/contact-us. -** -** GNU Lesser General Public License Usage -** Alternatively, this file may be used under the terms of the GNU Lesser -** General Public License version 3 as published by the Free Software -** Foundation and appearing in the file LICENSE.LGPL3 included in the -** packaging of this file. Please review the following information to -** ensure the GNU Lesser General Public License version 3 requirements -** will be met: https://www.gnu.org/licenses/lgpl-3.0.html. -** -** GNU General Public License Usage -** Alternatively, this file may be used under the terms of the GNU -** General Public License version 2.0 or (at your option) the GNU General -** Public license version 3 or any later version approved by the KDE Free -** Qt Foundation. The licenses are as published by the Free Software -** Foundation and appearing in the file LICENSE.GPL2 and LICENSE.GPL3 -** included in the packaging of this file. Please review the following -** information to ensure the GNU General Public License requirements will -** be met: https://www.gnu.org/licenses/gpl-2.0.html and -** https://www.gnu.org/licenses/gpl-3.0.html. -** -** $QT_END_LICENSE$ -** -****************************************************************************/ - -#include <sys/time.h> - -int main(int, char **) -{ - futimesat(-1,0,0); - return 0; -} - diff --git a/config.tests/unix/futimesat/futimesat.pro b/config.tests/unix/futimesat/futimesat.pro deleted file mode 100644 index 1b364e1977..0000000000 --- a/config.tests/unix/futimesat/futimesat.pro +++ /dev/null @@ -1 +0,0 @@ -SOURCES += futimesat.cpp |